1
0
Fork 0
alistair23-linux/drivers/char/tpm
Neil Horman 5d469ec0f4 [PATCH] Correct misc_register return code handling in several drivers
Clean up several code points in which the return code from misc_register is
not handled properly.

Several modules failed to deregister various hooks when misc_register fails,
and this patch cleans them up.  Also there are a few modules that legitimately
don't care about the failure status of misc register.  These drivers however
unilaterally call misc_deregister on module unload.

Since misc_register doesn't initialize the list_head in the init_routine if it
fails, the deregister operation is at risk for oopsing when list_del is
called.  The initial solution was to manually init the list in the miscdev
structure in each of those modules, but the consensus in this thread was to
consolodate and do that universally inside misc_register.

Signed-off-by: Neil Horman <nhorman@tuxdriver.com>
Cc: Bjorn Helgaas <bjorn.helgaas@hp.com>
Cc: Kylene Jo Hall <kjhall@us.ibm.com>
Cc: Dmitry Torokhov <dtor@mail.ru>
Cc: Olaf Hering <olh@suse.de>
Cc: Benjamin Herrenschmidt <benh@kernel.crashing.org>
Signed-off-by: Andrew Morton <akpm@osdl.org>
Signed-off-by: Linus Torvalds <torvalds@osdl.org>
2006-12-07 08:39:35 -08:00
..
Kconfig [PATCH] tpm: update module dependencies 2006-05-15 11:20:54 -07:00
Makefile [PATCH] tpm: driver for next generation TPM chips 2006-04-22 09:19:54 -07:00
tpm.c [PATCH] Correct misc_register return code handling in several drivers 2006-12-07 08:39:35 -08:00
tpm.h [PATCH] severing fs.h, radix-tree.h -> sched.h 2006-12-04 02:00:24 -05:00
tpm_atmel.c [PATCH] tpm: fix error handling 2006-10-11 11:14:22 -07:00
tpm_atmel.h [POWERPC] tmp_atmel: Constify & voidify get_property() 2006-07-31 15:55:06 +10:00
tpm_bios.c [PATCH] tpm: more bios log parsing fixes 2006-05-31 16:27:10 -07:00
tpm_infineon.c [PATCH] make more file_operation structs static 2006-07-03 15:26:59 -07:00
tpm_nsc.c [PATCH] tpm: fix error handling 2006-10-11 11:14:22 -07:00
tpm_tis.c IRQ: Maintain regs pointer globally rather than passing to IRQ handlers 2006-10-05 15:10:12 +01:00