1
0
Fork 0
alistair23-linux/sound/hda
Kai Vehmanen 1cb3c0cecc ALSA: hda: do not override bus codec_mask in link_get()
[ Upstream commit 43bcb1c050 ]

snd_hdac_ext_bus_link_get() does not work correctly in case
there are multiple codecs on the bus. It unconditionally
resets the bus->codec_mask value. As per documentation in
hdaudio.h and existing use in client code, this field should
be used to store bit flag of detected codecs on the bus.

By overwriting value of the codec_mask, information on all
detected codecs is lost. No current user of hdac is impacted,
but use of bus->codec_mask is planned in future patches
for SOF.

Signed-off-by: Kai Vehmanen <kai.vehmanen@linux.intel.com>
Reviewed-by: Ranjani Sridharan <ranjani.sridharan@linux.intel.com>
Reviewed-by: Pierre-Louis Bossart <pierre-louis.bossart@linux.intel.com>
Reviewed-by: Takashi Iwai <tiwai@suse.de>
Link: https://lore.kernel.org/r/20200206200223.7715-1-kai.vehmanen@linux.intel.com
Signed-off-by: Mark Brown <broonie@kernel.org>
Signed-off-by: Sasha Levin <sashal@kernel.org>
2020-03-12 13:00:10 +01:00
..
ext ALSA: hda: do not override bus codec_mask in link_get() 2020-03-12 13:00:10 +01:00
Kconfig Merge branch 'topic/hda-bus-ops-cleanup' into for-next 2019-08-08 22:35:44 +02:00
Makefile ALSA: hda: move parts of NHLT code to new module 2019-07-31 15:45:59 +02:00
array.c treewide: Add SPDX license identifier for missed files 2019-05-21 10:50:45 +02:00
hda_bus_type.c treewide: Add SPDX license identifier for more missed files 2019-05-21 10:50:45 +02:00
hdac_bus.c ALSA: hda: Unexport a few more stuff 2019-08-14 20:00:56 +02:00
hdac_component.c Linux 5.1-rc5 2019-04-15 15:51:49 +10:00
hdac_controller.c Revert "ALSA: hda: Flush interrupts on disabling" 2019-10-28 11:47:59 +01:00
hdac_device.c Revert "ALSA: hda: Add codec on bus address table lately" 2019-08-15 21:43:05 +02:00
hdac_i915.c ALSA: hda: Fix 1-minute detection delay when i915 module is not available 2019-07-27 08:31:46 +02:00
hdac_regmap.c ALSA: hda: Unexport a few more stuff 2019-08-14 20:00:56 +02:00
hdac_stream.c ALSA: hda: Fix regression by strip mask fix 2019-12-21 11:05:23 +01:00
hdac_sysfs.c ALSA: hda: Simplify snd_hdac_refresh_widgets() 2019-07-05 12:01:06 +02:00
hdmi_chmap.c ALSA: hda: Use scnprintf() for printing texts for sysfs/procfs 2020-02-28 17:22:12 +01:00
intel-nhlt.c ALSA: hda: intel-nhlt: handle NHLT VENDOR_DEFINED DMIC geometry 2019-07-31 15:46:00 +02:00
local.h ALSA: hda: Unexport a few more stuff 2019-08-14 20:00:56 +02:00
trace.c ALSA: hda - Re-add tracepoints to HD-audio core driver 2015-03-23 13:17:58 +01:00
trace.h License cleanup: add SPDX GPL-2.0 license identifier to files with no license 2017-11-02 11:10:55 +01:00