1
0
Fork 0
alistair23-linux/drivers/usb/isp1760
Colin Ian King e3e64f3f99 usb: isp1760: check for null return from kzalloc
isp1760_ep_alloc_request allocates a structure with kzalloc without checking
for NULL and then returns a pointer to one of the structure fields. As the
field happens to be the first in the structure the caller can properly check
for NULL, but this is risky if the structure layout is changed later. Add an
explicit NULL check for the kzalloc return value

Detected with smatch static analysis:

drivers/usb/isp1760/isp1760-udc.c:816 isp1760_ep_alloc_request()
  error: potential null dereference 'req'.  (kzalloc returns null)

[ thanks to Laurent Pinchart for improved commit message ]

Signed-off-by: Colin Ian King <colin.king@canonical.com>
Acked-by: Laurent Pinchart <laurent.pinchart@ideasonboard.com>
Signed-off-by: Greg Kroah-Hartman <gregkh@linuxfoundation.org>
2015-06-08 14:25:04 -07:00
..
Kconfig
Makefile
isp1760-core.c usb: isp1760: set IRQ flags properly 2015-03-09 10:46:15 -05:00
isp1760-core.h
isp1760-hcd.c usb: generic resume timeout for v4.1 2015-04-10 13:45:27 +02:00
isp1760-hcd.h
isp1760-if.c
isp1760-regs.h
isp1760-udc.c usb: isp1760: check for null return from kzalloc 2015-06-08 14:25:04 -07:00
isp1760-udc.h