63673597cc
Before an smc ib device is used the first time for an smc link it is
lazily initialized. When there are 2 active link groups and a new ib
device is brought online then it might happen that 2 link creations run
in parallel and enter smc_ib_setup_per_ibdev(). Both allocate new send
and receive completion queues on the device, but only one set of them
keeps assigned and the other leaks.
Fix that by protecting the setup and cleanup code using a mutex.
Reviewed-by: Ursula Braun <ubraun@linux.ibm.com>
Fixes: f3c1deddb2 ("net/smc: separate function for link initialization")
Signed-off-by: Karsten Graul <kgraul@linux.ibm.com>
Signed-off-by: David S. Miller <davem@davemloft.net>
91 lines
3.3 KiB
C
91 lines
3.3 KiB
C
/* SPDX-License-Identifier: GPL-2.0 */
|
|
/*
|
|
* Shared Memory Communications over RDMA (SMC-R) and RoCE
|
|
*
|
|
* Definitions for IB environment
|
|
*
|
|
* Copyright IBM Corp. 2016
|
|
*
|
|
* Author(s): Ursula Braun <Ursula Braun@linux.vnet.ibm.com>
|
|
*/
|
|
|
|
#ifndef _SMC_IB_H
|
|
#define _SMC_IB_H
|
|
|
|
#include <linux/interrupt.h>
|
|
#include <linux/if_ether.h>
|
|
#include <linux/mutex.h>
|
|
#include <linux/wait.h>
|
|
#include <rdma/ib_verbs.h>
|
|
#include <net/smc.h>
|
|
|
|
#define SMC_MAX_PORTS 2 /* Max # of ports */
|
|
#define SMC_GID_SIZE sizeof(union ib_gid)
|
|
|
|
#define SMC_IB_MAX_SEND_SGE 2
|
|
|
|
struct smc_ib_devices { /* list of smc ib devices definition */
|
|
struct list_head list;
|
|
struct mutex mutex; /* protects list of smc ib devices */
|
|
};
|
|
|
|
extern struct smc_ib_devices smc_ib_devices; /* list of smc ib devices */
|
|
|
|
struct smc_ib_device { /* ib-device infos for smc */
|
|
struct list_head list;
|
|
struct ib_device *ibdev;
|
|
struct ib_port_attr pattr[SMC_MAX_PORTS]; /* ib dev. port attrs */
|
|
struct ib_event_handler event_handler; /* global ib_event handler */
|
|
struct ib_cq *roce_cq_send; /* send completion queue */
|
|
struct ib_cq *roce_cq_recv; /* recv completion queue */
|
|
struct tasklet_struct send_tasklet; /* called by send cq handler */
|
|
struct tasklet_struct recv_tasklet; /* called by recv cq handler */
|
|
char mac[SMC_MAX_PORTS][ETH_ALEN];
|
|
/* mac address per port*/
|
|
u8 pnetid[SMC_MAX_PORTS][SMC_MAX_PNETID_LEN];
|
|
/* pnetid per port */
|
|
bool pnetid_by_user[SMC_MAX_PORTS];
|
|
/* pnetid defined by user? */
|
|
u8 initialized : 1; /* ib dev CQ, evthdl done */
|
|
struct work_struct port_event_work;
|
|
unsigned long port_event_mask;
|
|
DECLARE_BITMAP(ports_going_away, SMC_MAX_PORTS);
|
|
atomic_t lnk_cnt; /* number of links on ibdev */
|
|
wait_queue_head_t lnks_deleted; /* wait 4 removal of all links*/
|
|
struct mutex mutex; /* protect dev setup+cleanup */
|
|
};
|
|
|
|
struct smc_buf_desc;
|
|
struct smc_link;
|
|
|
|
int smc_ib_register_client(void) __init;
|
|
void smc_ib_unregister_client(void);
|
|
bool smc_ib_port_active(struct smc_ib_device *smcibdev, u8 ibport);
|
|
int smc_ib_buf_map_sg(struct smc_link *lnk,
|
|
struct smc_buf_desc *buf_slot,
|
|
enum dma_data_direction data_direction);
|
|
void smc_ib_buf_unmap_sg(struct smc_link *lnk,
|
|
struct smc_buf_desc *buf_slot,
|
|
enum dma_data_direction data_direction);
|
|
void smc_ib_dealloc_protection_domain(struct smc_link *lnk);
|
|
int smc_ib_create_protection_domain(struct smc_link *lnk);
|
|
void smc_ib_destroy_queue_pair(struct smc_link *lnk);
|
|
int smc_ib_create_queue_pair(struct smc_link *lnk);
|
|
int smc_ib_ready_link(struct smc_link *lnk);
|
|
int smc_ib_modify_qp_rts(struct smc_link *lnk);
|
|
int smc_ib_modify_qp_reset(struct smc_link *lnk);
|
|
long smc_ib_setup_per_ibdev(struct smc_ib_device *smcibdev);
|
|
int smc_ib_get_memory_region(struct ib_pd *pd, int access_flags,
|
|
struct smc_buf_desc *buf_slot, u8 link_idx);
|
|
void smc_ib_put_memory_region(struct ib_mr *mr);
|
|
void smc_ib_sync_sg_for_cpu(struct smc_link *lnk,
|
|
struct smc_buf_desc *buf_slot,
|
|
enum dma_data_direction data_direction);
|
|
void smc_ib_sync_sg_for_device(struct smc_link *lnk,
|
|
struct smc_buf_desc *buf_slot,
|
|
enum dma_data_direction data_direction);
|
|
int smc_ib_determine_gid(struct smc_ib_device *smcibdev, u8 ibport,
|
|
unsigned short vlan_id, u8 gid[], u8 *sgid_index);
|
|
bool smc_ib_is_valid_local_systemid(void);
|
|
#endif
|