alistair23-linux/fs/udf
Jan Kara db0badc58e udf: Fix lock inversion between iprune_mutex and alloc_mutex (v2)
A memory allocation inside alloc_mutex must not recurse back into the
filesystem itself because that leads to lock inversion between iprune_mutex and
alloc_mutex (and thus to deadlocks - see traces below). alloc_mutex is actually
needed only to update allocation statistics in the superblock so we can drop it
before we start allocating memory for the inode.

tar           D ffff81015b9c8c90     0  6614   6612
 ffff8100d5a21a20 0000000000000086 0000000000000000 00000000ffff0000
 ffff81015b9c8c90 ffff81015b8f0cd0 ffff81015b9c8ee0 0000000000000000
 0000000000000003 0000000000000000 0000000000000000 0000000000000000
Call Trace:
 [<ffffffff803c1d8a>] __mutex_lock_slowpath+0x64/0x9b
 [<ffffffff803c1bef>] mutex_lock+0xa/0xb
 [<ffffffff8027f8c2>] shrink_icache_memory+0x38/0x200
 [<ffffffff80257742>] shrink_slab+0xe3/0x15b
 [<ffffffff802579db>] try_to_free_pages+0x221/0x30d
 [<ffffffff8025657e>] isolate_pages_global+0x0/0x31
 [<ffffffff8025324b>] __alloc_pages_internal+0x252/0x3ab
 [<ffffffff8026b08b>] cache_alloc_refill+0x22e/0x47b
 [<ffffffff8026ae37>] kmem_cache_alloc+0x3b/0x61
 [<ffffffff8026b15b>] cache_alloc_refill+0x2fe/0x47b
 [<ffffffff8026b34e>] __kmalloc+0x76/0x9c
 [<ffffffffa00751f2>] :udf:udf_new_inode+0x202/0x2e2
 [<ffffffffa007ae5e>] :udf:udf_create+0x2f/0x16d
 [<ffffffffa0078f27>] :udf:udf_lookup+0xa6/0xad
...
kswapd0       D ffff81015b9d9270     0   125      2
 ffff81015b903c28 0000000000000046 ffffffff8028cbb0 00000000fffffffb
 ffff81015b9d9270 ffff81015b8f0cd0 ffff81015b9d94c0 000000000271b490
 ffffe2000271b458 ffffe2000271b420 ffffe20002728dc8 ffffe20002728d90
Call Trace:
 [<ffffffff8028cbb0>] __set_page_dirty+0xeb/0xf5
 [<ffffffff8025403a>] get_dirty_limits+0x1d/0x22f
 [<ffffffff803c1d8a>] __mutex_lock_slowpath+0x64/0x9b
 [<ffffffff803c1bef>] mutex_lock+0xa/0xb
 [<ffffffffa0073f58>] :udf:udf_bitmap_free_blocks+0x47/0x1eb
 [<ffffffffa007df31>] :udf:udf_discard_prealloc+0xc6/0x172
 [<ffffffffa007875a>] :udf:udf_clear_inode+0x1e/0x48
 [<ffffffff8027f121>] clear_inode+0x6d/0xc4
 [<ffffffff8027f7f2>] dispose_list+0x56/0xee
 [<ffffffff8027fa5a>] shrink_icache_memory+0x1d0/0x200
 [<ffffffff80257742>] shrink_slab+0xe3/0x15b
 [<ffffffff80257e93>] kswapd+0x346/0x447
...

Reported-by: Tibor Tajti <tibor.tajti@gmail.com>
Reviewed-by: Ingo Oeser <ioe-lkml@rameria.de>
Signed-off-by: Jan Kara <jack@suse.cz>
2008-08-19 11:04:36 +02:00
..
balloc.c udf: replace all adds to little endians variables with le*_add_cpu 2008-04-17 14:22:28 +02:00
dir.c udf: Remove declarations of arrays of size UDF_NAME_LEN (256 bytes) 2008-04-17 14:23:04 +02:00
directory.c udf: cleanup directory offset handling 2008-02-08 09:22:36 -08:00
ecma_167.h udf: remove unneeded kernel_timestamp type 2008-04-17 14:22:42 +02:00
file.c udf: move headers out include/linux/ 2008-04-17 14:22:23 +02:00
fsync.c UDF: coding style conversion - lindent fixups 2007-07-21 17:49:14 -07:00
ialloc.c udf: Fix lock inversion between iprune_mutex and alloc_mutex (v2) 2008-08-19 11:04:36 +02:00
inode.c udf: use crc_itu_t from lib instead of udf_crc 2008-04-17 14:29:56 +02:00
lowlevel.c udf: move headers out include/linux/ 2008-04-17 14:22:23 +02:00
Makefile udf: use crc_itu_t from lib instead of udf_crc 2008-04-17 14:29:56 +02:00
misc.c udf: use crc_itu_t from lib instead of udf_crc 2008-04-17 14:29:56 +02:00
namei.c Merge branch 'for_linus' of git://git.kernel.org/pub/scm/linux/kernel/git/jack/linux-udf-2.6 2008-05-08 10:48:03 -07:00
osta_udf.h UDF: coding style conversion - lindent fixups 2007-07-21 17:49:14 -07:00
partition.c udf: fs/udf/partition.c:udf_get_pblock() mustn't be inline 2008-04-28 18:44:26 +02:00
super.c SL*B: drop kmem cache argument from constructor 2008-07-26 12:00:07 -07:00
symlink.c udf: move headers out include/linux/ 2008-04-17 14:22:23 +02:00
truncate.c udf: truncate: create function for updating of Allocation Ext Descriptor 2008-04-17 14:22:28 +02:00
udf_i.h udf: replace udf_*_offset macros with functions 2008-04-17 14:22:29 +02:00
udf_sb.h udf: Add read-only support for 2.50 UDF media 2008-04-17 14:29:36 +02:00
udfdecl.h udf: restore UDFFS_DEBUG to being undefined by default 2008-06-16 14:24:36 +02:00
udfend.h udf: remove unneeded kernel_timestamp type 2008-04-17 14:22:42 +02:00
udftime.c udf: convert udf_stamp_to_time and udf_time_to_stamp to use timestamps 2008-04-17 14:22:29 +02:00
unicode.c udf: use crc_itu_t from lib instead of udf_crc 2008-04-17 14:29:56 +02:00