Mika Westerberg 15ee8da79e i2c: i801: Do not add ICH_RES_IO_SMI for the iTCO_wdt device ... commit 04bbb97d1b upstream. Martin noticed that nct6775 driver does not load properly on his system in v5.4+ kernels. The issue was bisected to commit b84398d6d7 ("i2c: i801: Use iTCO version 6 in Cannon Lake PCH and beyond") but it is likely not the culprit because the faulty code has been in the driver already since commit 9424693035 ("i2c: i801: Create iTCO device on newer Intel PCHs"). So more likely some commit that added PCI IDs of recent chipsets made the driver to create the iTCO_wdt device on Martins system. The issue was debugged to be PCI configuration access to the PMC device that is not present. This returns all 1's when read and this caused the iTCO_wdt driver to accidentally request resourses used by nct6775. It turns out that the SMI resource is only required for some ancient systems, not the ones supported by this driver. For this reason do not populate the SMI resource at all and drop all the related code. The driver now always populates the main I/O resource and only in case of SPT (Intel Sunrisepoint) compatible devices it adds another resource for the NO_REBOOT bit. These two resources are of different types so platform_get_resource() used by the iTCO_wdt driver continues to find the both resources at index 0. Link: https://lore.kernel.org/linux-hwmon/CAM1AHpQ4196tyD=HhBu-2donSsuogabkfP03v1YF26Q7_BgvgA@mail.gmail.com/ Fixes: 9424693035 ("i2c: i801: Create iTCO device on newer Intel PCHs") [wsa: complete fix needs all of http://patchwork.ozlabs.org/project/linux-i2c/list/?series=160959&state=*] Reported-by: Martin Volf <martin.volf.42@gmail.com> Signed-off-by: Mika Westerberg <mika.westerberg@linux.intel.com> Reviewed-by: Guenter Roeck <linux@roeck-us.net> Signed-off-by: Wolfram Sang <wsa@the-dreams.de> Signed-off-by: Greg Kroah-Hartman <gregkh@linuxfoundation.org>		2020-04-08 09:08:46 +02:00
..
algos	treewide: Replace GPLv2 boilerplate/reference with SPDX - rule 157	2019-05-30 11:26:37 -07:00
busses	i2c: i801: Do not add ICH_RES_IO_SMI for the iTCO_wdt device	2020-04-08 09:08:46 +02:00
muxes	Merge branch 'i2c/for-5.3' of git://git.kernel.org/pub/scm/linux/kernel/git/wsa/linux	2019-07-15 21:10:39 -07:00
Kconfig	docs: i2c: convert to ReST and add to driver-api bookset	2019-07-31 13:25:27 -06:00
Makefile	i2c: don't use any __deprecated handling anymore	2018-08-24 17:26:43 +02:00
i2c-boardinfo.c	treewide: Replace GPLv2 boilerplate/reference with SPDX - rule 157	2019-05-30 11:26:37 -07:00
i2c-core-acpi.c	i2c: acpi: put device when verifying client fails	2020-03-18 07:17:58 +01:00
i2c-core-base.c	i2c: fix bus recovery stop mode timing	2020-01-14 20:08:18 +01:00
i2c-core-of.c	i2c: core: fix use after free in of_i2c_notify	2019-11-15 22:01:13 +01:00
i2c-core-slave.c	treewide: Replace GPLv2 boilerplate/reference with SPDX - rule 152	2019-05-30 11:26:32 -07:00
i2c-core-smbus.c	treewide: Replace GPLv2 boilerplate/reference with SPDX - rule 152	2019-05-30 11:26:32 -07:00
i2c-core.h	Merge branch 'i2c/for-5.3' of git://git.kernel.org/pub/scm/linux/kernel/git/wsa/linux	2019-07-15 21:10:39 -07:00
i2c-dev.c	Merge branch 'i2c/for-current' of git://git.kernel.org/pub/scm/linux/kernel/git/wsa/linux	2019-06-02 10:18:11 -07:00
i2c-mux.c	i2c: mux: add sysfs header	2019-06-22 07:32:33 +02:00
i2c-slave-eeprom.c	i2c: slave-eeprom: Add read only mode	2019-09-28 20:44:12 +02:00
i2c-smbus.c	treewide: Replace GPLv2 boilerplate/reference with SPDX - rule 157	2019-05-30 11:26:37 -07:00
i2c-stub.c	treewide: Replace GPLv2 boilerplate/reference with SPDX - rule 157	2019-05-30 11:26:37 -07:00