![Rob Herring](/assets/img/avatar_default.png)
Currently we get the following kind of errors if we try to use interrupt phandles to irqchips that have not yet initialized: irq: no irq domain found for /ocp/pinmux@48002030 ! ------------[ cut here ]------------ WARNING: CPU: 0 PID: 1 at drivers/of/platform.c:171 of_device_alloc+0x144/0x184() Modules linked in: CPU: 0 PID: 1 Comm: swapper/0 Not tainted 3.12.0-00038-g42a9708 #1012 (show_stack+0x14/0x1c) (dump_stack+0x6c/0xa0) (warn_slowpath_common+0x64/0x84) (warn_slowpath_null+0x1c/0x24) (of_device_alloc+0x144/0x184) (of_platform_device_create_pdata+0x44/0x9c) (of_platform_bus_create+0xd0/0x170) (of_platform_bus_create+0x12c/0x170) (of_platform_populate+0x60/0x98) This is because we're wrongly trying to populate resources that are not yet available. It's perfectly valid to create irqchips dynamically, so let's fix up the issue by resolving the interrupt resources when platform_get_irq is called. And then we also need to accept the fact that some irqdomains do not exist that early on, and only get initialized later on. So we can make the current WARN_ON into just into a pr_debug(). We still attempt to populate irq resources when we create the devices. This allows current drivers which don't use platform_get_irq to continue to function. Once all drivers are fixed, this code can be removed. Suggested-by: Russell King <linux@arm.linux.org.uk> Signed-off-by: Rob Herring <robh@kernel.org> Signed-off-by: Tony Lindgren <tony@atomide.com> Tested-by: Tony Lindgren <tony@atomide.com> Cc: stable@vger.kernel.org # v3.10+ Signed-off-by: Grant Likely <grant.likely@linaro.org>
82 lines
2.4 KiB
C
82 lines
2.4 KiB
C
#ifndef __OF_IRQ_H
|
|
#define __OF_IRQ_H
|
|
|
|
#include <linux/types.h>
|
|
#include <linux/errno.h>
|
|
#include <linux/irq.h>
|
|
#include <linux/irqdomain.h>
|
|
#include <linux/ioport.h>
|
|
#include <linux/of.h>
|
|
|
|
typedef int (*of_irq_init_cb_t)(struct device_node *, struct device_node *);
|
|
|
|
/*
|
|
* Workarounds only applied to 32bit powermac machines
|
|
*/
|
|
#define OF_IMAP_OLDWORLD_MAC 0x00000001
|
|
#define OF_IMAP_NO_PHANDLE 0x00000002
|
|
|
|
#if defined(CONFIG_PPC32) && defined(CONFIG_PPC_PMAC)
|
|
extern unsigned int of_irq_workarounds;
|
|
extern struct device_node *of_irq_dflt_pic;
|
|
extern int of_irq_parse_oldworld(struct device_node *device, int index,
|
|
struct of_phandle_args *out_irq);
|
|
#else /* CONFIG_PPC32 && CONFIG_PPC_PMAC */
|
|
#define of_irq_workarounds (0)
|
|
#define of_irq_dflt_pic (NULL)
|
|
static inline int of_irq_parse_oldworld(struct device_node *device, int index,
|
|
struct of_phandle_args *out_irq)
|
|
{
|
|
return -EINVAL;
|
|
}
|
|
#endif /* CONFIG_PPC32 && CONFIG_PPC_PMAC */
|
|
|
|
extern int of_irq_parse_raw(const __be32 *addr, struct of_phandle_args *out_irq);
|
|
extern int of_irq_parse_one(struct device_node *device, int index,
|
|
struct of_phandle_args *out_irq);
|
|
extern unsigned int irq_create_of_mapping(struct of_phandle_args *irq_data);
|
|
extern int of_irq_to_resource(struct device_node *dev, int index,
|
|
struct resource *r);
|
|
extern int of_irq_to_resource_table(struct device_node *dev,
|
|
struct resource *res, int nr_irqs);
|
|
|
|
extern void of_irq_init(const struct of_device_id *matches);
|
|
|
|
#ifdef CONFIG_OF_IRQ
|
|
extern int of_irq_count(struct device_node *dev);
|
|
extern int of_irq_get(struct device_node *dev, int index);
|
|
#else
|
|
static inline int of_irq_count(struct device_node *dev)
|
|
{
|
|
return 0;
|
|
}
|
|
static inline int of_irq_get(struct device_node *dev, int index)
|
|
{
|
|
return 0;
|
|
}
|
|
#endif
|
|
|
|
#if defined(CONFIG_OF)
|
|
/*
|
|
* irq_of_parse_and_map() is used by all OF enabled platforms; but SPARC
|
|
* implements it differently. However, the prototype is the same for all,
|
|
* so declare it here regardless of the CONFIG_OF_IRQ setting.
|
|
*/
|
|
extern unsigned int irq_of_parse_and_map(struct device_node *node, int index);
|
|
extern struct device_node *of_irq_find_parent(struct device_node *child);
|
|
|
|
#else /* !CONFIG_OF */
|
|
static inline unsigned int irq_of_parse_and_map(struct device_node *dev,
|
|
int index)
|
|
{
|
|
return 0;
|
|
}
|
|
|
|
static inline void *of_irq_find_parent(struct device_node *child)
|
|
{
|
|
return NULL;
|
|
}
|
|
#endif /* !CONFIG_OF */
|
|
|
|
#endif /* __OF_IRQ_H */
|