6f9ca1d3eb
When building with -Wsometimes-uninitialized, Clang warns: drivers/iio/common/ssp_sensors/ssp_iio.c:95:6: warning: variable 'calculated_time' is used uninitialized whenever 'if' condition is false [-Wsometimes-uninitialized] While it isn't wrong, this will never be a problem because iio_push_to_buffers_with_timestamp only uses calculated_time on the same condition that it is assigned (when scan_timestamp is not zero). While iio_push_to_buffers_with_timestamp is marked as inline, Clang does inlining in the optimization stage, which happens after the semantic analysis phase (plus inline is merely a hint to the compiler). Fix this by just zero initializing calculated_time. Link: https://github.com/ClangBuiltLinux/linux/issues/394 Signed-off-by: Nathan Chancellor <natechancellor@gmail.com> Reviewed-by: Nick Desaulniers <ndesaulniers@google.com> Signed-off-by: Jonathan Cameron <Jonathan.Cameron@huawei.com>
109 lines
3 KiB
C
109 lines
3 KiB
C
/*
|
|
* Copyright (C) 2014, Samsung Electronics Co. Ltd. All Rights Reserved.
|
|
*
|
|
* This program is free software; you can redistribute it and/or modify
|
|
* it under the terms of the GNU General Public License as published by
|
|
* the Free Software Foundation; either version 2 of the License, or
|
|
* (at your option) any later version.
|
|
*
|
|
* This program is distributed in the hope that it will be useful,
|
|
* but WITHOUT ANY WARRANTY; without even the implied warranty of
|
|
* MERCHANTABILITY or FITNESS FOR A PARTICULAR PURPOSE. See the
|
|
* GNU General Public License for more details.
|
|
*
|
|
*/
|
|
|
|
#include <linux/iio/common/ssp_sensors.h>
|
|
#include <linux/iio/buffer.h>
|
|
#include <linux/iio/kfifo_buf.h>
|
|
#include <linux/module.h>
|
|
#include <linux/slab.h>
|
|
#include "ssp_iio_sensor.h"
|
|
|
|
/**
|
|
* ssp_common_buffer_postenable() - generic postenable callback for ssp buffer
|
|
*
|
|
* @indio_dev: iio device
|
|
*
|
|
* Returns 0 or negative value in case of error
|
|
*/
|
|
int ssp_common_buffer_postenable(struct iio_dev *indio_dev)
|
|
{
|
|
struct ssp_sensor_data *spd = iio_priv(indio_dev);
|
|
struct ssp_data *data = dev_get_drvdata(indio_dev->dev.parent->parent);
|
|
|
|
/* the allocation is made in post because scan size is known in this
|
|
* moment
|
|
* */
|
|
spd->buffer = kmalloc(indio_dev->scan_bytes, GFP_KERNEL | GFP_DMA);
|
|
if (!spd->buffer)
|
|
return -ENOMEM;
|
|
|
|
return ssp_enable_sensor(data, spd->type,
|
|
ssp_get_sensor_delay(data, spd->type));
|
|
}
|
|
EXPORT_SYMBOL(ssp_common_buffer_postenable);
|
|
|
|
/**
|
|
* ssp_common_buffer_postdisable() - generic postdisable callback for ssp buffer
|
|
*
|
|
* @indio_dev: iio device
|
|
*
|
|
* Returns 0 or negative value in case of error
|
|
*/
|
|
int ssp_common_buffer_postdisable(struct iio_dev *indio_dev)
|
|
{
|
|
int ret;
|
|
struct ssp_sensor_data *spd = iio_priv(indio_dev);
|
|
struct ssp_data *data = dev_get_drvdata(indio_dev->dev.parent->parent);
|
|
|
|
ret = ssp_disable_sensor(data, spd->type);
|
|
if (ret < 0)
|
|
return ret;
|
|
|
|
kfree(spd->buffer);
|
|
|
|
return ret;
|
|
}
|
|
EXPORT_SYMBOL(ssp_common_buffer_postdisable);
|
|
|
|
/**
|
|
* ssp_common_process_data() - Common process data callback for ssp sensors
|
|
*
|
|
* @indio_dev: iio device
|
|
* @buf: source buffer
|
|
* @len: sensor data length
|
|
* @timestamp: system timestamp
|
|
*
|
|
* Returns 0 or negative value in case of error
|
|
*/
|
|
int ssp_common_process_data(struct iio_dev *indio_dev, void *buf,
|
|
unsigned int len, int64_t timestamp)
|
|
{
|
|
__le32 time;
|
|
int64_t calculated_time = 0;
|
|
struct ssp_sensor_data *spd = iio_priv(indio_dev);
|
|
|
|
if (indio_dev->scan_bytes == 0)
|
|
return 0;
|
|
|
|
/*
|
|
* it always sends full set of samples, remember about available masks
|
|
*/
|
|
memcpy(spd->buffer, buf, len);
|
|
|
|
if (indio_dev->scan_timestamp) {
|
|
memcpy(&time, &((char *)buf)[len], SSP_TIME_SIZE);
|
|
calculated_time =
|
|
timestamp + (int64_t)le32_to_cpu(time) * 1000000;
|
|
}
|
|
|
|
return iio_push_to_buffers_with_timestamp(indio_dev, spd->buffer,
|
|
calculated_time);
|
|
}
|
|
EXPORT_SYMBOL(ssp_common_process_data);
|
|
|
|
MODULE_AUTHOR("Karol Wrona <k.wrona@samsung.com>");
|
|
MODULE_DESCRIPTION("Samsung sensorhub commons");
|
|
MODULE_LICENSE("GPL");
|