kiyin(尹亮) b7f7474b39 perf/core: Fix a memory leak in perf_event_parse_addr_filter() ... commit 7bdb157cde upstream. As shown through runtime testing, the "filename" allocation is not always freed in perf_event_parse_addr_filter(). There are three possible ways that this could happen: - It could be allocated twice on subsequent iterations through the loop, - or leaked on the success path, - or on the failure path. Clean up the code flow to make it obvious that 'filename' is always freed in the reallocation path and in the two return paths as well. We rely on the fact that kfree(NULL) is NOP and filename is initialized with NULL. This fixes the leak. No other side effects expected. [ Dan Carpenter: cleaned up the code flow & added a changelog. ] [ Ingo Molnar: updated the changelog some more. ] Fixes: 375637bc52 ("perf/core: Introduce address range filtering") Signed-off-by: "kiyin(尹亮)" <kiyin@tencent.com> Signed-off-by: Dan Carpenter <dan.carpenter@oracle.com> Signed-off-by: Ingo Molnar <mingo@kernel.org> Cc: "Srivatsa S. Bhat" <srivatsa@csail.mit.edu> Cc: Anthony Liguori <aliguori@amazon.com> -- kernel/events/core.c | 12 +++++------- 1 file changed, 5 insertions(+), 7 deletions(-) Signed-off-by: Greg Kroah-Hartman <gregkh@linuxfoundation.org>		2020-11-10 12:37:34 +01:00
..
Makefile	License cleanup: add SPDX GPL-2.0 license identifier to files with no license	2017-11-02 11:10:55 +01:00
callchain.c	perf/core: Convert to SPDX license identifiers	2019-02-04 08:46:11 +01:00
core.c	perf/core: Fix a memory leak in perf_event_parse_addr_filter()	2020-11-10 12:37:34 +01:00
hw_breakpoint.c	perf/hw_breakpoint: Fix arch_hw_breakpoint use-before-initialization	2019-09-06 08:24:01 +02:00
internal.h	perf/ring-buffer: Use regular variables for nesting	2019-05-24 09:00:11 +02:00
ring_buffer.c	perf/ring-buffer: Use regular variables for nesting	2019-05-24 09:00:11 +02:00
uprobes.c	uprobes: __replace_page() avoid BUG in munlock_vma_page()	2020-08-26 10:40:51 +02:00