1
0
Fork 0
alistair23-linux/drivers/misc/cxl
Daniel Axtens 2c069a118f cxl: Check if afu is not null in cxl_slbia
The pointer to an AFU in the adapter's list of AFUs can be null
if we're in the process of removing AFUs. The afu_list_lock
doesn't guard against this.

Say we have 2 slices, and we're in the process of removing cxl.
 - We remove the AFUs in order (see cxl_remove). In cxl_remove_afu
   for AFU 0, we take the lock, set adapter->afu[0] = NULL, and
   release the lock.
 - Then we get an slbia. In cxl_slbia we take the lock, and set
   afu = adapter->afu[0], which is NULL.
 - Therefore our attempt to check afu->enabled will blow up.

Therefore, check if afu is a null pointer before dereferencing it.

Cc: stable@vger.kernel.org
Signed-off-by: Daniel Axtens <dja@axtens.net>
Acked-by: Michael Neuling <mikey@neuling.org>
Acked-by: Ian Munsie <imunsie@au1.ibm.com>
Signed-off-by: Michael Ellerman <mpe@ellerman.id.au>
2015-07-10 11:44:25 +10:00
..
Kconfig cxl: Add CXL_KERNEL_API config option 2015-06-19 17:10:30 +10:00
Makefile cxl: Add AFU virtual PHB and kernel API 2015-06-03 13:27:20 +10:00
api.c cxl: Fix refcounting in kernel API 2015-07-07 19:38:37 +10:00
base.c cxl: Move include file cxl.h -> cxl-base.h 2015-06-03 13:27:19 +10:00
context.c cxl: Fix off by one error allowing subsequent mmap page to be accessed 2015-07-08 15:17:47 +10:00
cxl.h cxl: Add AFU virtual PHB and kernel API 2015-06-03 13:27:20 +10:00
debugfs.c cxl: Driver code for powernv PCIe based cards for userspace access 2014-10-08 20:15:57 +11:00
fault.c cxl: Only check pid for userspace contexts 2015-06-03 13:27:18 +10:00
file.c cxl: Export file ops for use by API 2015-06-03 13:27:20 +10:00
irq.c cxl: Move include file cxl.h -> cxl-base.h 2015-06-03 13:27:19 +10:00
main.c cxl: Check if afu is not null in cxl_slbia 2015-07-10 11:44:25 +10:00
native.c cxl: Move include file cxl.h -> cxl-base.h 2015-06-03 13:27:19 +10:00
pci.c cxl: Test the correct mmio space before unmapping 2015-07-06 20:24:35 +10:00
sysfs.c cxl: cxl_afu_reset() -> __cxl_afu_reset() 2015-06-03 13:27:18 +10:00
trace.c cxl: Add tracepoints 2015-01-22 17:31:51 +11:00
trace.h cxl: Add tracepoints 2015-01-22 17:31:51 +11:00
vphb.c cxl/vphb.c: Use phb pointer after NULL check 2015-07-06 20:24:34 +10:00