Eduardo Valentin 1bfb159673 bridge: mdb: fix leak on complete_info ptr on fail path ... We currently get the following kmemleak report: unreferenced object 0xffff8800039d9820 (size 32): comm "softirq", pid 0, jiffies 4295212383 (age 792.416s) hex dump (first 32 bytes): 00 0c e0 03 00 88 ff ff ff 02 00 00 00 00 00 00 ................ 00 00 00 01 ff 11 00 02 86 dd 00 00 ff ff ff ff ................ backtrace: [<ffffffff8152b4aa>] kmemleak_alloc+0x4a/0xa0 [<ffffffff811d8ec8>] kmem_cache_alloc_trace+0xb8/0x1c0 [<ffffffffa0389683>] __br_mdb_notify+0x2a3/0x300 [bridge] [<ffffffffa038a0ce>] br_mdb_notify+0x6e/0x70 [bridge] [<ffffffffa0386479>] br_multicast_add_group+0x109/0x150 [bridge] [<ffffffffa0386518>] br_ip6_multicast_add_group+0x58/0x60 [bridge] [<ffffffffa0387fb5>] br_multicast_rcv+0x1d5/0xdb0 [bridge] [<ffffffffa037d7cf>] br_handle_frame_finish+0xcf/0x510 [bridge] [<ffffffffa03a236b>] br_nf_hook_thresh.part.27+0xb/0x10 [br_netfilter] [<ffffffffa03a3738>] br_nf_hook_thresh+0x48/0xb0 [br_netfilter] [<ffffffffa03a3fb9>] br_nf_pre_routing_finish_ipv6+0x109/0x1d0 [br_netfilter] [<ffffffffa03a4400>] br_nf_pre_routing_ipv6+0xd0/0x14c [br_netfilter] [<ffffffffa03a3c27>] br_nf_pre_routing+0x197/0x3d0 [br_netfilter] [<ffffffff814a2952>] nf_iterate+0x52/0x60 [<ffffffff814a29bc>] nf_hook_slow+0x5c/0xb0 [<ffffffffa037ddf4>] br_handle_frame+0x1a4/0x2c0 [bridge] This happens when switchdev_port_obj_add() fails. This patch frees complete_info object in the fail path. Reviewed-by: Vallish Vaidyeshwara <vallish@amazon.com> Signed-off-by: Eduardo Valentin <eduval@amazon.com> Signed-off-by: David S. Miller <davem@davemloft.net>		2017-07-11 20:01:39 -07:00
..
netfilter	Merge git://git.kernel.org/pub/scm/linux/kernel/git/pablo/nf	2017-07-06 14:02:22 +01:00
Kconfig	bridge: Add vlan filtering infrastructure	2013-02-13 19:41:46 -05:00
Makefile	bridge: per vlan dst_metadata netlink support	2017-02-03 15:21:22 -05:00
br.c	net: bridge: Receive notification about successful FDB offload	2017-06-08 14:16:25 -04:00
br_device.c	net: Fix inconsistent teardown and release of private netdev state.	2017-06-07 15:53:24 -04:00
br_fdb.c	bridge: allow ext learned entries to change ports	2017-07-04 01:49:44 -07:00
br_forward.c	bridge: add per-port broadcast flood flag	2017-04-27 16:34:29 -04:00
br_if.c	bridge: Export VLAN filtering state	2017-05-26 15:18:44 -04:00
br_input.c	bridge: drop netfilter fake rtable unconditionally	2017-03-13 13:01:10 -07:00
br_ioctl.c	bridge: move to workqueue gc	2017-02-06 22:53:13 -05:00
br_mdb.c	bridge: mdb: fix leak on complete_info ptr on fail path	2017-07-11 20:01:39 -07:00
br_multicast.c	bridge: Export multicast enabled state	2017-05-26 15:18:44 -04:00
br_netfilter_hooks.c	net: convert nf_bridge_info.use from atomic_t to refcount_t	2017-07-01 07:39:07 -07:00
br_netfilter_ipv6.c	Replace <asm/uaccess.h> with <linux/uaccess.h> globally	2016-12-24 11:46:01 -08:00
br_netlink.c	net: add netlink_ext_ack argument to rtnl_link_ops.slave_changelink	2017-06-26 23:13:22 -04:00
br_netlink_tunnel.c	netlink: pass extended ACK struct to parsing functions	2017-04-13 13:58:22 -04:00
br_nf_core.c	net: Remove protocol from struct dst_ops	2015-03-09 16:06:10 -04:00
br_private.h	net, bridge: convert net_bridge_vlan.refcnt from atomic_t to refcount_t	2017-07-04 22:35:16 +01:00
br_private_stp.h	net: bridge: add helper to set topology change	2016-12-10 21:27:23 -05:00
br_private_tunnel.h	bridge: vlan dst_metadata hooks in ingress and egress paths	2017-02-03 15:21:22 -05:00
br_stp.c	bridge: move to workqueue gc	2017-02-06 22:53:13 -05:00
br_stp_bpdu.c	net: introduce __skb_put_[zero, data, u8]	2017-06-20 13:30:14 -04:00
br_stp_if.c	Merge git://git.kernel.org/pub/scm/linux/kernel/git/davem/net	2017-06-06 22:20:08 -04:00
br_stp_timer.c	bridge: start hello_timer when enabling KERNEL_STP in br_stp_start	2017-05-21 13:33:28 -04:00
br_switchdev.c	net: bridge: Add support for notifying devices about FDB add/del	2017-06-08 14:16:25 -04:00
br_sysfs_br.c	net: bridge: constify attribute_group structures.	2017-06-29 15:48:52 -04:00
br_sysfs_if.c	bridge: add per-port broadcast flood flag	2017-04-27 16:34:29 -04:00
br_vlan.c	net, bridge: convert net_bridge_vlan.refcnt from atomic_t to refcount_t	2017-07-04 22:35:16 +01:00
br_vlan_tunnel.c	bridge: vlan_tunnel: explicitly reset metadata attrs to NULL on failure	2017-02-17 13:33:41 -05:00