1
0
Fork 0
alistair23-linux/net/openvswitch
Florian Westphal 330966e501 net: make skb_gso_segment error handling more robust
skb_gso_segment has three possible return values:
1. a pointer to the first segmented skb
2. an errno value (IS_ERR())
3. NULL.  This can happen when GSO is used for header verification.

However, several callers currently test IS_ERR instead of IS_ERR_OR_NULL
and would oops when NULL is returned.

Note that these call sites should never actually see such a NULL return
value; all callers mask out the GSO bits in the feature argument.

However, there have been issues with some protocol handlers erronously not
respecting the specified feature mask in some cases.

It is preferable to get 'have to turn off hw offloading, else slow' reports
rather than 'kernel crashes'.

Signed-off-by: Florian Westphal <fw@strlen.de>
Signed-off-by: David S. Miller <davem@davemloft.net>
2014-10-20 12:38:13 -04:00
..
Kconfig openvswitch: Add support for Geneve tunneling. 2014-10-06 00:32:21 -04:00
Makefile openvswitch: Add support for Geneve tunneling. 2014-10-06 00:32:21 -04:00
actions.c openvswitch: Wrap struct ovs_key_ipv4_tunnel in a new structure. 2014-10-06 00:32:20 -04:00
datapath.c net: make skb_gso_segment error handling more robust 2014-10-20 12:38:13 -04:00
datapath.h openvswitch: Wrap struct ovs_key_ipv4_tunnel in a new structure. 2014-10-06 00:32:20 -04:00
dp_notify.c genetlink: make multicast groups const, prevent abuse 2013-11-19 16:39:06 -05:00
flow.c openvswitch: Set flow-key members. 2014-10-17 23:54:02 -04:00
flow.h openvswitch: Add support for Geneve tunneling. 2014-10-06 00:32:21 -04:00
flow_netlink.c openvswitch: Create right mask with disabled megaflows 2014-10-17 16:49:34 -04:00
flow_netlink.h openvswitch: refactor ovs flow extract API. 2014-09-15 23:28:13 -07:00
flow_table.c openvswitch: Use exact lookup for flow_get and flow_del. 2014-06-30 20:47:15 -07:00
flow_table.h openvswitch: Use exact lookup for flow_get and flow_del. 2014-06-30 20:47:15 -07:00
vport-geneve.c openvswitch: kerneldoc warning fix 2014-10-15 23:25:33 -04:00
vport-gre.c openvswitch: Add support for Geneve tunneling. 2014-10-06 00:32:21 -04:00
vport-internal_dev.c openvswitch: Enable tunnel GSO for OVS bridge. 2014-07-24 01:15:04 -07:00
vport-internal_dev.h openvswitch: introduce rtnl ops stub 2014-07-01 14:40:17 -07:00
vport-netdev.c openvswitch: fix vport-netdev unregister 2013-10-16 14:50:22 -07:00
vport-netdev.h openvswitch: fix vport-netdev unregister 2013-10-16 14:50:22 -07:00
vport-vxlan.c openvswitch: Add support for Geneve tunneling. 2014-10-06 00:32:21 -04:00
vport.c openvswitch: use vport instead of p 2014-10-15 23:25:33 -04:00
vport.h openvswitch: Add support for Geneve tunneling. 2014-10-06 00:32:21 -04:00