![Tejun Heo](/assets/img/avatar_default.png)
percpu.h is included by sched.h and module.h and thus ends up being included when building most .c files. percpu.h includes slab.h which in turn includes gfp.h making everything defined by the two files universally available and complicating inclusion dependencies. percpu.h -> slab.h dependency is about to be removed. Prepare for this change by updating users of gfp and slab facilities include those headers directly instead of assuming availability. As this conversion needs to touch large number of source files, the following script is used as the basis of conversion. http://userweb.kernel.org/~tj/misc/slabh-sweep.py The script does the followings. * Scan files for gfp and slab usages and update includes such that only the necessary includes are there. ie. if only gfp is used, gfp.h, if slab is used, slab.h. * When the script inserts a new include, it looks at the include blocks and try to put the new include such that its order conforms to its surrounding. It's put in the include block which contains core kernel includes, in the same order that the rest are ordered - alphabetical, Christmas tree, rev-Xmas-tree or at the end if there doesn't seem to be any matching order. * If the script can't find a place to put a new include (mostly because the file doesn't have fitting include block), it prints out an error message indicating which .h file needs to be added to the file. The conversion was done in the following steps. 1. The initial automatic conversion of all .c files updated slightly over 4000 files, deleting around 700 includes and adding ~480 gfp.h and ~3000 slab.h inclusions. The script emitted errors for ~400 files. 2. Each error was manually checked. Some didn't need the inclusion, some needed manual addition while adding it to implementation .h or embedding .c file was more appropriate for others. This step added inclusions to around 150 files. 3. The script was run again and the output was compared to the edits from #2 to make sure no file was left behind. 4. Several build tests were done and a couple of problems were fixed. e.g. lib/decompress_*.c used malloc/free() wrappers around slab APIs requiring slab.h to be added manually. 5. The script was run on all .h files but without automatically editing them as sprinkling gfp.h and slab.h inclusions around .h files could easily lead to inclusion dependency hell. Most gfp.h inclusion directives were ignored as stuff from gfp.h was usually wildly available and often used in preprocessor macros. Each slab.h inclusion directive was examined and added manually as necessary. 6. percpu.h was updated not to include slab.h. 7. Build test were done on the following configurations and failures were fixed. CONFIG_GCOV_KERNEL was turned off for all tests (as my distributed build env didn't work with gcov compiles) and a few more options had to be turned off depending on archs to make things build (like ipr on powerpc/64 which failed due to missing writeq). * x86 and x86_64 UP and SMP allmodconfig and a custom test config. * powerpc and powerpc64 SMP allmodconfig * sparc and sparc64 SMP allmodconfig * ia64 SMP allmodconfig * s390 SMP allmodconfig * alpha SMP allmodconfig * um on x86_64 SMP allmodconfig 8. percpu.h modifications were reverted so that it could be applied as a separate patch and serve as bisection point. Given the fact that I had only a couple of failures from tests on step 6, I'm fairly confident about the coverage of this conversion patch. If there is a breakage, it's likely to be something in one of the arch headers which should be easily discoverable easily on most builds of the specific arch. Signed-off-by: Tejun Heo <tj@kernel.org> Guess-its-ok-by: Christoph Lameter <cl@linux-foundation.org> Cc: Ingo Molnar <mingo@redhat.com> Cc: Lee Schermerhorn <Lee.Schermerhorn@hp.com>
281 lines
6.6 KiB
C
281 lines
6.6 KiB
C
/*
|
|
* LCD Lowlevel Control Abstraction
|
|
*
|
|
* Copyright (C) 2003,2004 Hewlett-Packard Company
|
|
*
|
|
*/
|
|
|
|
#include <linux/module.h>
|
|
#include <linux/init.h>
|
|
#include <linux/device.h>
|
|
#include <linux/lcd.h>
|
|
#include <linux/notifier.h>
|
|
#include <linux/ctype.h>
|
|
#include <linux/err.h>
|
|
#include <linux/fb.h>
|
|
#include <linux/slab.h>
|
|
|
|
#if defined(CONFIG_FB) || (defined(CONFIG_FB_MODULE) && \
|
|
defined(CONFIG_LCD_CLASS_DEVICE_MODULE))
|
|
/* This callback gets called when something important happens inside a
|
|
* framebuffer driver. We're looking if that important event is blanking,
|
|
* and if it is, we're switching lcd power as well ...
|
|
*/
|
|
static int fb_notifier_callback(struct notifier_block *self,
|
|
unsigned long event, void *data)
|
|
{
|
|
struct lcd_device *ld;
|
|
struct fb_event *evdata = data;
|
|
|
|
/* If we aren't interested in this event, skip it immediately ... */
|
|
switch (event) {
|
|
case FB_EVENT_BLANK:
|
|
case FB_EVENT_MODE_CHANGE:
|
|
case FB_EVENT_MODE_CHANGE_ALL:
|
|
break;
|
|
default:
|
|
return 0;
|
|
}
|
|
|
|
ld = container_of(self, struct lcd_device, fb_notif);
|
|
if (!ld->ops)
|
|
return 0;
|
|
|
|
mutex_lock(&ld->ops_lock);
|
|
if (!ld->ops->check_fb || ld->ops->check_fb(ld, evdata->info)) {
|
|
if (event == FB_EVENT_BLANK) {
|
|
if (ld->ops->set_power)
|
|
ld->ops->set_power(ld, *(int *)evdata->data);
|
|
} else {
|
|
if (ld->ops->set_mode)
|
|
ld->ops->set_mode(ld, evdata->data);
|
|
}
|
|
}
|
|
mutex_unlock(&ld->ops_lock);
|
|
return 0;
|
|
}
|
|
|
|
static int lcd_register_fb(struct lcd_device *ld)
|
|
{
|
|
memset(&ld->fb_notif, 0, sizeof(ld->fb_notif));
|
|
ld->fb_notif.notifier_call = fb_notifier_callback;
|
|
return fb_register_client(&ld->fb_notif);
|
|
}
|
|
|
|
static void lcd_unregister_fb(struct lcd_device *ld)
|
|
{
|
|
fb_unregister_client(&ld->fb_notif);
|
|
}
|
|
#else
|
|
static int lcd_register_fb(struct lcd_device *ld)
|
|
{
|
|
return 0;
|
|
}
|
|
|
|
static inline void lcd_unregister_fb(struct lcd_device *ld)
|
|
{
|
|
}
|
|
#endif /* CONFIG_FB */
|
|
|
|
static ssize_t lcd_show_power(struct device *dev, struct device_attribute *attr,
|
|
char *buf)
|
|
{
|
|
int rc;
|
|
struct lcd_device *ld = to_lcd_device(dev);
|
|
|
|
mutex_lock(&ld->ops_lock);
|
|
if (ld->ops && ld->ops->get_power)
|
|
rc = sprintf(buf, "%d\n", ld->ops->get_power(ld));
|
|
else
|
|
rc = -ENXIO;
|
|
mutex_unlock(&ld->ops_lock);
|
|
|
|
return rc;
|
|
}
|
|
|
|
static ssize_t lcd_store_power(struct device *dev,
|
|
struct device_attribute *attr, const char *buf, size_t count)
|
|
{
|
|
int rc = -ENXIO;
|
|
char *endp;
|
|
struct lcd_device *ld = to_lcd_device(dev);
|
|
int power = simple_strtoul(buf, &endp, 0);
|
|
size_t size = endp - buf;
|
|
|
|
if (isspace(*endp))
|
|
size++;
|
|
if (size != count)
|
|
return -EINVAL;
|
|
|
|
mutex_lock(&ld->ops_lock);
|
|
if (ld->ops && ld->ops->set_power) {
|
|
pr_debug("lcd: set power to %d\n", power);
|
|
ld->ops->set_power(ld, power);
|
|
rc = count;
|
|
}
|
|
mutex_unlock(&ld->ops_lock);
|
|
|
|
return rc;
|
|
}
|
|
|
|
static ssize_t lcd_show_contrast(struct device *dev,
|
|
struct device_attribute *attr, char *buf)
|
|
{
|
|
int rc = -ENXIO;
|
|
struct lcd_device *ld = to_lcd_device(dev);
|
|
|
|
mutex_lock(&ld->ops_lock);
|
|
if (ld->ops && ld->ops->get_contrast)
|
|
rc = sprintf(buf, "%d\n", ld->ops->get_contrast(ld));
|
|
mutex_unlock(&ld->ops_lock);
|
|
|
|
return rc;
|
|
}
|
|
|
|
static ssize_t lcd_store_contrast(struct device *dev,
|
|
struct device_attribute *attr, const char *buf, size_t count)
|
|
{
|
|
int rc = -ENXIO;
|
|
char *endp;
|
|
struct lcd_device *ld = to_lcd_device(dev);
|
|
int contrast = simple_strtoul(buf, &endp, 0);
|
|
size_t size = endp - buf;
|
|
|
|
if (isspace(*endp))
|
|
size++;
|
|
if (size != count)
|
|
return -EINVAL;
|
|
|
|
mutex_lock(&ld->ops_lock);
|
|
if (ld->ops && ld->ops->set_contrast) {
|
|
pr_debug("lcd: set contrast to %d\n", contrast);
|
|
ld->ops->set_contrast(ld, contrast);
|
|
rc = count;
|
|
}
|
|
mutex_unlock(&ld->ops_lock);
|
|
|
|
return rc;
|
|
}
|
|
|
|
static ssize_t lcd_show_max_contrast(struct device *dev,
|
|
struct device_attribute *attr, char *buf)
|
|
{
|
|
struct lcd_device *ld = to_lcd_device(dev);
|
|
|
|
return sprintf(buf, "%d\n", ld->props.max_contrast);
|
|
}
|
|
|
|
static struct class *lcd_class;
|
|
|
|
static void lcd_device_release(struct device *dev)
|
|
{
|
|
struct lcd_device *ld = to_lcd_device(dev);
|
|
kfree(ld);
|
|
}
|
|
|
|
static struct device_attribute lcd_device_attributes[] = {
|
|
__ATTR(lcd_power, 0644, lcd_show_power, lcd_store_power),
|
|
__ATTR(contrast, 0644, lcd_show_contrast, lcd_store_contrast),
|
|
__ATTR(max_contrast, 0444, lcd_show_max_contrast, NULL),
|
|
__ATTR_NULL,
|
|
};
|
|
|
|
/**
|
|
* lcd_device_register - register a new object of lcd_device class.
|
|
* @name: the name of the new object(must be the same as the name of the
|
|
* respective framebuffer device).
|
|
* @devdata: an optional pointer to be stored in the device. The
|
|
* methods may retrieve it by using lcd_get_data(ld).
|
|
* @ops: the lcd operations structure.
|
|
*
|
|
* Creates and registers a new lcd device. Returns either an ERR_PTR()
|
|
* or a pointer to the newly allocated device.
|
|
*/
|
|
struct lcd_device *lcd_device_register(const char *name, struct device *parent,
|
|
void *devdata, struct lcd_ops *ops)
|
|
{
|
|
struct lcd_device *new_ld;
|
|
int rc;
|
|
|
|
pr_debug("lcd_device_register: name=%s\n", name);
|
|
|
|
new_ld = kzalloc(sizeof(struct lcd_device), GFP_KERNEL);
|
|
if (!new_ld)
|
|
return ERR_PTR(-ENOMEM);
|
|
|
|
mutex_init(&new_ld->ops_lock);
|
|
mutex_init(&new_ld->update_lock);
|
|
|
|
new_ld->dev.class = lcd_class;
|
|
new_ld->dev.parent = parent;
|
|
new_ld->dev.release = lcd_device_release;
|
|
dev_set_name(&new_ld->dev, name);
|
|
dev_set_drvdata(&new_ld->dev, devdata);
|
|
|
|
rc = device_register(&new_ld->dev);
|
|
if (rc) {
|
|
kfree(new_ld);
|
|
return ERR_PTR(rc);
|
|
}
|
|
|
|
rc = lcd_register_fb(new_ld);
|
|
if (rc) {
|
|
device_unregister(&new_ld->dev);
|
|
return ERR_PTR(rc);
|
|
}
|
|
|
|
new_ld->ops = ops;
|
|
|
|
return new_ld;
|
|
}
|
|
EXPORT_SYMBOL(lcd_device_register);
|
|
|
|
/**
|
|
* lcd_device_unregister - unregisters a object of lcd_device class.
|
|
* @ld: the lcd device object to be unregistered and freed.
|
|
*
|
|
* Unregisters a previously registered via lcd_device_register object.
|
|
*/
|
|
void lcd_device_unregister(struct lcd_device *ld)
|
|
{
|
|
if (!ld)
|
|
return;
|
|
|
|
mutex_lock(&ld->ops_lock);
|
|
ld->ops = NULL;
|
|
mutex_unlock(&ld->ops_lock);
|
|
lcd_unregister_fb(ld);
|
|
|
|
device_unregister(&ld->dev);
|
|
}
|
|
EXPORT_SYMBOL(lcd_device_unregister);
|
|
|
|
static void __exit lcd_class_exit(void)
|
|
{
|
|
class_destroy(lcd_class);
|
|
}
|
|
|
|
static int __init lcd_class_init(void)
|
|
{
|
|
lcd_class = class_create(THIS_MODULE, "lcd");
|
|
if (IS_ERR(lcd_class)) {
|
|
printk(KERN_WARNING "Unable to create backlight class; errno = %ld\n",
|
|
PTR_ERR(lcd_class));
|
|
return PTR_ERR(lcd_class);
|
|
}
|
|
|
|
lcd_class->dev_attrs = lcd_device_attributes;
|
|
return 0;
|
|
}
|
|
|
|
/*
|
|
* if this is compiled into the kernel, we need to ensure that the
|
|
* class is registered before users of the class try to register lcd's
|
|
*/
|
|
postcore_initcall(lcd_class_init);
|
|
module_exit(lcd_class_exit);
|
|
|
|
MODULE_LICENSE("GPL");
|
|
MODULE_AUTHOR("Jamey Hicks <jamey.hicks@hp.com>, Andrew Zabolotny <zap@homelink.ru>");
|
|
MODULE_DESCRIPTION("LCD Lowlevel Control Abstraction");
|