6f4e02193c
When the state of rep was introduced, it was also designed to prevent
duplicate unloading of the same rep. Considering the following two
flows when an eswitch manager is at switchdev mode with n VF reps loaded.
+--------------------------------------+--------------------------------+
| cpu-0 | cpu-1 |
| -------- | -------- |
| mlx5_ib_remove | mlx5_eswitch_disable_sriov |
| mlx5_ib_unregister_vport_reps | esw_offloads_cleanup |
| mlx5_eswitch_unregister_vport_reps | esw_offloads_unload_all_reps |
| __unload_reps_all_vport | __unload_reps_all_vport |
+--------------------------------------+--------------------------------+
These two flows will try to unload the same rep. Per original design,
once one flow unloads the rep, the state moves to REGISTERED. The 2nd
flow will no longer needs to do the unload and bails out. However, as
read and write of the state is not atomic, when 1st flow is doing the
unload, the state is still LOADED, 2nd flow is able to do the same
unload action. Kernel crash will happen.
To solve this, driver should do atomic test-and-set for the state. So
that only one flow can change the rep state from LOADED to REGISTERED,
and proceed to do the actual unloading.
Since the state is changing to atomic type, all other read/write should
be atomic action as well.
Fixes: f121e0ea95 (net/mlx5: E-Switch, Add state to eswitch vport representors)
Signed-off-by: Bodong Wang <bodong@mellanox.com>
Reviewed-by: Parav Pandit <parav@mellanox.com>
Reviewed-by: Vu Pham <vuhuong@mellanox.com>
Signed-off-by: Saeed Mahameed <saeedm@mellanox.com>
64 lines
1.5 KiB
C
64 lines
1.5 KiB
C
/* SPDX-License-Identifier: (GPL-2.0+ OR BSD-3-Clause) */
|
|
/*
|
|
* Copyright (c) 2018 Mellanox Technologies. All rights reserved.
|
|
*/
|
|
|
|
#ifndef _MLX5_ESWITCH_
|
|
#define _MLX5_ESWITCH_
|
|
|
|
#include <linux/mlx5/driver.h>
|
|
|
|
#define MLX5_ESWITCH_MANAGER(mdev) MLX5_CAP_GEN(mdev, eswitch_manager)
|
|
|
|
enum {
|
|
SRIOV_NONE,
|
|
SRIOV_LEGACY,
|
|
SRIOV_OFFLOADS
|
|
};
|
|
|
|
enum {
|
|
REP_ETH,
|
|
REP_IB,
|
|
NUM_REP_TYPES,
|
|
};
|
|
|
|
enum {
|
|
REP_UNREGISTERED,
|
|
REP_REGISTERED,
|
|
REP_LOADED,
|
|
};
|
|
|
|
struct mlx5_eswitch_rep;
|
|
struct mlx5_eswitch_rep_if {
|
|
int (*load)(struct mlx5_core_dev *dev,
|
|
struct mlx5_eswitch_rep *rep);
|
|
void (*unload)(struct mlx5_eswitch_rep *rep);
|
|
void *(*get_proto_dev)(struct mlx5_eswitch_rep *rep);
|
|
void *priv;
|
|
atomic_t state;
|
|
};
|
|
|
|
struct mlx5_eswitch_rep {
|
|
struct mlx5_eswitch_rep_if rep_if[NUM_REP_TYPES];
|
|
u16 vport;
|
|
u8 hw_id[ETH_ALEN];
|
|
u16 vlan;
|
|
u32 vlan_refcount;
|
|
};
|
|
|
|
void mlx5_eswitch_register_vport_reps(struct mlx5_eswitch *esw,
|
|
struct mlx5_eswitch_rep_if *rep_if,
|
|
u8 rep_type);
|
|
void mlx5_eswitch_unregister_vport_reps(struct mlx5_eswitch *esw, u8 rep_type);
|
|
void *mlx5_eswitch_get_proto_dev(struct mlx5_eswitch *esw,
|
|
int vport,
|
|
u8 rep_type);
|
|
struct mlx5_eswitch_rep *mlx5_eswitch_vport_rep(struct mlx5_eswitch *esw,
|
|
int vport);
|
|
void *mlx5_eswitch_uplink_get_proto_dev(struct mlx5_eswitch *esw, u8 rep_type);
|
|
u8 mlx5_eswitch_mode(struct mlx5_eswitch *esw);
|
|
struct mlx5_flow_handle *
|
|
mlx5_eswitch_add_send_to_vport_rule(struct mlx5_eswitch *esw,
|
|
int vport, u32 sqn);
|
|
#endif
|