![Ander Conselvan de Oliveira](/assets/img/avatar_default.png)
Use the helpers introduced by the commit below to properly initialize
the duplicated states.
commit f5e7840b0c
Author: Thierry Reding <treding@nvidia.com>
Date: Wed Jan 28 14:54:32 2015 +0100
drm/atomic: Add helpers for state-subclassing drivers
Signed-off-by: Ander Conselvan de Oliveira <ander.conselvan.de.oliveira@intel.com>
Reviewed-by: Maarten Lankhorst <maarten.lankhorst@linux.intel.com>
Signed-off-by: Daniel Vetter <daniel.vetter@ffwll.ch>
424 lines
12 KiB
C
424 lines
12 KiB
C
/*
|
|
* Copyright © 2015 Intel Corporation
|
|
*
|
|
* Permission is hereby granted, free of charge, to any person obtaining a
|
|
* copy of this software and associated documentation files (the "Software"),
|
|
* to deal in the Software without restriction, including without limitation
|
|
* the rights to use, copy, modify, merge, publish, distribute, sublicense,
|
|
* and/or sell copies of the Software, and to permit persons to whom the
|
|
* Software is furnished to do so, subject to the following conditions:
|
|
*
|
|
* The above copyright notice and this permission notice (including the next
|
|
* paragraph) shall be included in all copies or substantial portions of the
|
|
* Software.
|
|
*
|
|
* THE SOFTWARE IS PROVIDED "AS IS", WITHOUT WARRANTY OF ANY KIND, EXPRESS OR
|
|
* IMPLIED, INCLUDING BUT NOT LIMITED TO THE WARRANTIES OF MERCHANTABILITY,
|
|
* FITNESS FOR A PARTICULAR PURPOSE AND NONINFRINGEMENT. IN NO EVENT SHALL
|
|
* THE AUTHORS OR COPYRIGHT HOLDERS BE LIABLE FOR ANY CLAIM, DAMAGES OR OTHER
|
|
* LIABILITY, WHETHER IN AN ACTION OF CONTRACT, TORT OR OTHERWISE, ARISING
|
|
* FROM, OUT OF OR IN CONNECTION WITH THE SOFTWARE OR THE USE OR OTHER
|
|
* DEALINGS IN THE SOFTWARE.
|
|
*/
|
|
|
|
/**
|
|
* DOC: atomic modeset support
|
|
*
|
|
* The functions here implement the state management and hardware programming
|
|
* dispatch required by the atomic modeset infrastructure.
|
|
* See intel_atomic_plane.c for the plane-specific atomic functionality.
|
|
*/
|
|
|
|
#include <drm/drmP.h>
|
|
#include <drm/drm_atomic.h>
|
|
#include <drm/drm_atomic_helper.h>
|
|
#include <drm/drm_plane_helper.h>
|
|
#include "intel_drv.h"
|
|
|
|
|
|
/**
|
|
* intel_atomic_check - validate state object
|
|
* @dev: drm device
|
|
* @state: state to validate
|
|
*/
|
|
int intel_atomic_check(struct drm_device *dev,
|
|
struct drm_atomic_state *state)
|
|
{
|
|
int nplanes = dev->mode_config.num_total_plane;
|
|
int ncrtcs = dev->mode_config.num_crtc;
|
|
int nconnectors = dev->mode_config.num_connector;
|
|
enum pipe nuclear_pipe = INVALID_PIPE;
|
|
struct intel_crtc *nuclear_crtc = NULL;
|
|
struct intel_crtc_state *crtc_state = NULL;
|
|
int ret;
|
|
int i;
|
|
bool not_nuclear = false;
|
|
|
|
/*
|
|
* FIXME: At the moment, we only support "nuclear pageflip" on a
|
|
* single CRTC. Cross-crtc updates will be added later.
|
|
*/
|
|
for (i = 0; i < nplanes; i++) {
|
|
struct intel_plane *plane = to_intel_plane(state->planes[i]);
|
|
if (!plane)
|
|
continue;
|
|
|
|
if (nuclear_pipe == INVALID_PIPE) {
|
|
nuclear_pipe = plane->pipe;
|
|
} else if (nuclear_pipe != plane->pipe) {
|
|
DRM_DEBUG_KMS("i915 only support atomic plane operations on a single CRTC at the moment\n");
|
|
return -EINVAL;
|
|
}
|
|
}
|
|
|
|
/*
|
|
* FIXME: We only handle planes for now; make sure there are no CRTC's
|
|
* or connectors involved.
|
|
*/
|
|
state->allow_modeset = false;
|
|
for (i = 0; i < ncrtcs; i++) {
|
|
struct intel_crtc *crtc = to_intel_crtc(state->crtcs[i]);
|
|
if (crtc)
|
|
memset(&crtc->atomic, 0, sizeof(crtc->atomic));
|
|
if (crtc && crtc->pipe != nuclear_pipe)
|
|
not_nuclear = true;
|
|
if (crtc && crtc->pipe == nuclear_pipe) {
|
|
nuclear_crtc = crtc;
|
|
crtc_state = to_intel_crtc_state(state->crtc_states[i]);
|
|
}
|
|
}
|
|
for (i = 0; i < nconnectors; i++)
|
|
if (state->connectors[i] != NULL)
|
|
not_nuclear = true;
|
|
|
|
if (not_nuclear) {
|
|
DRM_DEBUG_KMS("i915 only supports atomic plane operations at the moment\n");
|
|
return -EINVAL;
|
|
}
|
|
|
|
ret = drm_atomic_helper_check_planes(dev, state);
|
|
if (ret)
|
|
return ret;
|
|
|
|
/* FIXME: move to crtc atomic check function once it is ready */
|
|
ret = intel_atomic_setup_scalers(dev, nuclear_crtc, crtc_state);
|
|
if (ret)
|
|
return ret;
|
|
|
|
return ret;
|
|
}
|
|
|
|
|
|
/**
|
|
* intel_atomic_commit - commit validated state object
|
|
* @dev: DRM device
|
|
* @state: the top-level driver state object
|
|
* @async: asynchronous commit
|
|
*
|
|
* This function commits a top-level state object that has been validated
|
|
* with drm_atomic_helper_check().
|
|
*
|
|
* FIXME: Atomic modeset support for i915 is not yet complete. At the moment
|
|
* we can only handle plane-related operations and do not yet support
|
|
* asynchronous commit.
|
|
*
|
|
* RETURNS
|
|
* Zero for success or -errno.
|
|
*/
|
|
int intel_atomic_commit(struct drm_device *dev,
|
|
struct drm_atomic_state *state,
|
|
bool async)
|
|
{
|
|
int ret;
|
|
int i;
|
|
|
|
if (async) {
|
|
DRM_DEBUG_KMS("i915 does not yet support async commit\n");
|
|
return -EINVAL;
|
|
}
|
|
|
|
ret = drm_atomic_helper_prepare_planes(dev, state);
|
|
if (ret)
|
|
return ret;
|
|
|
|
/* Point of no return */
|
|
|
|
/*
|
|
* FIXME: The proper sequence here will eventually be:
|
|
*
|
|
* drm_atomic_helper_swap_state(dev, state)
|
|
* drm_atomic_helper_commit_modeset_disables(dev, state);
|
|
* drm_atomic_helper_commit_planes(dev, state);
|
|
* drm_atomic_helper_commit_modeset_enables(dev, state);
|
|
* drm_atomic_helper_wait_for_vblanks(dev, state);
|
|
* drm_atomic_helper_cleanup_planes(dev, state);
|
|
* drm_atomic_state_free(state);
|
|
*
|
|
* once we have full atomic modeset. For now, just manually update
|
|
* plane states to avoid clobbering good states with dummy states
|
|
* while nuclear pageflipping.
|
|
*/
|
|
for (i = 0; i < dev->mode_config.num_total_plane; i++) {
|
|
struct drm_plane *plane = state->planes[i];
|
|
|
|
if (!plane)
|
|
continue;
|
|
|
|
plane->state->state = state;
|
|
swap(state->plane_states[i], plane->state);
|
|
plane->state->state = NULL;
|
|
}
|
|
|
|
/* swap crtc_scaler_state */
|
|
for (i = 0; i < dev->mode_config.num_crtc; i++) {
|
|
struct drm_crtc *crtc = state->crtcs[i];
|
|
if (!crtc) {
|
|
continue;
|
|
}
|
|
|
|
to_intel_crtc(crtc)->config->scaler_state =
|
|
to_intel_crtc_state(state->crtc_states[i])->scaler_state;
|
|
|
|
if (INTEL_INFO(dev)->gen >= 9)
|
|
skl_detach_scalers(to_intel_crtc(crtc));
|
|
}
|
|
|
|
drm_atomic_helper_commit_planes(dev, state);
|
|
drm_atomic_helper_wait_for_vblanks(dev, state);
|
|
drm_atomic_helper_cleanup_planes(dev, state);
|
|
drm_atomic_state_free(state);
|
|
|
|
return 0;
|
|
}
|
|
|
|
/**
|
|
* intel_connector_atomic_get_property - fetch connector property value
|
|
* @connector: connector to fetch property for
|
|
* @state: state containing the property value
|
|
* @property: property to look up
|
|
* @val: pointer to write property value into
|
|
*
|
|
* The DRM core does not store shadow copies of properties for
|
|
* atomic-capable drivers. This entrypoint is used to fetch
|
|
* the current value of a driver-specific connector property.
|
|
*/
|
|
int
|
|
intel_connector_atomic_get_property(struct drm_connector *connector,
|
|
const struct drm_connector_state *state,
|
|
struct drm_property *property,
|
|
uint64_t *val)
|
|
{
|
|
int i;
|
|
|
|
/*
|
|
* TODO: We only have atomic modeset for planes at the moment, so the
|
|
* crtc/connector code isn't quite ready yet. Until it's ready,
|
|
* continue to look up all property values in the DRM's shadow copy
|
|
* in obj->properties->values[].
|
|
*
|
|
* When the crtc/connector state work matures, this function should
|
|
* be updated to read the values out of the state structure instead.
|
|
*/
|
|
for (i = 0; i < connector->base.properties->count; i++) {
|
|
if (connector->base.properties->properties[i] == property) {
|
|
*val = connector->base.properties->values[i];
|
|
return 0;
|
|
}
|
|
}
|
|
|
|
return -EINVAL;
|
|
}
|
|
|
|
/*
|
|
* intel_crtc_duplicate_state - duplicate crtc state
|
|
* @crtc: drm crtc
|
|
*
|
|
* Allocates and returns a copy of the crtc state (both common and
|
|
* Intel-specific) for the specified crtc.
|
|
*
|
|
* Returns: The newly allocated crtc state, or NULL on failure.
|
|
*/
|
|
struct drm_crtc_state *
|
|
intel_crtc_duplicate_state(struct drm_crtc *crtc)
|
|
{
|
|
struct intel_crtc *intel_crtc = to_intel_crtc(crtc);
|
|
struct intel_crtc_state *crtc_state;
|
|
|
|
if (WARN_ON(!intel_crtc->config))
|
|
crtc_state = kzalloc(sizeof(*crtc_state), GFP_KERNEL);
|
|
else
|
|
crtc_state = kmemdup(intel_crtc->config,
|
|
sizeof(*intel_crtc->config), GFP_KERNEL);
|
|
|
|
if (!crtc_state)
|
|
return NULL;
|
|
|
|
__drm_atomic_helper_crtc_duplicate_state(crtc, &crtc_state->base);
|
|
|
|
crtc_state->base.crtc = crtc;
|
|
|
|
return &crtc_state->base;
|
|
}
|
|
|
|
/**
|
|
* intel_crtc_destroy_state - destroy crtc state
|
|
* @crtc: drm crtc
|
|
*
|
|
* Destroys the crtc state (both common and Intel-specific) for the
|
|
* specified crtc.
|
|
*/
|
|
void
|
|
intel_crtc_destroy_state(struct drm_crtc *crtc,
|
|
struct drm_crtc_state *state)
|
|
{
|
|
drm_atomic_helper_crtc_destroy_state(crtc, state);
|
|
}
|
|
|
|
/**
|
|
* intel_atomic_setup_scalers() - setup scalers for crtc per staged requests
|
|
* @dev: DRM device
|
|
* @crtc: intel crtc
|
|
* @crtc_state: incoming crtc_state to validate and setup scalers
|
|
*
|
|
* This function sets up scalers based on staged scaling requests for
|
|
* a @crtc and its planes. It is called from crtc level check path. If request
|
|
* is a supportable request, it attaches scalers to requested planes and crtc.
|
|
*
|
|
* This function takes into account the current scaler(s) in use by any planes
|
|
* not being part of this atomic state
|
|
*
|
|
* Returns:
|
|
* 0 - scalers were setup succesfully
|
|
* error code - otherwise
|
|
*/
|
|
int intel_atomic_setup_scalers(struct drm_device *dev,
|
|
struct intel_crtc *intel_crtc,
|
|
struct intel_crtc_state *crtc_state)
|
|
{
|
|
struct drm_plane *plane = NULL;
|
|
struct intel_plane *intel_plane;
|
|
struct intel_plane_state *plane_state = NULL;
|
|
struct intel_crtc_scaler_state *scaler_state;
|
|
struct drm_atomic_state *drm_state;
|
|
int num_scalers_need;
|
|
int i, j;
|
|
|
|
if (INTEL_INFO(dev)->gen < 9 || !intel_crtc || !crtc_state)
|
|
return 0;
|
|
|
|
scaler_state = &crtc_state->scaler_state;
|
|
drm_state = crtc_state->base.state;
|
|
|
|
num_scalers_need = hweight32(scaler_state->scaler_users);
|
|
DRM_DEBUG_KMS("crtc_state = %p need = %d avail = %d scaler_users = 0x%x\n",
|
|
crtc_state, num_scalers_need, intel_crtc->num_scalers,
|
|
scaler_state->scaler_users);
|
|
|
|
/*
|
|
* High level flow:
|
|
* - staged scaler requests are already in scaler_state->scaler_users
|
|
* - check whether staged scaling requests can be supported
|
|
* - add planes using scalers that aren't in current transaction
|
|
* - assign scalers to requested users
|
|
* - as part of plane commit, scalers will be committed
|
|
* (i.e., either attached or detached) to respective planes in hw
|
|
* - as part of crtc_commit, scaler will be either attached or detached
|
|
* to crtc in hw
|
|
*/
|
|
|
|
/* fail if required scalers > available scalers */
|
|
if (num_scalers_need > intel_crtc->num_scalers){
|
|
DRM_DEBUG_KMS("Too many scaling requests %d > %d\n",
|
|
num_scalers_need, intel_crtc->num_scalers);
|
|
return -EINVAL;
|
|
}
|
|
|
|
/* walkthrough scaler_users bits and start assigning scalers */
|
|
for (i = 0; i < sizeof(scaler_state->scaler_users) * 8; i++) {
|
|
int *scaler_id;
|
|
|
|
/* skip if scaler not required */
|
|
if (!(scaler_state->scaler_users & (1 << i)))
|
|
continue;
|
|
|
|
if (i == SKL_CRTC_INDEX) {
|
|
/* panel fitter case: assign as a crtc scaler */
|
|
scaler_id = &scaler_state->scaler_id;
|
|
} else {
|
|
if (!drm_state)
|
|
continue;
|
|
|
|
/* plane scaler case: assign as a plane scaler */
|
|
/* find the plane that set the bit as scaler_user */
|
|
plane = drm_state->planes[i];
|
|
|
|
/*
|
|
* to enable/disable hq mode, add planes that are using scaler
|
|
* into this transaction
|
|
*/
|
|
if (!plane) {
|
|
struct drm_plane_state *state;
|
|
plane = drm_plane_from_index(dev, i);
|
|
state = drm_atomic_get_plane_state(drm_state, plane);
|
|
if (IS_ERR(state)) {
|
|
DRM_DEBUG_KMS("Failed to add [PLANE:%d] to drm_state\n",
|
|
plane->base.id);
|
|
return PTR_ERR(state);
|
|
}
|
|
}
|
|
|
|
intel_plane = to_intel_plane(plane);
|
|
|
|
/* plane on different crtc cannot be a scaler user of this crtc */
|
|
if (WARN_ON(intel_plane->pipe != intel_crtc->pipe)) {
|
|
continue;
|
|
}
|
|
|
|
plane_state = to_intel_plane_state(drm_state->plane_states[i]);
|
|
scaler_id = &plane_state->scaler_id;
|
|
}
|
|
|
|
if (*scaler_id < 0) {
|
|
/* find a free scaler */
|
|
for (j = 0; j < intel_crtc->num_scalers; j++) {
|
|
if (!scaler_state->scalers[j].in_use) {
|
|
scaler_state->scalers[j].in_use = 1;
|
|
*scaler_id = scaler_state->scalers[j].id;
|
|
DRM_DEBUG_KMS("Attached scaler id %u.%u to %s:%d\n",
|
|
intel_crtc->pipe,
|
|
i == SKL_CRTC_INDEX ? scaler_state->scaler_id :
|
|
plane_state->scaler_id,
|
|
i == SKL_CRTC_INDEX ? "CRTC" : "PLANE",
|
|
i == SKL_CRTC_INDEX ? intel_crtc->base.base.id :
|
|
plane->base.id);
|
|
break;
|
|
}
|
|
}
|
|
}
|
|
|
|
if (WARN_ON(*scaler_id < 0)) {
|
|
DRM_DEBUG_KMS("Cannot find scaler for %s:%d\n",
|
|
i == SKL_CRTC_INDEX ? "CRTC" : "PLANE",
|
|
i == SKL_CRTC_INDEX ? intel_crtc->base.base.id:plane->base.id);
|
|
continue;
|
|
}
|
|
|
|
/* set scaler mode */
|
|
if (num_scalers_need == 1 && intel_crtc->pipe != PIPE_C) {
|
|
/*
|
|
* when only 1 scaler is in use on either pipe A or B,
|
|
* scaler 0 operates in high quality (HQ) mode.
|
|
* In this case use scaler 0 to take advantage of HQ mode
|
|
*/
|
|
*scaler_id = 0;
|
|
scaler_state->scalers[0].in_use = 1;
|
|
scaler_state->scalers[0].mode = PS_SCALER_MODE_HQ;
|
|
scaler_state->scalers[1].in_use = 0;
|
|
} else {
|
|
scaler_state->scalers[*scaler_id].mode = PS_SCALER_MODE_DYN;
|
|
}
|
|
}
|
|
|
|
return 0;
|
|
}
|