![Taeung Song](/assets/img/avatar_default.png)
Many sub-commands use perf_config() but everytime perf_config() is called, perf_config() always read config files. (i.e. user config '~/.perfconfig' and system config '$(sysconfdir)/perfconfig') But it is better to use the config set that already contains all config key-value pairs to avoid this repetitive work reading the config files in perf_config(). (the config set mean a static variable 'config_set') In other words, if new perf_config__init() is called, only first time 'config_set' is initialized collecting all configs from the config files. And then we could use new perf_config() like old perf_config(). When a sub-command finished, free the config set by perf_config__exit() at run_builtin(). If we do, 'config_set' can be reused wherever perf_config() is called and a feature of old perf_config() is the same as new perf_config() work without the repetitive work that read the config files. In summary, in order to use features about configuration, we can call the functions at perf.c and other source files as below. # initialize a config set perf_config__init() # configure actual variables from a config set perf_config() # eliminate allocated config set perf_config__exit() # destroy existing config set and initialize a new config set. perf_config__refresh() Signed-off-by: Taeung Song <treeze.taeung@gmail.com> Cc: Alexander Shishkin <alexander.shishkin@linux.intel.com> Cc: Jiri Olsa <jolsa@kernel.org> Cc: Masami Hiramatsu <mhiramat@kernel.org> Cc: Namhyung Kim <namhyung@kernel.org> Cc: Peter Zijlstra <peterz@infradead.org> Cc: Wang Nan <wangnan0@huawei.com> Link: http://lkml.kernel.org/r/1466691272-24117-3-git-send-email-treeze.taeung@gmail.com [ 'init' counterpart is 'exit', not 'finish' ] Signed-off-by: Arnaldo Carvalho de Melo <acme@redhat.com>
67 lines
1.9 KiB
C
67 lines
1.9 KiB
C
#ifndef __PERF_CONFIG_H
|
|
#define __PERF_CONFIG_H
|
|
|
|
#include <stdbool.h>
|
|
#include <linux/list.h>
|
|
|
|
struct perf_config_item {
|
|
char *name;
|
|
char *value;
|
|
struct list_head node;
|
|
};
|
|
|
|
struct perf_config_section {
|
|
char *name;
|
|
struct list_head items;
|
|
struct list_head node;
|
|
};
|
|
|
|
struct perf_config_set {
|
|
struct list_head sections;
|
|
};
|
|
|
|
extern const char *config_exclusive_filename;
|
|
|
|
typedef int (*config_fn_t)(const char *, const char *, void *);
|
|
int perf_default_config(const char *, const char *, void *);
|
|
int perf_config(config_fn_t fn, void *);
|
|
int perf_config_int(const char *, const char *);
|
|
u64 perf_config_u64(const char *, const char *);
|
|
int perf_config_bool(const char *, const char *);
|
|
int config_error_nonbool(const char *);
|
|
const char *perf_etc_perfconfig(void);
|
|
|
|
struct perf_config_set *perf_config_set__new(void);
|
|
void perf_config_set__delete(struct perf_config_set *set);
|
|
void perf_config__init(void);
|
|
void perf_config__exit(void);
|
|
void perf_config__refresh(void);
|
|
|
|
/**
|
|
* perf_config_sections__for_each - iterate thru all the sections
|
|
* @list: list_head instance to iterate
|
|
* @section: struct perf_config_section iterator
|
|
*/
|
|
#define perf_config_sections__for_each_entry(list, section) \
|
|
list_for_each_entry(section, list, node)
|
|
|
|
/**
|
|
* perf_config_items__for_each - iterate thru all the items
|
|
* @list: list_head instance to iterate
|
|
* @item: struct perf_config_item iterator
|
|
*/
|
|
#define perf_config_items__for_each_entry(list, item) \
|
|
list_for_each_entry(item, list, node)
|
|
|
|
/**
|
|
* perf_config_set__for_each - iterate thru all the config section-item pairs
|
|
* @set: evlist instance to iterate
|
|
* @section: struct perf_config_section iterator
|
|
* @item: struct perf_config_item iterator
|
|
*/
|
|
#define perf_config_set__for_each_entry(set, section, item) \
|
|
perf_config_sections__for_each_entry(&set->sections, section) \
|
|
perf_config_items__for_each_entry(§ion->items, item)
|
|
|
|
#endif /* __PERF_CONFIG_H */
|