1
0
Fork 0
alistair23-linux/drivers/net/xen-netback
Willem de Bruijn cc8737a5fe xen-netback: update ubuf_info initialization to anonymous union
The xen driver initializes struct ubuf_info fields using designated
initializers. I recently moved these fields inside a nested anonymous
struct inside an anonymous union. I had missed this use case.

This breaks compilation of xen-netback with older compilers.
>From kbuild bot with gcc-4.4.7:

   drivers/net//xen-netback/interface.c: In function
   'xenvif_init_queue':
   >> drivers/net//xen-netback/interface.c:554: error: unknown field 'ctx' specified in initializer
   >> drivers/net//xen-netback/interface.c:554: warning: missing braces around initializer
      drivers/net//xen-netback/interface.c:554: warning: (near initialization for '(anonymous).<anonymous>')
   >> drivers/net//xen-netback/interface.c:554: warning: initialization makes integer from pointer without a cast
   >> drivers/net//xen-netback/interface.c:555: error: unknown field 'desc' specified in initializer

Add double braces around the designated initializers to match their
nested position in the struct. After this, compilation succeeds again.

Fixes: 4ab6c99d99 ("sock: MSG_ZEROCOPY notification coalescing")
Reported-by: kbuild bot <lpk@intel.com>
Signed-off-by: Willem de Bruijn <willemb@google.com>
Acked-by: Wei Liu <wei.liu2@citrix.com>
Signed-off-by: David S. Miller <davem@davemloft.net>
2017-08-28 15:11:50 -07:00
..
Makefile xen-netback: separate guest side rx code into separate module 2016-10-06 20:37:35 -04:00
common.h xen-netback: correctly schedule rate-limited queues 2017-06-22 11:15:42 -04:00
hash.c xen-netback: Use GFP_ATOMIC to allocate hash 2017-03-02 14:44:22 -08:00
interface.c xen-netback: update ubuf_info initialization to anonymous union 2017-08-28 15:11:50 -07:00
netback.c xen-netback: correctly schedule rate-limited queues 2017-06-22 11:15:42 -04:00
rx.c xen-netback: fix type mismatch warning 2016-10-13 11:02:25 -04:00
xenbus.c xen-netback: fix race condition on XenBus disconnect 2017-03-12 23:44:43 -07:00