![Russell King](/assets/img/avatar_default.png)
As suggested by Andrew Morton: This is a pet peeve of mine. Any time there's a long list of items (header file inclusions, kconfig entries, array initalisers, etc) and someone wants to add a new item, they *always* go and stick it at the end of the list. Guys, don't do this. Either put the new item into a randomly-chosen position or, probably better, alphanumerically sort the list. lets sort all our select statements alphanumerically. This commit was created by the following perl: while (<>) { while (/\\\s*$/) { $_ .= <>; } undef %selects if /^\s*config\s+/; if (/^\s+select\s+(\w+).*/) { if (defined($selects{$1})) { if ($selects{$1} eq $_) { print STDERR "Warning: removing duplicated $1 entry\n"; } else { print STDERR "Error: $1 differently selected\n". "\tOld: $selects{$1}\n". "\tNew: $_\n"; exit 1; } } $selects{$1} = $_; next; } if (%selects and (/^\s*$/ or /^\s+help/ or /^\s+---help---/ or /^endif/ or /^endchoice/)) { foreach $k (sort (keys %selects)) { print "$selects{$k}"; } undef %selects; } print; } if (%selects) { foreach $k (sort (keys %selects)) { print "$selects{$k}"; } } It found two duplicates: Warning: removing duplicated S5P_SETUP_MIPIPHY entry Warning: removing duplicated HARDIRQS_SW_RESEND entry and they are identical duplicates, hence the shrinkage in the diffstat of two lines. We have four testers reporting success of this change (Tony, Stephen, Linus and Sekhar.) Acked-by: Jason Cooper <jason@lakedaemon.net> Acked-by: Tony Lindgren <tony@atomide.com> Acked-by: Stephen Warren <swarren@nvidia.com> Acked-by: Linus Walleij <linus.walleij@linaro.org> Acked-by: Sekhar Nori <nsekhar@ti.com> Signed-off-by: Russell King <rmk+kernel@arm.linux.org.uk>
117 lines
2.8 KiB
Plaintext
117 lines
2.8 KiB
Plaintext
# Copyright 2007 Simtec Electronics
|
|
#
|
|
# Licensed under GPLv2
|
|
|
|
config PLAT_S3C24XX
|
|
bool
|
|
depends on ARCH_S3C24XX
|
|
default y
|
|
select ARCH_REQUIRE_GPIOLIB
|
|
select NO_IOPORT
|
|
select S3C_DEV_NAND
|
|
help
|
|
Base platform code for any Samsung S3C24XX device
|
|
|
|
if PLAT_S3C24XX
|
|
|
|
# low-level serial option nodes
|
|
|
|
config CPU_LLSERIAL_S3C2410_ONLY
|
|
bool
|
|
default y if CPU_LLSERIAL_S3C2410 && !CPU_LLSERIAL_S3C2440
|
|
|
|
config CPU_LLSERIAL_S3C2440_ONLY
|
|
bool
|
|
default y if CPU_LLSERIAL_S3C2440 && !CPU_LLSERIAL_S3C2410
|
|
|
|
config CPU_LLSERIAL_S3C2410
|
|
bool
|
|
help
|
|
Selected if there is an S3C2410 (or register compatible) serial
|
|
low-level implementation needed
|
|
|
|
config CPU_LLSERIAL_S3C2440
|
|
bool
|
|
help
|
|
Selected if there is an S3C2440 (or register compatible) serial
|
|
low-level implementation needed
|
|
|
|
# code that is shared between a number of the s3c24xx implementations
|
|
|
|
config S3C2410_CLOCK
|
|
bool
|
|
help
|
|
Clock code for the S3C2410, and similar processors which
|
|
is currently includes the S3C2410, S3C2440, S3C2442.
|
|
|
|
config S3C24XX_DCLK
|
|
bool
|
|
help
|
|
Clock code for supporting DCLK/CLKOUT on S3C24XX architectures
|
|
|
|
# gpio configurations
|
|
|
|
config S3C24XX_GPIO_EXTRA
|
|
int
|
|
default 128 if S3C24XX_GPIO_EXTRA128
|
|
default 64 if S3C24XX_GPIO_EXTRA64
|
|
default 16 if ARCH_H1940
|
|
default 0
|
|
|
|
config S3C24XX_GPIO_EXTRA64
|
|
bool
|
|
help
|
|
Add an extra 64 gpio numbers to the available GPIO pool. This is
|
|
available for boards that need extra gpios for external devices.
|
|
|
|
config S3C24XX_GPIO_EXTRA128
|
|
bool
|
|
help
|
|
Add an extra 128 gpio numbers to the available GPIO pool. This is
|
|
available for boards that need extra gpios for external devices.
|
|
|
|
config S3C24XX_DMA
|
|
bool "S3C2410 DMA support"
|
|
depends on ARCH_S3C24XX
|
|
select S3C_DMA
|
|
help
|
|
S3C2410 DMA support. This is needed for drivers like sound which
|
|
use the S3C2410's DMA system to move data to and from the
|
|
peripheral blocks.
|
|
|
|
config S3C2410_DMA_DEBUG
|
|
bool "S3C2410 DMA support debug"
|
|
depends on ARCH_S3C24XX && S3C2410_DMA
|
|
help
|
|
Enable debugging output for the DMA code. This option sends info
|
|
to the kernel log, at priority KERN_DEBUG.
|
|
|
|
# common code for s3c24xx based machines, such as the SMDKs.
|
|
|
|
# cpu frequency items common between s3c2410 and s3c2440/s3c2442
|
|
|
|
config S3C2410_IOTIMING
|
|
bool
|
|
depends on CPU_FREQ_S3C24XX
|
|
help
|
|
Internal node to select io timing code that is common to the s3c2410
|
|
and s3c2440/s3c2442 cpu frequency support.
|
|
|
|
config S3C2410_CPUFREQ_UTILS
|
|
bool
|
|
depends on CPU_FREQ_S3C24XX
|
|
help
|
|
Internal node to select timing code that is common to the s3c2410
|
|
and s3c2440/s3c244 cpu frequency support.
|
|
|
|
# cpu frequency support common to s3c2412, s3c2413 and s3c2442
|
|
|
|
config S3C2412_IOTIMING
|
|
bool
|
|
depends on CPU_FREQ_S3C24XX && (CPU_S3C2412 || CPU_S3C2443)
|
|
help
|
|
Intel node to select io timing code that is common to the s3c2412
|
|
and the s3c2443.
|
|
|
|
endif
|