1
0
Fork 0
alistair23-linux/drivers/net/ethernet/sfc/falcon
Will Deacon fb24ea52f7 drivers: Remove explicit invocations of mmiowb()
mmiowb() is now implied by spin_unlock() on architectures that require
it, so there is no reason to call it from driver code. This patch was
generated using coccinelle:

	@mmiowb@
	@@
	- mmiowb();

and invoked as:

$ for d in drivers include/linux/qed sound; do \
spatch --include-headers --sp-file mmiowb.cocci --dir $d --in-place; done

NOTE: mmiowb() has only ever guaranteed ordering in conjunction with
spin_unlock(). However, pairing each mmiowb() removal in this patch with
the corresponding call to spin_unlock() is not at all trivial, so there
is a small chance that this change may regress any drivers incorrectly
relying on mmiowb() to order MMIO writes between CPUs using lock-free
synchronisation. If you've ended up bisecting to this commit, you can
reintroduce the mmiowb() calls using wmb() instead, which should restore
the old behaviour on all architectures other than some esoteric ia64
systems.

Acked-by: Linus Torvalds <torvalds@linux-foundation.org>
Signed-off-by: Will Deacon <will.deacon@arm.com>
2019-04-08 12:01:02 +01:00
..
Kconfig
Makefile License cleanup: add SPDX GPL-2.0 license identifier to files with no license 2017-11-02 11:10:55 +01:00
bitfield.h
efx.c pci-v4.20-changes 2018-10-25 06:50:48 -07:00
efx.h net: ethernet/sfc: Convert timers to use timer_setup() 2017-10-25 12:57:33 +09:00
enum.h sfc: falcon: remove duplicated bit-wise or of LOOPBACK_SGMII 2018-02-26 11:33:52 -05:00
ethtool.c net: core: dev: Add extack argument to dev_open() 2018-12-06 13:26:06 -08:00
falcon.c Merge git://git.kernel.org/pub/scm/linux/kernel/git/davem/net-next 2017-11-15 11:56:19 -08:00
falcon_boards.c
farch.c treewide: Use array_size() in vzalloc() 2018-06-12 16:19:22 -07:00
farch_regs.h
filter.h
io.h drivers: Remove explicit invocations of mmiowb() 2019-04-08 12:01:02 +01:00
mdio_10g.c
mdio_10g.h
mtd.c mtd: Stop updating erase_info->state and calling mtd_erase_callback() 2018-03-21 09:50:56 +01:00
net_driver.h sfc-falcon: get rid of custom busy polling code 2017-02-03 09:56:50 -05:00
nic.c cross-tree: phase out dma_zalloc_coherent() 2019-01-08 07:58:37 -05:00
nic.h Merge git://git.kernel.org/pub/scm/linux/kernel/git/davem/net-next 2017-11-15 11:56:19 -08:00
phy.h
qt202x_phy.c
rx.c Merge branch 'akpm' (patches from Andrew) 2017-11-15 19:42:40 -08:00
selftest.c networking: make skb_put & friends return void pointers 2017-06-16 11:48:39 -04:00
selftest.h
tenxpress.c
tx.c Merge git://git.kernel.org/pub/scm/linux/kernel/git/davem/net-next 2017-11-15 11:56:19 -08:00
tx.h
txc43128_phy.c
workarounds.h