1
0
Fork 0
alistair23-linux/drivers/isdn/gigaset
Jiri Slaby fc258f8940 TTY: isdn/gigaset, do not set tty->driver_data to NULL
Close the window in open where driver_data is reset to NULL on each
open. It could cause other processes to get invalid retval from the
tty->ops operations because of the checks all over the code.

With this change we may do other cleanups. Now, the only valid check
for tty->driver_data != NULL is in close. This can happen only if open
fails at gigaset_get_cs_by_tty or try_module_get. The rest of checks
in various tty->ops->* are invalid as driver_data cannot be NULL
there. The same holds for cs->open_count. So remove them.

Signed-off-by: Jiri Slaby <jslaby@suse.cz>
Cc: Hansjoerg Lipp <hjlipp@web.de>
Cc: Tilman Schmidt <tilman@imap.cc>
Cc: gigaset307x-common@lists.sourceforge.net
Signed-off-by: Greg Kroah-Hartman <gregkh@linuxfoundation.org>
2012-03-08 12:51:13 -08:00
..
Kconfig isdn/gigaset: remove EXPERIMENTAL tag from GIGASET_CAPI 2010-07-07 16:57:56 -07:00
Makefile gigaset: add Kernel CAPI interface (v3) 2009-10-06 22:43:53 -07:00
asyncdata.c drivers/isdn: Add export.h for EXPORT_SYMBOL/THIS_MODULE as required. 2011-10-31 19:31:49 -04:00
bas-gigaset.c isdn: gigaset: Fix set-but-unused variable. 2011-04-17 16:22:33 -07:00
capi.c drivers/isdn: Add export.h for EXPORT_SYMBOL/THIS_MODULE as required. 2011-10-31 19:31:49 -04:00
common.c TTY: remove unneeded tty->index checks 2012-03-08 11:42:21 -08:00
dummyll.c drivers/isdn: Add export.h for EXPORT_SYMBOL/THIS_MODULE as required. 2011-10-31 19:31:49 -04:00
ev-layer.c drivers/isdn: Add export.h for EXPORT_SYMBOL/THIS_MODULE as required. 2011-10-31 19:31:49 -04:00
gigaset.h atomic: use <linux/atomic.h> 2011-07-26 16:49:47 -07:00
i4l.c isdn/gigaset: report ISDN4Linux interface only once 2011-11-27 17:08:30 -05:00
interface.c TTY: isdn/gigaset, do not set tty->driver_data to NULL 2012-03-08 12:51:13 -08:00
isocdata.c isdn/gigaset: correct bas_gigaset rx buffer handling 2010-10-01 00:33:33 -07:00
proc.c gigaset: include cleanup cleanup 2010-04-18 02:33:29 -07:00
ser-gigaset.c Revert "tty: make receive_buf() return the amout of bytes received" 2011-06-04 06:33:24 +09:00
usb-gigaset.c tree-wide: fix comment/printk typos 2010-11-01 15:38:34 -04:00