3db8cc1065
Deduplication of formats and consolidating tests makes the object much smaller. Add bnx2fc_debug.c, add functions for a few logging functions (BNX2FC_IO_DBG, BNX2FC_TGT_DBG, BNX2FC_HBA_DBG). Use printf extension %pV. Add and use pr_fmt and pr_<level>. Move the debug #include below structure definitions. $ size drivers/scsi/bnx2fc/built-in.o* text data bss dec hex filename 101563 1165 24976 127704 1f2d8 drivers/scsi/bnx2fc/built-in.o.new 138473 1109 33400 172982 2a3b6 drivers/scsi/bnx2fc/built-in.o.old Signed-off-by: Joe Perches <joe@perches.com> Signed-off-by: Bhanu Prakash Gollapudi <bprakash@broadcom.com> Signed-off-by: James Bottomley <JBottomley@Parallels.com>
71 lines
1.3 KiB
C
71 lines
1.3 KiB
C
#include "bnx2fc.h"
|
|
|
|
void BNX2FC_IO_DBG(const struct bnx2fc_cmd *io_req, const char *fmt, ...)
|
|
{
|
|
struct va_format vaf;
|
|
va_list args;
|
|
|
|
if (likely(!(bnx2fc_debug_level & LOG_IO)))
|
|
return;
|
|
|
|
va_start(args, fmt);
|
|
|
|
vaf.fmt = fmt;
|
|
vaf.va = &args;
|
|
|
|
if (io_req && io_req->port && io_req->port->lport &&
|
|
io_req->port->lport->host)
|
|
shost_printk(KERN_INFO, io_req->port->lport->host,
|
|
PFX "xid:0x%x %pV",
|
|
io_req->xid, &vaf);
|
|
else
|
|
pr_info("NULL %pV", &vaf);
|
|
|
|
va_end(args);
|
|
}
|
|
|
|
void BNX2FC_TGT_DBG(const struct bnx2fc_rport *tgt, const char *fmt, ...)
|
|
{
|
|
struct va_format vaf;
|
|
va_list args;
|
|
|
|
if (likely(!(bnx2fc_debug_level & LOG_TGT)))
|
|
return;
|
|
|
|
va_start(args, fmt);
|
|
|
|
vaf.fmt = fmt;
|
|
vaf.va = &args;
|
|
|
|
if (tgt && tgt->port && tgt->port->lport && tgt->port->lport->host &&
|
|
tgt->rport)
|
|
shost_printk(KERN_INFO, tgt->port->lport->host,
|
|
PFX "port:%x %pV",
|
|
tgt->rport->port_id, &vaf);
|
|
else
|
|
pr_info("NULL %pV", &vaf);
|
|
|
|
va_end(args);
|
|
}
|
|
|
|
void BNX2FC_HBA_DBG(const struct fc_lport *lport, const char *fmt, ...)
|
|
{
|
|
struct va_format vaf;
|
|
va_list args;
|
|
|
|
if (likely(!(bnx2fc_debug_level & LOG_HBA)))
|
|
return;
|
|
|
|
va_start(args, fmt);
|
|
|
|
vaf.fmt = fmt;
|
|
vaf.va = &args;
|
|
|
|
if (lport && lport->host)
|
|
shost_printk(KERN_INFO, lport->host, PFX "%pV", &vaf);
|
|
else
|
|
pr_info("NULL %pV", &vaf);
|
|
|
|
va_end(args);
|
|
}
|