0a938697d7
gcc-6 warns about a pointless loop in exynos_drm_subdrv_open:
drivers/gpu/drm/exynos/exynos_drm_core.c: In function 'exynos_drm_subdrv_open':
drivers/gpu/drm/exynos/exynos_drm_core.c:104:199: error: self-comparison always evaluates to false [-Werror=tautological-compare]
list_for_each_entry_reverse(subdrv, &subdrv->list, list) {
Here, the list_for_each_entry_reverse immediately terminates because
the subdrv pointer is compared to itself as the loop end condition.
If we were to take the current subdrv pointer as the start of the
list (as we would do if list_for_each_entry_reverse() was not a macro),
we would iterate backwards over the &exynos_drm_subdrv_list anchor,
which would be even worse.
Instead, we need to use list_for_each_entry_continue_reverse()
to go back over each subdrv that was successfully opened until
the first entry.
Signed-off-by: Arnd Bergmann <arnd@arndb.de>
Signed-off-by: Inki Dae <inki.dae@samsung.com>
120 lines
2.5 KiB
C
120 lines
2.5 KiB
C
/* exynos_drm_core.c
|
|
*
|
|
* Copyright (c) 2011 Samsung Electronics Co., Ltd.
|
|
* Author:
|
|
* Inki Dae <inki.dae@samsung.com>
|
|
* Joonyoung Shim <jy0922.shim@samsung.com>
|
|
* Seung-Woo Kim <sw0312.kim@samsung.com>
|
|
*
|
|
* This program is free software; you can redistribute it and/or modify it
|
|
* under the terms of the GNU General Public License as published by the
|
|
* Free Software Foundation; either version 2 of the License, or (at your
|
|
* option) any later version.
|
|
*/
|
|
|
|
#include <drm/drmP.h>
|
|
#include "exynos_drm_drv.h"
|
|
#include "exynos_drm_crtc.h"
|
|
#include "exynos_drm_fbdev.h"
|
|
|
|
static LIST_HEAD(exynos_drm_subdrv_list);
|
|
|
|
int exynos_drm_subdrv_register(struct exynos_drm_subdrv *subdrv)
|
|
{
|
|
if (!subdrv)
|
|
return -EINVAL;
|
|
|
|
list_add_tail(&subdrv->list, &exynos_drm_subdrv_list);
|
|
|
|
return 0;
|
|
}
|
|
|
|
int exynos_drm_subdrv_unregister(struct exynos_drm_subdrv *subdrv)
|
|
{
|
|
if (!subdrv)
|
|
return -EINVAL;
|
|
|
|
list_del(&subdrv->list);
|
|
|
|
return 0;
|
|
}
|
|
|
|
int exynos_drm_device_subdrv_probe(struct drm_device *dev)
|
|
{
|
|
struct exynos_drm_subdrv *subdrv, *n;
|
|
int err;
|
|
|
|
if (!dev)
|
|
return -EINVAL;
|
|
|
|
list_for_each_entry_safe(subdrv, n, &exynos_drm_subdrv_list, list) {
|
|
if (subdrv->probe) {
|
|
subdrv->drm_dev = dev;
|
|
|
|
/*
|
|
* this probe callback would be called by sub driver
|
|
* after setting of all resources to this sub driver,
|
|
* such as clock, irq and register map are done.
|
|
*/
|
|
err = subdrv->probe(dev, subdrv->dev);
|
|
if (err) {
|
|
DRM_DEBUG("exynos drm subdrv probe failed.\n");
|
|
list_del(&subdrv->list);
|
|
continue;
|
|
}
|
|
}
|
|
}
|
|
|
|
return 0;
|
|
}
|
|
|
|
int exynos_drm_device_subdrv_remove(struct drm_device *dev)
|
|
{
|
|
struct exynos_drm_subdrv *subdrv;
|
|
|
|
if (!dev) {
|
|
WARN(1, "Unexpected drm device unregister!\n");
|
|
return -EINVAL;
|
|
}
|
|
|
|
list_for_each_entry(subdrv, &exynos_drm_subdrv_list, list) {
|
|
if (subdrv->remove)
|
|
subdrv->remove(dev, subdrv->dev);
|
|
}
|
|
|
|
return 0;
|
|
}
|
|
|
|
int exynos_drm_subdrv_open(struct drm_device *dev, struct drm_file *file)
|
|
{
|
|
struct exynos_drm_subdrv *subdrv;
|
|
int ret;
|
|
|
|
list_for_each_entry(subdrv, &exynos_drm_subdrv_list, list) {
|
|
if (subdrv->open) {
|
|
ret = subdrv->open(dev, subdrv->dev, file);
|
|
if (ret)
|
|
goto err;
|
|
}
|
|
}
|
|
|
|
return 0;
|
|
|
|
err:
|
|
list_for_each_entry_continue_reverse(subdrv, &exynos_drm_subdrv_list, list) {
|
|
if (subdrv->close)
|
|
subdrv->close(dev, subdrv->dev, file);
|
|
}
|
|
return ret;
|
|
}
|
|
|
|
void exynos_drm_subdrv_close(struct drm_device *dev, struct drm_file *file)
|
|
{
|
|
struct exynos_drm_subdrv *subdrv;
|
|
|
|
list_for_each_entry(subdrv, &exynos_drm_subdrv_list, list) {
|
|
if (subdrv->close)
|
|
subdrv->close(dev, subdrv->dev, file);
|
|
}
|
|
}
|