1
0
Fork 0
alistair23-linux/drivers/isdn/hardware/avm
Nathan Chancellor 7afa81c55f isdn: avm: Fix string plus integer warning from Clang
A recent commit in Clang expanded the -Wstring-plus-int warning, showing
some odd behavior in this file.

drivers/isdn/hardware/avm/b1.c:426:30: warning: adding 'int' to a string does not append to the string [-Wstring-plus-int]
                cinfo->version[j] = "\0\0" + 1;
                                    ~~~~~~~^~~
drivers/isdn/hardware/avm/b1.c:426:30: note: use array indexing to silence this warning
                cinfo->version[j] = "\0\0" + 1;
                                           ^
                                    &      [  ]
1 warning generated.

This is equivalent to just "\0". Nick pointed out that it is smarter to
use "" instead of "\0" because "" is used elsewhere in the kernel and
can be deduplicated at the linking stage.

Link: https://github.com/ClangBuiltLinux/linux/issues/309
Suggested-by: Nick Desaulniers <ndesaulniers@google.com>
Signed-off-by: Nathan Chancellor <natechancellor@gmail.com>
Signed-off-by: David S. Miller <davem@davemloft.net>
2019-01-19 10:01:03 -08:00
..
Kconfig
Makefile License cleanup: add SPDX GPL-2.0 license identifier to files with no license 2017-11-02 11:10:55 +01:00
avm_cs.c drivers/isdn: use module_pcmcia_driver() in pcmcia drivers 2013-03-15 12:26:04 -07:00
avmcard.h isdn: replace ->proc_fops with ->proc_show 2018-05-16 07:24:30 +02:00
b1.c isdn: avm: Fix string plus integer warning from Clang 2019-01-19 10:01:03 -08:00
b1dma.c isdn: replace ->proc_fops with ->proc_show 2018-05-16 07:24:30 +02:00
b1isa.c isdn: replace ->proc_fops with ->proc_show 2018-05-16 07:24:30 +02:00
b1pci.c isdn: replace ->proc_fops with ->proc_show 2018-05-16 07:24:30 +02:00
b1pcmcia.c isdn: replace ->proc_fops with ->proc_show 2018-05-16 07:24:30 +02:00
c4.c isdn: replace ->proc_fops with ->proc_show 2018-05-16 07:24:30 +02:00
t1isa.c isdn: replace ->proc_fops with ->proc_show 2018-05-16 07:24:30 +02:00
t1pci.c isdn: replace ->proc_fops with ->proc_show 2018-05-16 07:24:30 +02:00