redonkable/freescale-linux-fslc
redonkable/freescale-linux-fslc
1
0
Fork 0
Code Releases Activity

sound: sound_firmware: Fix invalid use of vfs_read()

Browse source 
It should use kernel_read() instead of vfs_read() to load a firmware
binary onto the kernel pages.

Signed-off-by: Takashi Iwai <tiwai@suse.de>
This commit is contained in:
Takashi Iwai 2015-05-26 12:57:56 +02:00
parent 574d69c27b
commit 0d769a523a
1 changed files with 1 additions and 3 deletions
Show stats Download patch file Download diff file Expand all files Collapse all files

4
sound/sound_firmware.c
View file

@ -12,7 +12,6 @@ static int do_mod_firmware_load(const char *fn, char **fp)
struct file* filp; struct file* filp;
long l; long l;
char *dp; char *dp;
loff_t pos;
filp = filp_open(fn, 0, 0); filp = filp_open(fn, 0, 0);
if (IS_ERR(filp)) if (IS_ERR(filp))
@ -34,8 +33,7 @@ static int do_mod_firmware_load(const char *fn, char **fp)
fput(filp); fput(filp);
return 0; return 0;
} }
pos = 0; if (kernel_read(filp, 0, dp, l) != l)
if (vfs_read(filp, dp, l, &pos) != l)
{ {
printk(KERN_INFO "Failed to read '%s'.\n", fn); printk(KERN_INFO "Failed to read '%s'.\n", fn);
vfree(dp); vfree(dp);