redonkable
/
freescale-linux-fslc
1
0
Fork 0
Code Releases Activity

KEYS: trusted: Fix memory leak on object td 

commit 83a775d5f9 upstream.

Two error return paths are neglecting to free allocated object td,
causing a memory leak. Fix this by returning via the error return
path that securely kfree's td.

Fixes clang scan-build warning:
security/keys/trusted-keys/trusted_tpm1.c:496:10: warning: Potential
memory leak [unix.Malloc]

Cc: stable@vger.kernel.org
Fixes: 5df16caada ("KEYS: trusted: Fix incorrect handling of tpm_get_random()")
Signed-off-by: Colin Ian King <colin.king@canonical.com>
Reviewed-by: Nick Desaulniers <ndesaulniers@google.com>
Reviewed-by: Jarkko Sakkinen <jarkko@kernel.org>
Signed-off-by: Jarkko Sakkinen <jarkko@kernel.org>
Signed-off-by: Greg Kroah-Hartman <gregkh@linuxfoundation.org>
pull/345/head^2
Colin Ian King 2021-04-30 12:37:24 +01:00 committed by Greg Kroah-Hartman
parent e97bd1e03e
commit 31c9a4b24d
1 changed files with 5 additions and 3 deletions
Show Stats Download Patch File Download Diff File Expand all files Collapse all files

8
security/keys/trusted-keys/trusted_tpm1.c
View File

@ -500,10 +500,12 @@ static int tpm_seal(struct tpm_buf *tb, uint16_t keytype,
ret = tpm_get_random(chip, td->nonceodd, TPM_NONCE_SIZE);
if (ret < 0)
return ret;
goto out;
if (ret != TPM_NONCE_SIZE)
return -EIO;
if (ret != TPM_NONCE_SIZE) {
ret = -EIO;
goto out;
}
ordinal = htonl(TPM_ORD_SEAL);
datsize = htonl(datalen);