media: Clarify how menus are hidden by SUBDRV_AUTOSELECT
Some users have been having a hard time finding the hidden menus. A typically case are camera sensor drivers (e.g IMX219, OV5645, etc), which are common on embedded platforms and not really "ancillary" devices. The problem with MEDIA_SUBDRV_AUTOSELECT seems to be related to the fact that it uses the "visible" syntax to hide the menus. This is not obvious and it normally takes some time to figure out. To fix the problem, add a comment on each of hidden menus, which should clarify what option is causing menus to be hidden. Signed-off-by: Ezequiel Garcia <ezequiel@collabora.com> Signed-off-by: Hans Verkuil <hverkuil-cisco@xs4all.nl> Signed-off-by: Mauro Carvalho Chehab <mchehab+samsung@kernel.org>
This commit is contained in:
parent
31d5d15dfc
commit
4fa4ef39e1
|
@ -207,6 +207,11 @@ config MEDIA_SUBDRV_AUTOSELECT
|
|||
|
||||
If unsure say Y.
|
||||
|
||||
config MEDIA_HIDE_ANCILLARY_SUBDRV
|
||||
bool
|
||||
depends on MEDIA_SUBDRV_AUTOSELECT && !COMPILE_TEST && !EXPERT
|
||||
default y
|
||||
|
||||
config MEDIA_ATTACH
|
||||
bool
|
||||
depends on MEDIA_ANALOG_TV_SUPPORT || MEDIA_DIGITAL_TV_SUPPORT || MEDIA_RADIO_SUPPORT
|
||||
|
|
|
@ -1,5 +1,8 @@
|
|||
comment "DVB Frontend drivers hidden by 'Autoselect ancillary drivers'"
|
||||
depends on MEDIA_HIDE_ANCILLARY_SUBDRV
|
||||
|
||||
menu "Customise DVB Frontends"
|
||||
visible if !MEDIA_SUBDRV_AUTOSELECT || COMPILE_TEST || EXPERT
|
||||
visible if !MEDIA_HIDE_ANCILLARY_SUBDRV
|
||||
|
||||
comment "Multistandard (satellite) frontends"
|
||||
depends on DVB_CORE
|
||||
|
|
|
@ -22,8 +22,11 @@ config VIDEO_IR_I2C
|
|||
# Encoder / Decoder module configuration
|
||||
#
|
||||
|
||||
comment "I2C drivers hidden by 'Autoselect ancillary drivers'"
|
||||
depends on MEDIA_HIDE_ANCILLARY_SUBDRV
|
||||
|
||||
menu "I2C Encoders, decoders, sensors and other helper chips"
|
||||
visible if !MEDIA_SUBDRV_AUTOSELECT || COMPILE_TEST || EXPERT
|
||||
visible if !MEDIA_HIDE_ANCILLARY_SUBDRV
|
||||
|
||||
comment "Audio decoders, processors and mixers"
|
||||
|
||||
|
|
|
@ -1,8 +1,11 @@
|
|||
# SPDX-License-Identifier: GPL-2.0-only
|
||||
if VIDEO_V4L2
|
||||
|
||||
comment "SPI drivers hidden by 'Autoselect ancillary drivers'"
|
||||
depends on MEDIA_HIDE_ANCILLARY_SUBDRV
|
||||
|
||||
menu "SPI helper chips"
|
||||
visible if !MEDIA_SUBDRV_AUTOSELECT || COMPILE_TEST || EXPERT
|
||||
visible if !MEDIA_HIDE_ANCILLARY_SUBDRV
|
||||
|
||||
config VIDEO_GS1662
|
||||
tristate "Gennum Serializers video"
|
||||
|
|
|
@ -15,8 +15,12 @@ config MEDIA_TUNER
|
|||
select MEDIA_TUNER_TDA9887 if MEDIA_SUBDRV_AUTOSELECT
|
||||
select MEDIA_TUNER_MC44S803 if MEDIA_SUBDRV_AUTOSELECT
|
||||
|
||||
comment "Tuner drivers hidden by 'Autoselect ancillary drivers'"
|
||||
depends on MEDIA_HIDE_ANCILLARY_SUBDRV
|
||||
depends on MEDIA_ANALOG_TV_SUPPORT || MEDIA_DIGITAL_TV_SUPPORT || MEDIA_RADIO_SUPPORT || MEDIA_SDR_SUPPORT
|
||||
|
||||
menu "Customize TV tuners"
|
||||
visible if !MEDIA_SUBDRV_AUTOSELECT || COMPILE_TEST || EXPERT
|
||||
visible if !MEDIA_HIDE_ANCILLARY_SUBDRV
|
||||
depends on MEDIA_ANALOG_TV_SUPPORT || MEDIA_DIGITAL_TV_SUPPORT || MEDIA_RADIO_SUPPORT || MEDIA_SDR_SUPPORT
|
||||
|
||||
config MEDIA_TUNER_SIMPLE
|
||||
|
|
Loading…
Reference in a new issue