crypto: drivers - Remove dev_err() usage after platform_get_irq()
We don't need dev_err() messages when platform_get_irq() fails now that platform_get_irq() prints an error message itself when something goes wrong. Let's remove these prints with a simple semantic patch. // <smpl> @@ expression ret; struct platform_device *E; @@ ret = ( platform_get_irq(E, ...) | platform_get_irq_byname(E, ...) ); if ( \( ret < 0 \| ret <= 0 \) ) { ( -if (ret != -EPROBE_DEFER) -{ ... -dev_err(...); -... } | ... -dev_err(...); ) ... } // </smpl> While we're here, remove braces on if statements that only have one statement (manually). Cc: Greg Kroah-Hartman <gregkh@linuxfoundation.org> Cc: Herbert Xu <herbert@gondor.apana.org.au> Cc: "David S. Miller" <davem@davemloft.net> Cc: <linux-crypto@vger.kernel.org> Signed-off-by: Stephen Boyd <swboyd@chromium.org> Signed-off-by: Herbert Xu <herbert@gondor.apana.org.au>
This commit is contained in:
parent
f26882a347
commit
514838e920
|
@ -2673,7 +2673,6 @@ static int atmel_aes_probe(struct platform_device *pdev)
|
|||
/* Get the IRQ */
|
||||
aes_dd->irq = platform_get_irq(pdev, 0);
|
||||
if (aes_dd->irq < 0) {
|
||||
dev_err(dev, "no IRQ resource info\n");
|
||||
err = aes_dd->irq;
|
||||
goto res_err;
|
||||
}
|
||||
|
|
|
@ -2779,7 +2779,6 @@ static int atmel_sha_probe(struct platform_device *pdev)
|
|||
/* Get the IRQ */
|
||||
sha_dd->irq = platform_get_irq(pdev, 0);
|
||||
if (sha_dd->irq < 0) {
|
||||
dev_err(dev, "no IRQ resource info\n");
|
||||
err = sha_dd->irq;
|
||||
goto res_err;
|
||||
}
|
||||
|
|
|
@ -1281,7 +1281,6 @@ static int atmel_tdes_probe(struct platform_device *pdev)
|
|||
/* Get the IRQ */
|
||||
tdes_dd->irq = platform_get_irq(pdev, 0);
|
||||
if (tdes_dd->irq < 0) {
|
||||
dev_err(dev, "no IRQ resource info\n");
|
||||
err = tdes_dd->irq;
|
||||
goto res_err;
|
||||
}
|
||||
|
|
|
@ -338,10 +338,8 @@ static int init_cc_resources(struct platform_device *plat_dev)
|
|||
|
||||
/* Then IRQ */
|
||||
new_drvdata->irq = platform_get_irq(plat_dev, 0);
|
||||
if (new_drvdata->irq < 0) {
|
||||
dev_err(dev, "Failed getting IRQ resource\n");
|
||||
if (new_drvdata->irq < 0)
|
||||
return new_drvdata->irq;
|
||||
}
|
||||
|
||||
init_completion(&new_drvdata->hw_queue_avail);
|
||||
|
||||
|
|
|
@ -980,7 +980,6 @@ static int img_hash_probe(struct platform_device *pdev)
|
|||
|
||||
irq = platform_get_irq(pdev, 0);
|
||||
if (irq < 0) {
|
||||
dev_err(dev, "no IRQ resource info\n");
|
||||
err = irq;
|
||||
goto res_err;
|
||||
}
|
||||
|
|
|
@ -495,10 +495,8 @@ static int mtk_crypto_probe(struct platform_device *pdev)
|
|||
|
||||
for (i = 0; i < MTK_IRQ_NUM; i++) {
|
||||
cryp->irq[i] = platform_get_irq(pdev, i);
|
||||
if (cryp->irq[i] < 0) {
|
||||
dev_err(cryp->dev, "no IRQ:%d resource info\n", i);
|
||||
if (cryp->irq[i] < 0)
|
||||
return cryp->irq[i];
|
||||
}
|
||||
}
|
||||
|
||||
cryp->clk_cryp = devm_clk_get(&pdev->dev, "cryp");
|
||||
|
|
|
@ -994,16 +994,12 @@ static int mxs_dcp_probe(struct platform_device *pdev)
|
|||
}
|
||||
|
||||
dcp_vmi_irq = platform_get_irq(pdev, 0);
|
||||
if (dcp_vmi_irq < 0) {
|
||||
dev_err(dev, "Failed to get IRQ: (%d)!\n", dcp_vmi_irq);
|
||||
if (dcp_vmi_irq < 0)
|
||||
return dcp_vmi_irq;
|
||||
}
|
||||
|
||||
dcp_irq = platform_get_irq(pdev, 1);
|
||||
if (dcp_irq < 0) {
|
||||
dev_err(dev, "Failed to get IRQ: (%d)!\n", dcp_irq);
|
||||
if (dcp_irq < 0)
|
||||
return dcp_irq;
|
||||
}
|
||||
|
||||
sdcp = devm_kzalloc(dev, sizeof(*sdcp), GFP_KERNEL);
|
||||
if (!sdcp)
|
||||
|
|
|
@ -1180,7 +1180,6 @@ static int omap_aes_probe(struct platform_device *pdev)
|
|||
|
||||
irq = platform_get_irq(pdev, 0);
|
||||
if (irq < 0) {
|
||||
dev_err(dev, "can't get IRQ resource\n");
|
||||
err = irq;
|
||||
goto err_irq;
|
||||
}
|
||||
|
|
|
@ -1049,7 +1049,6 @@ static int omap_des_probe(struct platform_device *pdev)
|
|||
|
||||
irq = platform_get_irq(pdev, 0);
|
||||
if (irq < 0) {
|
||||
dev_err(dev, "can't get IRQ resource: %d\n", irq);
|
||||
err = irq;
|
||||
goto err_irq;
|
||||
}
|
||||
|
|
|
@ -1989,7 +1989,6 @@ static int omap_sham_get_res_pdev(struct omap_sham_dev *dd,
|
|||
/* Get the IRQ */
|
||||
dd->irq = platform_get_irq(pdev, 0);
|
||||
if (dd->irq < 0) {
|
||||
dev_err(dev, "no IRQ resource info\n");
|
||||
err = dd->irq;
|
||||
goto err;
|
||||
}
|
||||
|
|
|
@ -1403,10 +1403,8 @@ static int sahara_probe(struct platform_device *pdev)
|
|||
|
||||
/* Get the IRQ */
|
||||
irq = platform_get_irq(pdev, 0);
|
||||
if (irq < 0) {
|
||||
dev_err(&pdev->dev, "failed to get irq resource\n");
|
||||
if (irq < 0)
|
||||
return irq;
|
||||
}
|
||||
|
||||
err = devm_request_irq(&pdev->dev, irq, sahara_irq_handler,
|
||||
0, dev_name(&pdev->dev), dev);
|
||||
|
|
|
@ -1975,10 +1975,8 @@ static int stm32_cryp_probe(struct platform_device *pdev)
|
|||
return PTR_ERR(cryp->regs);
|
||||
|
||||
irq = platform_get_irq(pdev, 0);
|
||||
if (irq < 0) {
|
||||
dev_err(dev, "Cannot get IRQ resource\n");
|
||||
if (irq < 0)
|
||||
return irq;
|
||||
}
|
||||
|
||||
ret = devm_request_threaded_irq(dev, irq, stm32_cryp_irq,
|
||||
stm32_cryp_irq_thread, IRQF_ONESHOT,
|
||||
|
|
|
@ -1450,10 +1450,8 @@ static int stm32_hash_probe(struct platform_device *pdev)
|
|||
return ret;
|
||||
|
||||
irq = platform_get_irq(pdev, 0);
|
||||
if (irq < 0) {
|
||||
dev_err(dev, "Cannot get IRQ resource\n");
|
||||
if (irq < 0)
|
||||
return irq;
|
||||
}
|
||||
|
||||
ret = devm_request_threaded_irq(dev, irq, stm32_hash_irq_handler,
|
||||
stm32_hash_irq_thread, IRQF_ONESHOT,
|
||||
|
|
Loading…
Reference in a new issue