mfd/asic3: Fix race in installing chained IRQ handler
Fix a race where a pending interrupt could be received and the handler called before the handler's data has been setup, by converting to irq_set_chained_handler_and_data(). Search and conversion was done with coccinelle: @@ expression E1, E2, E3; @@ ( -if (irq_set_chained_handler(E1, E3) != 0) - BUG(); | -irq_set_chained_handler(E1, E3); ) -irq_set_handler_data(E1, E2); +irq_set_chained_handler_and_data(E1, E3, E2); @@ expression E1, E2, E3; @@ ( -if (irq_set_chained_handler(E1, E3) != 0) - BUG(); ... | -irq_set_chained_handler(E1, E3); ... ) -irq_set_handler_data(E1, E2); +irq_set_chained_handler_and_data(E1, E3, E2); Reported-by: Russell King <rmk+kernel@arm.linux.org.uk> Signed-off-by: Thomas Gleixner <tglx@linutronix.de> Cc: Julia Lawall <Julia.Lawall@lip6.fr> Cc: Samuel Ortiz <sameo@linux.intel.com> Cc: Lee Jones <lee.jones@linaro.org>
This commit is contained in:
parent
3fb250ed39
commit
c30e30478c
|
@ -417,9 +417,8 @@ static int __init asic3_irq_probe(struct platform_device *pdev)
|
||||||
asic3_write_register(asic, ASIC3_OFFSET(INTR, INT_MASK),
|
asic3_write_register(asic, ASIC3_OFFSET(INTR, INT_MASK),
|
||||||
ASIC3_INTMASK_GINTMASK);
|
ASIC3_INTMASK_GINTMASK);
|
||||||
|
|
||||||
irq_set_chained_handler(asic->irq_nr, asic3_irq_demux);
|
irq_set_chained_handler_and_data(asic->irq_nr, asic3_irq_demux, asic);
|
||||||
irq_set_irq_type(asic->irq_nr, IRQ_TYPE_EDGE_RISING);
|
irq_set_irq_type(asic->irq_nr, IRQ_TYPE_EDGE_RISING);
|
||||||
irq_set_handler_data(asic->irq_nr, asic);
|
|
||||||
|
|
||||||
return 0;
|
return 0;
|
||||||
}
|
}
|
||||||
|
|
Loading…
Reference in a new issue