2007-05-05 12:45:53 -06:00
|
|
|
/*
|
|
|
|
* Copyright 2002-2005, Instant802 Networks, Inc.
|
|
|
|
* Copyright 2006-2007 Jiri Benc <jbenc@suse.cz>
|
2014-09-03 06:24:57 -06:00
|
|
|
* Copyright 2013-2014 Intel Mobile Communications GmbH
|
2007-05-05 12:45:53 -06:00
|
|
|
*
|
|
|
|
* This program is free software; you can redistribute it and/or modify
|
|
|
|
* it under the terms of the GNU General Public License version 2 as
|
|
|
|
* published by the Free Software Foundation.
|
|
|
|
*/
|
|
|
|
|
|
|
|
#include <linux/module.h>
|
|
|
|
#include <linux/init.h>
|
2012-03-01 07:22:09 -07:00
|
|
|
#include <linux/etherdevice.h>
|
2007-05-05 12:45:53 -06:00
|
|
|
#include <linux/netdevice.h>
|
|
|
|
#include <linux/types.h>
|
|
|
|
#include <linux/slab.h>
|
|
|
|
#include <linux/skbuff.h>
|
|
|
|
#include <linux/if_arp.h>
|
2007-12-17 07:07:43 -07:00
|
|
|
#include <linux/timer.h>
|
2008-02-25 08:27:46 -07:00
|
|
|
#include <linux/rtnetlink.h>
|
2007-05-05 12:45:53 -06:00
|
|
|
|
|
|
|
#include <net/mac80211.h>
|
|
|
|
#include "ieee80211_i.h"
|
2009-04-23 10:52:52 -06:00
|
|
|
#include "driver-ops.h"
|
2008-04-08 13:14:40 -06:00
|
|
|
#include "rate.h"
|
2007-05-05 12:45:53 -06:00
|
|
|
#include "sta_info.h"
|
2007-05-05 12:46:38 -06:00
|
|
|
#include "debugfs_sta.h"
|
2008-02-23 07:17:11 -07:00
|
|
|
#include "mesh.h"
|
2011-09-29 08:04:34 -06:00
|
|
|
#include "wme.h"
|
2007-05-05 12:45:53 -06:00
|
|
|
|
2008-02-25 08:27:46 -07:00
|
|
|
/**
|
|
|
|
* DOC: STA information lifetime rules
|
|
|
|
*
|
|
|
|
* STA info structures (&struct sta_info) are managed in a hash table
|
|
|
|
* for faster lookup and a list for iteration. They are managed using
|
|
|
|
* RCU, i.e. access to the list and hash table is protected by RCU.
|
|
|
|
*
|
2010-02-03 05:59:58 -07:00
|
|
|
* Upon allocating a STA info structure with sta_info_alloc(), the caller
|
|
|
|
* owns that structure. It must then insert it into the hash table using
|
|
|
|
* either sta_info_insert() or sta_info_insert_rcu(); only in the latter
|
|
|
|
* case (which acquires an rcu read section but must not be called from
|
|
|
|
* within one) will the pointer still be valid after the call. Note that
|
|
|
|
* the caller may not do much with the STA info before inserting it, in
|
|
|
|
* particular, it may not start any mesh peer link management or add
|
|
|
|
* encryption keys.
|
2008-04-01 07:21:00 -06:00
|
|
|
*
|
|
|
|
* When the insertion fails (sta_info_insert()) returns non-zero), the
|
|
|
|
* structure will have been freed by sta_info_insert()!
|
2008-02-25 08:27:46 -07:00
|
|
|
*
|
2010-02-03 05:59:58 -07:00
|
|
|
* Station entries are added by mac80211 when you establish a link with a
|
2009-06-02 16:38:14 -06:00
|
|
|
* peer. This means different things for the different type of interfaces
|
|
|
|
* we support. For a regular station this mean we add the AP sta when we
|
2011-03-30 19:57:33 -06:00
|
|
|
* receive an association response from the AP. For IBSS this occurs when
|
2010-02-03 05:59:58 -07:00
|
|
|
* get to know about a peer on the same IBSS. For WDS we add the sta for
|
2011-03-30 19:57:33 -06:00
|
|
|
* the peer immediately upon device open. When using AP mode we add stations
|
2010-02-03 05:59:58 -07:00
|
|
|
* for each respective station upon request from userspace through nl80211.
|
2009-06-02 16:38:14 -06:00
|
|
|
*
|
2010-02-03 05:59:58 -07:00
|
|
|
* In order to remove a STA info structure, various sta_info_destroy_*()
|
|
|
|
* calls are available.
|
2008-02-25 08:27:46 -07:00
|
|
|
*
|
2010-02-03 05:59:58 -07:00
|
|
|
* There is no concept of ownership on a STA entry, each structure is
|
|
|
|
* owned by the global hash table/list until it is removed. All users of
|
|
|
|
* the structure need to be RCU protected so that the structure won't be
|
|
|
|
* freed before they are done using it.
|
2008-02-25 08:27:46 -07:00
|
|
|
*/
|
2007-05-05 12:45:53 -06:00
|
|
|
|
2015-02-13 13:55:15 -07:00
|
|
|
static const struct rhashtable_params sta_rht_params = {
|
|
|
|
.nelem_hint = 3, /* start small */
|
2015-04-24 03:10:10 -06:00
|
|
|
.automatic_shrinking = true,
|
2015-02-13 13:55:15 -07:00
|
|
|
.head_offset = offsetof(struct sta_info, hash_node),
|
2015-06-16 08:22:12 -06:00
|
|
|
.key_offset = offsetof(struct sta_info, addr),
|
2015-02-13 13:55:15 -07:00
|
|
|
.key_len = ETH_ALEN,
|
|
|
|
.hashfn = sta_addr_hash,
|
2015-04-23 09:26:06 -06:00
|
|
|
.max_size = CONFIG_MAC80211_STA_HASH_MAX_SIZE,
|
2015-02-13 13:55:15 -07:00
|
|
|
};
|
|
|
|
|
2011-12-15 03:24:20 -07:00
|
|
|
/* Caller must hold local->sta_mtx */
|
2007-07-27 07:43:23 -06:00
|
|
|
static int sta_info_hash_del(struct ieee80211_local *local,
|
|
|
|
struct sta_info *sta)
|
2007-05-05 12:45:53 -06:00
|
|
|
{
|
2015-02-13 13:55:15 -07:00
|
|
|
return rhashtable_remove_fast(&local->sta_hash, &sta->hash_node,
|
|
|
|
sta_rht_params);
|
2007-05-05 12:45:53 -06:00
|
|
|
}
|
|
|
|
|
2014-02-17 12:49:03 -07:00
|
|
|
static void __cleanup_single_sta(struct sta_info *sta)
|
2012-09-09 05:43:51 -06:00
|
|
|
{
|
|
|
|
int ac, i;
|
|
|
|
struct tid_ampdu_tx *tid_tx;
|
|
|
|
struct ieee80211_sub_if_data *sdata = sta->sdata;
|
|
|
|
struct ieee80211_local *local = sdata->local;
|
2012-10-10 13:39:50 -06:00
|
|
|
struct ps_data *ps;
|
2012-09-09 05:43:51 -06:00
|
|
|
|
2014-02-20 03:19:58 -07:00
|
|
|
if (test_sta_flag(sta, WLAN_STA_PS_STA) ||
|
mac80211: fix station/driver powersave race
It is currently possible to have a race due to the station PS
unblock work like this:
* station goes to sleep with frames buffered in the driver
* driver blocks wakeup
* station wakes up again
* driver flushes/returns frames, and unblocks, which schedules
the unblock work
* unblock work starts to run, and checks that the station is
awake (i.e. that the WLAN_STA_PS_STA flag isn't set)
* we process a received frame with PM=1, setting the flag again
* ieee80211_sta_ps_deliver_wakeup() runs, delivering all frames
to the driver, and then clearing the WLAN_STA_PS_DRIVER and
WLAN_STA_PS_STA flags
In this scenario, mac80211 will think that the station is awake,
while it really is asleep, and any TX'ed frames should be filtered
by the device (it will know that the station is sleeping) but then
passed to mac80211 again, which will not buffer it either as it
thinks the station is awake, and eventually the packets will be
dropped.
Fix this by moving the clearing of the flags to exactly where we
learn about the situation. This creates a problem of reordering,
so introduce another flag indicating that delivery is being done,
this new flag also queues frames and is cleared only while the
spinlock is held (which the queuing code also holds) so that any
concurrent delivery/TX is handled correctly.
Reported-by: Andrei Otcheretianski <andrei.otcheretianski@intel.com>
Signed-off-by: Johannes Berg <johannes.berg@intel.com>
2014-05-27 08:32:27 -06:00
|
|
|
test_sta_flag(sta, WLAN_STA_PS_DRIVER) ||
|
|
|
|
test_sta_flag(sta, WLAN_STA_PS_DELIVER)) {
|
2012-10-10 13:39:50 -06:00
|
|
|
if (sta->sdata->vif.type == NL80211_IFTYPE_AP ||
|
|
|
|
sta->sdata->vif.type == NL80211_IFTYPE_AP_VLAN)
|
|
|
|
ps = &sdata->bss->ps;
|
2013-01-30 10:14:08 -07:00
|
|
|
else if (ieee80211_vif_is_mesh(&sdata->vif))
|
|
|
|
ps = &sdata->u.mesh.ps;
|
2012-10-10 13:39:50 -06:00
|
|
|
else
|
|
|
|
return;
|
2012-09-09 05:43:51 -06:00
|
|
|
|
|
|
|
clear_sta_flag(sta, WLAN_STA_PS_STA);
|
2014-02-20 03:19:58 -07:00
|
|
|
clear_sta_flag(sta, WLAN_STA_PS_DRIVER);
|
mac80211: fix station/driver powersave race
It is currently possible to have a race due to the station PS
unblock work like this:
* station goes to sleep with frames buffered in the driver
* driver blocks wakeup
* station wakes up again
* driver flushes/returns frames, and unblocks, which schedules
the unblock work
* unblock work starts to run, and checks that the station is
awake (i.e. that the WLAN_STA_PS_STA flag isn't set)
* we process a received frame with PM=1, setting the flag again
* ieee80211_sta_ps_deliver_wakeup() runs, delivering all frames
to the driver, and then clearing the WLAN_STA_PS_DRIVER and
WLAN_STA_PS_STA flags
In this scenario, mac80211 will think that the station is awake,
while it really is asleep, and any TX'ed frames should be filtered
by the device (it will know that the station is sleeping) but then
passed to mac80211 again, which will not buffer it either as it
thinks the station is awake, and eventually the packets will be
dropped.
Fix this by moving the clearing of the flags to exactly where we
learn about the situation. This creates a problem of reordering,
so introduce another flag indicating that delivery is being done,
this new flag also queues frames and is cleared only while the
spinlock is held (which the queuing code also holds) so that any
concurrent delivery/TX is handled correctly.
Reported-by: Andrei Otcheretianski <andrei.otcheretianski@intel.com>
Signed-off-by: Johannes Berg <johannes.berg@intel.com>
2014-05-27 08:32:27 -06:00
|
|
|
clear_sta_flag(sta, WLAN_STA_PS_DELIVER);
|
2012-09-09 05:43:51 -06:00
|
|
|
|
2012-10-10 13:39:50 -06:00
|
|
|
atomic_dec(&ps->num_sta_ps);
|
2012-09-09 05:43:51 -06:00
|
|
|
}
|
|
|
|
|
2015-03-27 14:30:37 -06:00
|
|
|
if (sta->sta.txq[0]) {
|
|
|
|
for (i = 0; i < ARRAY_SIZE(sta->sta.txq); i++) {
|
|
|
|
struct txq_info *txqi = to_txq_info(sta->sta.txq[i]);
|
|
|
|
int n = skb_queue_len(&txqi->queue);
|
|
|
|
|
|
|
|
ieee80211_purge_tx_queue(&local->hw, &txqi->queue);
|
|
|
|
atomic_sub(n, &sdata->txqs_len[txqi->txq.ac]);
|
|
|
|
}
|
|
|
|
}
|
|
|
|
|
2012-09-09 05:43:51 -06:00
|
|
|
for (ac = 0; ac < IEEE80211_NUM_ACS; ac++) {
|
|
|
|
local->total_ps_buffered -= skb_queue_len(&sta->ps_tx_buf[ac]);
|
2012-11-09 19:44:14 -07:00
|
|
|
ieee80211_purge_tx_queue(&local->hw, &sta->ps_tx_buf[ac]);
|
|
|
|
ieee80211_purge_tx_queue(&local->hw, &sta->tx_filtered[ac]);
|
2012-09-09 05:43:51 -06:00
|
|
|
}
|
|
|
|
|
2013-02-06 11:17:21 -07:00
|
|
|
if (ieee80211_vif_is_mesh(&sdata->vif))
|
|
|
|
mesh_sta_cleanup(sta);
|
2012-09-09 05:43:51 -06:00
|
|
|
|
mac80211: fix station/driver powersave race
It is currently possible to have a race due to the station PS
unblock work like this:
* station goes to sleep with frames buffered in the driver
* driver blocks wakeup
* station wakes up again
* driver flushes/returns frames, and unblocks, which schedules
the unblock work
* unblock work starts to run, and checks that the station is
awake (i.e. that the WLAN_STA_PS_STA flag isn't set)
* we process a received frame with PM=1, setting the flag again
* ieee80211_sta_ps_deliver_wakeup() runs, delivering all frames
to the driver, and then clearing the WLAN_STA_PS_DRIVER and
WLAN_STA_PS_STA flags
In this scenario, mac80211 will think that the station is awake,
while it really is asleep, and any TX'ed frames should be filtered
by the device (it will know that the station is sleeping) but then
passed to mac80211 again, which will not buffer it either as it
thinks the station is awake, and eventually the packets will be
dropped.
Fix this by moving the clearing of the flags to exactly where we
learn about the situation. This creates a problem of reordering,
so introduce another flag indicating that delivery is being done,
this new flag also queues frames and is cleared only while the
spinlock is held (which the queuing code also holds) so that any
concurrent delivery/TX is handled correctly.
Reported-by: Andrei Otcheretianski <andrei.otcheretianski@intel.com>
Signed-off-by: Johannes Berg <johannes.berg@intel.com>
2014-05-27 08:32:27 -06:00
|
|
|
cancel_work_sync(&sta->drv_deliver_wk);
|
2012-09-09 05:43:51 -06:00
|
|
|
|
|
|
|
/*
|
|
|
|
* Destroy aggregation state here. It would be nice to wait for the
|
|
|
|
* driver to finish aggregation stop and then clean up, but for now
|
|
|
|
* drivers have to handle aggregation stop being requested, followed
|
|
|
|
* directly by station destruction.
|
|
|
|
*/
|
2012-11-14 15:22:21 -07:00
|
|
|
for (i = 0; i < IEEE80211_NUM_TIDS; i++) {
|
2013-06-12 14:47:56 -06:00
|
|
|
kfree(sta->ampdu_mlme.tid_start_tx[i]);
|
2012-09-09 05:43:51 -06:00
|
|
|
tid_tx = rcu_dereference_raw(sta->ampdu_mlme.tid_tx[i]);
|
|
|
|
if (!tid_tx)
|
|
|
|
continue;
|
2012-11-09 19:44:14 -07:00
|
|
|
ieee80211_purge_tx_queue(&local->hw, &tid_tx->pending);
|
2012-09-09 05:43:51 -06:00
|
|
|
kfree(tid_tx);
|
|
|
|
}
|
2014-02-17 12:49:03 -07:00
|
|
|
}
|
2012-09-09 05:43:51 -06:00
|
|
|
|
2014-02-17 12:49:03 -07:00
|
|
|
static void cleanup_single_sta(struct sta_info *sta)
|
|
|
|
{
|
|
|
|
struct ieee80211_sub_if_data *sdata = sta->sdata;
|
|
|
|
struct ieee80211_local *local = sdata->local;
|
|
|
|
|
|
|
|
__cleanup_single_sta(sta);
|
2012-09-09 05:43:51 -06:00
|
|
|
sta_info_free(local, sta);
|
|
|
|
}
|
|
|
|
|
2008-02-25 08:27:46 -07:00
|
|
|
/* protected by RCU */
|
2009-11-25 09:46:18 -07:00
|
|
|
struct sta_info *sta_info_get(struct ieee80211_sub_if_data *sdata,
|
|
|
|
const u8 *addr)
|
2007-05-05 12:45:53 -06:00
|
|
|
{
|
2009-11-25 09:46:18 -07:00
|
|
|
struct ieee80211_local *local = sdata->local;
|
2015-04-23 06:02:30 -06:00
|
|
|
struct sta_info *sta;
|
|
|
|
struct rhash_head *tmp;
|
|
|
|
const struct bucket_table *tbl;
|
2007-05-05 12:45:53 -06:00
|
|
|
|
2015-04-23 06:02:30 -06:00
|
|
|
rcu_read_lock();
|
|
|
|
tbl = rht_dereference_rcu(local->sta_hash.tbl, &local->sta_hash);
|
2007-05-05 12:45:53 -06:00
|
|
|
|
2015-04-23 06:02:30 -06:00
|
|
|
for_each_sta_info(local, tbl, addr, sta, tmp) {
|
|
|
|
if (sta->sdata == sdata) {
|
|
|
|
rcu_read_unlock();
|
|
|
|
/* this is safe as the caller must already hold
|
|
|
|
* another rcu read section or the mutex
|
|
|
|
*/
|
|
|
|
return sta;
|
|
|
|
}
|
|
|
|
}
|
|
|
|
rcu_read_unlock();
|
|
|
|
return NULL;
|
2008-02-21 06:09:30 -07:00
|
|
|
}
|
|
|
|
|
2010-01-08 10:10:58 -07:00
|
|
|
/*
|
|
|
|
* Get sta info either from the specified interface
|
|
|
|
* or from one of its vlans
|
|
|
|
*/
|
|
|
|
struct sta_info *sta_info_get_bss(struct ieee80211_sub_if_data *sdata,
|
|
|
|
const u8 *addr)
|
|
|
|
{
|
|
|
|
struct ieee80211_local *local = sdata->local;
|
|
|
|
struct sta_info *sta;
|
2015-02-13 13:55:15 -07:00
|
|
|
struct rhash_head *tmp;
|
|
|
|
const struct bucket_table *tbl;
|
2010-01-08 10:10:58 -07:00
|
|
|
|
2015-02-13 13:55:15 -07:00
|
|
|
rcu_read_lock();
|
|
|
|
tbl = rht_dereference_rcu(local->sta_hash.tbl, &local->sta_hash);
|
|
|
|
|
|
|
|
for_each_sta_info(local, tbl, addr, sta, tmp) {
|
|
|
|
if (sta->sdata == sdata ||
|
|
|
|
(sta->sdata->bss && sta->sdata->bss == sdata->bss)) {
|
|
|
|
rcu_read_unlock();
|
|
|
|
/* this is safe as the caller must already hold
|
|
|
|
* another rcu read section or the mutex
|
|
|
|
*/
|
|
|
|
return sta;
|
|
|
|
}
|
2010-01-08 10:10:58 -07:00
|
|
|
}
|
2015-02-13 13:55:15 -07:00
|
|
|
rcu_read_unlock();
|
|
|
|
return NULL;
|
2010-01-08 10:10:58 -07:00
|
|
|
}
|
|
|
|
|
2009-11-16 04:00:37 -07:00
|
|
|
struct sta_info *sta_info_get_by_idx(struct ieee80211_sub_if_data *sdata,
|
|
|
|
int idx)
|
2008-02-23 07:17:11 -07:00
|
|
|
{
|
2009-11-16 04:00:37 -07:00
|
|
|
struct ieee80211_local *local = sdata->local;
|
2008-02-23 07:17:11 -07:00
|
|
|
struct sta_info *sta;
|
|
|
|
int i = 0;
|
|
|
|
|
2008-02-25 08:27:46 -07:00
|
|
|
list_for_each_entry_rcu(sta, &local->sta_list, list) {
|
2009-11-16 04:00:37 -07:00
|
|
|
if (sdata != sta->sdata)
|
2008-02-29 18:51:25 -07:00
|
|
|
continue;
|
2008-02-23 07:17:11 -07:00
|
|
|
if (i < idx) {
|
|
|
|
++i;
|
|
|
|
continue;
|
|
|
|
}
|
2008-02-29 18:51:25 -07:00
|
|
|
return sta;
|
2008-02-23 07:17:11 -07:00
|
|
|
}
|
|
|
|
|
|
|
|
return NULL;
|
|
|
|
}
|
2007-05-05 12:45:53 -06:00
|
|
|
|
2008-04-01 07:21:00 -06:00
|
|
|
/**
|
2011-12-14 04:35:30 -07:00
|
|
|
* sta_info_free - free STA
|
2008-04-01 07:21:00 -06:00
|
|
|
*
|
2008-07-03 14:52:18 -06:00
|
|
|
* @local: pointer to the global information
|
2008-04-01 07:21:00 -06:00
|
|
|
* @sta: STA info to free
|
|
|
|
*
|
|
|
|
* This function must undo everything done by sta_info_alloc()
|
2011-12-14 04:35:30 -07:00
|
|
|
* that may happen before sta_info_insert(). It may only be
|
|
|
|
* called when sta_info_insert() has not been attempted (and
|
|
|
|
* if that fails, the station is freed anyway.)
|
2008-04-01 07:21:00 -06:00
|
|
|
*/
|
2011-12-14 04:35:30 -07:00
|
|
|
void sta_info_free(struct ieee80211_local *local, struct sta_info *sta)
|
2008-04-01 07:21:00 -06:00
|
|
|
{
|
2012-01-17 02:33:29 -07:00
|
|
|
if (sta->rate_ctrl)
|
2009-11-17 10:18:36 -07:00
|
|
|
rate_control_free_sta(sta);
|
2008-04-01 07:21:00 -06:00
|
|
|
|
2012-06-22 03:29:50 -06:00
|
|
|
sta_dbg(sta->sdata, "Destroyed STA %pM\n", sta->sta.addr);
|
2008-04-01 07:21:00 -06:00
|
|
|
|
2015-03-27 14:30:37 -06:00
|
|
|
if (sta->sta.txq[0])
|
|
|
|
kfree(to_txq_info(sta->sta.txq[0]));
|
2014-05-27 14:33:57 -06:00
|
|
|
kfree(rcu_dereference_raw(sta->sta.rates));
|
2015-06-17 02:31:00 -06:00
|
|
|
#ifdef CONFIG_MAC80211_MESH
|
|
|
|
kfree(sta->mesh);
|
|
|
|
#endif
|
2008-04-01 07:21:00 -06:00
|
|
|
kfree(sta);
|
|
|
|
}
|
|
|
|
|
2011-12-15 03:24:20 -07:00
|
|
|
/* Caller must hold local->sta_mtx */
|
2008-02-25 08:27:46 -07:00
|
|
|
static void sta_info_hash_add(struct ieee80211_local *local,
|
|
|
|
struct sta_info *sta)
|
2007-05-05 12:45:53 -06:00
|
|
|
{
|
2015-02-13 13:55:15 -07:00
|
|
|
rhashtable_insert_fast(&local->sta_hash, &sta->hash_node,
|
|
|
|
sta_rht_params);
|
2007-05-05 12:45:53 -06:00
|
|
|
}
|
|
|
|
|
mac80211: fix station/driver powersave race
It is currently possible to have a race due to the station PS
unblock work like this:
* station goes to sleep with frames buffered in the driver
* driver blocks wakeup
* station wakes up again
* driver flushes/returns frames, and unblocks, which schedules
the unblock work
* unblock work starts to run, and checks that the station is
awake (i.e. that the WLAN_STA_PS_STA flag isn't set)
* we process a received frame with PM=1, setting the flag again
* ieee80211_sta_ps_deliver_wakeup() runs, delivering all frames
to the driver, and then clearing the WLAN_STA_PS_DRIVER and
WLAN_STA_PS_STA flags
In this scenario, mac80211 will think that the station is awake,
while it really is asleep, and any TX'ed frames should be filtered
by the device (it will know that the station is sleeping) but then
passed to mac80211 again, which will not buffer it either as it
thinks the station is awake, and eventually the packets will be
dropped.
Fix this by moving the clearing of the flags to exactly where we
learn about the situation. This creates a problem of reordering,
so introduce another flag indicating that delivery is being done,
this new flag also queues frames and is cleared only while the
spinlock is held (which the queuing code also holds) so that any
concurrent delivery/TX is handled correctly.
Reported-by: Andrei Otcheretianski <andrei.otcheretianski@intel.com>
Signed-off-by: Johannes Berg <johannes.berg@intel.com>
2014-05-27 08:32:27 -06:00
|
|
|
static void sta_deliver_ps_frames(struct work_struct *wk)
|
mac80211: async station powersave handling
Some devices require that all frames to a station
are flushed when that station goes into powersave
mode before being able to send frames to that
station again when it wakes up or polls -- all in
order to avoid reordering and too many or too few
frames being sent to the station when it polls.
Normally, this is the case unless the station
goes to sleep and wakes up very quickly again.
But in that case, frames for it may be pending
on the hardware queues, and thus races could
happen in the case of multiple hardware queues
used for QoS/WMM. Normally this isn't a problem,
but with the iwlwifi mechanism we need to make
sure the race doesn't happen.
This makes mac80211 able to cope with the race
with driver help by a new WLAN_STA_PS_DRIVER
per-station flag that can be controlled by the
driver and tells mac80211 whether it can transmit
frames or not. This flag must be set according to
very specific rules outlined in the documentation
for the function that controls it.
When we buffer new frames for the station, we
normally set the TIM bit right away, but while
the driver has blocked transmission to that sta
we need to avoid that as well since we cannot
respond to the station if it wakes up due to the
TIM bit. Once the driver unblocks, we can set
the TIM bit.
Similarly, when the station just wakes up, we
need to wait until all other frames are flushed
before we can transmit frames to that station,
so the same applies here, we need to wait for
the driver to give the OK.
Signed-off-by: Johannes Berg <johannes@sipsolutions.net>
Signed-off-by: John W. Linville <linville@tuxdriver.com>
2009-11-06 03:35:50 -07:00
|
|
|
{
|
|
|
|
struct sta_info *sta;
|
|
|
|
|
mac80211: fix station/driver powersave race
It is currently possible to have a race due to the station PS
unblock work like this:
* station goes to sleep with frames buffered in the driver
* driver blocks wakeup
* station wakes up again
* driver flushes/returns frames, and unblocks, which schedules
the unblock work
* unblock work starts to run, and checks that the station is
awake (i.e. that the WLAN_STA_PS_STA flag isn't set)
* we process a received frame with PM=1, setting the flag again
* ieee80211_sta_ps_deliver_wakeup() runs, delivering all frames
to the driver, and then clearing the WLAN_STA_PS_DRIVER and
WLAN_STA_PS_STA flags
In this scenario, mac80211 will think that the station is awake,
while it really is asleep, and any TX'ed frames should be filtered
by the device (it will know that the station is sleeping) but then
passed to mac80211 again, which will not buffer it either as it
thinks the station is awake, and eventually the packets will be
dropped.
Fix this by moving the clearing of the flags to exactly where we
learn about the situation. This creates a problem of reordering,
so introduce another flag indicating that delivery is being done,
this new flag also queues frames and is cleared only while the
spinlock is held (which the queuing code also holds) so that any
concurrent delivery/TX is handled correctly.
Reported-by: Andrei Otcheretianski <andrei.otcheretianski@intel.com>
Signed-off-by: Johannes Berg <johannes.berg@intel.com>
2014-05-27 08:32:27 -06:00
|
|
|
sta = container_of(wk, struct sta_info, drv_deliver_wk);
|
mac80211: async station powersave handling
Some devices require that all frames to a station
are flushed when that station goes into powersave
mode before being able to send frames to that
station again when it wakes up or polls -- all in
order to avoid reordering and too many or too few
frames being sent to the station when it polls.
Normally, this is the case unless the station
goes to sleep and wakes up very quickly again.
But in that case, frames for it may be pending
on the hardware queues, and thus races could
happen in the case of multiple hardware queues
used for QoS/WMM. Normally this isn't a problem,
but with the iwlwifi mechanism we need to make
sure the race doesn't happen.
This makes mac80211 able to cope with the race
with driver help by a new WLAN_STA_PS_DRIVER
per-station flag that can be controlled by the
driver and tells mac80211 whether it can transmit
frames or not. This flag must be set according to
very specific rules outlined in the documentation
for the function that controls it.
When we buffer new frames for the station, we
normally set the TIM bit right away, but while
the driver has blocked transmission to that sta
we need to avoid that as well since we cannot
respond to the station if it wakes up due to the
TIM bit. Once the driver unblocks, we can set
the TIM bit.
Similarly, when the station just wakes up, we
need to wait until all other frames are flushed
before we can transmit frames to that station,
so the same applies here, we need to wait for
the driver to give the OK.
Signed-off-by: Johannes Berg <johannes@sipsolutions.net>
Signed-off-by: John W. Linville <linville@tuxdriver.com>
2009-11-06 03:35:50 -07:00
|
|
|
|
|
|
|
if (sta->dead)
|
|
|
|
return;
|
|
|
|
|
mac80211: fix station/driver powersave race
It is currently possible to have a race due to the station PS
unblock work like this:
* station goes to sleep with frames buffered in the driver
* driver blocks wakeup
* station wakes up again
* driver flushes/returns frames, and unblocks, which schedules
the unblock work
* unblock work starts to run, and checks that the station is
awake (i.e. that the WLAN_STA_PS_STA flag isn't set)
* we process a received frame with PM=1, setting the flag again
* ieee80211_sta_ps_deliver_wakeup() runs, delivering all frames
to the driver, and then clearing the WLAN_STA_PS_DRIVER and
WLAN_STA_PS_STA flags
In this scenario, mac80211 will think that the station is awake,
while it really is asleep, and any TX'ed frames should be filtered
by the device (it will know that the station is sleeping) but then
passed to mac80211 again, which will not buffer it either as it
thinks the station is awake, and eventually the packets will be
dropped.
Fix this by moving the clearing of the flags to exactly where we
learn about the situation. This creates a problem of reordering,
so introduce another flag indicating that delivery is being done,
this new flag also queues frames and is cleared only while the
spinlock is held (which the queuing code also holds) so that any
concurrent delivery/TX is handled correctly.
Reported-by: Andrei Otcheretianski <andrei.otcheretianski@intel.com>
Signed-off-by: Johannes Berg <johannes.berg@intel.com>
2014-05-27 08:32:27 -06:00
|
|
|
local_bh_disable();
|
|
|
|
if (!test_sta_flag(sta, WLAN_STA_PS_STA))
|
mac80211: async station powersave handling
Some devices require that all frames to a station
are flushed when that station goes into powersave
mode before being able to send frames to that
station again when it wakes up or polls -- all in
order to avoid reordering and too many or too few
frames being sent to the station when it polls.
Normally, this is the case unless the station
goes to sleep and wakes up very quickly again.
But in that case, frames for it may be pending
on the hardware queues, and thus races could
happen in the case of multiple hardware queues
used for QoS/WMM. Normally this isn't a problem,
but with the iwlwifi mechanism we need to make
sure the race doesn't happen.
This makes mac80211 able to cope with the race
with driver help by a new WLAN_STA_PS_DRIVER
per-station flag that can be controlled by the
driver and tells mac80211 whether it can transmit
frames or not. This flag must be set according to
very specific rules outlined in the documentation
for the function that controls it.
When we buffer new frames for the station, we
normally set the TIM bit right away, but while
the driver has blocked transmission to that sta
we need to avoid that as well since we cannot
respond to the station if it wakes up due to the
TIM bit. Once the driver unblocks, we can set
the TIM bit.
Similarly, when the station just wakes up, we
need to wait until all other frames are flushed
before we can transmit frames to that station,
so the same applies here, we need to wait for
the driver to give the OK.
Signed-off-by: Johannes Berg <johannes@sipsolutions.net>
Signed-off-by: John W. Linville <linville@tuxdriver.com>
2009-11-06 03:35:50 -07:00
|
|
|
ieee80211_sta_ps_deliver_wakeup(sta);
|
mac80211: fix station/driver powersave race
It is currently possible to have a race due to the station PS
unblock work like this:
* station goes to sleep with frames buffered in the driver
* driver blocks wakeup
* station wakes up again
* driver flushes/returns frames, and unblocks, which schedules
the unblock work
* unblock work starts to run, and checks that the station is
awake (i.e. that the WLAN_STA_PS_STA flag isn't set)
* we process a received frame with PM=1, setting the flag again
* ieee80211_sta_ps_deliver_wakeup() runs, delivering all frames
to the driver, and then clearing the WLAN_STA_PS_DRIVER and
WLAN_STA_PS_STA flags
In this scenario, mac80211 will think that the station is awake,
while it really is asleep, and any TX'ed frames should be filtered
by the device (it will know that the station is sleeping) but then
passed to mac80211 again, which will not buffer it either as it
thinks the station is awake, and eventually the packets will be
dropped.
Fix this by moving the clearing of the flags to exactly where we
learn about the situation. This creates a problem of reordering,
so introduce another flag indicating that delivery is being done,
this new flag also queues frames and is cleared only while the
spinlock is held (which the queuing code also holds) so that any
concurrent delivery/TX is handled correctly.
Reported-by: Andrei Otcheretianski <andrei.otcheretianski@intel.com>
Signed-off-by: Johannes Berg <johannes.berg@intel.com>
2014-05-27 08:32:27 -06:00
|
|
|
else if (test_and_clear_sta_flag(sta, WLAN_STA_PSPOLL))
|
mac80211: async station powersave handling
Some devices require that all frames to a station
are flushed when that station goes into powersave
mode before being able to send frames to that
station again when it wakes up or polls -- all in
order to avoid reordering and too many or too few
frames being sent to the station when it polls.
Normally, this is the case unless the station
goes to sleep and wakes up very quickly again.
But in that case, frames for it may be pending
on the hardware queues, and thus races could
happen in the case of multiple hardware queues
used for QoS/WMM. Normally this isn't a problem,
but with the iwlwifi mechanism we need to make
sure the race doesn't happen.
This makes mac80211 able to cope with the race
with driver help by a new WLAN_STA_PS_DRIVER
per-station flag that can be controlled by the
driver and tells mac80211 whether it can transmit
frames or not. This flag must be set according to
very specific rules outlined in the documentation
for the function that controls it.
When we buffer new frames for the station, we
normally set the TIM bit right away, but while
the driver has blocked transmission to that sta
we need to avoid that as well since we cannot
respond to the station if it wakes up due to the
TIM bit. Once the driver unblocks, we can set
the TIM bit.
Similarly, when the station just wakes up, we
need to wait until all other frames are flushed
before we can transmit frames to that station,
so the same applies here, we need to wait for
the driver to give the OK.
Signed-off-by: Johannes Berg <johannes@sipsolutions.net>
Signed-off-by: John W. Linville <linville@tuxdriver.com>
2009-11-06 03:35:50 -07:00
|
|
|
ieee80211_sta_ps_deliver_poll_response(sta);
|
mac80211: fix station/driver powersave race
It is currently possible to have a race due to the station PS
unblock work like this:
* station goes to sleep with frames buffered in the driver
* driver blocks wakeup
* station wakes up again
* driver flushes/returns frames, and unblocks, which schedules
the unblock work
* unblock work starts to run, and checks that the station is
awake (i.e. that the WLAN_STA_PS_STA flag isn't set)
* we process a received frame with PM=1, setting the flag again
* ieee80211_sta_ps_deliver_wakeup() runs, delivering all frames
to the driver, and then clearing the WLAN_STA_PS_DRIVER and
WLAN_STA_PS_STA flags
In this scenario, mac80211 will think that the station is awake,
while it really is asleep, and any TX'ed frames should be filtered
by the device (it will know that the station is sleeping) but then
passed to mac80211 again, which will not buffer it either as it
thinks the station is awake, and eventually the packets will be
dropped.
Fix this by moving the clearing of the flags to exactly where we
learn about the situation. This creates a problem of reordering,
so introduce another flag indicating that delivery is being done,
this new flag also queues frames and is cleared only while the
spinlock is held (which the queuing code also holds) so that any
concurrent delivery/TX is handled correctly.
Reported-by: Andrei Otcheretianski <andrei.otcheretianski@intel.com>
Signed-off-by: Johannes Berg <johannes.berg@intel.com>
2014-05-27 08:32:27 -06:00
|
|
|
else if (test_and_clear_sta_flag(sta, WLAN_STA_UAPSD))
|
2011-09-29 08:04:33 -06:00
|
|
|
ieee80211_sta_ps_deliver_uapsd(sta);
|
mac80211: fix station/driver powersave race
It is currently possible to have a race due to the station PS
unblock work like this:
* station goes to sleep with frames buffered in the driver
* driver blocks wakeup
* station wakes up again
* driver flushes/returns frames, and unblocks, which schedules
the unblock work
* unblock work starts to run, and checks that the station is
awake (i.e. that the WLAN_STA_PS_STA flag isn't set)
* we process a received frame with PM=1, setting the flag again
* ieee80211_sta_ps_deliver_wakeup() runs, delivering all frames
to the driver, and then clearing the WLAN_STA_PS_DRIVER and
WLAN_STA_PS_STA flags
In this scenario, mac80211 will think that the station is awake,
while it really is asleep, and any TX'ed frames should be filtered
by the device (it will know that the station is sleeping) but then
passed to mac80211 again, which will not buffer it either as it
thinks the station is awake, and eventually the packets will be
dropped.
Fix this by moving the clearing of the flags to exactly where we
learn about the situation. This creates a problem of reordering,
so introduce another flag indicating that delivery is being done,
this new flag also queues frames and is cleared only while the
spinlock is held (which the queuing code also holds) so that any
concurrent delivery/TX is handled correctly.
Reported-by: Andrei Otcheretianski <andrei.otcheretianski@intel.com>
Signed-off-by: Johannes Berg <johannes.berg@intel.com>
2014-05-27 08:32:27 -06:00
|
|
|
local_bh_enable();
|
mac80211: async station powersave handling
Some devices require that all frames to a station
are flushed when that station goes into powersave
mode before being able to send frames to that
station again when it wakes up or polls -- all in
order to avoid reordering and too many or too few
frames being sent to the station when it polls.
Normally, this is the case unless the station
goes to sleep and wakes up very quickly again.
But in that case, frames for it may be pending
on the hardware queues, and thus races could
happen in the case of multiple hardware queues
used for QoS/WMM. Normally this isn't a problem,
but with the iwlwifi mechanism we need to make
sure the race doesn't happen.
This makes mac80211 able to cope with the race
with driver help by a new WLAN_STA_PS_DRIVER
per-station flag that can be controlled by the
driver and tells mac80211 whether it can transmit
frames or not. This flag must be set according to
very specific rules outlined in the documentation
for the function that controls it.
When we buffer new frames for the station, we
normally set the TIM bit right away, but while
the driver has blocked transmission to that sta
we need to avoid that as well since we cannot
respond to the station if it wakes up due to the
TIM bit. Once the driver unblocks, we can set
the TIM bit.
Similarly, when the station just wakes up, we
need to wait until all other frames are flushed
before we can transmit frames to that station,
so the same applies here, we need to wait for
the driver to give the OK.
Signed-off-by: Johannes Berg <johannes@sipsolutions.net>
Signed-off-by: John W. Linville <linville@tuxdriver.com>
2009-11-06 03:35:50 -07:00
|
|
|
}
|
|
|
|
|
2009-11-17 10:18:36 -07:00
|
|
|
static int sta_prepare_rate_control(struct ieee80211_local *local,
|
|
|
|
struct sta_info *sta, gfp_t gfp)
|
|
|
|
{
|
2015-06-02 13:39:54 -06:00
|
|
|
if (ieee80211_hw_check(&local->hw, HAS_RATE_CONTROL))
|
2009-11-17 10:18:36 -07:00
|
|
|
return 0;
|
|
|
|
|
2012-01-17 02:33:29 -07:00
|
|
|
sta->rate_ctrl = local->rate_ctrl;
|
2009-11-17 10:18:36 -07:00
|
|
|
sta->rate_ctrl_priv = rate_control_alloc_sta(sta->rate_ctrl,
|
2015-03-05 08:10:08 -07:00
|
|
|
sta, gfp);
|
2012-01-17 02:33:29 -07:00
|
|
|
if (!sta->rate_ctrl_priv)
|
2009-11-17 10:18:36 -07:00
|
|
|
return -ENOMEM;
|
|
|
|
|
|
|
|
return 0;
|
|
|
|
}
|
|
|
|
|
2008-02-25 08:27:47 -07:00
|
|
|
struct sta_info *sta_info_alloc(struct ieee80211_sub_if_data *sdata,
|
2011-12-14 05:28:46 -07:00
|
|
|
const u8 *addr, gfp_t gfp)
|
2007-05-05 12:45:53 -06:00
|
|
|
{
|
2008-02-25 08:27:46 -07:00
|
|
|
struct ieee80211_local *local = sdata->local;
|
2015-03-27 14:30:37 -06:00
|
|
|
struct ieee80211_hw *hw = &local->hw;
|
2007-05-05 12:45:53 -06:00
|
|
|
struct sta_info *sta;
|
2011-04-08 09:54:24 -06:00
|
|
|
struct timespec uptime;
|
2007-12-25 08:00:34 -07:00
|
|
|
int i;
|
2007-05-05 12:45:53 -06:00
|
|
|
|
2015-03-27 14:30:37 -06:00
|
|
|
sta = kzalloc(sizeof(*sta) + hw->sta_data_size, gfp);
|
2007-05-05 12:45:53 -06:00
|
|
|
if (!sta)
|
2008-02-25 08:27:47 -07:00
|
|
|
return NULL;
|
2007-05-05 12:45:53 -06:00
|
|
|
|
2008-05-02 17:02:02 -06:00
|
|
|
spin_lock_init(&sta->lock);
|
mac80211: fix AP powersave TX vs. wakeup race
There is a race between the TX path and the STA wakeup: while
a station is sleeping, mac80211 buffers frames until it wakes
up, then the frames are transmitted. However, the RX and TX
path are concurrent, so the packet indicating wakeup can be
processed while a packet is being transmitted.
This can lead to a situation where the buffered frames list
is emptied on the one side, while a frame is being added on
the other side, as the station is still seen as sleeping in
the TX path.
As a result, the newly added frame will not be send anytime
soon. It might be sent much later (and out of order) when the
station goes to sleep and wakes up the next time.
Additionally, it can lead to the crash below.
Fix all this by synchronising both paths with a new lock.
Both path are not fastpath since they handle PS situations.
In a later patch we'll remove the extra skb queue locks to
reduce locking overhead.
BUG: unable to handle kernel
NULL pointer dereference at 000000b0
IP: [<ff6f1791>] ieee80211_report_used_skb+0x11/0x3e0 [mac80211]
*pde = 00000000
Oops: 0000 [#1] SMP DEBUG_PAGEALLOC
EIP: 0060:[<ff6f1791>] EFLAGS: 00210282 CPU: 1
EIP is at ieee80211_report_used_skb+0x11/0x3e0 [mac80211]
EAX: e5900da0 EBX: 00000000 ECX: 00000001 EDX: 00000000
ESI: e41d00c0 EDI: e5900da0 EBP: ebe458e4 ESP: ebe458b0
DS: 007b ES: 007b FS: 00d8 GS: 00e0 SS: 0068
CR0: 8005003b CR2: 000000b0 CR3: 25a78000 CR4: 000407d0
DR0: 00000000 DR1: 00000000 DR2: 00000000 DR3: 00000000
DR6: ffff0ff0 DR7: 00000400
Process iperf (pid: 3934, ti=ebe44000 task=e757c0b0 task.ti=ebe44000)
iwlwifi 0000:02:00.0: I iwl_pcie_enqueue_hcmd Sending command LQ_CMD (#4e), seq: 0x0903, 92 bytes at 3[3]:9
Stack:
e403b32c ebe458c4 00200002 00200286 e403b338 ebe458cc c10960bb e5900da0
ff76a6ec ebe458d8 00000000 e41d00c0 e5900da0 ebe458f0 ff6f1b75 e403b210
ebe4598c ff723dc1 00000000 ff76a6ec e597c978 e403b758 00000002 00000002
Call Trace:
[<ff6f1b75>] ieee80211_free_txskb+0x15/0x20 [mac80211]
[<ff723dc1>] invoke_tx_handlers+0x1661/0x1780 [mac80211]
[<ff7248a5>] ieee80211_tx+0x75/0x100 [mac80211]
[<ff7249bf>] ieee80211_xmit+0x8f/0xc0 [mac80211]
[<ff72550e>] ieee80211_subif_start_xmit+0x4fe/0xe20 [mac80211]
[<c149ef70>] dev_hard_start_xmit+0x450/0x950
[<c14b9aa9>] sch_direct_xmit+0xa9/0x250
[<c14b9c9b>] __qdisc_run+0x4b/0x150
[<c149f732>] dev_queue_xmit+0x2c2/0xca0
Cc: stable@vger.kernel.org
Reported-by: Yaara Rozenblum <yaara.rozenblum@intel.com>
Signed-off-by: Emmanuel Grumbach <emmanuel.grumbach@intel.com>
Reviewed-by: Stanislaw Gruszka <sgruszka@redhat.com>
[reword commit log, use a separate lock]
Signed-off-by: Johannes Berg <johannes.berg@intel.com>
2014-02-20 00:22:11 -07:00
|
|
|
spin_lock_init(&sta->ps_lock);
|
mac80211: fix station/driver powersave race
It is currently possible to have a race due to the station PS
unblock work like this:
* station goes to sleep with frames buffered in the driver
* driver blocks wakeup
* station wakes up again
* driver flushes/returns frames, and unblocks, which schedules
the unblock work
* unblock work starts to run, and checks that the station is
awake (i.e. that the WLAN_STA_PS_STA flag isn't set)
* we process a received frame with PM=1, setting the flag again
* ieee80211_sta_ps_deliver_wakeup() runs, delivering all frames
to the driver, and then clearing the WLAN_STA_PS_DRIVER and
WLAN_STA_PS_STA flags
In this scenario, mac80211 will think that the station is awake,
while it really is asleep, and any TX'ed frames should be filtered
by the device (it will know that the station is sleeping) but then
passed to mac80211 again, which will not buffer it either as it
thinks the station is awake, and eventually the packets will be
dropped.
Fix this by moving the clearing of the flags to exactly where we
learn about the situation. This creates a problem of reordering,
so introduce another flag indicating that delivery is being done,
this new flag also queues frames and is cleared only while the
spinlock is held (which the queuing code also holds) so that any
concurrent delivery/TX is handled correctly.
Reported-by: Andrei Otcheretianski <andrei.otcheretianski@intel.com>
Signed-off-by: Johannes Berg <johannes.berg@intel.com>
2014-05-27 08:32:27 -06:00
|
|
|
INIT_WORK(&sta->drv_deliver_wk, sta_deliver_ps_frames);
|
2010-06-10 02:21:43 -06:00
|
|
|
INIT_WORK(&sta->ampdu_mlme.work, ieee80211_ba_session_work);
|
2010-06-10 02:21:46 -06:00
|
|
|
mutex_init(&sta->ampdu_mlme.mtx);
|
2013-03-01 23:02:52 -07:00
|
|
|
#ifdef CONFIG_MAC80211_MESH
|
2015-06-17 02:31:00 -06:00
|
|
|
if (ieee80211_vif_is_mesh(&sdata->vif)) {
|
|
|
|
sta->mesh = kzalloc(sizeof(*sta->mesh), gfp);
|
|
|
|
if (!sta->mesh)
|
|
|
|
goto free;
|
|
|
|
spin_lock_init(&sta->mesh->plink_lock);
|
|
|
|
if (ieee80211_vif_is_mesh(&sdata->vif) &&
|
|
|
|
!sdata->u.mesh.user_mpm)
|
|
|
|
init_timer(&sta->mesh->plink_timer);
|
|
|
|
sta->mesh->nonpeer_pm = NL80211_MESH_POWER_ACTIVE;
|
|
|
|
}
|
2013-03-01 23:02:52 -07:00
|
|
|
#endif
|
2008-05-02 17:02:02 -06:00
|
|
|
|
2015-06-16 08:22:12 -06:00
|
|
|
memcpy(sta->addr, addr, ETH_ALEN);
|
2008-09-10 16:02:02 -06:00
|
|
|
memcpy(sta->sta.addr, addr, ETH_ALEN);
|
2008-02-25 08:27:46 -07:00
|
|
|
sta->local = local;
|
|
|
|
sta->sdata = sdata;
|
2011-03-21 13:01:00 -06:00
|
|
|
sta->last_rx = jiffies;
|
2007-05-05 12:45:53 -06:00
|
|
|
|
2012-01-20 05:55:20 -07:00
|
|
|
sta->sta_state = IEEE80211_STA_NONE;
|
|
|
|
|
2014-11-19 04:47:38 -07:00
|
|
|
/* Mark TID as unreserved */
|
|
|
|
sta->reserved_tid = IEEE80211_TID_UNRESERVED;
|
|
|
|
|
2014-06-11 17:59:14 -06:00
|
|
|
ktime_get_ts(&uptime);
|
2011-04-08 09:54:24 -06:00
|
|
|
sta->last_connected = uptime.tv_sec;
|
2015-07-13 04:26:46 -06:00
|
|
|
ewma_signal_init(&sta->avg_signal);
|
2013-04-22 08:29:31 -06:00
|
|
|
for (i = 0; i < ARRAY_SIZE(sta->chain_signal_avg); i++)
|
2015-07-13 04:26:46 -06:00
|
|
|
ewma_signal_init(&sta->chain_signal_avg[i]);
|
2010-12-02 03:12:43 -07:00
|
|
|
|
2015-03-27 14:30:37 -06:00
|
|
|
if (local->ops->wake_tx_queue) {
|
|
|
|
void *txq_data;
|
|
|
|
int size = sizeof(struct txq_info) +
|
|
|
|
ALIGN(hw->txq_data_size, sizeof(void *));
|
|
|
|
|
|
|
|
txq_data = kcalloc(ARRAY_SIZE(sta->sta.txq), size, gfp);
|
|
|
|
if (!txq_data)
|
|
|
|
goto free;
|
|
|
|
|
|
|
|
for (i = 0; i < ARRAY_SIZE(sta->sta.txq); i++) {
|
|
|
|
struct txq_info *txq = txq_data + i * size;
|
|
|
|
|
|
|
|
ieee80211_init_tx_queue(sdata, sta, txq, i);
|
|
|
|
}
|
2015-02-25 02:03:25 -07:00
|
|
|
}
|
2007-05-05 12:45:53 -06:00
|
|
|
|
2015-03-27 14:30:37 -06:00
|
|
|
if (sta_prepare_rate_control(local, sta, gfp))
|
|
|
|
goto free_txq;
|
|
|
|
|
2012-11-14 15:22:21 -07:00
|
|
|
for (i = 0; i < IEEE80211_NUM_TIDS; i++) {
|
2010-06-10 02:21:39 -06:00
|
|
|
/*
|
|
|
|
* timer_to_tid must be initialized with identity mapping
|
|
|
|
* to enable session_timer's data differentiation. See
|
|
|
|
* sta_rx_agg_session_timer_expired for usage.
|
|
|
|
*/
|
2007-12-25 08:00:34 -07:00
|
|
|
sta->timer_to_tid[i] = i;
|
|
|
|
}
|
2011-09-29 08:04:29 -06:00
|
|
|
for (i = 0; i < IEEE80211_NUM_ACS; i++) {
|
|
|
|
skb_queue_head_init(&sta->ps_tx_buf[i]);
|
|
|
|
skb_queue_head_init(&sta->tx_filtered[i]);
|
|
|
|
}
|
2008-02-25 08:27:47 -07:00
|
|
|
|
2012-11-14 15:22:21 -07:00
|
|
|
for (i = 0; i < IEEE80211_NUM_TIDS; i++)
|
2010-05-24 15:33:03 -06:00
|
|
|
sta->last_seq_ctrl[i] = cpu_to_le16(USHRT_MAX);
|
2009-05-14 07:12:08 -06:00
|
|
|
|
2013-02-12 06:21:00 -07:00
|
|
|
sta->sta.smps_mode = IEEE80211_SMPS_OFF;
|
2013-10-01 07:45:43 -06:00
|
|
|
if (sdata->vif.type == NL80211_IFTYPE_AP ||
|
|
|
|
sdata->vif.type == NL80211_IFTYPE_AP_VLAN) {
|
|
|
|
struct ieee80211_supported_band *sband =
|
2015-03-27 14:30:37 -06:00
|
|
|
hw->wiphy->bands[ieee80211_get_sdata_band(sdata)];
|
2013-10-01 07:45:43 -06:00
|
|
|
u8 smps = (sband->ht_cap.cap & IEEE80211_HT_CAP_SM_PS) >>
|
|
|
|
IEEE80211_HT_CAP_SM_PS_SHIFT;
|
|
|
|
/*
|
|
|
|
* Assume that hostapd advertises our caps in the beacon and
|
|
|
|
* this is the known_smps_mode for a station that just assciated
|
|
|
|
*/
|
|
|
|
switch (smps) {
|
|
|
|
case WLAN_HT_SMPS_CONTROL_DISABLED:
|
|
|
|
sta->known_smps_mode = IEEE80211_SMPS_OFF;
|
|
|
|
break;
|
|
|
|
case WLAN_HT_SMPS_CONTROL_STATIC:
|
|
|
|
sta->known_smps_mode = IEEE80211_SMPS_STATIC;
|
|
|
|
break;
|
|
|
|
case WLAN_HT_SMPS_CONTROL_DYNAMIC:
|
|
|
|
sta->known_smps_mode = IEEE80211_SMPS_DYNAMIC;
|
|
|
|
break;
|
|
|
|
default:
|
|
|
|
WARN_ON(1);
|
|
|
|
}
|
|
|
|
}
|
2013-02-12 06:21:00 -07:00
|
|
|
|
2012-06-22 03:29:50 -06:00
|
|
|
sta_dbg(sdata, "Allocated STA %pM\n", sta->sta.addr);
|
2014-01-06 07:56:59 -07:00
|
|
|
|
2015-02-25 02:03:25 -07:00
|
|
|
return sta;
|
2015-03-27 14:30:37 -06:00
|
|
|
|
|
|
|
free_txq:
|
|
|
|
if (sta->sta.txq[0])
|
|
|
|
kfree(to_txq_info(sta->sta.txq[0]));
|
|
|
|
free:
|
2015-06-17 02:31:00 -06:00
|
|
|
#ifdef CONFIG_MAC80211_MESH
|
|
|
|
kfree(sta->mesh);
|
|
|
|
#endif
|
2015-03-27 14:30:37 -06:00
|
|
|
kfree(sta);
|
|
|
|
return NULL;
|
2008-02-25 08:27:47 -07:00
|
|
|
}
|
|
|
|
|
2011-08-17 06:18:14 -06:00
|
|
|
static int sta_info_insert_check(struct sta_info *sta)
|
2010-02-03 05:59:58 -07:00
|
|
|
{
|
|
|
|
struct ieee80211_sub_if_data *sdata = sta->sdata;
|
|
|
|
|
2008-02-27 01:56:40 -07:00
|
|
|
/*
|
|
|
|
* Can't be a WARN_ON because it can be triggered through a race:
|
|
|
|
* something inserts a STA (on one CPU) without holding the RTNL
|
|
|
|
* and another CPU turns off the net device.
|
|
|
|
*/
|
2011-08-17 06:18:14 -06:00
|
|
|
if (unlikely(!ieee80211_sdata_running(sdata)))
|
|
|
|
return -ENETDOWN;
|
2008-02-27 01:56:40 -07:00
|
|
|
|
mac80211: Convert compare_ether_addr to ether_addr_equal
Use the new bool function ether_addr_equal to add
some clarity and reduce the likelihood for misuse
of compare_ether_addr for sorting.
Done via cocci script:
$ cat compare_ether_addr.cocci
@@
expression a,b;
@@
- !compare_ether_addr(a, b)
+ ether_addr_equal(a, b)
@@
expression a,b;
@@
- compare_ether_addr(a, b)
+ !ether_addr_equal(a, b)
@@
expression a,b;
@@
- !ether_addr_equal(a, b) == 0
+ ether_addr_equal(a, b)
@@
expression a,b;
@@
- !ether_addr_equal(a, b) != 0
+ !ether_addr_equal(a, b)
@@
expression a,b;
@@
- ether_addr_equal(a, b) == 0
+ !ether_addr_equal(a, b)
@@
expression a,b;
@@
- ether_addr_equal(a, b) != 0
+ ether_addr_equal(a, b)
@@
expression a,b;
@@
- !!ether_addr_equal(a, b)
+ ether_addr_equal(a, b)
Signed-off-by: Joe Perches <joe@perches.com>
Signed-off-by: David S. Miller <davem@davemloft.net>
2012-05-08 12:56:52 -06:00
|
|
|
if (WARN_ON(ether_addr_equal(sta->sta.addr, sdata->vif.addr) ||
|
2011-08-17 06:18:14 -06:00
|
|
|
is_multicast_ether_addr(sta->sta.addr)))
|
|
|
|
return -EINVAL;
|
|
|
|
|
|
|
|
return 0;
|
|
|
|
}
|
|
|
|
|
2012-01-20 05:55:21 -07:00
|
|
|
static int sta_info_insert_drv_state(struct ieee80211_local *local,
|
|
|
|
struct ieee80211_sub_if_data *sdata,
|
|
|
|
struct sta_info *sta)
|
|
|
|
{
|
|
|
|
enum ieee80211_sta_state state;
|
|
|
|
int err = 0;
|
|
|
|
|
|
|
|
for (state = IEEE80211_STA_NOTEXIST; state < sta->sta_state; state++) {
|
|
|
|
err = drv_sta_state(local, sdata, sta, state, state + 1);
|
|
|
|
if (err)
|
|
|
|
break;
|
|
|
|
}
|
|
|
|
|
|
|
|
if (!err) {
|
2012-01-20 05:55:22 -07:00
|
|
|
/*
|
|
|
|
* Drivers using legacy sta_add/sta_remove callbacks only
|
|
|
|
* get uploaded set to true after sta_add is called.
|
|
|
|
*/
|
|
|
|
if (!local->ops->sta_add)
|
|
|
|
sta->uploaded = true;
|
2012-01-20 05:55:21 -07:00
|
|
|
return 0;
|
|
|
|
}
|
|
|
|
|
|
|
|
if (sdata->vif.type == NL80211_IFTYPE_ADHOC) {
|
2012-06-22 03:29:50 -06:00
|
|
|
sdata_info(sdata,
|
|
|
|
"failed to move IBSS STA %pM to state %d (%d) - keeping it anyway\n",
|
|
|
|
sta->sta.addr, state + 1, err);
|
2012-01-20 05:55:21 -07:00
|
|
|
err = 0;
|
|
|
|
}
|
|
|
|
|
|
|
|
/* unwind on error */
|
|
|
|
for (; state > IEEE80211_STA_NOTEXIST; state--)
|
|
|
|
WARN_ON(drv_sta_state(local, sdata, sta, state, state - 1));
|
|
|
|
|
|
|
|
return err;
|
|
|
|
}
|
|
|
|
|
2011-08-17 06:18:14 -06:00
|
|
|
/*
|
|
|
|
* should be called with sta_mtx locked
|
|
|
|
* this function replaces the mutex lock
|
|
|
|
* with a RCU lock
|
|
|
|
*/
|
2011-12-15 03:24:20 -07:00
|
|
|
static int sta_info_insert_finish(struct sta_info *sta) __acquires(RCU)
|
2011-08-17 06:18:14 -06:00
|
|
|
{
|
|
|
|
struct ieee80211_local *local = sta->local;
|
|
|
|
struct ieee80211_sub_if_data *sdata = sta->sdata;
|
2012-01-20 05:55:24 -07:00
|
|
|
struct station_info sinfo;
|
2011-08-17 06:18:14 -06:00
|
|
|
int err = 0;
|
|
|
|
|
|
|
|
lockdep_assert_held(&local->sta_mtx);
|
2010-02-03 05:59:58 -07:00
|
|
|
|
2012-01-20 05:55:24 -07:00
|
|
|
/* check if STA exists already */
|
|
|
|
if (sta_info_get_bss(sdata, sta->sta.addr)) {
|
|
|
|
err = -EEXIST;
|
|
|
|
goto out_err;
|
2011-12-15 03:24:20 -07:00
|
|
|
}
|
2007-12-18 17:31:26 -07:00
|
|
|
|
2012-01-20 05:55:24 -07:00
|
|
|
local->num_sta++;
|
|
|
|
local->sta_generation++;
|
|
|
|
smp_mb();
|
2011-12-15 03:24:20 -07:00
|
|
|
|
2014-02-17 12:49:03 -07:00
|
|
|
/* simplify things and don't accept BA sessions yet */
|
|
|
|
set_sta_flag(sta, WLAN_STA_BLOCK_BA);
|
|
|
|
|
2012-01-20 05:55:24 -07:00
|
|
|
/* make the station visible */
|
|
|
|
sta_info_hash_add(local, sta);
|
2012-01-12 01:31:10 -07:00
|
|
|
|
2014-10-22 03:32:16 -06:00
|
|
|
list_add_tail_rcu(&sta->list, &local->sta_list);
|
2011-12-15 03:24:20 -07:00
|
|
|
|
2014-02-17 12:49:03 -07:00
|
|
|
/* notify driver */
|
|
|
|
err = sta_info_insert_drv_state(local, sdata, sta);
|
|
|
|
if (err)
|
|
|
|
goto out_remove;
|
|
|
|
|
2012-01-20 05:55:24 -07:00
|
|
|
set_sta_flag(sta, WLAN_STA_INSERTED);
|
2014-02-17 12:49:03 -07:00
|
|
|
/* accept BA sessions now */
|
|
|
|
clear_sta_flag(sta, WLAN_STA_BLOCK_BA);
|
2011-12-15 03:24:20 -07:00
|
|
|
|
2013-11-11 11:14:01 -07:00
|
|
|
ieee80211_recalc_min_chandef(sdata);
|
2012-01-20 05:55:24 -07:00
|
|
|
ieee80211_sta_debugfs_add(sta);
|
|
|
|
rate_control_add_sta_debugfs(sta);
|
2011-12-15 03:24:20 -07:00
|
|
|
|
2012-01-20 05:55:24 -07:00
|
|
|
memset(&sinfo, 0, sizeof(sinfo));
|
|
|
|
sinfo.filled = 0;
|
|
|
|
sinfo.generation = local->sta_generation;
|
|
|
|
cfg80211_new_sta(sdata->dev, sta->sta.addr, &sinfo, GFP_KERNEL);
|
2008-02-25 08:27:46 -07:00
|
|
|
|
2012-06-22 03:29:50 -06:00
|
|
|
sta_dbg(sdata, "Inserted STA %pM\n", sta->sta.addr);
|
2007-05-05 12:45:53 -06:00
|
|
|
|
2010-02-03 05:59:58 -07:00
|
|
|
/* move reference to rcu-protected */
|
|
|
|
rcu_read_lock();
|
|
|
|
mutex_unlock(&local->sta_mtx);
|
2007-05-05 12:46:38 -06:00
|
|
|
|
2008-02-25 08:27:47 -07:00
|
|
|
if (ieee80211_vif_is_mesh(&sdata->vif))
|
|
|
|
mesh_accept_plinks_update(sdata);
|
|
|
|
|
2011-08-17 06:18:14 -06:00
|
|
|
return 0;
|
2014-02-17 12:49:03 -07:00
|
|
|
out_remove:
|
|
|
|
sta_info_hash_del(local, sta);
|
|
|
|
list_del_rcu(&sta->list);
|
|
|
|
local->num_sta--;
|
|
|
|
synchronize_net();
|
|
|
|
__cleanup_single_sta(sta);
|
2011-12-15 03:24:20 -07:00
|
|
|
out_err:
|
|
|
|
mutex_unlock(&local->sta_mtx);
|
|
|
|
rcu_read_lock();
|
|
|
|
return err;
|
2011-08-17 06:18:14 -06:00
|
|
|
}
|
|
|
|
|
|
|
|
int sta_info_insert_rcu(struct sta_info *sta) __acquires(RCU)
|
|
|
|
{
|
|
|
|
struct ieee80211_local *local = sta->local;
|
2014-04-20 22:53:00 -06:00
|
|
|
int err;
|
2011-08-17 06:18:14 -06:00
|
|
|
|
2011-12-15 03:24:20 -07:00
|
|
|
might_sleep();
|
|
|
|
|
2011-08-17 06:18:14 -06:00
|
|
|
err = sta_info_insert_check(sta);
|
|
|
|
if (err) {
|
|
|
|
rcu_read_lock();
|
|
|
|
goto out_free;
|
|
|
|
}
|
|
|
|
|
|
|
|
mutex_lock(&local->sta_mtx);
|
|
|
|
|
2011-12-15 03:24:20 -07:00
|
|
|
err = sta_info_insert_finish(sta);
|
2011-08-17 06:18:14 -06:00
|
|
|
if (err)
|
|
|
|
goto out_free;
|
|
|
|
|
2008-02-25 08:27:47 -07:00
|
|
|
return 0;
|
2008-04-01 07:21:00 -06:00
|
|
|
out_free:
|
2011-12-14 04:35:30 -07:00
|
|
|
sta_info_free(local, sta);
|
2008-04-01 07:21:00 -06:00
|
|
|
return err;
|
2007-05-05 12:45:53 -06:00
|
|
|
}
|
|
|
|
|
2010-02-03 05:59:58 -07:00
|
|
|
int sta_info_insert(struct sta_info *sta)
|
|
|
|
{
|
|
|
|
int err = sta_info_insert_rcu(sta);
|
|
|
|
|
|
|
|
rcu_read_unlock();
|
|
|
|
|
|
|
|
return err;
|
|
|
|
}
|
|
|
|
|
2012-10-10 13:39:50 -06:00
|
|
|
static inline void __bss_tim_set(u8 *tim, u16 id)
|
2008-02-20 03:21:35 -07:00
|
|
|
{
|
|
|
|
/*
|
|
|
|
* This format has been mandated by the IEEE specifications,
|
|
|
|
* so this line may not be changed to use the __set_bit() format.
|
|
|
|
*/
|
2012-10-10 13:39:50 -06:00
|
|
|
tim[id / 8] |= (1 << (id % 8));
|
2008-02-20 03:21:35 -07:00
|
|
|
}
|
|
|
|
|
2012-10-10 13:39:50 -06:00
|
|
|
static inline void __bss_tim_clear(u8 *tim, u16 id)
|
2008-02-20 03:21:35 -07:00
|
|
|
{
|
|
|
|
/*
|
|
|
|
* This format has been mandated by the IEEE specifications,
|
|
|
|
* so this line may not be changed to use the __clear_bit() format.
|
|
|
|
*/
|
2012-10-10 13:39:50 -06:00
|
|
|
tim[id / 8] &= ~(1 << (id % 8));
|
2008-02-20 03:21:35 -07:00
|
|
|
}
|
|
|
|
|
2013-03-05 06:27:20 -07:00
|
|
|
static inline bool __bss_tim_get(u8 *tim, u16 id)
|
|
|
|
{
|
|
|
|
/*
|
|
|
|
* This format has been mandated by the IEEE specifications,
|
|
|
|
* so this line may not be changed to use the test_bit() format.
|
|
|
|
*/
|
|
|
|
return tim[id / 8] & (1 << (id % 8));
|
|
|
|
}
|
|
|
|
|
2011-09-29 08:04:29 -06:00
|
|
|
static unsigned long ieee80211_tids_for_ac(int ac)
|
2008-02-20 03:21:35 -07:00
|
|
|
{
|
2011-09-29 08:04:29 -06:00
|
|
|
/* If we ever support TIDs > 7, this obviously needs to be adjusted */
|
|
|
|
switch (ac) {
|
|
|
|
case IEEE80211_AC_VO:
|
|
|
|
return BIT(6) | BIT(7);
|
|
|
|
case IEEE80211_AC_VI:
|
|
|
|
return BIT(4) | BIT(5);
|
|
|
|
case IEEE80211_AC_BE:
|
|
|
|
return BIT(0) | BIT(3);
|
|
|
|
case IEEE80211_AC_BK:
|
|
|
|
return BIT(1) | BIT(2);
|
|
|
|
default:
|
|
|
|
WARN_ON(1);
|
|
|
|
return 0;
|
2008-02-25 08:27:46 -07:00
|
|
|
}
|
2008-02-20 03:21:35 -07:00
|
|
|
}
|
|
|
|
|
2015-01-09 03:40:39 -07:00
|
|
|
static void __sta_info_recalc_tim(struct sta_info *sta, bool ignore_pending)
|
2008-02-20 03:21:35 -07:00
|
|
|
{
|
2011-09-29 08:04:27 -06:00
|
|
|
struct ieee80211_local *local = sta->local;
|
2012-10-10 13:39:50 -06:00
|
|
|
struct ps_data *ps;
|
2011-09-29 08:04:29 -06:00
|
|
|
bool indicate_tim = false;
|
|
|
|
u8 ignore_for_tim = sta->sta.uapsd_queues;
|
|
|
|
int ac;
|
2015-07-14 06:31:58 -06:00
|
|
|
u16 id = sta->sta.aid;
|
2012-10-10 13:39:50 -06:00
|
|
|
|
|
|
|
if (sta->sdata->vif.type == NL80211_IFTYPE_AP ||
|
|
|
|
sta->sdata->vif.type == NL80211_IFTYPE_AP_VLAN) {
|
|
|
|
if (WARN_ON_ONCE(!sta->sdata->bss))
|
|
|
|
return;
|
2008-02-20 03:21:35 -07:00
|
|
|
|
2012-10-10 13:39:50 -06:00
|
|
|
ps = &sta->sdata->bss->ps;
|
2013-01-30 10:14:08 -07:00
|
|
|
#ifdef CONFIG_MAC80211_MESH
|
|
|
|
} else if (ieee80211_vif_is_mesh(&sta->sdata->vif)) {
|
|
|
|
ps = &sta->sdata->u.mesh.ps;
|
|
|
|
#endif
|
2012-10-10 13:39:50 -06:00
|
|
|
} else {
|
2011-09-29 08:04:27 -06:00
|
|
|
return;
|
2012-10-10 13:39:50 -06:00
|
|
|
}
|
mac80211: make master netdev handling sane
Currently, almost every interface type has a 'bss' pointer
pointing to BSS information. This BSS information, however,
is for a _local_ BSS, not for the BSS we joined, so having
it on a STA mode interface makes little sense, but now they
have it pointing to the master device, which is an AP mode
virtual interface. However, except for some bitrate control
data, this pointer is only used in AP/VLAN modes (for power
saving stations.)
Overall, it is not necessary to even have the master netdev
be a valid virtual interface, and it doesn't have to be on
the list of interfaces either.
This patch changes the master netdev to be special, it now
- no longer is on the list of virtual interfaces, which
lets me remove a lot of tests for that
- no longer has sub_if_data attached, since that isn't used
Additionally, this patch changes some vlan/ap mode handling
that is related to these 'bss' pointers described above (but
in the VLAN case they actually make sense because there they
point to the AP they belong to); it also adds some debugging
code to IEEE80211_DEV_TO_SUB_IF to validate it is not called
on the master netdev any more.
Signed-off-by: Johannes Berg <johannes@sipsolutions.net>
Signed-off-by: John W. Linville <linville@tuxdriver.com>
2008-07-09 06:40:34 -06:00
|
|
|
|
2011-09-29 08:04:27 -06:00
|
|
|
/* No need to do anything if the driver does all */
|
2015-06-02 13:39:54 -06:00
|
|
|
if (ieee80211_hw_check(&local->hw, AP_LINK_PS))
|
2011-09-29 08:04:27 -06:00
|
|
|
return;
|
2008-02-20 03:21:35 -07:00
|
|
|
|
2011-09-29 08:04:27 -06:00
|
|
|
if (sta->dead)
|
|
|
|
goto done;
|
mac80211: make master netdev handling sane
Currently, almost every interface type has a 'bss' pointer
pointing to BSS information. This BSS information, however,
is for a _local_ BSS, not for the BSS we joined, so having
it on a STA mode interface makes little sense, but now they
have it pointing to the master device, which is an AP mode
virtual interface. However, except for some bitrate control
data, this pointer is only used in AP/VLAN modes (for power
saving stations.)
Overall, it is not necessary to even have the master netdev
be a valid virtual interface, and it doesn't have to be on
the list of interfaces either.
This patch changes the master netdev to be special, it now
- no longer is on the list of virtual interfaces, which
lets me remove a lot of tests for that
- no longer has sub_if_data attached, since that isn't used
Additionally, this patch changes some vlan/ap mode handling
that is related to these 'bss' pointers described above (but
in the VLAN case they actually make sense because there they
point to the AP they belong to); it also adds some debugging
code to IEEE80211_DEV_TO_SUB_IF to validate it is not called
on the master netdev any more.
Signed-off-by: Johannes Berg <johannes@sipsolutions.net>
Signed-off-by: John W. Linville <linville@tuxdriver.com>
2008-07-09 06:40:34 -06:00
|
|
|
|
2011-09-29 08:04:29 -06:00
|
|
|
/*
|
|
|
|
* If all ACs are delivery-enabled then we should build
|
|
|
|
* the TIM bit for all ACs anyway; if only some are then
|
|
|
|
* we ignore those and build the TIM bit using only the
|
|
|
|
* non-enabled ones.
|
|
|
|
*/
|
|
|
|
if (ignore_for_tim == BIT(IEEE80211_NUM_ACS) - 1)
|
|
|
|
ignore_for_tim = 0;
|
|
|
|
|
2015-01-09 03:40:39 -07:00
|
|
|
if (ignore_pending)
|
|
|
|
ignore_for_tim = BIT(IEEE80211_NUM_ACS) - 1;
|
|
|
|
|
2011-09-29 08:04:29 -06:00
|
|
|
for (ac = 0; ac < IEEE80211_NUM_ACS; ac++) {
|
|
|
|
unsigned long tids;
|
mac80211: make master netdev handling sane
Currently, almost every interface type has a 'bss' pointer
pointing to BSS information. This BSS information, however,
is for a _local_ BSS, not for the BSS we joined, so having
it on a STA mode interface makes little sense, but now they
have it pointing to the master device, which is an AP mode
virtual interface. However, except for some bitrate control
data, this pointer is only used in AP/VLAN modes (for power
saving stations.)
Overall, it is not necessary to even have the master netdev
be a valid virtual interface, and it doesn't have to be on
the list of interfaces either.
This patch changes the master netdev to be special, it now
- no longer is on the list of virtual interfaces, which
lets me remove a lot of tests for that
- no longer has sub_if_data attached, since that isn't used
Additionally, this patch changes some vlan/ap mode handling
that is related to these 'bss' pointers described above (but
in the VLAN case they actually make sense because there they
point to the AP they belong to); it also adds some debugging
code to IEEE80211_DEV_TO_SUB_IF to validate it is not called
on the master netdev any more.
Signed-off-by: Johannes Berg <johannes@sipsolutions.net>
Signed-off-by: John W. Linville <linville@tuxdriver.com>
2008-07-09 06:40:34 -06:00
|
|
|
|
2011-09-29 08:04:29 -06:00
|
|
|
if (ignore_for_tim & BIT(ac))
|
|
|
|
continue;
|
|
|
|
|
|
|
|
indicate_tim |= !skb_queue_empty(&sta->tx_filtered[ac]) ||
|
|
|
|
!skb_queue_empty(&sta->ps_tx_buf[ac]);
|
|
|
|
if (indicate_tim)
|
|
|
|
break;
|
mac80211: make master netdev handling sane
Currently, almost every interface type has a 'bss' pointer
pointing to BSS information. This BSS information, however,
is for a _local_ BSS, not for the BSS we joined, so having
it on a STA mode interface makes little sense, but now they
have it pointing to the master device, which is an AP mode
virtual interface. However, except for some bitrate control
data, this pointer is only used in AP/VLAN modes (for power
saving stations.)
Overall, it is not necessary to even have the master netdev
be a valid virtual interface, and it doesn't have to be on
the list of interfaces either.
This patch changes the master netdev to be special, it now
- no longer is on the list of virtual interfaces, which
lets me remove a lot of tests for that
- no longer has sub_if_data attached, since that isn't used
Additionally, this patch changes some vlan/ap mode handling
that is related to these 'bss' pointers described above (but
in the VLAN case they actually make sense because there they
point to the AP they belong to); it also adds some debugging
code to IEEE80211_DEV_TO_SUB_IF to validate it is not called
on the master netdev any more.
Signed-off-by: Johannes Berg <johannes@sipsolutions.net>
Signed-off-by: John W. Linville <linville@tuxdriver.com>
2008-07-09 06:40:34 -06:00
|
|
|
|
2011-09-29 08:04:29 -06:00
|
|
|
tids = ieee80211_tids_for_ac(ac);
|
|
|
|
|
|
|
|
indicate_tim |=
|
|
|
|
sta->driver_buffered_tids & tids;
|
2015-03-27 14:30:37 -06:00
|
|
|
indicate_tim |=
|
|
|
|
sta->txq_buffered_tids & tids;
|
2008-02-25 08:27:46 -07:00
|
|
|
}
|
2008-02-20 03:21:35 -07:00
|
|
|
|
2011-09-29 08:04:27 -06:00
|
|
|
done:
|
2013-02-13 09:39:53 -07:00
|
|
|
spin_lock_bh(&local->tim_lock);
|
2008-02-20 03:21:35 -07:00
|
|
|
|
2013-03-05 06:27:20 -07:00
|
|
|
if (indicate_tim == __bss_tim_get(ps->tim, id))
|
|
|
|
goto out_unlock;
|
|
|
|
|
2011-09-29 08:04:29 -06:00
|
|
|
if (indicate_tim)
|
2012-10-10 13:39:50 -06:00
|
|
|
__bss_tim_set(ps->tim, id);
|
2011-09-29 08:04:27 -06:00
|
|
|
else
|
2012-10-10 13:39:50 -06:00
|
|
|
__bss_tim_clear(ps->tim, id);
|
2008-02-20 03:21:35 -07:00
|
|
|
|
2015-01-09 03:40:39 -07:00
|
|
|
if (local->ops->set_tim && !WARN_ON(sta->dead)) {
|
2011-09-29 08:04:27 -06:00
|
|
|
local->tim_in_locked_section = true;
|
2011-09-29 08:04:29 -06:00
|
|
|
drv_set_tim(local, &sta->sta, indicate_tim);
|
2011-09-29 08:04:27 -06:00
|
|
|
local->tim_in_locked_section = false;
|
|
|
|
}
|
mac80211: make master netdev handling sane
Currently, almost every interface type has a 'bss' pointer
pointing to BSS information. This BSS information, however,
is for a _local_ BSS, not for the BSS we joined, so having
it on a STA mode interface makes little sense, but now they
have it pointing to the master device, which is an AP mode
virtual interface. However, except for some bitrate control
data, this pointer is only used in AP/VLAN modes (for power
saving stations.)
Overall, it is not necessary to even have the master netdev
be a valid virtual interface, and it doesn't have to be on
the list of interfaces either.
This patch changes the master netdev to be special, it now
- no longer is on the list of virtual interfaces, which
lets me remove a lot of tests for that
- no longer has sub_if_data attached, since that isn't used
Additionally, this patch changes some vlan/ap mode handling
that is related to these 'bss' pointers described above (but
in the VLAN case they actually make sense because there they
point to the AP they belong to); it also adds some debugging
code to IEEE80211_DEV_TO_SUB_IF to validate it is not called
on the master netdev any more.
Signed-off-by: Johannes Berg <johannes@sipsolutions.net>
Signed-off-by: John W. Linville <linville@tuxdriver.com>
2008-07-09 06:40:34 -06:00
|
|
|
|
2013-03-05 06:27:20 -07:00
|
|
|
out_unlock:
|
2013-02-13 09:39:53 -07:00
|
|
|
spin_unlock_bh(&local->tim_lock);
|
2008-02-20 03:21:35 -07:00
|
|
|
}
|
|
|
|
|
2015-01-09 03:40:39 -07:00
|
|
|
void sta_info_recalc_tim(struct sta_info *sta)
|
|
|
|
{
|
|
|
|
__sta_info_recalc_tim(sta, false);
|
|
|
|
}
|
|
|
|
|
2011-09-06 06:13:06 -06:00
|
|
|
static bool sta_info_buffer_expired(struct sta_info *sta, struct sk_buff *skb)
|
2007-05-05 12:45:53 -06:00
|
|
|
{
|
2008-05-15 04:55:29 -06:00
|
|
|
struct ieee80211_tx_info *info;
|
2007-05-05 12:45:53 -06:00
|
|
|
int timeout;
|
|
|
|
|
|
|
|
if (!skb)
|
2011-09-06 06:13:06 -06:00
|
|
|
return false;
|
2007-05-05 12:45:53 -06:00
|
|
|
|
2008-05-15 04:55:29 -06:00
|
|
|
info = IEEE80211_SKB_CB(skb);
|
2007-05-05 12:45:53 -06:00
|
|
|
|
|
|
|
/* Timeout: (2 * listen_interval * beacon_int * 1024 / 1000000) sec */
|
2009-04-23 08:10:04 -06:00
|
|
|
timeout = (sta->listen_interval *
|
|
|
|
sta->sdata->vif.bss_conf.beacon_int *
|
|
|
|
32 / 15625) * HZ;
|
2007-05-05 12:45:53 -06:00
|
|
|
if (timeout < STA_TX_BUFFER_EXPIRE)
|
|
|
|
timeout = STA_TX_BUFFER_EXPIRE;
|
2008-05-15 04:55:29 -06:00
|
|
|
return time_after(jiffies, info->control.jiffies + timeout);
|
2007-05-05 12:45:53 -06:00
|
|
|
}
|
|
|
|
|
|
|
|
|
2011-09-29 08:04:29 -06:00
|
|
|
static bool sta_info_cleanup_expire_buffered_ac(struct ieee80211_local *local,
|
|
|
|
struct sta_info *sta, int ac)
|
2007-05-05 12:45:53 -06:00
|
|
|
{
|
|
|
|
unsigned long flags;
|
|
|
|
struct sk_buff *skb;
|
|
|
|
|
2011-09-29 08:04:28 -06:00
|
|
|
/*
|
|
|
|
* First check for frames that should expire on the filtered
|
|
|
|
* queue. Frames here were rejected by the driver and are on
|
|
|
|
* a separate queue to avoid reordering with normal PS-buffered
|
|
|
|
* frames. They also aren't accounted for right now in the
|
|
|
|
* total_ps_buffered counter.
|
|
|
|
*/
|
|
|
|
for (;;) {
|
2011-09-29 08:04:29 -06:00
|
|
|
spin_lock_irqsave(&sta->tx_filtered[ac].lock, flags);
|
|
|
|
skb = skb_peek(&sta->tx_filtered[ac]);
|
2011-09-29 08:04:28 -06:00
|
|
|
if (sta_info_buffer_expired(sta, skb))
|
2011-09-29 08:04:29 -06:00
|
|
|
skb = __skb_dequeue(&sta->tx_filtered[ac]);
|
2011-09-29 08:04:28 -06:00
|
|
|
else
|
|
|
|
skb = NULL;
|
2011-09-29 08:04:29 -06:00
|
|
|
spin_unlock_irqrestore(&sta->tx_filtered[ac].lock, flags);
|
2011-09-29 08:04:28 -06:00
|
|
|
|
|
|
|
/*
|
|
|
|
* Frames are queued in order, so if this one
|
|
|
|
* hasn't expired yet we can stop testing. If
|
|
|
|
* we actually reached the end of the queue we
|
|
|
|
* also need to stop, of course.
|
|
|
|
*/
|
|
|
|
if (!skb)
|
|
|
|
break;
|
2012-10-10 14:40:23 -06:00
|
|
|
ieee80211_free_txskb(&local->hw, skb);
|
2011-09-29 08:04:28 -06:00
|
|
|
}
|
|
|
|
|
|
|
|
/*
|
|
|
|
* Now also check the normal PS-buffered queue, this will
|
|
|
|
* only find something if the filtered queue was emptied
|
|
|
|
* since the filtered frames are all before the normal PS
|
|
|
|
* buffered frames.
|
|
|
|
*/
|
2007-05-05 12:45:53 -06:00
|
|
|
for (;;) {
|
2011-09-29 08:04:29 -06:00
|
|
|
spin_lock_irqsave(&sta->ps_tx_buf[ac].lock, flags);
|
|
|
|
skb = skb_peek(&sta->ps_tx_buf[ac]);
|
2009-04-23 08:10:04 -06:00
|
|
|
if (sta_info_buffer_expired(sta, skb))
|
2011-09-29 08:04:29 -06:00
|
|
|
skb = __skb_dequeue(&sta->ps_tx_buf[ac]);
|
2008-02-19 18:07:21 -07:00
|
|
|
else
|
2007-05-05 12:45:53 -06:00
|
|
|
skb = NULL;
|
2011-09-29 08:04:29 -06:00
|
|
|
spin_unlock_irqrestore(&sta->ps_tx_buf[ac].lock, flags);
|
2007-05-05 12:45:53 -06:00
|
|
|
|
2011-09-29 08:04:28 -06:00
|
|
|
/*
|
|
|
|
* frames are queued in order, so if this one
|
|
|
|
* hasn't expired yet (or we reached the end of
|
|
|
|
* the queue) we can stop testing
|
|
|
|
*/
|
2008-02-19 18:07:21 -07:00
|
|
|
if (!skb)
|
2007-05-05 12:45:53 -06:00
|
|
|
break;
|
2008-02-19 18:07:21 -07:00
|
|
|
|
|
|
|
local->total_ps_buffered--;
|
2012-06-22 03:29:50 -06:00
|
|
|
ps_dbg(sta->sdata, "Buffered frame expired (STA %pM)\n",
|
|
|
|
sta->sta.addr);
|
2012-10-10 14:40:23 -06:00
|
|
|
ieee80211_free_txskb(&local->hw, skb);
|
2007-05-05 12:45:53 -06:00
|
|
|
}
|
2010-04-19 01:12:52 -06:00
|
|
|
|
2011-09-29 08:04:28 -06:00
|
|
|
/*
|
|
|
|
* Finally, recalculate the TIM bit for this station -- it might
|
|
|
|
* now be clear because the station was too slow to retrieve its
|
|
|
|
* frames.
|
|
|
|
*/
|
|
|
|
sta_info_recalc_tim(sta);
|
|
|
|
|
|
|
|
/*
|
|
|
|
* Return whether there are any frames still buffered, this is
|
|
|
|
* used to check whether the cleanup timer still needs to run,
|
|
|
|
* if there are no frames we don't need to rearm the timer.
|
|
|
|
*/
|
2011-09-29 08:04:29 -06:00
|
|
|
return !(skb_queue_empty(&sta->ps_tx_buf[ac]) &&
|
|
|
|
skb_queue_empty(&sta->tx_filtered[ac]));
|
|
|
|
}
|
|
|
|
|
|
|
|
static bool sta_info_cleanup_expire_buffered(struct ieee80211_local *local,
|
|
|
|
struct sta_info *sta)
|
|
|
|
{
|
|
|
|
bool have_buffered = false;
|
|
|
|
int ac;
|
|
|
|
|
2013-01-30 10:14:08 -07:00
|
|
|
/* This is only necessary for stations on BSS/MBSS interfaces */
|
|
|
|
if (!sta->sdata->bss &&
|
|
|
|
!ieee80211_vif_is_mesh(&sta->sdata->vif))
|
2011-09-29 08:04:29 -06:00
|
|
|
return false;
|
|
|
|
|
|
|
|
for (ac = 0; ac < IEEE80211_NUM_ACS; ac++)
|
|
|
|
have_buffered |=
|
|
|
|
sta_info_cleanup_expire_buffered_ac(local, sta, ac);
|
|
|
|
|
|
|
|
return have_buffered;
|
2007-05-05 12:45:53 -06:00
|
|
|
}
|
|
|
|
|
2013-12-04 15:12:31 -07:00
|
|
|
static int __must_check __sta_info_destroy_part1(struct sta_info *sta)
|
2007-05-05 12:45:53 -06:00
|
|
|
{
|
2010-02-03 05:59:58 -07:00
|
|
|
struct ieee80211_local *local;
|
|
|
|
struct ieee80211_sub_if_data *sdata;
|
2013-03-06 15:09:11 -07:00
|
|
|
int ret;
|
2007-05-05 12:45:53 -06:00
|
|
|
|
2010-02-03 05:59:58 -07:00
|
|
|
might_sleep();
|
2007-05-05 12:45:53 -06:00
|
|
|
|
2010-02-03 05:59:58 -07:00
|
|
|
if (!sta)
|
|
|
|
return -ENOENT;
|
2009-05-17 03:40:42 -06:00
|
|
|
|
2010-02-03 05:59:58 -07:00
|
|
|
local = sta->local;
|
|
|
|
sdata = sta->sdata;
|
2007-05-05 12:45:53 -06:00
|
|
|
|
2012-01-12 01:31:10 -07:00
|
|
|
lockdep_assert_held(&local->sta_mtx);
|
|
|
|
|
2010-04-06 03:18:47 -06:00
|
|
|
/*
|
|
|
|
* Before removing the station from the driver and
|
|
|
|
* rate control, it might still start new aggregation
|
|
|
|
* sessions -- block that to make sure the tear-down
|
|
|
|
* will be sufficient.
|
|
|
|
*/
|
2011-09-29 08:04:36 -06:00
|
|
|
set_sta_flag(sta, WLAN_STA_BLOCK_BA);
|
2012-07-18 05:31:31 -06:00
|
|
|
ieee80211_sta_tear_down_BA_sessions(sta, AGG_STOP_DESTROY_STA);
|
2010-04-06 03:18:47 -06:00
|
|
|
|
2010-02-03 05:59:58 -07:00
|
|
|
ret = sta_info_hash_del(local, sta);
|
2013-12-04 12:25:27 -07:00
|
|
|
if (WARN_ON(ret))
|
2010-02-03 05:59:58 -07:00
|
|
|
return ret;
|
|
|
|
|
2014-11-09 09:50:19 -07:00
|
|
|
/*
|
|
|
|
* for TDLS peers, make sure to return to the base channel before
|
|
|
|
* removal.
|
|
|
|
*/
|
|
|
|
if (test_sta_flag(sta, WLAN_STA_TDLS_OFF_CHANNEL)) {
|
|
|
|
drv_tdls_cancel_channel_switch(local, sdata, &sta->sta);
|
|
|
|
clear_sta_flag(sta, WLAN_STA_TDLS_OFF_CHANNEL);
|
|
|
|
}
|
|
|
|
|
2012-06-03 14:32:32 -06:00
|
|
|
list_del_rcu(&sta->list);
|
2011-12-15 03:24:20 -07:00
|
|
|
|
2013-12-04 14:39:17 -07:00
|
|
|
drv_sta_pre_rcu_remove(local, sta->sdata, sta);
|
|
|
|
|
2013-12-04 12:11:06 -07:00
|
|
|
if (sdata->vif.type == NL80211_IFTYPE_AP_VLAN &&
|
|
|
|
rcu_access_pointer(sdata->u.vlan.sta) == sta)
|
|
|
|
RCU_INIT_POINTER(sdata->u.vlan.sta, NULL);
|
|
|
|
|
2013-12-04 15:12:31 -07:00
|
|
|
return 0;
|
|
|
|
}
|
|
|
|
|
|
|
|
static void __sta_info_destroy_part2(struct sta_info *sta)
|
|
|
|
{
|
|
|
|
struct ieee80211_local *local = sta->local;
|
|
|
|
struct ieee80211_sub_if_data *sdata = sta->sdata;
|
2014-11-14 12:32:57 -07:00
|
|
|
struct station_info sinfo = {};
|
2013-12-04 15:12:31 -07:00
|
|
|
int ret;
|
|
|
|
|
|
|
|
/*
|
|
|
|
* NOTE: This assumes at least synchronize_net() was done
|
|
|
|
* after _part1 and before _part2!
|
|
|
|
*/
|
|
|
|
|
|
|
|
might_sleep();
|
|
|
|
lockdep_assert_held(&local->sta_mtx);
|
|
|
|
|
2013-12-04 15:05:45 -07:00
|
|
|
/* now keys can no longer be reached */
|
2013-03-06 15:09:11 -07:00
|
|
|
ieee80211_free_sta_keys(local, sta);
|
2010-02-03 05:59:58 -07:00
|
|
|
|
2015-01-09 03:40:39 -07:00
|
|
|
/* disable TIM bit - last chance to tell driver */
|
|
|
|
__sta_info_recalc_tim(sta, true);
|
|
|
|
|
2010-02-03 05:59:58 -07:00
|
|
|
sta->dead = true;
|
|
|
|
|
|
|
|
local->num_sta--;
|
|
|
|
local->sta_generation++;
|
|
|
|
|
2012-01-12 01:31:10 -07:00
|
|
|
while (sta->sta_state > IEEE80211_STA_NONE) {
|
2012-01-20 05:55:21 -07:00
|
|
|
ret = sta_info_move_state(sta, sta->sta_state - 1);
|
|
|
|
if (ret) {
|
2012-01-12 01:31:10 -07:00
|
|
|
WARN_ON_ONCE(1);
|
|
|
|
break;
|
|
|
|
}
|
|
|
|
}
|
2011-12-14 04:35:30 -07:00
|
|
|
|
2012-01-20 05:55:21 -07:00
|
|
|
if (sta->uploaded) {
|
|
|
|
ret = drv_sta_state(local, sdata, sta, IEEE80211_STA_NONE,
|
|
|
|
IEEE80211_STA_NOTEXIST);
|
|
|
|
WARN_ON_ONCE(ret != 0);
|
|
|
|
}
|
2010-02-03 05:59:58 -07:00
|
|
|
|
2012-06-22 03:29:50 -06:00
|
|
|
sta_dbg(sdata, "Removed STA %pM\n", sta->sta.addr);
|
|
|
|
|
2014-11-14 12:32:57 -07:00
|
|
|
sta_set_sinfo(sta, &sinfo);
|
|
|
|
cfg80211_del_sta_sinfo(sdata->dev, sta->sta.addr, &sinfo, GFP_KERNEL);
|
2011-03-23 07:29:52 -06:00
|
|
|
|
2010-02-03 05:59:58 -07:00
|
|
|
rate_control_remove_sta_debugfs(sta);
|
|
|
|
ieee80211_sta_debugfs_remove(sta);
|
2013-11-11 11:14:01 -07:00
|
|
|
ieee80211_recalc_min_chandef(sdata);
|
2010-02-03 05:59:58 -07:00
|
|
|
|
2013-12-04 14:46:11 -07:00
|
|
|
cleanup_single_sta(sta);
|
2013-12-04 15:12:31 -07:00
|
|
|
}
|
|
|
|
|
|
|
|
int __must_check __sta_info_destroy(struct sta_info *sta)
|
|
|
|
{
|
|
|
|
int err = __sta_info_destroy_part1(sta);
|
|
|
|
|
|
|
|
if (err)
|
|
|
|
return err;
|
|
|
|
|
|
|
|
synchronize_net();
|
|
|
|
|
|
|
|
__sta_info_destroy_part2(sta);
|
2010-02-03 05:59:58 -07:00
|
|
|
|
|
|
|
return 0;
|
2008-04-07 13:53:49 -06:00
|
|
|
}
|
|
|
|
|
2010-02-03 05:59:58 -07:00
|
|
|
int sta_info_destroy_addr(struct ieee80211_sub_if_data *sdata, const u8 *addr)
|
2008-04-07 13:53:49 -06:00
|
|
|
{
|
2010-02-03 05:59:58 -07:00
|
|
|
struct sta_info *sta;
|
|
|
|
int ret;
|
2008-04-07 13:53:49 -06:00
|
|
|
|
2010-02-03 05:59:58 -07:00
|
|
|
mutex_lock(&sdata->local->sta_mtx);
|
2012-01-20 05:55:24 -07:00
|
|
|
sta = sta_info_get(sdata, addr);
|
2010-02-03 05:59:58 -07:00
|
|
|
ret = __sta_info_destroy(sta);
|
|
|
|
mutex_unlock(&sdata->local->sta_mtx);
|
2008-04-07 13:53:49 -06:00
|
|
|
|
|
|
|
return ret;
|
|
|
|
}
|
|
|
|
|
2010-02-03 05:59:58 -07:00
|
|
|
int sta_info_destroy_addr_bss(struct ieee80211_sub_if_data *sdata,
|
|
|
|
const u8 *addr)
|
2007-05-05 12:46:38 -06:00
|
|
|
{
|
2010-02-03 05:59:58 -07:00
|
|
|
struct sta_info *sta;
|
|
|
|
int ret;
|
2007-05-05 12:46:38 -06:00
|
|
|
|
2010-02-03 05:59:58 -07:00
|
|
|
mutex_lock(&sdata->local->sta_mtx);
|
2012-01-20 05:55:24 -07:00
|
|
|
sta = sta_info_get_bss(sdata, addr);
|
2010-02-03 05:59:58 -07:00
|
|
|
ret = __sta_info_destroy(sta);
|
|
|
|
mutex_unlock(&sdata->local->sta_mtx);
|
2008-02-25 08:27:46 -07:00
|
|
|
|
2010-02-03 05:59:58 -07:00
|
|
|
return ret;
|
|
|
|
}
|
2007-05-05 12:46:38 -06:00
|
|
|
|
2010-02-03 05:59:58 -07:00
|
|
|
static void sta_info_cleanup(unsigned long data)
|
|
|
|
{
|
|
|
|
struct ieee80211_local *local = (struct ieee80211_local *) data;
|
|
|
|
struct sta_info *sta;
|
2010-04-19 01:12:52 -06:00
|
|
|
bool timer_needed = false;
|
2010-02-03 05:59:58 -07:00
|
|
|
|
|
|
|
rcu_read_lock();
|
|
|
|
list_for_each_entry_rcu(sta, &local->sta_list, list)
|
2010-04-19 01:12:52 -06:00
|
|
|
if (sta_info_cleanup_expire_buffered(local, sta))
|
|
|
|
timer_needed = true;
|
2010-02-03 05:59:58 -07:00
|
|
|
rcu_read_unlock();
|
2007-05-05 12:46:38 -06:00
|
|
|
|
2010-02-03 05:59:58 -07:00
|
|
|
if (local->quiescing)
|
|
|
|
return;
|
2008-02-25 08:27:46 -07:00
|
|
|
|
2010-04-19 01:12:52 -06:00
|
|
|
if (!timer_needed)
|
|
|
|
return;
|
|
|
|
|
2011-04-01 05:52:48 -06:00
|
|
|
mod_timer(&local->sta_cleanup,
|
|
|
|
round_jiffies(jiffies + STA_INFO_CLEANUP_INTERVAL));
|
2007-05-05 12:46:38 -06:00
|
|
|
}
|
|
|
|
|
2015-02-13 13:55:15 -07:00
|
|
|
u32 sta_addr_hash(const void *key, u32 length, u32 seed)
|
2007-05-05 12:45:53 -06:00
|
|
|
{
|
2015-02-13 13:55:15 -07:00
|
|
|
return jhash(key, ETH_ALEN, seed);
|
|
|
|
}
|
|
|
|
|
|
|
|
int sta_info_init(struct ieee80211_local *local)
|
|
|
|
{
|
|
|
|
int err;
|
|
|
|
|
|
|
|
err = rhashtable_init(&local->sta_hash, &sta_rht_params);
|
|
|
|
if (err)
|
|
|
|
return err;
|
|
|
|
|
2011-12-15 03:24:20 -07:00
|
|
|
spin_lock_init(&local->tim_lock);
|
2010-02-03 05:59:58 -07:00
|
|
|
mutex_init(&local->sta_mtx);
|
2007-05-05 12:45:53 -06:00
|
|
|
INIT_LIST_HEAD(&local->sta_list);
|
|
|
|
|
2008-01-23 22:20:07 -07:00
|
|
|
setup_timer(&local->sta_cleanup, sta_info_cleanup,
|
|
|
|
(unsigned long)local);
|
2015-02-13 13:55:15 -07:00
|
|
|
return 0;
|
2007-05-05 12:45:53 -06:00
|
|
|
}
|
|
|
|
|
|
|
|
void sta_info_stop(struct ieee80211_local *local)
|
|
|
|
{
|
2012-12-13 15:08:52 -07:00
|
|
|
del_timer_sync(&local->sta_cleanup);
|
2015-02-13 13:55:15 -07:00
|
|
|
rhashtable_destroy(&local->sta_hash);
|
2007-05-05 12:45:53 -06:00
|
|
|
}
|
|
|
|
|
2012-12-13 15:49:02 -07:00
|
|
|
|
2013-12-04 15:18:37 -07:00
|
|
|
int __sta_info_flush(struct ieee80211_sub_if_data *sdata, bool vlans)
|
2007-05-05 12:45:53 -06:00
|
|
|
{
|
2012-12-13 15:07:46 -07:00
|
|
|
struct ieee80211_local *local = sdata->local;
|
2007-05-05 12:45:53 -06:00
|
|
|
struct sta_info *sta, *tmp;
|
2013-12-04 15:12:31 -07:00
|
|
|
LIST_HEAD(free_list);
|
2008-02-25 08:27:49 -07:00
|
|
|
int ret = 0;
|
2007-05-05 12:45:53 -06:00
|
|
|
|
2008-02-25 08:27:46 -07:00
|
|
|
might_sleep();
|
2007-07-27 07:43:23 -06:00
|
|
|
|
2013-12-04 15:18:37 -07:00
|
|
|
WARN_ON(vlans && sdata->vif.type != NL80211_IFTYPE_AP);
|
|
|
|
WARN_ON(vlans && !sdata->bss);
|
|
|
|
|
2010-02-03 05:59:58 -07:00
|
|
|
mutex_lock(&local->sta_mtx);
|
2008-02-25 08:27:46 -07:00
|
|
|
list_for_each_entry_safe(sta, tmp, &local->sta_list, list) {
|
2013-12-04 15:18:37 -07:00
|
|
|
if (sdata == sta->sdata ||
|
|
|
|
(vlans && sdata->bss == sta->sdata->bss)) {
|
2013-12-04 15:12:31 -07:00
|
|
|
if (!WARN_ON(__sta_info_destroy_part1(sta)))
|
|
|
|
list_add(&sta->free_list, &free_list);
|
2012-02-25 13:40:46 -07:00
|
|
|
ret++;
|
|
|
|
}
|
2007-07-27 07:43:23 -06:00
|
|
|
}
|
2013-12-04 15:12:31 -07:00
|
|
|
|
|
|
|
if (!list_empty(&free_list)) {
|
|
|
|
synchronize_net();
|
|
|
|
list_for_each_entry_safe(sta, tmp, &free_list, free_list)
|
|
|
|
__sta_info_destroy_part2(sta);
|
|
|
|
}
|
2010-02-03 05:59:58 -07:00
|
|
|
mutex_unlock(&local->sta_mtx);
|
2008-02-25 08:27:49 -07:00
|
|
|
|
2012-12-13 15:49:02 -07:00
|
|
|
return ret;
|
|
|
|
}
|
|
|
|
|
2008-09-10 16:01:46 -06:00
|
|
|
void ieee80211_sta_expire(struct ieee80211_sub_if_data *sdata,
|
|
|
|
unsigned long exp_time)
|
|
|
|
{
|
|
|
|
struct ieee80211_local *local = sdata->local;
|
|
|
|
struct sta_info *sta, *tmp;
|
|
|
|
|
2010-02-03 05:59:58 -07:00
|
|
|
mutex_lock(&local->sta_mtx);
|
2011-12-25 22:13:29 -07:00
|
|
|
|
|
|
|
list_for_each_entry_safe(sta, tmp, &local->sta_list, list) {
|
2011-12-20 08:16:52 -07:00
|
|
|
if (sdata != sta->sdata)
|
|
|
|
continue;
|
|
|
|
|
2008-09-10 16:01:46 -06:00
|
|
|
if (time_after(jiffies, sta->last_rx + exp_time)) {
|
2012-10-08 10:03:47 -06:00
|
|
|
sta_dbg(sta->sdata, "expiring inactive STA %pM\n",
|
|
|
|
sta->sta.addr);
|
2013-01-30 10:14:08 -07:00
|
|
|
|
|
|
|
if (ieee80211_vif_is_mesh(&sdata->vif) &&
|
|
|
|
test_sta_flag(sta, WLAN_STA_PS_STA))
|
|
|
|
atomic_dec(&sdata->u.mesh.ps.num_sta_ps);
|
|
|
|
|
2010-02-03 05:59:58 -07:00
|
|
|
WARN_ON(__sta_info_destroy(sta));
|
2008-09-10 16:01:46 -06:00
|
|
|
}
|
2011-12-25 22:13:29 -07:00
|
|
|
}
|
|
|
|
|
2010-02-03 05:59:58 -07:00
|
|
|
mutex_unlock(&local->sta_mtx);
|
2008-09-10 16:01:46 -06:00
|
|
|
}
|
2008-09-10 16:02:02 -06:00
|
|
|
|
2010-09-23 10:44:36 -06:00
|
|
|
struct ieee80211_sta *ieee80211_find_sta_by_ifaddr(struct ieee80211_hw *hw,
|
2015-02-13 13:55:15 -07:00
|
|
|
const u8 *addr,
|
|
|
|
const u8 *localaddr)
|
2008-09-10 16:02:02 -06:00
|
|
|
{
|
2015-02-13 13:55:15 -07:00
|
|
|
struct ieee80211_local *local = hw_to_local(hw);
|
|
|
|
struct sta_info *sta;
|
|
|
|
struct rhash_head *tmp;
|
|
|
|
const struct bucket_table *tbl;
|
|
|
|
|
|
|
|
tbl = rht_dereference_rcu(local->sta_hash.tbl, &local->sta_hash);
|
2008-09-10 16:02:02 -06:00
|
|
|
|
2010-09-23 10:44:36 -06:00
|
|
|
/*
|
|
|
|
* Just return a random station if localaddr is NULL
|
|
|
|
* ... first in list.
|
|
|
|
*/
|
2015-02-13 13:55:15 -07:00
|
|
|
for_each_sta_info(local, tbl, addr, sta, tmp) {
|
2010-09-23 10:44:36 -06:00
|
|
|
if (localaddr &&
|
mac80211: Convert compare_ether_addr to ether_addr_equal
Use the new bool function ether_addr_equal to add
some clarity and reduce the likelihood for misuse
of compare_ether_addr for sorting.
Done via cocci script:
$ cat compare_ether_addr.cocci
@@
expression a,b;
@@
- !compare_ether_addr(a, b)
+ ether_addr_equal(a, b)
@@
expression a,b;
@@
- compare_ether_addr(a, b)
+ !ether_addr_equal(a, b)
@@
expression a,b;
@@
- !ether_addr_equal(a, b) == 0
+ ether_addr_equal(a, b)
@@
expression a,b;
@@
- !ether_addr_equal(a, b) != 0
+ !ether_addr_equal(a, b)
@@
expression a,b;
@@
- ether_addr_equal(a, b) == 0
+ !ether_addr_equal(a, b)
@@
expression a,b;
@@
- ether_addr_equal(a, b) != 0
+ ether_addr_equal(a, b)
@@
expression a,b;
@@
- !!ether_addr_equal(a, b)
+ ether_addr_equal(a, b)
Signed-off-by: Joe Perches <joe@perches.com>
Signed-off-by: David S. Miller <davem@davemloft.net>
2012-05-08 12:56:52 -06:00
|
|
|
!ether_addr_equal(sta->sdata->vif.addr, localaddr))
|
2010-09-23 10:44:36 -06:00
|
|
|
continue;
|
2010-04-30 05:48:36 -06:00
|
|
|
if (!sta->uploaded)
|
|
|
|
return NULL;
|
2009-11-25 09:46:18 -07:00
|
|
|
return &sta->sta;
|
2010-04-30 05:48:36 -06:00
|
|
|
}
|
|
|
|
|
2009-11-25 09:46:18 -07:00
|
|
|
return NULL;
|
2008-09-10 16:02:02 -06:00
|
|
|
}
|
2010-09-23 10:44:36 -06:00
|
|
|
EXPORT_SYMBOL_GPL(ieee80211_find_sta_by_ifaddr);
|
2009-11-04 06:42:28 -07:00
|
|
|
|
|
|
|
struct ieee80211_sta *ieee80211_find_sta(struct ieee80211_vif *vif,
|
|
|
|
const u8 *addr)
|
|
|
|
{
|
2010-04-30 05:48:36 -06:00
|
|
|
struct sta_info *sta;
|
2009-11-04 06:42:28 -07:00
|
|
|
|
|
|
|
if (!vif)
|
|
|
|
return NULL;
|
|
|
|
|
2010-04-30 05:48:36 -06:00
|
|
|
sta = sta_info_get_bss(vif_to_sdata(vif), addr);
|
|
|
|
if (!sta)
|
|
|
|
return NULL;
|
|
|
|
|
|
|
|
if (!sta->uploaded)
|
|
|
|
return NULL;
|
2009-11-04 06:42:28 -07:00
|
|
|
|
2010-04-30 05:48:36 -06:00
|
|
|
return &sta->sta;
|
2009-11-04 06:42:28 -07:00
|
|
|
}
|
2008-09-10 16:02:02 -06:00
|
|
|
EXPORT_SYMBOL(ieee80211_find_sta);
|
mac80211: async station powersave handling
Some devices require that all frames to a station
are flushed when that station goes into powersave
mode before being able to send frames to that
station again when it wakes up or polls -- all in
order to avoid reordering and too many or too few
frames being sent to the station when it polls.
Normally, this is the case unless the station
goes to sleep and wakes up very quickly again.
But in that case, frames for it may be pending
on the hardware queues, and thus races could
happen in the case of multiple hardware queues
used for QoS/WMM. Normally this isn't a problem,
but with the iwlwifi mechanism we need to make
sure the race doesn't happen.
This makes mac80211 able to cope with the race
with driver help by a new WLAN_STA_PS_DRIVER
per-station flag that can be controlled by the
driver and tells mac80211 whether it can transmit
frames or not. This flag must be set according to
very specific rules outlined in the documentation
for the function that controls it.
When we buffer new frames for the station, we
normally set the TIM bit right away, but while
the driver has blocked transmission to that sta
we need to avoid that as well since we cannot
respond to the station if it wakes up due to the
TIM bit. Once the driver unblocks, we can set
the TIM bit.
Similarly, when the station just wakes up, we
need to wait until all other frames are flushed
before we can transmit frames to that station,
so the same applies here, we need to wait for
the driver to give the OK.
Signed-off-by: Johannes Berg <johannes@sipsolutions.net>
Signed-off-by: John W. Linville <linville@tuxdriver.com>
2009-11-06 03:35:50 -07:00
|
|
|
|
2014-02-20 03:19:58 -07:00
|
|
|
/* powersave support code */
|
|
|
|
void ieee80211_sta_ps_deliver_wakeup(struct sta_info *sta)
|
2010-11-16 12:50:28 -07:00
|
|
|
{
|
2012-01-30 07:18:00 -07:00
|
|
|
struct ieee80211_sub_if_data *sdata = sta->sdata;
|
2014-02-20 03:19:58 -07:00
|
|
|
struct ieee80211_local *local = sdata->local;
|
|
|
|
struct sk_buff_head pending;
|
2015-03-27 14:30:37 -06:00
|
|
|
int filtered = 0, buffered = 0, ac, i;
|
2014-02-20 03:19:58 -07:00
|
|
|
unsigned long flags;
|
2012-10-10 13:39:50 -06:00
|
|
|
struct ps_data *ps;
|
|
|
|
|
2014-07-25 08:20:23 -06:00
|
|
|
if (sdata->vif.type == NL80211_IFTYPE_AP_VLAN)
|
|
|
|
sdata = container_of(sdata->bss, struct ieee80211_sub_if_data,
|
|
|
|
u.ap);
|
|
|
|
|
|
|
|
if (sdata->vif.type == NL80211_IFTYPE_AP)
|
2012-10-10 13:39:50 -06:00
|
|
|
ps = &sdata->bss->ps;
|
2013-01-30 10:14:08 -07:00
|
|
|
else if (ieee80211_vif_is_mesh(&sdata->vif))
|
|
|
|
ps = &sdata->u.mesh.ps;
|
2012-10-10 13:39:50 -06:00
|
|
|
else
|
|
|
|
return;
|
2010-11-16 12:50:28 -07:00
|
|
|
|
2011-09-29 08:04:36 -06:00
|
|
|
clear_sta_flag(sta, WLAN_STA_SP);
|
2011-09-29 08:04:33 -06:00
|
|
|
|
2012-11-14 15:22:21 -07:00
|
|
|
BUILD_BUG_ON(BITS_TO_LONGS(IEEE80211_NUM_TIDS) > 1);
|
2011-09-29 08:04:29 -06:00
|
|
|
sta->driver_buffered_tids = 0;
|
2015-03-27 14:30:37 -06:00
|
|
|
sta->txq_buffered_tids = 0;
|
mac80211: async station powersave handling
Some devices require that all frames to a station
are flushed when that station goes into powersave
mode before being able to send frames to that
station again when it wakes up or polls -- all in
order to avoid reordering and too many or too few
frames being sent to the station when it polls.
Normally, this is the case unless the station
goes to sleep and wakes up very quickly again.
But in that case, frames for it may be pending
on the hardware queues, and thus races could
happen in the case of multiple hardware queues
used for QoS/WMM. Normally this isn't a problem,
but with the iwlwifi mechanism we need to make
sure the race doesn't happen.
This makes mac80211 able to cope with the race
with driver help by a new WLAN_STA_PS_DRIVER
per-station flag that can be controlled by the
driver and tells mac80211 whether it can transmit
frames or not. This flag must be set according to
very specific rules outlined in the documentation
for the function that controls it.
When we buffer new frames for the station, we
normally set the TIM bit right away, but while
the driver has blocked transmission to that sta
we need to avoid that as well since we cannot
respond to the station if it wakes up due to the
TIM bit. Once the driver unblocks, we can set
the TIM bit.
Similarly, when the station just wakes up, we
need to wait until all other frames are flushed
before we can transmit frames to that station,
so the same applies here, we need to wait for
the driver to give the OK.
Signed-off-by: Johannes Berg <johannes@sipsolutions.net>
Signed-off-by: John W. Linville <linville@tuxdriver.com>
2009-11-06 03:35:50 -07:00
|
|
|
|
2015-06-02 13:39:54 -06:00
|
|
|
if (!ieee80211_hw_check(&local->hw, AP_LINK_PS))
|
2011-01-31 13:29:13 -07:00
|
|
|
drv_sta_notify(local, sdata, STA_NOTIFY_AWAKE, &sta->sta);
|
mac80211: async station powersave handling
Some devices require that all frames to a station
are flushed when that station goes into powersave
mode before being able to send frames to that
station again when it wakes up or polls -- all in
order to avoid reordering and too many or too few
frames being sent to the station when it polls.
Normally, this is the case unless the station
goes to sleep and wakes up very quickly again.
But in that case, frames for it may be pending
on the hardware queues, and thus races could
happen in the case of multiple hardware queues
used for QoS/WMM. Normally this isn't a problem,
but with the iwlwifi mechanism we need to make
sure the race doesn't happen.
This makes mac80211 able to cope with the race
with driver help by a new WLAN_STA_PS_DRIVER
per-station flag that can be controlled by the
driver and tells mac80211 whether it can transmit
frames or not. This flag must be set according to
very specific rules outlined in the documentation
for the function that controls it.
When we buffer new frames for the station, we
normally set the TIM bit right away, but while
the driver has blocked transmission to that sta
we need to avoid that as well since we cannot
respond to the station if it wakes up due to the
TIM bit. Once the driver unblocks, we can set
the TIM bit.
Similarly, when the station just wakes up, we
need to wait until all other frames are flushed
before we can transmit frames to that station,
so the same applies here, we need to wait for
the driver to give the OK.
Signed-off-by: Johannes Berg <johannes@sipsolutions.net>
Signed-off-by: John W. Linville <linville@tuxdriver.com>
2009-11-06 03:35:50 -07:00
|
|
|
|
2015-03-27 14:30:37 -06:00
|
|
|
if (sta->sta.txq[0]) {
|
|
|
|
for (i = 0; i < ARRAY_SIZE(sta->sta.txq); i++) {
|
|
|
|
struct txq_info *txqi = to_txq_info(sta->sta.txq[i]);
|
|
|
|
|
|
|
|
if (!skb_queue_len(&txqi->queue))
|
|
|
|
continue;
|
|
|
|
|
|
|
|
drv_wake_tx_queue(local, txqi);
|
|
|
|
}
|
|
|
|
}
|
|
|
|
|
2011-09-29 08:04:29 -06:00
|
|
|
skb_queue_head_init(&pending);
|
mac80211: async station powersave handling
Some devices require that all frames to a station
are flushed when that station goes into powersave
mode before being able to send frames to that
station again when it wakes up or polls -- all in
order to avoid reordering and too many or too few
frames being sent to the station when it polls.
Normally, this is the case unless the station
goes to sleep and wakes up very quickly again.
But in that case, frames for it may be pending
on the hardware queues, and thus races could
happen in the case of multiple hardware queues
used for QoS/WMM. Normally this isn't a problem,
but with the iwlwifi mechanism we need to make
sure the race doesn't happen.
This makes mac80211 able to cope with the race
with driver help by a new WLAN_STA_PS_DRIVER
per-station flag that can be controlled by the
driver and tells mac80211 whether it can transmit
frames or not. This flag must be set according to
very specific rules outlined in the documentation
for the function that controls it.
When we buffer new frames for the station, we
normally set the TIM bit right away, but while
the driver has blocked transmission to that sta
we need to avoid that as well since we cannot
respond to the station if it wakes up due to the
TIM bit. Once the driver unblocks, we can set
the TIM bit.
Similarly, when the station just wakes up, we
need to wait until all other frames are flushed
before we can transmit frames to that station,
so the same applies here, we need to wait for
the driver to give the OK.
Signed-off-by: Johannes Berg <johannes@sipsolutions.net>
Signed-off-by: John W. Linville <linville@tuxdriver.com>
2009-11-06 03:35:50 -07:00
|
|
|
|
mac80211: fix AP powersave TX vs. wakeup race
There is a race between the TX path and the STA wakeup: while
a station is sleeping, mac80211 buffers frames until it wakes
up, then the frames are transmitted. However, the RX and TX
path are concurrent, so the packet indicating wakeup can be
processed while a packet is being transmitted.
This can lead to a situation where the buffered frames list
is emptied on the one side, while a frame is being added on
the other side, as the station is still seen as sleeping in
the TX path.
As a result, the newly added frame will not be send anytime
soon. It might be sent much later (and out of order) when the
station goes to sleep and wakes up the next time.
Additionally, it can lead to the crash below.
Fix all this by synchronising both paths with a new lock.
Both path are not fastpath since they handle PS situations.
In a later patch we'll remove the extra skb queue locks to
reduce locking overhead.
BUG: unable to handle kernel
NULL pointer dereference at 000000b0
IP: [<ff6f1791>] ieee80211_report_used_skb+0x11/0x3e0 [mac80211]
*pde = 00000000
Oops: 0000 [#1] SMP DEBUG_PAGEALLOC
EIP: 0060:[<ff6f1791>] EFLAGS: 00210282 CPU: 1
EIP is at ieee80211_report_used_skb+0x11/0x3e0 [mac80211]
EAX: e5900da0 EBX: 00000000 ECX: 00000001 EDX: 00000000
ESI: e41d00c0 EDI: e5900da0 EBP: ebe458e4 ESP: ebe458b0
DS: 007b ES: 007b FS: 00d8 GS: 00e0 SS: 0068
CR0: 8005003b CR2: 000000b0 CR3: 25a78000 CR4: 000407d0
DR0: 00000000 DR1: 00000000 DR2: 00000000 DR3: 00000000
DR6: ffff0ff0 DR7: 00000400
Process iperf (pid: 3934, ti=ebe44000 task=e757c0b0 task.ti=ebe44000)
iwlwifi 0000:02:00.0: I iwl_pcie_enqueue_hcmd Sending command LQ_CMD (#4e), seq: 0x0903, 92 bytes at 3[3]:9
Stack:
e403b32c ebe458c4 00200002 00200286 e403b338 ebe458cc c10960bb e5900da0
ff76a6ec ebe458d8 00000000 e41d00c0 e5900da0 ebe458f0 ff6f1b75 e403b210
ebe4598c ff723dc1 00000000 ff76a6ec e597c978 e403b758 00000002 00000002
Call Trace:
[<ff6f1b75>] ieee80211_free_txskb+0x15/0x20 [mac80211]
[<ff723dc1>] invoke_tx_handlers+0x1661/0x1780 [mac80211]
[<ff7248a5>] ieee80211_tx+0x75/0x100 [mac80211]
[<ff7249bf>] ieee80211_xmit+0x8f/0xc0 [mac80211]
[<ff72550e>] ieee80211_subif_start_xmit+0x4fe/0xe20 [mac80211]
[<c149ef70>] dev_hard_start_xmit+0x450/0x950
[<c14b9aa9>] sch_direct_xmit+0xa9/0x250
[<c14b9c9b>] __qdisc_run+0x4b/0x150
[<c149f732>] dev_queue_xmit+0x2c2/0xca0
Cc: stable@vger.kernel.org
Reported-by: Yaara Rozenblum <yaara.rozenblum@intel.com>
Signed-off-by: Emmanuel Grumbach <emmanuel.grumbach@intel.com>
Reviewed-by: Stanislaw Gruszka <sgruszka@redhat.com>
[reword commit log, use a separate lock]
Signed-off-by: Johannes Berg <johannes.berg@intel.com>
2014-02-20 00:22:11 -07:00
|
|
|
/* sync with ieee80211_tx_h_unicast_ps_buf */
|
|
|
|
spin_lock(&sta->ps_lock);
|
mac80211: async station powersave handling
Some devices require that all frames to a station
are flushed when that station goes into powersave
mode before being able to send frames to that
station again when it wakes up or polls -- all in
order to avoid reordering and too many or too few
frames being sent to the station when it polls.
Normally, this is the case unless the station
goes to sleep and wakes up very quickly again.
But in that case, frames for it may be pending
on the hardware queues, and thus races could
happen in the case of multiple hardware queues
used for QoS/WMM. Normally this isn't a problem,
but with the iwlwifi mechanism we need to make
sure the race doesn't happen.
This makes mac80211 able to cope with the race
with driver help by a new WLAN_STA_PS_DRIVER
per-station flag that can be controlled by the
driver and tells mac80211 whether it can transmit
frames or not. This flag must be set according to
very specific rules outlined in the documentation
for the function that controls it.
When we buffer new frames for the station, we
normally set the TIM bit right away, but while
the driver has blocked transmission to that sta
we need to avoid that as well since we cannot
respond to the station if it wakes up due to the
TIM bit. Once the driver unblocks, we can set
the TIM bit.
Similarly, when the station just wakes up, we
need to wait until all other frames are flushed
before we can transmit frames to that station,
so the same applies here, we need to wait for
the driver to give the OK.
Signed-off-by: Johannes Berg <johannes@sipsolutions.net>
Signed-off-by: John W. Linville <linville@tuxdriver.com>
2009-11-06 03:35:50 -07:00
|
|
|
/* Send all buffered frames to the station */
|
2011-09-29 08:04:29 -06:00
|
|
|
for (ac = 0; ac < IEEE80211_NUM_ACS; ac++) {
|
|
|
|
int count = skb_queue_len(&pending), tmp;
|
|
|
|
|
2012-11-05 01:27:52 -07:00
|
|
|
spin_lock_irqsave(&sta->tx_filtered[ac].lock, flags);
|
2011-09-29 08:04:29 -06:00
|
|
|
skb_queue_splice_tail_init(&sta->tx_filtered[ac], &pending);
|
2012-11-05 01:27:52 -07:00
|
|
|
spin_unlock_irqrestore(&sta->tx_filtered[ac].lock, flags);
|
2011-09-29 08:04:29 -06:00
|
|
|
tmp = skb_queue_len(&pending);
|
|
|
|
filtered += tmp - count;
|
|
|
|
count = tmp;
|
|
|
|
|
2012-11-05 01:27:52 -07:00
|
|
|
spin_lock_irqsave(&sta->ps_tx_buf[ac].lock, flags);
|
2011-09-29 08:04:29 -06:00
|
|
|
skb_queue_splice_tail_init(&sta->ps_tx_buf[ac], &pending);
|
2012-11-05 01:27:52 -07:00
|
|
|
spin_unlock_irqrestore(&sta->ps_tx_buf[ac].lock, flags);
|
2011-09-29 08:04:29 -06:00
|
|
|
tmp = skb_queue_len(&pending);
|
|
|
|
buffered += tmp - count;
|
|
|
|
}
|
|
|
|
|
2014-02-20 03:19:58 -07:00
|
|
|
ieee80211_add_pending_skbs(local, &pending);
|
mac80211: fix station/driver powersave race
It is currently possible to have a race due to the station PS
unblock work like this:
* station goes to sleep with frames buffered in the driver
* driver blocks wakeup
* station wakes up again
* driver flushes/returns frames, and unblocks, which schedules
the unblock work
* unblock work starts to run, and checks that the station is
awake (i.e. that the WLAN_STA_PS_STA flag isn't set)
* we process a received frame with PM=1, setting the flag again
* ieee80211_sta_ps_deliver_wakeup() runs, delivering all frames
to the driver, and then clearing the WLAN_STA_PS_DRIVER and
WLAN_STA_PS_STA flags
In this scenario, mac80211 will think that the station is awake,
while it really is asleep, and any TX'ed frames should be filtered
by the device (it will know that the station is sleeping) but then
passed to mac80211 again, which will not buffer it either as it
thinks the station is awake, and eventually the packets will be
dropped.
Fix this by moving the clearing of the flags to exactly where we
learn about the situation. This creates a problem of reordering,
so introduce another flag indicating that delivery is being done,
this new flag also queues frames and is cleared only while the
spinlock is held (which the queuing code also holds) so that any
concurrent delivery/TX is handled correctly.
Reported-by: Andrei Otcheretianski <andrei.otcheretianski@intel.com>
Signed-off-by: Johannes Berg <johannes.berg@intel.com>
2014-05-27 08:32:27 -06:00
|
|
|
|
|
|
|
/* now we're no longer in the deliver code */
|
|
|
|
clear_sta_flag(sta, WLAN_STA_PS_DELIVER);
|
|
|
|
|
|
|
|
/* The station might have polled and then woken up before we responded,
|
|
|
|
* so clear these flags now to avoid them sticking around.
|
|
|
|
*/
|
|
|
|
clear_sta_flag(sta, WLAN_STA_PSPOLL);
|
|
|
|
clear_sta_flag(sta, WLAN_STA_UAPSD);
|
mac80211: fix AP powersave TX vs. wakeup race
There is a race between the TX path and the STA wakeup: while
a station is sleeping, mac80211 buffers frames until it wakes
up, then the frames are transmitted. However, the RX and TX
path are concurrent, so the packet indicating wakeup can be
processed while a packet is being transmitted.
This can lead to a situation where the buffered frames list
is emptied on the one side, while a frame is being added on
the other side, as the station is still seen as sleeping in
the TX path.
As a result, the newly added frame will not be send anytime
soon. It might be sent much later (and out of order) when the
station goes to sleep and wakes up the next time.
Additionally, it can lead to the crash below.
Fix all this by synchronising both paths with a new lock.
Both path are not fastpath since they handle PS situations.
In a later patch we'll remove the extra skb queue locks to
reduce locking overhead.
BUG: unable to handle kernel
NULL pointer dereference at 000000b0
IP: [<ff6f1791>] ieee80211_report_used_skb+0x11/0x3e0 [mac80211]
*pde = 00000000
Oops: 0000 [#1] SMP DEBUG_PAGEALLOC
EIP: 0060:[<ff6f1791>] EFLAGS: 00210282 CPU: 1
EIP is at ieee80211_report_used_skb+0x11/0x3e0 [mac80211]
EAX: e5900da0 EBX: 00000000 ECX: 00000001 EDX: 00000000
ESI: e41d00c0 EDI: e5900da0 EBP: ebe458e4 ESP: ebe458b0
DS: 007b ES: 007b FS: 00d8 GS: 00e0 SS: 0068
CR0: 8005003b CR2: 000000b0 CR3: 25a78000 CR4: 000407d0
DR0: 00000000 DR1: 00000000 DR2: 00000000 DR3: 00000000
DR6: ffff0ff0 DR7: 00000400
Process iperf (pid: 3934, ti=ebe44000 task=e757c0b0 task.ti=ebe44000)
iwlwifi 0000:02:00.0: I iwl_pcie_enqueue_hcmd Sending command LQ_CMD (#4e), seq: 0x0903, 92 bytes at 3[3]:9
Stack:
e403b32c ebe458c4 00200002 00200286 e403b338 ebe458cc c10960bb e5900da0
ff76a6ec ebe458d8 00000000 e41d00c0 e5900da0 ebe458f0 ff6f1b75 e403b210
ebe4598c ff723dc1 00000000 ff76a6ec e597c978 e403b758 00000002 00000002
Call Trace:
[<ff6f1b75>] ieee80211_free_txskb+0x15/0x20 [mac80211]
[<ff723dc1>] invoke_tx_handlers+0x1661/0x1780 [mac80211]
[<ff7248a5>] ieee80211_tx+0x75/0x100 [mac80211]
[<ff7249bf>] ieee80211_xmit+0x8f/0xc0 [mac80211]
[<ff72550e>] ieee80211_subif_start_xmit+0x4fe/0xe20 [mac80211]
[<c149ef70>] dev_hard_start_xmit+0x450/0x950
[<c14b9aa9>] sch_direct_xmit+0xa9/0x250
[<c14b9c9b>] __qdisc_run+0x4b/0x150
[<c149f732>] dev_queue_xmit+0x2c2/0xca0
Cc: stable@vger.kernel.org
Reported-by: Yaara Rozenblum <yaara.rozenblum@intel.com>
Signed-off-by: Emmanuel Grumbach <emmanuel.grumbach@intel.com>
Reviewed-by: Stanislaw Gruszka <sgruszka@redhat.com>
[reword commit log, use a separate lock]
Signed-off-by: Johannes Berg <johannes.berg@intel.com>
2014-02-20 00:22:11 -07:00
|
|
|
spin_unlock(&sta->ps_lock);
|
2011-09-29 08:04:29 -06:00
|
|
|
|
2014-02-20 03:19:58 -07:00
|
|
|
atomic_dec(&ps->num_sta_ps);
|
|
|
|
|
2013-10-01 07:45:43 -06:00
|
|
|
/* This station just woke up and isn't aware of our SMPS state */
|
2014-04-22 04:19:25 -06:00
|
|
|
if (!ieee80211_vif_is_mesh(&sdata->vif) &&
|
|
|
|
!ieee80211_smps_is_restrictive(sta->known_smps_mode,
|
2013-10-01 07:45:43 -06:00
|
|
|
sdata->smps_mode) &&
|
|
|
|
sta->known_smps_mode != sdata->bss->req_smps &&
|
|
|
|
sta_info_tx_streams(sta) != 1) {
|
|
|
|
ht_dbg(sdata,
|
|
|
|
"%pM just woke up and MIMO capable - update SMPS\n",
|
|
|
|
sta->sta.addr);
|
|
|
|
ieee80211_send_smps_action(sdata, sdata->bss->req_smps,
|
|
|
|
sta->sta.addr,
|
|
|
|
sdata->vif.bss_conf.bssid);
|
|
|
|
}
|
|
|
|
|
mac80211: async station powersave handling
Some devices require that all frames to a station
are flushed when that station goes into powersave
mode before being able to send frames to that
station again when it wakes up or polls -- all in
order to avoid reordering and too many or too few
frames being sent to the station when it polls.
Normally, this is the case unless the station
goes to sleep and wakes up very quickly again.
But in that case, frames for it may be pending
on the hardware queues, and thus races could
happen in the case of multiple hardware queues
used for QoS/WMM. Normally this isn't a problem,
but with the iwlwifi mechanism we need to make
sure the race doesn't happen.
This makes mac80211 able to cope with the race
with driver help by a new WLAN_STA_PS_DRIVER
per-station flag that can be controlled by the
driver and tells mac80211 whether it can transmit
frames or not. This flag must be set according to
very specific rules outlined in the documentation
for the function that controls it.
When we buffer new frames for the station, we
normally set the TIM bit right away, but while
the driver has blocked transmission to that sta
we need to avoid that as well since we cannot
respond to the station if it wakes up due to the
TIM bit. Once the driver unblocks, we can set
the TIM bit.
Similarly, when the station just wakes up, we
need to wait until all other frames are flushed
before we can transmit frames to that station,
so the same applies here, we need to wait for
the driver to give the OK.
Signed-off-by: Johannes Berg <johannes@sipsolutions.net>
Signed-off-by: John W. Linville <linville@tuxdriver.com>
2009-11-06 03:35:50 -07:00
|
|
|
local->total_ps_buffered -= buffered;
|
|
|
|
|
2011-09-29 08:04:27 -06:00
|
|
|
sta_info_recalc_tim(sta);
|
|
|
|
|
2012-06-22 03:29:50 -06:00
|
|
|
ps_dbg(sdata,
|
|
|
|
"STA %pM aid %d sending %d filtered/%d PS frames since STA not sleeping anymore\n",
|
|
|
|
sta->sta.addr, sta->sta.aid, filtered, buffered);
|
2015-03-21 08:25:43 -06:00
|
|
|
|
|
|
|
ieee80211_check_fast_xmit(sta);
|
mac80211: async station powersave handling
Some devices require that all frames to a station
are flushed when that station goes into powersave
mode before being able to send frames to that
station again when it wakes up or polls -- all in
order to avoid reordering and too many or too few
frames being sent to the station when it polls.
Normally, this is the case unless the station
goes to sleep and wakes up very quickly again.
But in that case, frames for it may be pending
on the hardware queues, and thus races could
happen in the case of multiple hardware queues
used for QoS/WMM. Normally this isn't a problem,
but with the iwlwifi mechanism we need to make
sure the race doesn't happen.
This makes mac80211 able to cope with the race
with driver help by a new WLAN_STA_PS_DRIVER
per-station flag that can be controlled by the
driver and tells mac80211 whether it can transmit
frames or not. This flag must be set according to
very specific rules outlined in the documentation
for the function that controls it.
When we buffer new frames for the station, we
normally set the TIM bit right away, but while
the driver has blocked transmission to that sta
we need to avoid that as well since we cannot
respond to the station if it wakes up due to the
TIM bit. Once the driver unblocks, we can set
the TIM bit.
Similarly, when the station just wakes up, we
need to wait until all other frames are flushed
before we can transmit frames to that station,
so the same applies here, we need to wait for
the driver to give the OK.
Signed-off-by: Johannes Berg <johannes@sipsolutions.net>
Signed-off-by: John W. Linville <linville@tuxdriver.com>
2009-11-06 03:35:50 -07:00
|
|
|
}
|
|
|
|
|
2011-09-29 08:04:34 -06:00
|
|
|
static void ieee80211_send_null_response(struct ieee80211_sub_if_data *sdata,
|
|
|
|
struct sta_info *sta, int tid,
|
2014-01-08 16:00:38 -07:00
|
|
|
enum ieee80211_frame_release_type reason,
|
|
|
|
bool call_driver)
|
mac80211: async station powersave handling
Some devices require that all frames to a station
are flushed when that station goes into powersave
mode before being able to send frames to that
station again when it wakes up or polls -- all in
order to avoid reordering and too many or too few
frames being sent to the station when it polls.
Normally, this is the case unless the station
goes to sleep and wakes up very quickly again.
But in that case, frames for it may be pending
on the hardware queues, and thus races could
happen in the case of multiple hardware queues
used for QoS/WMM. Normally this isn't a problem,
but with the iwlwifi mechanism we need to make
sure the race doesn't happen.
This makes mac80211 able to cope with the race
with driver help by a new WLAN_STA_PS_DRIVER
per-station flag that can be controlled by the
driver and tells mac80211 whether it can transmit
frames or not. This flag must be set according to
very specific rules outlined in the documentation
for the function that controls it.
When we buffer new frames for the station, we
normally set the TIM bit right away, but while
the driver has blocked transmission to that sta
we need to avoid that as well since we cannot
respond to the station if it wakes up due to the
TIM bit. Once the driver unblocks, we can set
the TIM bit.
Similarly, when the station just wakes up, we
need to wait until all other frames are flushed
before we can transmit frames to that station,
so the same applies here, we need to wait for
the driver to give the OK.
Signed-off-by: Johannes Berg <johannes@sipsolutions.net>
Signed-off-by: John W. Linville <linville@tuxdriver.com>
2009-11-06 03:35:50 -07:00
|
|
|
{
|
|
|
|
struct ieee80211_local *local = sdata->local;
|
2011-09-29 08:04:34 -06:00
|
|
|
struct ieee80211_qos_hdr *nullfunc;
|
mac80211: async station powersave handling
Some devices require that all frames to a station
are flushed when that station goes into powersave
mode before being able to send frames to that
station again when it wakes up or polls -- all in
order to avoid reordering and too many or too few
frames being sent to the station when it polls.
Normally, this is the case unless the station
goes to sleep and wakes up very quickly again.
But in that case, frames for it may be pending
on the hardware queues, and thus races could
happen in the case of multiple hardware queues
used for QoS/WMM. Normally this isn't a problem,
but with the iwlwifi mechanism we need to make
sure the race doesn't happen.
This makes mac80211 able to cope with the race
with driver help by a new WLAN_STA_PS_DRIVER
per-station flag that can be controlled by the
driver and tells mac80211 whether it can transmit
frames or not. This flag must be set according to
very specific rules outlined in the documentation
for the function that controls it.
When we buffer new frames for the station, we
normally set the TIM bit right away, but while
the driver has blocked transmission to that sta
we need to avoid that as well since we cannot
respond to the station if it wakes up due to the
TIM bit. Once the driver unblocks, we can set
the TIM bit.
Similarly, when the station just wakes up, we
need to wait until all other frames are flushed
before we can transmit frames to that station,
so the same applies here, we need to wait for
the driver to give the OK.
Signed-off-by: Johannes Berg <johannes@sipsolutions.net>
Signed-off-by: John W. Linville <linville@tuxdriver.com>
2009-11-06 03:35:50 -07:00
|
|
|
struct sk_buff *skb;
|
2011-09-29 08:04:34 -06:00
|
|
|
int size = sizeof(*nullfunc);
|
|
|
|
__le16 fc;
|
2014-07-22 06:50:47 -06:00
|
|
|
bool qos = sta->sta.wme;
|
2011-09-29 08:04:34 -06:00
|
|
|
struct ieee80211_tx_info *info;
|
2012-07-26 09:24:39 -06:00
|
|
|
struct ieee80211_chanctx_conf *chanctx_conf;
|
mac80211: async station powersave handling
Some devices require that all frames to a station
are flushed when that station goes into powersave
mode before being able to send frames to that
station again when it wakes up or polls -- all in
order to avoid reordering and too many or too few
frames being sent to the station when it polls.
Normally, this is the case unless the station
goes to sleep and wakes up very quickly again.
But in that case, frames for it may be pending
on the hardware queues, and thus races could
happen in the case of multiple hardware queues
used for QoS/WMM. Normally this isn't a problem,
but with the iwlwifi mechanism we need to make
sure the race doesn't happen.
This makes mac80211 able to cope with the race
with driver help by a new WLAN_STA_PS_DRIVER
per-station flag that can be controlled by the
driver and tells mac80211 whether it can transmit
frames or not. This flag must be set according to
very specific rules outlined in the documentation
for the function that controls it.
When we buffer new frames for the station, we
normally set the TIM bit right away, but while
the driver has blocked transmission to that sta
we need to avoid that as well since we cannot
respond to the station if it wakes up due to the
TIM bit. Once the driver unblocks, we can set
the TIM bit.
Similarly, when the station just wakes up, we
need to wait until all other frames are flushed
before we can transmit frames to that station,
so the same applies here, we need to wait for
the driver to give the OK.
Signed-off-by: Johannes Berg <johannes@sipsolutions.net>
Signed-off-by: John W. Linville <linville@tuxdriver.com>
2009-11-06 03:35:50 -07:00
|
|
|
|
2011-09-29 08:04:34 -06:00
|
|
|
if (qos) {
|
|
|
|
fc = cpu_to_le16(IEEE80211_FTYPE_DATA |
|
|
|
|
IEEE80211_STYPE_QOS_NULLFUNC |
|
|
|
|
IEEE80211_FCTL_FROMDS);
|
|
|
|
} else {
|
|
|
|
size -= 2;
|
|
|
|
fc = cpu_to_le16(IEEE80211_FTYPE_DATA |
|
|
|
|
IEEE80211_STYPE_NULLFUNC |
|
|
|
|
IEEE80211_FCTL_FROMDS);
|
mac80211: async station powersave handling
Some devices require that all frames to a station
are flushed when that station goes into powersave
mode before being able to send frames to that
station again when it wakes up or polls -- all in
order to avoid reordering and too many or too few
frames being sent to the station when it polls.
Normally, this is the case unless the station
goes to sleep and wakes up very quickly again.
But in that case, frames for it may be pending
on the hardware queues, and thus races could
happen in the case of multiple hardware queues
used for QoS/WMM. Normally this isn't a problem,
but with the iwlwifi mechanism we need to make
sure the race doesn't happen.
This makes mac80211 able to cope with the race
with driver help by a new WLAN_STA_PS_DRIVER
per-station flag that can be controlled by the
driver and tells mac80211 whether it can transmit
frames or not. This flag must be set according to
very specific rules outlined in the documentation
for the function that controls it.
When we buffer new frames for the station, we
normally set the TIM bit right away, but while
the driver has blocked transmission to that sta
we need to avoid that as well since we cannot
respond to the station if it wakes up due to the
TIM bit. Once the driver unblocks, we can set
the TIM bit.
Similarly, when the station just wakes up, we
need to wait until all other frames are flushed
before we can transmit frames to that station,
so the same applies here, we need to wait for
the driver to give the OK.
Signed-off-by: Johannes Berg <johannes@sipsolutions.net>
Signed-off-by: John W. Linville <linville@tuxdriver.com>
2009-11-06 03:35:50 -07:00
|
|
|
}
|
|
|
|
|
2011-09-29 08:04:34 -06:00
|
|
|
skb = dev_alloc_skb(local->hw.extra_tx_headroom + size);
|
|
|
|
if (!skb)
|
|
|
|
return;
|
|
|
|
|
|
|
|
skb_reserve(skb, local->hw.extra_tx_headroom);
|
|
|
|
|
|
|
|
nullfunc = (void *) skb_put(skb, size);
|
|
|
|
nullfunc->frame_control = fc;
|
|
|
|
nullfunc->duration_id = 0;
|
|
|
|
memcpy(nullfunc->addr1, sta->sta.addr, ETH_ALEN);
|
|
|
|
memcpy(nullfunc->addr2, sdata->vif.addr, ETH_ALEN);
|
|
|
|
memcpy(nullfunc->addr3, sdata->vif.addr, ETH_ALEN);
|
2014-03-04 05:46:53 -07:00
|
|
|
nullfunc->seq_ctrl = 0;
|
2011-09-29 08:04:34 -06:00
|
|
|
|
2011-10-13 05:19:19 -06:00
|
|
|
skb->priority = tid;
|
|
|
|
skb_set_queue_mapping(skb, ieee802_1d_to_ac[tid]);
|
2011-09-29 08:04:34 -06:00
|
|
|
if (qos) {
|
|
|
|
nullfunc->qos_ctrl = cpu_to_le16(tid);
|
|
|
|
|
2011-09-29 08:04:38 -06:00
|
|
|
if (reason == IEEE80211_FRAME_RELEASE_UAPSD)
|
2011-09-29 08:04:34 -06:00
|
|
|
nullfunc->qos_ctrl |=
|
|
|
|
cpu_to_le16(IEEE80211_QOS_CTL_EOSP);
|
|
|
|
}
|
|
|
|
|
|
|
|
info = IEEE80211_SKB_CB(skb);
|
|
|
|
|
|
|
|
/*
|
|
|
|
* Tell TX path to send this frame even though the
|
|
|
|
* STA may still remain is PS mode after this frame
|
2011-09-29 08:04:35 -06:00
|
|
|
* exchange. Also set EOSP to indicate this packet
|
|
|
|
* ends the poll/service period.
|
2011-09-29 08:04:34 -06:00
|
|
|
*/
|
2012-02-27 04:18:30 -07:00
|
|
|
info->flags |= IEEE80211_TX_CTL_NO_PS_BUFFER |
|
2011-09-29 08:04:35 -06:00
|
|
|
IEEE80211_TX_STATUS_EOSP |
|
|
|
|
IEEE80211_TX_CTL_REQ_TX_STATUS;
|
2011-09-29 08:04:34 -06:00
|
|
|
|
2014-12-10 08:56:10 -07:00
|
|
|
info->control.flags |= IEEE80211_TX_CTRL_PS_RESPONSE;
|
|
|
|
|
2014-01-08 16:00:38 -07:00
|
|
|
if (call_driver)
|
|
|
|
drv_allow_buffered_frames(local, sta, BIT(tid), 1,
|
|
|
|
reason, false);
|
2011-09-29 08:04:38 -06:00
|
|
|
|
2013-02-13 07:39:57 -07:00
|
|
|
skb->dev = sdata->dev;
|
|
|
|
|
2012-07-26 09:24:39 -06:00
|
|
|
rcu_read_lock();
|
|
|
|
chanctx_conf = rcu_dereference(sdata->vif.chanctx_conf);
|
|
|
|
if (WARN_ON(!chanctx_conf)) {
|
|
|
|
rcu_read_unlock();
|
|
|
|
kfree_skb(skb);
|
|
|
|
return;
|
|
|
|
}
|
|
|
|
|
2014-11-09 09:50:09 -07:00
|
|
|
info->band = chanctx_conf->def.chan->band;
|
2015-03-20 07:18:27 -06:00
|
|
|
ieee80211_xmit(sdata, sta, skb);
|
2012-07-26 09:24:39 -06:00
|
|
|
rcu_read_unlock();
|
2011-09-29 08:04:34 -06:00
|
|
|
}
|
|
|
|
|
2014-01-09 03:05:31 -07:00
|
|
|
static int find_highest_prio_tid(unsigned long tids)
|
|
|
|
{
|
|
|
|
/* lower 3 TIDs aren't ordered perfectly */
|
|
|
|
if (tids & 0xF8)
|
|
|
|
return fls(tids) - 1;
|
|
|
|
/* TID 0 is BE just like TID 3 */
|
|
|
|
if (tids & BIT(0))
|
|
|
|
return 0;
|
|
|
|
return fls(tids) - 1;
|
|
|
|
}
|
|
|
|
|
2011-09-29 08:04:33 -06:00
|
|
|
static void
|
|
|
|
ieee80211_sta_ps_deliver_response(struct sta_info *sta,
|
|
|
|
int n_frames, u8 ignored_acs,
|
|
|
|
enum ieee80211_frame_release_type reason)
|
mac80211: async station powersave handling
Some devices require that all frames to a station
are flushed when that station goes into powersave
mode before being able to send frames to that
station again when it wakes up or polls -- all in
order to avoid reordering and too many or too few
frames being sent to the station when it polls.
Normally, this is the case unless the station
goes to sleep and wakes up very quickly again.
But in that case, frames for it may be pending
on the hardware queues, and thus races could
happen in the case of multiple hardware queues
used for QoS/WMM. Normally this isn't a problem,
but with the iwlwifi mechanism we need to make
sure the race doesn't happen.
This makes mac80211 able to cope with the race
with driver help by a new WLAN_STA_PS_DRIVER
per-station flag that can be controlled by the
driver and tells mac80211 whether it can transmit
frames or not. This flag must be set according to
very specific rules outlined in the documentation
for the function that controls it.
When we buffer new frames for the station, we
normally set the TIM bit right away, but while
the driver has blocked transmission to that sta
we need to avoid that as well since we cannot
respond to the station if it wakes up due to the
TIM bit. Once the driver unblocks, we can set
the TIM bit.
Similarly, when the station just wakes up, we
need to wait until all other frames are flushed
before we can transmit frames to that station,
so the same applies here, we need to wait for
the driver to give the OK.
Signed-off-by: Johannes Berg <johannes@sipsolutions.net>
Signed-off-by: John W. Linville <linville@tuxdriver.com>
2009-11-06 03:35:50 -07:00
|
|
|
{
|
|
|
|
struct ieee80211_sub_if_data *sdata = sta->sdata;
|
|
|
|
struct ieee80211_local *local = sdata->local;
|
2011-09-29 08:04:29 -06:00
|
|
|
bool more_data = false;
|
|
|
|
int ac;
|
2011-09-29 08:04:32 -06:00
|
|
|
unsigned long driver_release_tids = 0;
|
2011-09-29 08:04:33 -06:00
|
|
|
struct sk_buff_head frames;
|
mac80211: async station powersave handling
Some devices require that all frames to a station
are flushed when that station goes into powersave
mode before being able to send frames to that
station again when it wakes up or polls -- all in
order to avoid reordering and too many or too few
frames being sent to the station when it polls.
Normally, this is the case unless the station
goes to sleep and wakes up very quickly again.
But in that case, frames for it may be pending
on the hardware queues, and thus races could
happen in the case of multiple hardware queues
used for QoS/WMM. Normally this isn't a problem,
but with the iwlwifi mechanism we need to make
sure the race doesn't happen.
This makes mac80211 able to cope with the race
with driver help by a new WLAN_STA_PS_DRIVER
per-station flag that can be controlled by the
driver and tells mac80211 whether it can transmit
frames or not. This flag must be set according to
very specific rules outlined in the documentation
for the function that controls it.
When we buffer new frames for the station, we
normally set the TIM bit right away, but while
the driver has blocked transmission to that sta
we need to avoid that as well since we cannot
respond to the station if it wakes up due to the
TIM bit. Once the driver unblocks, we can set
the TIM bit.
Similarly, when the station just wakes up, we
need to wait until all other frames are flushed
before we can transmit frames to that station,
so the same applies here, we need to wait for
the driver to give the OK.
Signed-off-by: Johannes Berg <johannes@sipsolutions.net>
Signed-off-by: John W. Linville <linville@tuxdriver.com>
2009-11-06 03:35:50 -07:00
|
|
|
|
2011-09-29 08:04:35 -06:00
|
|
|
/* Service or PS-Poll period starts */
|
2011-09-29 08:04:36 -06:00
|
|
|
set_sta_flag(sta, WLAN_STA_SP);
|
2011-09-29 08:04:35 -06:00
|
|
|
|
2011-09-29 08:04:33 -06:00
|
|
|
__skb_queue_head_init(&frames);
|
2011-09-29 08:04:29 -06:00
|
|
|
|
mac80211: release multiple ACs in uAPSD, fix more-data bug
When a response for PS-Poll or a uAPSD trigger frame is sent, the
more-data bit should be set according to 802.11-2012 11.2.1.5 h),
meaning that it should indicate more data on the relevant ACs
(delivery-enabled or nondelivery-enabled for uAPSD or PS-Poll.)
In, for example, the following scenario:
* 1 frame on VO queue (either in driver or in mac80211)
* at least 1 frame on VI queue (in the driver)
* both VO/VI are delivery-enabled
* uAPSD trigger frame received
The more-data flag to the driver would not be set, even though
it should be.
While fixing this, I noticed that we should really release frames
from multiple ACs where there's data buffered in the driver for
the corresponding TIDs.
To address all this, restructure the code a bit to consider all
ACs if we only release driver frames or only buffered frames.
This also addresses the more-data bug described above as now the
TIDs will all be marked as released, so the driver will have to
check the number of frames.
While at it, clarify some code and comments and remove the found
variable, replacing it with the appropriate sw/hw release check.
Reported-by: Eliad Peller <eliad@wizery.com>
Signed-off-by: Johannes Berg <johannes.berg@intel.com>
2014-01-08 09:45:07 -07:00
|
|
|
/* Get response frame(s) and more data bit for the last one. */
|
2011-09-29 08:04:29 -06:00
|
|
|
for (ac = 0; ac < IEEE80211_NUM_ACS; ac++) {
|
2011-09-29 08:04:32 -06:00
|
|
|
unsigned long tids;
|
|
|
|
|
2011-09-29 08:04:33 -06:00
|
|
|
if (ignored_acs & BIT(ac))
|
2011-09-29 08:04:29 -06:00
|
|
|
continue;
|
|
|
|
|
2011-09-29 08:04:32 -06:00
|
|
|
tids = ieee80211_tids_for_ac(ac);
|
|
|
|
|
mac80211: release multiple ACs in uAPSD, fix more-data bug
When a response for PS-Poll or a uAPSD trigger frame is sent, the
more-data bit should be set according to 802.11-2012 11.2.1.5 h),
meaning that it should indicate more data on the relevant ACs
(delivery-enabled or nondelivery-enabled for uAPSD or PS-Poll.)
In, for example, the following scenario:
* 1 frame on VO queue (either in driver or in mac80211)
* at least 1 frame on VI queue (in the driver)
* both VO/VI are delivery-enabled
* uAPSD trigger frame received
The more-data flag to the driver would not be set, even though
it should be.
While fixing this, I noticed that we should really release frames
from multiple ACs where there's data buffered in the driver for
the corresponding TIDs.
To address all this, restructure the code a bit to consider all
ACs if we only release driver frames or only buffered frames.
This also addresses the more-data bug described above as now the
TIDs will all be marked as released, so the driver will have to
check the number of frames.
While at it, clarify some code and comments and remove the found
variable, replacing it with the appropriate sw/hw release check.
Reported-by: Eliad Peller <eliad@wizery.com>
Signed-off-by: Johannes Berg <johannes.berg@intel.com>
2014-01-08 09:45:07 -07:00
|
|
|
/* if we already have frames from software, then we can't also
|
|
|
|
* release from hardware queues
|
|
|
|
*/
|
2015-03-27 14:30:37 -06:00
|
|
|
if (skb_queue_empty(&frames)) {
|
mac80211: release multiple ACs in uAPSD, fix more-data bug
When a response for PS-Poll or a uAPSD trigger frame is sent, the
more-data bit should be set according to 802.11-2012 11.2.1.5 h),
meaning that it should indicate more data on the relevant ACs
(delivery-enabled or nondelivery-enabled for uAPSD or PS-Poll.)
In, for example, the following scenario:
* 1 frame on VO queue (either in driver or in mac80211)
* at least 1 frame on VI queue (in the driver)
* both VO/VI are delivery-enabled
* uAPSD trigger frame received
The more-data flag to the driver would not be set, even though
it should be.
While fixing this, I noticed that we should really release frames
from multiple ACs where there's data buffered in the driver for
the corresponding TIDs.
To address all this, restructure the code a bit to consider all
ACs if we only release driver frames or only buffered frames.
This also addresses the more-data bug described above as now the
TIDs will all be marked as released, so the driver will have to
check the number of frames.
While at it, clarify some code and comments and remove the found
variable, replacing it with the appropriate sw/hw release check.
Reported-by: Eliad Peller <eliad@wizery.com>
Signed-off-by: Johannes Berg <johannes.berg@intel.com>
2014-01-08 09:45:07 -07:00
|
|
|
driver_release_tids |= sta->driver_buffered_tids & tids;
|
2015-03-27 14:30:37 -06:00
|
|
|
driver_release_tids |= sta->txq_buffered_tids & tids;
|
|
|
|
}
|
2011-09-29 08:04:29 -06:00
|
|
|
|
mac80211: release multiple ACs in uAPSD, fix more-data bug
When a response for PS-Poll or a uAPSD trigger frame is sent, the
more-data bit should be set according to 802.11-2012 11.2.1.5 h),
meaning that it should indicate more data on the relevant ACs
(delivery-enabled or nondelivery-enabled for uAPSD or PS-Poll.)
In, for example, the following scenario:
* 1 frame on VO queue (either in driver or in mac80211)
* at least 1 frame on VI queue (in the driver)
* both VO/VI are delivery-enabled
* uAPSD trigger frame received
The more-data flag to the driver would not be set, even though
it should be.
While fixing this, I noticed that we should really release frames
from multiple ACs where there's data buffered in the driver for
the corresponding TIDs.
To address all this, restructure the code a bit to consider all
ACs if we only release driver frames or only buffered frames.
This also addresses the more-data bug described above as now the
TIDs will all be marked as released, so the driver will have to
check the number of frames.
While at it, clarify some code and comments and remove the found
variable, replacing it with the appropriate sw/hw release check.
Reported-by: Eliad Peller <eliad@wizery.com>
Signed-off-by: Johannes Berg <johannes.berg@intel.com>
2014-01-08 09:45:07 -07:00
|
|
|
if (driver_release_tids) {
|
|
|
|
/* If the driver has data on more than one TID then
|
2011-09-29 08:04:32 -06:00
|
|
|
* certainly there's more data if we release just a
|
mac80211: release multiple ACs in uAPSD, fix more-data bug
When a response for PS-Poll or a uAPSD trigger frame is sent, the
more-data bit should be set according to 802.11-2012 11.2.1.5 h),
meaning that it should indicate more data on the relevant ACs
(delivery-enabled or nondelivery-enabled for uAPSD or PS-Poll.)
In, for example, the following scenario:
* 1 frame on VO queue (either in driver or in mac80211)
* at least 1 frame on VI queue (in the driver)
* both VO/VI are delivery-enabled
* uAPSD trigger frame received
The more-data flag to the driver would not be set, even though
it should be.
While fixing this, I noticed that we should really release frames
from multiple ACs where there's data buffered in the driver for
the corresponding TIDs.
To address all this, restructure the code a bit to consider all
ACs if we only release driver frames or only buffered frames.
This also addresses the more-data bug described above as now the
TIDs will all be marked as released, so the driver will have to
check the number of frames.
While at it, clarify some code and comments and remove the found
variable, replacing it with the appropriate sw/hw release check.
Reported-by: Eliad Peller <eliad@wizery.com>
Signed-off-by: Johannes Berg <johannes.berg@intel.com>
2014-01-08 09:45:07 -07:00
|
|
|
* single frame now (from a single TID). This will
|
|
|
|
* only happen for PS-Poll.
|
2011-09-29 08:04:32 -06:00
|
|
|
*/
|
2011-09-29 08:04:33 -06:00
|
|
|
if (reason == IEEE80211_FRAME_RELEASE_PSPOLL &&
|
|
|
|
hweight16(driver_release_tids) > 1) {
|
2011-09-29 08:04:32 -06:00
|
|
|
more_data = true;
|
|
|
|
driver_release_tids =
|
2014-01-09 03:05:31 -07:00
|
|
|
BIT(find_highest_prio_tid(
|
|
|
|
driver_release_tids));
|
2011-09-29 08:04:32 -06:00
|
|
|
break;
|
|
|
|
}
|
mac80211: release multiple ACs in uAPSD, fix more-data bug
When a response for PS-Poll or a uAPSD trigger frame is sent, the
more-data bit should be set according to 802.11-2012 11.2.1.5 h),
meaning that it should indicate more data on the relevant ACs
(delivery-enabled or nondelivery-enabled for uAPSD or PS-Poll.)
In, for example, the following scenario:
* 1 frame on VO queue (either in driver or in mac80211)
* at least 1 frame on VI queue (in the driver)
* both VO/VI are delivery-enabled
* uAPSD trigger frame received
The more-data flag to the driver would not be set, even though
it should be.
While fixing this, I noticed that we should really release frames
from multiple ACs where there's data buffered in the driver for
the corresponding TIDs.
To address all this, restructure the code a bit to consider all
ACs if we only release driver frames or only buffered frames.
This also addresses the more-data bug described above as now the
TIDs will all be marked as released, so the driver will have to
check the number of frames.
While at it, clarify some code and comments and remove the found
variable, replacing it with the appropriate sw/hw release check.
Reported-by: Eliad Peller <eliad@wizery.com>
Signed-off-by: Johannes Berg <johannes.berg@intel.com>
2014-01-08 09:45:07 -07:00
|
|
|
} else {
|
|
|
|
struct sk_buff *skb;
|
|
|
|
|
|
|
|
while (n_frames > 0) {
|
|
|
|
skb = skb_dequeue(&sta->tx_filtered[ac]);
|
|
|
|
if (!skb) {
|
|
|
|
skb = skb_dequeue(
|
|
|
|
&sta->ps_tx_buf[ac]);
|
|
|
|
if (skb)
|
|
|
|
local->total_ps_buffered--;
|
|
|
|
}
|
|
|
|
if (!skb)
|
|
|
|
break;
|
|
|
|
n_frames--;
|
|
|
|
__skb_queue_tail(&frames, skb);
|
|
|
|
}
|
2011-09-29 08:04:32 -06:00
|
|
|
}
|
2011-09-29 08:04:29 -06:00
|
|
|
|
mac80211: release multiple ACs in uAPSD, fix more-data bug
When a response for PS-Poll or a uAPSD trigger frame is sent, the
more-data bit should be set according to 802.11-2012 11.2.1.5 h),
meaning that it should indicate more data on the relevant ACs
(delivery-enabled or nondelivery-enabled for uAPSD or PS-Poll.)
In, for example, the following scenario:
* 1 frame on VO queue (either in driver or in mac80211)
* at least 1 frame on VI queue (in the driver)
* both VO/VI are delivery-enabled
* uAPSD trigger frame received
The more-data flag to the driver would not be set, even though
it should be.
While fixing this, I noticed that we should really release frames
from multiple ACs where there's data buffered in the driver for
the corresponding TIDs.
To address all this, restructure the code a bit to consider all
ACs if we only release driver frames or only buffered frames.
This also addresses the more-data bug described above as now the
TIDs will all be marked as released, so the driver will have to
check the number of frames.
While at it, clarify some code and comments and remove the found
variable, replacing it with the appropriate sw/hw release check.
Reported-by: Eliad Peller <eliad@wizery.com>
Signed-off-by: Johannes Berg <johannes.berg@intel.com>
2014-01-08 09:45:07 -07:00
|
|
|
/* If we have more frames buffered on this AC, then set the
|
|
|
|
* more-data bit and abort the loop since we can't send more
|
|
|
|
* data from other ACs before the buffered frames from this.
|
|
|
|
*/
|
2011-09-29 08:04:29 -06:00
|
|
|
if (!skb_queue_empty(&sta->tx_filtered[ac]) ||
|
|
|
|
!skb_queue_empty(&sta->ps_tx_buf[ac])) {
|
|
|
|
more_data = true;
|
|
|
|
break;
|
|
|
|
}
|
mac80211: async station powersave handling
Some devices require that all frames to a station
are flushed when that station goes into powersave
mode before being able to send frames to that
station again when it wakes up or polls -- all in
order to avoid reordering and too many or too few
frames being sent to the station when it polls.
Normally, this is the case unless the station
goes to sleep and wakes up very quickly again.
But in that case, frames for it may be pending
on the hardware queues, and thus races could
happen in the case of multiple hardware queues
used for QoS/WMM. Normally this isn't a problem,
but with the iwlwifi mechanism we need to make
sure the race doesn't happen.
This makes mac80211 able to cope with the race
with driver help by a new WLAN_STA_PS_DRIVER
per-station flag that can be controlled by the
driver and tells mac80211 whether it can transmit
frames or not. This flag must be set according to
very specific rules outlined in the documentation
for the function that controls it.
When we buffer new frames for the station, we
normally set the TIM bit right away, but while
the driver has blocked transmission to that sta
we need to avoid that as well since we cannot
respond to the station if it wakes up due to the
TIM bit. Once the driver unblocks, we can set
the TIM bit.
Similarly, when the station just wakes up, we
need to wait until all other frames are flushed
before we can transmit frames to that station,
so the same applies here, we need to wait for
the driver to give the OK.
Signed-off-by: Johannes Berg <johannes@sipsolutions.net>
Signed-off-by: John W. Linville <linville@tuxdriver.com>
2009-11-06 03:35:50 -07:00
|
|
|
}
|
|
|
|
|
mac80211: release multiple ACs in uAPSD, fix more-data bug
When a response for PS-Poll or a uAPSD trigger frame is sent, the
more-data bit should be set according to 802.11-2012 11.2.1.5 h),
meaning that it should indicate more data on the relevant ACs
(delivery-enabled or nondelivery-enabled for uAPSD or PS-Poll.)
In, for example, the following scenario:
* 1 frame on VO queue (either in driver or in mac80211)
* at least 1 frame on VI queue (in the driver)
* both VO/VI are delivery-enabled
* uAPSD trigger frame received
The more-data flag to the driver would not be set, even though
it should be.
While fixing this, I noticed that we should really release frames
from multiple ACs where there's data buffered in the driver for
the corresponding TIDs.
To address all this, restructure the code a bit to consider all
ACs if we only release driver frames or only buffered frames.
This also addresses the more-data bug described above as now the
TIDs will all be marked as released, so the driver will have to
check the number of frames.
While at it, clarify some code and comments and remove the found
variable, replacing it with the appropriate sw/hw release check.
Reported-by: Eliad Peller <eliad@wizery.com>
Signed-off-by: Johannes Berg <johannes.berg@intel.com>
2014-01-08 09:45:07 -07:00
|
|
|
if (skb_queue_empty(&frames) && !driver_release_tids) {
|
2011-09-29 08:04:34 -06:00
|
|
|
int tid;
|
mac80211: async station powersave handling
Some devices require that all frames to a station
are flushed when that station goes into powersave
mode before being able to send frames to that
station again when it wakes up or polls -- all in
order to avoid reordering and too many or too few
frames being sent to the station when it polls.
Normally, this is the case unless the station
goes to sleep and wakes up very quickly again.
But in that case, frames for it may be pending
on the hardware queues, and thus races could
happen in the case of multiple hardware queues
used for QoS/WMM. Normally this isn't a problem,
but with the iwlwifi mechanism we need to make
sure the race doesn't happen.
This makes mac80211 able to cope with the race
with driver help by a new WLAN_STA_PS_DRIVER
per-station flag that can be controlled by the
driver and tells mac80211 whether it can transmit
frames or not. This flag must be set according to
very specific rules outlined in the documentation
for the function that controls it.
When we buffer new frames for the station, we
normally set the TIM bit right away, but while
the driver has blocked transmission to that sta
we need to avoid that as well since we cannot
respond to the station if it wakes up due to the
TIM bit. Once the driver unblocks, we can set
the TIM bit.
Similarly, when the station just wakes up, we
need to wait until all other frames are flushed
before we can transmit frames to that station,
so the same applies here, we need to wait for
the driver to give the OK.
Signed-off-by: Johannes Berg <johannes@sipsolutions.net>
Signed-off-by: John W. Linville <linville@tuxdriver.com>
2009-11-06 03:35:50 -07:00
|
|
|
|
|
|
|
/*
|
2011-09-29 08:04:34 -06:00
|
|
|
* For PS-Poll, this can only happen due to a race condition
|
|
|
|
* when we set the TIM bit and the station notices it, but
|
|
|
|
* before it can poll for the frame we expire it.
|
|
|
|
*
|
|
|
|
* For uAPSD, this is said in the standard (11.2.1.5 h):
|
|
|
|
* At each unscheduled SP for a non-AP STA, the AP shall
|
|
|
|
* attempt to transmit at least one MSDU or MMPDU, but no
|
|
|
|
* more than the value specified in the Max SP Length field
|
|
|
|
* in the QoS Capability element from delivery-enabled ACs,
|
|
|
|
* that are destined for the non-AP STA.
|
|
|
|
*
|
|
|
|
* Since we have no other MSDU/MMPDU, transmit a QoS null frame.
|
mac80211: async station powersave handling
Some devices require that all frames to a station
are flushed when that station goes into powersave
mode before being able to send frames to that
station again when it wakes up or polls -- all in
order to avoid reordering and too many or too few
frames being sent to the station when it polls.
Normally, this is the case unless the station
goes to sleep and wakes up very quickly again.
But in that case, frames for it may be pending
on the hardware queues, and thus races could
happen in the case of multiple hardware queues
used for QoS/WMM. Normally this isn't a problem,
but with the iwlwifi mechanism we need to make
sure the race doesn't happen.
This makes mac80211 able to cope with the race
with driver help by a new WLAN_STA_PS_DRIVER
per-station flag that can be controlled by the
driver and tells mac80211 whether it can transmit
frames or not. This flag must be set according to
very specific rules outlined in the documentation
for the function that controls it.
When we buffer new frames for the station, we
normally set the TIM bit right away, but while
the driver has blocked transmission to that sta
we need to avoid that as well since we cannot
respond to the station if it wakes up due to the
TIM bit. Once the driver unblocks, we can set
the TIM bit.
Similarly, when the station just wakes up, we
need to wait until all other frames are flushed
before we can transmit frames to that station,
so the same applies here, we need to wait for
the driver to give the OK.
Signed-off-by: Johannes Berg <johannes@sipsolutions.net>
Signed-off-by: John W. Linville <linville@tuxdriver.com>
2009-11-06 03:35:50 -07:00
|
|
|
*/
|
|
|
|
|
2011-09-29 08:04:34 -06:00
|
|
|
/* This will evaluate to 1, 3, 5 or 7. */
|
|
|
|
tid = 7 - ((ffs(~ignored_acs) - 1) << 1);
|
mac80211: async station powersave handling
Some devices require that all frames to a station
are flushed when that station goes into powersave
mode before being able to send frames to that
station again when it wakes up or polls -- all in
order to avoid reordering and too many or too few
frames being sent to the station when it polls.
Normally, this is the case unless the station
goes to sleep and wakes up very quickly again.
But in that case, frames for it may be pending
on the hardware queues, and thus races could
happen in the case of multiple hardware queues
used for QoS/WMM. Normally this isn't a problem,
but with the iwlwifi mechanism we need to make
sure the race doesn't happen.
This makes mac80211 able to cope with the race
with driver help by a new WLAN_STA_PS_DRIVER
per-station flag that can be controlled by the
driver and tells mac80211 whether it can transmit
frames or not. This flag must be set according to
very specific rules outlined in the documentation
for the function that controls it.
When we buffer new frames for the station, we
normally set the TIM bit right away, but while
the driver has blocked transmission to that sta
we need to avoid that as well since we cannot
respond to the station if it wakes up due to the
TIM bit. Once the driver unblocks, we can set
the TIM bit.
Similarly, when the station just wakes up, we
need to wait until all other frames are flushed
before we can transmit frames to that station,
so the same applies here, we need to wait for
the driver to give the OK.
Signed-off-by: Johannes Berg <johannes@sipsolutions.net>
Signed-off-by: John W. Linville <linville@tuxdriver.com>
2009-11-06 03:35:50 -07:00
|
|
|
|
2014-01-08 16:00:38 -07:00
|
|
|
ieee80211_send_null_response(sdata, sta, tid, reason, true);
|
mac80211: release multiple ACs in uAPSD, fix more-data bug
When a response for PS-Poll or a uAPSD trigger frame is sent, the
more-data bit should be set according to 802.11-2012 11.2.1.5 h),
meaning that it should indicate more data on the relevant ACs
(delivery-enabled or nondelivery-enabled for uAPSD or PS-Poll.)
In, for example, the following scenario:
* 1 frame on VO queue (either in driver or in mac80211)
* at least 1 frame on VI queue (in the driver)
* both VO/VI are delivery-enabled
* uAPSD trigger frame received
The more-data flag to the driver would not be set, even though
it should be.
While fixing this, I noticed that we should really release frames
from multiple ACs where there's data buffered in the driver for
the corresponding TIDs.
To address all this, restructure the code a bit to consider all
ACs if we only release driver frames or only buffered frames.
This also addresses the more-data bug described above as now the
TIDs will all be marked as released, so the driver will have to
check the number of frames.
While at it, clarify some code and comments and remove the found
variable, replacing it with the appropriate sw/hw release check.
Reported-by: Eliad Peller <eliad@wizery.com>
Signed-off-by: Johannes Berg <johannes.berg@intel.com>
2014-01-08 09:45:07 -07:00
|
|
|
} else if (!driver_release_tids) {
|
2011-09-29 08:04:33 -06:00
|
|
|
struct sk_buff_head pending;
|
|
|
|
struct sk_buff *skb;
|
2011-09-29 08:04:38 -06:00
|
|
|
int num = 0;
|
|
|
|
u16 tids = 0;
|
2014-01-08 16:00:38 -07:00
|
|
|
bool need_null = false;
|
mac80211: async station powersave handling
Some devices require that all frames to a station
are flushed when that station goes into powersave
mode before being able to send frames to that
station again when it wakes up or polls -- all in
order to avoid reordering and too many or too few
frames being sent to the station when it polls.
Normally, this is the case unless the station
goes to sleep and wakes up very quickly again.
But in that case, frames for it may be pending
on the hardware queues, and thus races could
happen in the case of multiple hardware queues
used for QoS/WMM. Normally this isn't a problem,
but with the iwlwifi mechanism we need to make
sure the race doesn't happen.
This makes mac80211 able to cope with the race
with driver help by a new WLAN_STA_PS_DRIVER
per-station flag that can be controlled by the
driver and tells mac80211 whether it can transmit
frames or not. This flag must be set according to
very specific rules outlined in the documentation
for the function that controls it.
When we buffer new frames for the station, we
normally set the TIM bit right away, but while
the driver has blocked transmission to that sta
we need to avoid that as well since we cannot
respond to the station if it wakes up due to the
TIM bit. Once the driver unblocks, we can set
the TIM bit.
Similarly, when the station just wakes up, we
need to wait until all other frames are flushed
before we can transmit frames to that station,
so the same applies here, we need to wait for
the driver to give the OK.
Signed-off-by: Johannes Berg <johannes@sipsolutions.net>
Signed-off-by: John W. Linville <linville@tuxdriver.com>
2009-11-06 03:35:50 -07:00
|
|
|
|
2011-09-29 08:04:33 -06:00
|
|
|
skb_queue_head_init(&pending);
|
mac80211: async station powersave handling
Some devices require that all frames to a station
are flushed when that station goes into powersave
mode before being able to send frames to that
station again when it wakes up or polls -- all in
order to avoid reordering and too many or too few
frames being sent to the station when it polls.
Normally, this is the case unless the station
goes to sleep and wakes up very quickly again.
But in that case, frames for it may be pending
on the hardware queues, and thus races could
happen in the case of multiple hardware queues
used for QoS/WMM. Normally this isn't a problem,
but with the iwlwifi mechanism we need to make
sure the race doesn't happen.
This makes mac80211 able to cope with the race
with driver help by a new WLAN_STA_PS_DRIVER
per-station flag that can be controlled by the
driver and tells mac80211 whether it can transmit
frames or not. This flag must be set according to
very specific rules outlined in the documentation
for the function that controls it.
When we buffer new frames for the station, we
normally set the TIM bit right away, but while
the driver has blocked transmission to that sta
we need to avoid that as well since we cannot
respond to the station if it wakes up due to the
TIM bit. Once the driver unblocks, we can set
the TIM bit.
Similarly, when the station just wakes up, we
need to wait until all other frames are flushed
before we can transmit frames to that station,
so the same applies here, we need to wait for
the driver to give the OK.
Signed-off-by: Johannes Berg <johannes@sipsolutions.net>
Signed-off-by: John W. Linville <linville@tuxdriver.com>
2009-11-06 03:35:50 -07:00
|
|
|
|
2011-09-29 08:04:33 -06:00
|
|
|
while ((skb = __skb_dequeue(&frames))) {
|
|
|
|
struct ieee80211_tx_info *info = IEEE80211_SKB_CB(skb);
|
|
|
|
struct ieee80211_hdr *hdr = (void *) skb->data;
|
2011-09-29 08:04:38 -06:00
|
|
|
u8 *qoshdr = NULL;
|
|
|
|
|
|
|
|
num++;
|
mac80211: async station powersave handling
Some devices require that all frames to a station
are flushed when that station goes into powersave
mode before being able to send frames to that
station again when it wakes up or polls -- all in
order to avoid reordering and too many or too few
frames being sent to the station when it polls.
Normally, this is the case unless the station
goes to sleep and wakes up very quickly again.
But in that case, frames for it may be pending
on the hardware queues, and thus races could
happen in the case of multiple hardware queues
used for QoS/WMM. Normally this isn't a problem,
but with the iwlwifi mechanism we need to make
sure the race doesn't happen.
This makes mac80211 able to cope with the race
with driver help by a new WLAN_STA_PS_DRIVER
per-station flag that can be controlled by the
driver and tells mac80211 whether it can transmit
frames or not. This flag must be set according to
very specific rules outlined in the documentation
for the function that controls it.
When we buffer new frames for the station, we
normally set the TIM bit right away, but while
the driver has blocked transmission to that sta
we need to avoid that as well since we cannot
respond to the station if it wakes up due to the
TIM bit. Once the driver unblocks, we can set
the TIM bit.
Similarly, when the station just wakes up, we
need to wait until all other frames are flushed
before we can transmit frames to that station,
so the same applies here, we need to wait for
the driver to give the OK.
Signed-off-by: Johannes Berg <johannes@sipsolutions.net>
Signed-off-by: John W. Linville <linville@tuxdriver.com>
2009-11-06 03:35:50 -07:00
|
|
|
|
2011-09-29 08:04:33 -06:00
|
|
|
/*
|
|
|
|
* Tell TX path to send this frame even though the
|
|
|
|
* STA may still remain is PS mode after this frame
|
|
|
|
* exchange.
|
|
|
|
*/
|
2014-12-10 08:56:10 -07:00
|
|
|
info->flags |= IEEE80211_TX_CTL_NO_PS_BUFFER;
|
|
|
|
info->control.flags |= IEEE80211_TX_CTRL_PS_RESPONSE;
|
2011-09-29 08:04:33 -06:00
|
|
|
|
|
|
|
/*
|
|
|
|
* Use MoreData flag to indicate whether there are
|
|
|
|
* more buffered frames for this STA
|
|
|
|
*/
|
2011-11-07 00:47:47 -07:00
|
|
|
if (more_data || !skb_queue_empty(&frames))
|
2011-09-29 08:04:33 -06:00
|
|
|
hdr->frame_control |=
|
|
|
|
cpu_to_le16(IEEE80211_FCTL_MOREDATA);
|
2011-11-07 00:47:47 -07:00
|
|
|
else
|
|
|
|
hdr->frame_control &=
|
|
|
|
cpu_to_le16(~IEEE80211_FCTL_MOREDATA);
|
2011-09-29 08:04:33 -06:00
|
|
|
|
2011-09-29 08:04:38 -06:00
|
|
|
if (ieee80211_is_data_qos(hdr->frame_control) ||
|
|
|
|
ieee80211_is_qos_nullfunc(hdr->frame_control))
|
|
|
|
qoshdr = ieee80211_get_qos_ctl(hdr);
|
|
|
|
|
2014-01-08 16:00:38 -07:00
|
|
|
tids |= BIT(skb->priority);
|
2012-03-16 08:30:26 -06:00
|
|
|
|
2014-01-08 16:00:38 -07:00
|
|
|
__skb_queue_tail(&pending, skb);
|
|
|
|
|
|
|
|
/* end service period after last frame or add one */
|
|
|
|
if (!skb_queue_empty(&frames))
|
|
|
|
continue;
|
|
|
|
|
|
|
|
if (reason != IEEE80211_FRAME_RELEASE_UAPSD) {
|
|
|
|
/* for PS-Poll, there's only one frame */
|
2012-03-16 08:30:26 -06:00
|
|
|
info->flags |= IEEE80211_TX_STATUS_EOSP |
|
|
|
|
IEEE80211_TX_CTL_REQ_TX_STATUS;
|
2014-01-08 16:00:38 -07:00
|
|
|
break;
|
2012-03-16 08:30:26 -06:00
|
|
|
}
|
2011-09-29 08:04:35 -06:00
|
|
|
|
2014-01-08 16:00:38 -07:00
|
|
|
/* For uAPSD, things are a bit more complicated. If the
|
|
|
|
* last frame has a QoS header (i.e. is a QoS-data or
|
|
|
|
* QoS-nulldata frame) then just set the EOSP bit there
|
|
|
|
* and be done.
|
|
|
|
* If the frame doesn't have a QoS header (which means
|
|
|
|
* it should be a bufferable MMPDU) then we can't set
|
|
|
|
* the EOSP bit in the QoS header; add a QoS-nulldata
|
|
|
|
* frame to the list to send it after the MMPDU.
|
|
|
|
*
|
|
|
|
* Note that this code is only in the mac80211-release
|
|
|
|
* code path, we assume that the driver will not buffer
|
|
|
|
* anything but QoS-data frames, or if it does, will
|
|
|
|
* create the QoS-nulldata frame by itself if needed.
|
|
|
|
*
|
|
|
|
* Cf. 802.11-2012 10.2.1.10 (c).
|
|
|
|
*/
|
|
|
|
if (qoshdr) {
|
|
|
|
*qoshdr |= IEEE80211_QOS_CTL_EOSP;
|
2011-09-29 08:04:38 -06:00
|
|
|
|
2014-01-08 16:00:38 -07:00
|
|
|
info->flags |= IEEE80211_TX_STATUS_EOSP |
|
|
|
|
IEEE80211_TX_CTL_REQ_TX_STATUS;
|
|
|
|
} else {
|
|
|
|
/* The standard isn't completely clear on this
|
|
|
|
* as it says the more-data bit should be set
|
|
|
|
* if there are more BUs. The QoS-Null frame
|
|
|
|
* we're about to send isn't buffered yet, we
|
|
|
|
* only create it below, but let's pretend it
|
|
|
|
* was buffered just in case some clients only
|
|
|
|
* expect more-data=0 when eosp=1.
|
|
|
|
*/
|
|
|
|
hdr->frame_control |=
|
|
|
|
cpu_to_le16(IEEE80211_FCTL_MOREDATA);
|
|
|
|
need_null = true;
|
|
|
|
num++;
|
|
|
|
}
|
|
|
|
break;
|
2011-09-29 08:04:33 -06:00
|
|
|
}
|
mac80211: async station powersave handling
Some devices require that all frames to a station
are flushed when that station goes into powersave
mode before being able to send frames to that
station again when it wakes up or polls -- all in
order to avoid reordering and too many or too few
frames being sent to the station when it polls.
Normally, this is the case unless the station
goes to sleep and wakes up very quickly again.
But in that case, frames for it may be pending
on the hardware queues, and thus races could
happen in the case of multiple hardware queues
used for QoS/WMM. Normally this isn't a problem,
but with the iwlwifi mechanism we need to make
sure the race doesn't happen.
This makes mac80211 able to cope with the race
with driver help by a new WLAN_STA_PS_DRIVER
per-station flag that can be controlled by the
driver and tells mac80211 whether it can transmit
frames or not. This flag must be set according to
very specific rules outlined in the documentation
for the function that controls it.
When we buffer new frames for the station, we
normally set the TIM bit right away, but while
the driver has blocked transmission to that sta
we need to avoid that as well since we cannot
respond to the station if it wakes up due to the
TIM bit. Once the driver unblocks, we can set
the TIM bit.
Similarly, when the station just wakes up, we
need to wait until all other frames are flushed
before we can transmit frames to that station,
so the same applies here, we need to wait for
the driver to give the OK.
Signed-off-by: Johannes Berg <johannes@sipsolutions.net>
Signed-off-by: John W. Linville <linville@tuxdriver.com>
2009-11-06 03:35:50 -07:00
|
|
|
|
2011-09-29 08:04:38 -06:00
|
|
|
drv_allow_buffered_frames(local, sta, tids, num,
|
|
|
|
reason, more_data);
|
|
|
|
|
2011-09-29 08:04:33 -06:00
|
|
|
ieee80211_add_pending_skbs(local, &pending);
|
mac80211: async station powersave handling
Some devices require that all frames to a station
are flushed when that station goes into powersave
mode before being able to send frames to that
station again when it wakes up or polls -- all in
order to avoid reordering and too many or too few
frames being sent to the station when it polls.
Normally, this is the case unless the station
goes to sleep and wakes up very quickly again.
But in that case, frames for it may be pending
on the hardware queues, and thus races could
happen in the case of multiple hardware queues
used for QoS/WMM. Normally this isn't a problem,
but with the iwlwifi mechanism we need to make
sure the race doesn't happen.
This makes mac80211 able to cope with the race
with driver help by a new WLAN_STA_PS_DRIVER
per-station flag that can be controlled by the
driver and tells mac80211 whether it can transmit
frames or not. This flag must be set according to
very specific rules outlined in the documentation
for the function that controls it.
When we buffer new frames for the station, we
normally set the TIM bit right away, but while
the driver has blocked transmission to that sta
we need to avoid that as well since we cannot
respond to the station if it wakes up due to the
TIM bit. Once the driver unblocks, we can set
the TIM bit.
Similarly, when the station just wakes up, we
need to wait until all other frames are flushed
before we can transmit frames to that station,
so the same applies here, we need to wait for
the driver to give the OK.
Signed-off-by: Johannes Berg <johannes@sipsolutions.net>
Signed-off-by: John W. Linville <linville@tuxdriver.com>
2009-11-06 03:35:50 -07:00
|
|
|
|
2014-01-08 16:00:38 -07:00
|
|
|
if (need_null)
|
|
|
|
ieee80211_send_null_response(
|
|
|
|
sdata, sta, find_highest_prio_tid(tids),
|
|
|
|
reason, false);
|
|
|
|
|
2011-09-29 08:04:27 -06:00
|
|
|
sta_info_recalc_tim(sta);
|
mac80211: async station powersave handling
Some devices require that all frames to a station
are flushed when that station goes into powersave
mode before being able to send frames to that
station again when it wakes up or polls -- all in
order to avoid reordering and too many or too few
frames being sent to the station when it polls.
Normally, this is the case unless the station
goes to sleep and wakes up very quickly again.
But in that case, frames for it may be pending
on the hardware queues, and thus races could
happen in the case of multiple hardware queues
used for QoS/WMM. Normally this isn't a problem,
but with the iwlwifi mechanism we need to make
sure the race doesn't happen.
This makes mac80211 able to cope with the race
with driver help by a new WLAN_STA_PS_DRIVER
per-station flag that can be controlled by the
driver and tells mac80211 whether it can transmit
frames or not. This flag must be set according to
very specific rules outlined in the documentation
for the function that controls it.
When we buffer new frames for the station, we
normally set the TIM bit right away, but while
the driver has blocked transmission to that sta
we need to avoid that as well since we cannot
respond to the station if it wakes up due to the
TIM bit. Once the driver unblocks, we can set
the TIM bit.
Similarly, when the station just wakes up, we
need to wait until all other frames are flushed
before we can transmit frames to that station,
so the same applies here, we need to wait for
the driver to give the OK.
Signed-off-by: Johannes Berg <johannes@sipsolutions.net>
Signed-off-by: John W. Linville <linville@tuxdriver.com>
2009-11-06 03:35:50 -07:00
|
|
|
} else {
|
2015-03-27 14:30:37 -06:00
|
|
|
unsigned long tids = sta->txq_buffered_tids & driver_release_tids;
|
|
|
|
int tid;
|
|
|
|
|
mac80211: async station powersave handling
Some devices require that all frames to a station
are flushed when that station goes into powersave
mode before being able to send frames to that
station again when it wakes up or polls -- all in
order to avoid reordering and too many or too few
frames being sent to the station when it polls.
Normally, this is the case unless the station
goes to sleep and wakes up very quickly again.
But in that case, frames for it may be pending
on the hardware queues, and thus races could
happen in the case of multiple hardware queues
used for QoS/WMM. Normally this isn't a problem,
but with the iwlwifi mechanism we need to make
sure the race doesn't happen.
This makes mac80211 able to cope with the race
with driver help by a new WLAN_STA_PS_DRIVER
per-station flag that can be controlled by the
driver and tells mac80211 whether it can transmit
frames or not. This flag must be set according to
very specific rules outlined in the documentation
for the function that controls it.
When we buffer new frames for the station, we
normally set the TIM bit right away, but while
the driver has blocked transmission to that sta
we need to avoid that as well since we cannot
respond to the station if it wakes up due to the
TIM bit. Once the driver unblocks, we can set
the TIM bit.
Similarly, when the station just wakes up, we
need to wait until all other frames are flushed
before we can transmit frames to that station,
so the same applies here, we need to wait for
the driver to give the OK.
Signed-off-by: Johannes Berg <johannes@sipsolutions.net>
Signed-off-by: John W. Linville <linville@tuxdriver.com>
2009-11-06 03:35:50 -07:00
|
|
|
/*
|
2011-09-29 08:04:32 -06:00
|
|
|
* We need to release a frame that is buffered somewhere in the
|
|
|
|
* driver ... it'll have to handle that.
|
mac80211: release multiple ACs in uAPSD, fix more-data bug
When a response for PS-Poll or a uAPSD trigger frame is sent, the
more-data bit should be set according to 802.11-2012 11.2.1.5 h),
meaning that it should indicate more data on the relevant ACs
(delivery-enabled or nondelivery-enabled for uAPSD or PS-Poll.)
In, for example, the following scenario:
* 1 frame on VO queue (either in driver or in mac80211)
* at least 1 frame on VI queue (in the driver)
* both VO/VI are delivery-enabled
* uAPSD trigger frame received
The more-data flag to the driver would not be set, even though
it should be.
While fixing this, I noticed that we should really release frames
from multiple ACs where there's data buffered in the driver for
the corresponding TIDs.
To address all this, restructure the code a bit to consider all
ACs if we only release driver frames or only buffered frames.
This also addresses the more-data bug described above as now the
TIDs will all be marked as released, so the driver will have to
check the number of frames.
While at it, clarify some code and comments and remove the found
variable, replacing it with the appropriate sw/hw release check.
Reported-by: Eliad Peller <eliad@wizery.com>
Signed-off-by: Johannes Berg <johannes.berg@intel.com>
2014-01-08 09:45:07 -07:00
|
|
|
* Note that the driver also has to check the number of frames
|
|
|
|
* on the TIDs we're releasing from - if there are more than
|
|
|
|
* n_frames it has to set the more-data bit (if we didn't ask
|
|
|
|
* it to set it anyway due to other buffered frames); if there
|
|
|
|
* are fewer than n_frames it has to make sure to adjust that
|
|
|
|
* to allow the service period to end properly.
|
2011-09-29 08:04:32 -06:00
|
|
|
*/
|
|
|
|
drv_release_buffered_frames(local, sta, driver_release_tids,
|
2011-09-29 08:04:33 -06:00
|
|
|
n_frames, reason, more_data);
|
2011-09-29 08:04:32 -06:00
|
|
|
|
|
|
|
/*
|
|
|
|
* Note that we don't recalculate the TIM bit here as it would
|
|
|
|
* most likely have no effect at all unless the driver told us
|
mac80211: release multiple ACs in uAPSD, fix more-data bug
When a response for PS-Poll or a uAPSD trigger frame is sent, the
more-data bit should be set according to 802.11-2012 11.2.1.5 h),
meaning that it should indicate more data on the relevant ACs
(delivery-enabled or nondelivery-enabled for uAPSD or PS-Poll.)
In, for example, the following scenario:
* 1 frame on VO queue (either in driver or in mac80211)
* at least 1 frame on VI queue (in the driver)
* both VO/VI are delivery-enabled
* uAPSD trigger frame received
The more-data flag to the driver would not be set, even though
it should be.
While fixing this, I noticed that we should really release frames
from multiple ACs where there's data buffered in the driver for
the corresponding TIDs.
To address all this, restructure the code a bit to consider all
ACs if we only release driver frames or only buffered frames.
This also addresses the more-data bug described above as now the
TIDs will all be marked as released, so the driver will have to
check the number of frames.
While at it, clarify some code and comments and remove the found
variable, replacing it with the appropriate sw/hw release check.
Reported-by: Eliad Peller <eliad@wizery.com>
Signed-off-by: Johannes Berg <johannes.berg@intel.com>
2014-01-08 09:45:07 -07:00
|
|
|
* that the TID(s) became empty before returning here from the
|
2011-09-29 08:04:32 -06:00
|
|
|
* release function.
|
mac80211: release multiple ACs in uAPSD, fix more-data bug
When a response for PS-Poll or a uAPSD trigger frame is sent, the
more-data bit should be set according to 802.11-2012 11.2.1.5 h),
meaning that it should indicate more data on the relevant ACs
(delivery-enabled or nondelivery-enabled for uAPSD or PS-Poll.)
In, for example, the following scenario:
* 1 frame on VO queue (either in driver or in mac80211)
* at least 1 frame on VI queue (in the driver)
* both VO/VI are delivery-enabled
* uAPSD trigger frame received
The more-data flag to the driver would not be set, even though
it should be.
While fixing this, I noticed that we should really release frames
from multiple ACs where there's data buffered in the driver for
the corresponding TIDs.
To address all this, restructure the code a bit to consider all
ACs if we only release driver frames or only buffered frames.
This also addresses the more-data bug described above as now the
TIDs will all be marked as released, so the driver will have to
check the number of frames.
While at it, clarify some code and comments and remove the found
variable, replacing it with the appropriate sw/hw release check.
Reported-by: Eliad Peller <eliad@wizery.com>
Signed-off-by: Johannes Berg <johannes.berg@intel.com>
2014-01-08 09:45:07 -07:00
|
|
|
* Either way, however, when the driver tells us that the TID(s)
|
2015-03-27 14:30:37 -06:00
|
|
|
* became empty or we find that a txq became empty, we'll do the
|
|
|
|
* TIM recalculation.
|
mac80211: async station powersave handling
Some devices require that all frames to a station
are flushed when that station goes into powersave
mode before being able to send frames to that
station again when it wakes up or polls -- all in
order to avoid reordering and too many or too few
frames being sent to the station when it polls.
Normally, this is the case unless the station
goes to sleep and wakes up very quickly again.
But in that case, frames for it may be pending
on the hardware queues, and thus races could
happen in the case of multiple hardware queues
used for QoS/WMM. Normally this isn't a problem,
but with the iwlwifi mechanism we need to make
sure the race doesn't happen.
This makes mac80211 able to cope with the race
with driver help by a new WLAN_STA_PS_DRIVER
per-station flag that can be controlled by the
driver and tells mac80211 whether it can transmit
frames or not. This flag must be set according to
very specific rules outlined in the documentation
for the function that controls it.
When we buffer new frames for the station, we
normally set the TIM bit right away, but while
the driver has blocked transmission to that sta
we need to avoid that as well since we cannot
respond to the station if it wakes up due to the
TIM bit. Once the driver unblocks, we can set
the TIM bit.
Similarly, when the station just wakes up, we
need to wait until all other frames are flushed
before we can transmit frames to that station,
so the same applies here, we need to wait for
the driver to give the OK.
Signed-off-by: Johannes Berg <johannes@sipsolutions.net>
Signed-off-by: John W. Linville <linville@tuxdriver.com>
2009-11-06 03:35:50 -07:00
|
|
|
*/
|
2015-03-27 14:30:37 -06:00
|
|
|
|
|
|
|
if (!sta->sta.txq[0])
|
|
|
|
return;
|
|
|
|
|
|
|
|
for (tid = 0; tid < ARRAY_SIZE(sta->sta.txq); tid++) {
|
|
|
|
struct txq_info *txqi = to_txq_info(sta->sta.txq[tid]);
|
|
|
|
|
|
|
|
if (!(tids & BIT(tid)) || skb_queue_len(&txqi->queue))
|
|
|
|
continue;
|
|
|
|
|
|
|
|
sta_info_recalc_tim(sta);
|
|
|
|
break;
|
|
|
|
}
|
mac80211: async station powersave handling
Some devices require that all frames to a station
are flushed when that station goes into powersave
mode before being able to send frames to that
station again when it wakes up or polls -- all in
order to avoid reordering and too many or too few
frames being sent to the station when it polls.
Normally, this is the case unless the station
goes to sleep and wakes up very quickly again.
But in that case, frames for it may be pending
on the hardware queues, and thus races could
happen in the case of multiple hardware queues
used for QoS/WMM. Normally this isn't a problem,
but with the iwlwifi mechanism we need to make
sure the race doesn't happen.
This makes mac80211 able to cope with the race
with driver help by a new WLAN_STA_PS_DRIVER
per-station flag that can be controlled by the
driver and tells mac80211 whether it can transmit
frames or not. This flag must be set according to
very specific rules outlined in the documentation
for the function that controls it.
When we buffer new frames for the station, we
normally set the TIM bit right away, but while
the driver has blocked transmission to that sta
we need to avoid that as well since we cannot
respond to the station if it wakes up due to the
TIM bit. Once the driver unblocks, we can set
the TIM bit.
Similarly, when the station just wakes up, we
need to wait until all other frames are flushed
before we can transmit frames to that station,
so the same applies here, we need to wait for
the driver to give the OK.
Signed-off-by: Johannes Berg <johannes@sipsolutions.net>
Signed-off-by: John W. Linville <linville@tuxdriver.com>
2009-11-06 03:35:50 -07:00
|
|
|
}
|
|
|
|
}
|
|
|
|
|
2011-09-29 08:04:33 -06:00
|
|
|
void ieee80211_sta_ps_deliver_poll_response(struct sta_info *sta)
|
|
|
|
{
|
|
|
|
u8 ignore_for_response = sta->sta.uapsd_queues;
|
|
|
|
|
|
|
|
/*
|
|
|
|
* If all ACs are delivery-enabled then we should reply
|
|
|
|
* from any of them, if only some are enabled we reply
|
|
|
|
* only from the non-enabled ones.
|
|
|
|
*/
|
|
|
|
if (ignore_for_response == BIT(IEEE80211_NUM_ACS) - 1)
|
|
|
|
ignore_for_response = 0;
|
|
|
|
|
|
|
|
ieee80211_sta_ps_deliver_response(sta, 1, ignore_for_response,
|
|
|
|
IEEE80211_FRAME_RELEASE_PSPOLL);
|
|
|
|
}
|
|
|
|
|
|
|
|
void ieee80211_sta_ps_deliver_uapsd(struct sta_info *sta)
|
|
|
|
{
|
|
|
|
int n_frames = sta->sta.max_sp;
|
|
|
|
u8 delivery_enabled = sta->sta.uapsd_queues;
|
|
|
|
|
|
|
|
/*
|
|
|
|
* If we ever grow support for TSPEC this might happen if
|
|
|
|
* the TSPEC update from hostapd comes in between a trigger
|
|
|
|
* frame setting WLAN_STA_UAPSD in the RX path and this
|
|
|
|
* actually getting called.
|
|
|
|
*/
|
|
|
|
if (!delivery_enabled)
|
|
|
|
return;
|
|
|
|
|
|
|
|
switch (sta->sta.max_sp) {
|
|
|
|
case 1:
|
|
|
|
n_frames = 2;
|
|
|
|
break;
|
|
|
|
case 2:
|
|
|
|
n_frames = 4;
|
|
|
|
break;
|
|
|
|
case 3:
|
|
|
|
n_frames = 6;
|
|
|
|
break;
|
|
|
|
case 0:
|
|
|
|
/* XXX: what is a good value? */
|
2014-11-04 02:33:04 -07:00
|
|
|
n_frames = 128;
|
2011-09-29 08:04:33 -06:00
|
|
|
break;
|
|
|
|
}
|
|
|
|
|
|
|
|
ieee80211_sta_ps_deliver_response(sta, n_frames, ~delivery_enabled,
|
|
|
|
IEEE80211_FRAME_RELEASE_UAPSD);
|
|
|
|
}
|
|
|
|
|
mac80211: async station powersave handling
Some devices require that all frames to a station
are flushed when that station goes into powersave
mode before being able to send frames to that
station again when it wakes up or polls -- all in
order to avoid reordering and too many or too few
frames being sent to the station when it polls.
Normally, this is the case unless the station
goes to sleep and wakes up very quickly again.
But in that case, frames for it may be pending
on the hardware queues, and thus races could
happen in the case of multiple hardware queues
used for QoS/WMM. Normally this isn't a problem,
but with the iwlwifi mechanism we need to make
sure the race doesn't happen.
This makes mac80211 able to cope with the race
with driver help by a new WLAN_STA_PS_DRIVER
per-station flag that can be controlled by the
driver and tells mac80211 whether it can transmit
frames or not. This flag must be set according to
very specific rules outlined in the documentation
for the function that controls it.
When we buffer new frames for the station, we
normally set the TIM bit right away, but while
the driver has blocked transmission to that sta
we need to avoid that as well since we cannot
respond to the station if it wakes up due to the
TIM bit. Once the driver unblocks, we can set
the TIM bit.
Similarly, when the station just wakes up, we
need to wait until all other frames are flushed
before we can transmit frames to that station,
so the same applies here, we need to wait for
the driver to give the OK.
Signed-off-by: Johannes Berg <johannes@sipsolutions.net>
Signed-off-by: John W. Linville <linville@tuxdriver.com>
2009-11-06 03:35:50 -07:00
|
|
|
void ieee80211_sta_block_awake(struct ieee80211_hw *hw,
|
|
|
|
struct ieee80211_sta *pubsta, bool block)
|
|
|
|
{
|
|
|
|
struct sta_info *sta = container_of(pubsta, struct sta_info, sta);
|
|
|
|
|
2010-04-07 08:48:40 -06:00
|
|
|
trace_api_sta_block_awake(sta->local, pubsta, block);
|
|
|
|
|
mac80211: fix station/driver powersave race
It is currently possible to have a race due to the station PS
unblock work like this:
* station goes to sleep with frames buffered in the driver
* driver blocks wakeup
* station wakes up again
* driver flushes/returns frames, and unblocks, which schedules
the unblock work
* unblock work starts to run, and checks that the station is
awake (i.e. that the WLAN_STA_PS_STA flag isn't set)
* we process a received frame with PM=1, setting the flag again
* ieee80211_sta_ps_deliver_wakeup() runs, delivering all frames
to the driver, and then clearing the WLAN_STA_PS_DRIVER and
WLAN_STA_PS_STA flags
In this scenario, mac80211 will think that the station is awake,
while it really is asleep, and any TX'ed frames should be filtered
by the device (it will know that the station is sleeping) but then
passed to mac80211 again, which will not buffer it either as it
thinks the station is awake, and eventually the packets will be
dropped.
Fix this by moving the clearing of the flags to exactly where we
learn about the situation. This creates a problem of reordering,
so introduce another flag indicating that delivery is being done,
this new flag also queues frames and is cleared only while the
spinlock is held (which the queuing code also holds) so that any
concurrent delivery/TX is handled correctly.
Reported-by: Andrei Otcheretianski <andrei.otcheretianski@intel.com>
Signed-off-by: Johannes Berg <johannes.berg@intel.com>
2014-05-27 08:32:27 -06:00
|
|
|
if (block) {
|
2011-09-29 08:04:36 -06:00
|
|
|
set_sta_flag(sta, WLAN_STA_PS_DRIVER);
|
2015-03-21 08:25:43 -06:00
|
|
|
ieee80211_clear_fast_xmit(sta);
|
mac80211: fix station/driver powersave race
It is currently possible to have a race due to the station PS
unblock work like this:
* station goes to sleep with frames buffered in the driver
* driver blocks wakeup
* station wakes up again
* driver flushes/returns frames, and unblocks, which schedules
the unblock work
* unblock work starts to run, and checks that the station is
awake (i.e. that the WLAN_STA_PS_STA flag isn't set)
* we process a received frame with PM=1, setting the flag again
* ieee80211_sta_ps_deliver_wakeup() runs, delivering all frames
to the driver, and then clearing the WLAN_STA_PS_DRIVER and
WLAN_STA_PS_STA flags
In this scenario, mac80211 will think that the station is awake,
while it really is asleep, and any TX'ed frames should be filtered
by the device (it will know that the station is sleeping) but then
passed to mac80211 again, which will not buffer it either as it
thinks the station is awake, and eventually the packets will be
dropped.
Fix this by moving the clearing of the flags to exactly where we
learn about the situation. This creates a problem of reordering,
so introduce another flag indicating that delivery is being done,
this new flag also queues frames and is cleared only while the
spinlock is held (which the queuing code also holds) so that any
concurrent delivery/TX is handled correctly.
Reported-by: Andrei Otcheretianski <andrei.otcheretianski@intel.com>
Signed-off-by: Johannes Berg <johannes.berg@intel.com>
2014-05-27 08:32:27 -06:00
|
|
|
return;
|
|
|
|
}
|
|
|
|
|
|
|
|
if (!test_sta_flag(sta, WLAN_STA_PS_DRIVER))
|
|
|
|
return;
|
|
|
|
|
|
|
|
if (!test_sta_flag(sta, WLAN_STA_PS_STA)) {
|
|
|
|
set_sta_flag(sta, WLAN_STA_PS_DELIVER);
|
|
|
|
clear_sta_flag(sta, WLAN_STA_PS_DRIVER);
|
|
|
|
ieee80211_queue_work(hw, &sta->drv_deliver_wk);
|
|
|
|
} else if (test_sta_flag(sta, WLAN_STA_PSPOLL) ||
|
|
|
|
test_sta_flag(sta, WLAN_STA_UAPSD)) {
|
|
|
|
/* must be asleep in this case */
|
|
|
|
clear_sta_flag(sta, WLAN_STA_PS_DRIVER);
|
|
|
|
ieee80211_queue_work(hw, &sta->drv_deliver_wk);
|
|
|
|
} else {
|
|
|
|
clear_sta_flag(sta, WLAN_STA_PS_DRIVER);
|
2015-03-21 08:25:43 -06:00
|
|
|
ieee80211_check_fast_xmit(sta);
|
mac80211: fix station/driver powersave race
It is currently possible to have a race due to the station PS
unblock work like this:
* station goes to sleep with frames buffered in the driver
* driver blocks wakeup
* station wakes up again
* driver flushes/returns frames, and unblocks, which schedules
the unblock work
* unblock work starts to run, and checks that the station is
awake (i.e. that the WLAN_STA_PS_STA flag isn't set)
* we process a received frame with PM=1, setting the flag again
* ieee80211_sta_ps_deliver_wakeup() runs, delivering all frames
to the driver, and then clearing the WLAN_STA_PS_DRIVER and
WLAN_STA_PS_STA flags
In this scenario, mac80211 will think that the station is awake,
while it really is asleep, and any TX'ed frames should be filtered
by the device (it will know that the station is sleeping) but then
passed to mac80211 again, which will not buffer it either as it
thinks the station is awake, and eventually the packets will be
dropped.
Fix this by moving the clearing of the flags to exactly where we
learn about the situation. This creates a problem of reordering,
so introduce another flag indicating that delivery is being done,
this new flag also queues frames and is cleared only while the
spinlock is held (which the queuing code also holds) so that any
concurrent delivery/TX is handled correctly.
Reported-by: Andrei Otcheretianski <andrei.otcheretianski@intel.com>
Signed-off-by: Johannes Berg <johannes.berg@intel.com>
2014-05-27 08:32:27 -06:00
|
|
|
}
|
mac80211: async station powersave handling
Some devices require that all frames to a station
are flushed when that station goes into powersave
mode before being able to send frames to that
station again when it wakes up or polls -- all in
order to avoid reordering and too many or too few
frames being sent to the station when it polls.
Normally, this is the case unless the station
goes to sleep and wakes up very quickly again.
But in that case, frames for it may be pending
on the hardware queues, and thus races could
happen in the case of multiple hardware queues
used for QoS/WMM. Normally this isn't a problem,
but with the iwlwifi mechanism we need to make
sure the race doesn't happen.
This makes mac80211 able to cope with the race
with driver help by a new WLAN_STA_PS_DRIVER
per-station flag that can be controlled by the
driver and tells mac80211 whether it can transmit
frames or not. This flag must be set according to
very specific rules outlined in the documentation
for the function that controls it.
When we buffer new frames for the station, we
normally set the TIM bit right away, but while
the driver has blocked transmission to that sta
we need to avoid that as well since we cannot
respond to the station if it wakes up due to the
TIM bit. Once the driver unblocks, we can set
the TIM bit.
Similarly, when the station just wakes up, we
need to wait until all other frames are flushed
before we can transmit frames to that station,
so the same applies here, we need to wait for
the driver to give the OK.
Signed-off-by: Johannes Berg <johannes@sipsolutions.net>
Signed-off-by: John W. Linville <linville@tuxdriver.com>
2009-11-06 03:35:50 -07:00
|
|
|
}
|
|
|
|
EXPORT_SYMBOL(ieee80211_sta_block_awake);
|
2011-04-17 09:45:00 -06:00
|
|
|
|
2013-02-15 13:38:08 -07:00
|
|
|
void ieee80211_sta_eosp(struct ieee80211_sta *pubsta)
|
2011-09-29 08:04:39 -06:00
|
|
|
{
|
|
|
|
struct sta_info *sta = container_of(pubsta, struct sta_info, sta);
|
|
|
|
struct ieee80211_local *local = sta->local;
|
|
|
|
|
|
|
|
trace_api_eosp(local, pubsta);
|
|
|
|
|
2013-02-15 13:38:08 -07:00
|
|
|
clear_sta_flag(sta, WLAN_STA_SP);
|
2011-09-29 08:04:39 -06:00
|
|
|
}
|
2013-02-15 13:38:08 -07:00
|
|
|
EXPORT_SYMBOL(ieee80211_sta_eosp);
|
2011-09-29 08:04:39 -06:00
|
|
|
|
2011-09-29 08:04:26 -06:00
|
|
|
void ieee80211_sta_set_buffered(struct ieee80211_sta *pubsta,
|
|
|
|
u8 tid, bool buffered)
|
2011-04-17 09:45:00 -06:00
|
|
|
{
|
|
|
|
struct sta_info *sta = container_of(pubsta, struct sta_info, sta);
|
|
|
|
|
2012-11-14 15:22:21 -07:00
|
|
|
if (WARN_ON(tid >= IEEE80211_NUM_TIDS))
|
2011-09-29 08:04:26 -06:00
|
|
|
return;
|
|
|
|
|
2013-12-19 02:47:48 -07:00
|
|
|
trace_api_sta_set_buffered(sta->local, pubsta, tid, buffered);
|
|
|
|
|
2011-09-29 08:04:29 -06:00
|
|
|
if (buffered)
|
|
|
|
set_bit(tid, &sta->driver_buffered_tids);
|
|
|
|
else
|
|
|
|
clear_bit(tid, &sta->driver_buffered_tids);
|
|
|
|
|
2011-09-29 08:04:27 -06:00
|
|
|
sta_info_recalc_tim(sta);
|
2011-04-17 09:45:00 -06:00
|
|
|
}
|
2011-09-29 08:04:26 -06:00
|
|
|
EXPORT_SYMBOL(ieee80211_sta_set_buffered);
|
2011-12-14 04:35:30 -07:00
|
|
|
|
2012-01-12 01:31:10 -07:00
|
|
|
int sta_info_move_state(struct sta_info *sta,
|
|
|
|
enum ieee80211_sta_state new_state)
|
2011-12-14 04:35:30 -07:00
|
|
|
{
|
2011-12-15 03:17:37 -07:00
|
|
|
might_sleep();
|
2011-12-14 04:35:30 -07:00
|
|
|
|
|
|
|
if (sta->sta_state == new_state)
|
|
|
|
return 0;
|
|
|
|
|
2012-01-20 05:55:21 -07:00
|
|
|
/* check allowed transitions first */
|
|
|
|
|
|
|
|
switch (new_state) {
|
|
|
|
case IEEE80211_STA_NONE:
|
|
|
|
if (sta->sta_state != IEEE80211_STA_AUTH)
|
|
|
|
return -EINVAL;
|
|
|
|
break;
|
|
|
|
case IEEE80211_STA_AUTH:
|
|
|
|
if (sta->sta_state != IEEE80211_STA_NONE &&
|
|
|
|
sta->sta_state != IEEE80211_STA_ASSOC)
|
|
|
|
return -EINVAL;
|
|
|
|
break;
|
|
|
|
case IEEE80211_STA_ASSOC:
|
|
|
|
if (sta->sta_state != IEEE80211_STA_AUTH &&
|
|
|
|
sta->sta_state != IEEE80211_STA_AUTHORIZED)
|
|
|
|
return -EINVAL;
|
|
|
|
break;
|
|
|
|
case IEEE80211_STA_AUTHORIZED:
|
|
|
|
if (sta->sta_state != IEEE80211_STA_ASSOC)
|
|
|
|
return -EINVAL;
|
|
|
|
break;
|
|
|
|
default:
|
|
|
|
WARN(1, "invalid state %d", new_state);
|
|
|
|
return -EINVAL;
|
|
|
|
}
|
|
|
|
|
2012-06-22 03:29:50 -06:00
|
|
|
sta_dbg(sta->sdata, "moving STA %pM to state %d\n",
|
|
|
|
sta->sta.addr, new_state);
|
2012-01-20 05:55:21 -07:00
|
|
|
|
|
|
|
/*
|
|
|
|
* notify the driver before the actual changes so it can
|
|
|
|
* fail the transition
|
|
|
|
*/
|
|
|
|
if (test_sta_flag(sta, WLAN_STA_INSERTED)) {
|
|
|
|
int err = drv_sta_state(sta->local, sta->sdata, sta,
|
|
|
|
sta->sta_state, new_state);
|
|
|
|
if (err)
|
|
|
|
return err;
|
|
|
|
}
|
|
|
|
|
|
|
|
/* reflect the change in all state variables */
|
|
|
|
|
2011-12-14 04:35:30 -07:00
|
|
|
switch (new_state) {
|
|
|
|
case IEEE80211_STA_NONE:
|
|
|
|
if (sta->sta_state == IEEE80211_STA_AUTH)
|
|
|
|
clear_bit(WLAN_STA_AUTH, &sta->_flags);
|
|
|
|
break;
|
|
|
|
case IEEE80211_STA_AUTH:
|
|
|
|
if (sta->sta_state == IEEE80211_STA_NONE)
|
|
|
|
set_bit(WLAN_STA_AUTH, &sta->_flags);
|
|
|
|
else if (sta->sta_state == IEEE80211_STA_ASSOC)
|
|
|
|
clear_bit(WLAN_STA_ASSOC, &sta->_flags);
|
|
|
|
break;
|
|
|
|
case IEEE80211_STA_ASSOC:
|
2011-12-14 04:20:31 -07:00
|
|
|
if (sta->sta_state == IEEE80211_STA_AUTH) {
|
2011-12-14 04:35:30 -07:00
|
|
|
set_bit(WLAN_STA_ASSOC, &sta->_flags);
|
2011-12-14 04:20:31 -07:00
|
|
|
} else if (sta->sta_state == IEEE80211_STA_AUTHORIZED) {
|
2012-04-23 11:49:03 -06:00
|
|
|
if (sta->sdata->vif.type == NL80211_IFTYPE_AP ||
|
|
|
|
(sta->sdata->vif.type == NL80211_IFTYPE_AP_VLAN &&
|
|
|
|
!sta->sdata->u.vlan.sta))
|
|
|
|
atomic_dec(&sta->sdata->bss->num_mcast_sta);
|
2011-12-14 04:35:30 -07:00
|
|
|
clear_bit(WLAN_STA_AUTHORIZED, &sta->_flags);
|
2015-03-21 08:25:43 -06:00
|
|
|
ieee80211_clear_fast_xmit(sta);
|
2012-01-20 05:55:21 -07:00
|
|
|
}
|
2011-12-14 04:35:30 -07:00
|
|
|
break;
|
|
|
|
case IEEE80211_STA_AUTHORIZED:
|
2011-12-14 04:20:31 -07:00
|
|
|
if (sta->sta_state == IEEE80211_STA_ASSOC) {
|
2012-04-23 11:49:03 -06:00
|
|
|
if (sta->sdata->vif.type == NL80211_IFTYPE_AP ||
|
|
|
|
(sta->sdata->vif.type == NL80211_IFTYPE_AP_VLAN &&
|
|
|
|
!sta->sdata->u.vlan.sta))
|
|
|
|
atomic_inc(&sta->sdata->bss->num_mcast_sta);
|
2011-12-14 04:35:30 -07:00
|
|
|
set_bit(WLAN_STA_AUTHORIZED, &sta->_flags);
|
2015-03-21 08:25:43 -06:00
|
|
|
ieee80211_check_fast_xmit(sta);
|
2012-01-20 05:55:21 -07:00
|
|
|
}
|
2011-12-14 04:35:30 -07:00
|
|
|
break;
|
|
|
|
default:
|
2012-01-20 05:55:21 -07:00
|
|
|
break;
|
2011-12-14 04:35:30 -07:00
|
|
|
}
|
|
|
|
|
|
|
|
sta->sta_state = new_state;
|
|
|
|
|
|
|
|
return 0;
|
|
|
|
}
|
2013-10-01 07:45:43 -06:00
|
|
|
|
|
|
|
u8 sta_info_tx_streams(struct sta_info *sta)
|
|
|
|
{
|
|
|
|
struct ieee80211_sta_ht_cap *ht_cap = &sta->sta.ht_cap;
|
|
|
|
u8 rx_streams;
|
|
|
|
|
|
|
|
if (!sta->sta.ht_cap.ht_supported)
|
|
|
|
return 1;
|
|
|
|
|
|
|
|
if (sta->sta.vht_cap.vht_supported) {
|
|
|
|
int i;
|
|
|
|
u16 tx_mcs_map =
|
|
|
|
le16_to_cpu(sta->sta.vht_cap.vht_mcs.tx_mcs_map);
|
|
|
|
|
|
|
|
for (i = 7; i >= 0; i--)
|
|
|
|
if ((tx_mcs_map & (0x3 << (i * 2))) !=
|
|
|
|
IEEE80211_VHT_MCS_NOT_SUPPORTED)
|
|
|
|
return i + 1;
|
|
|
|
}
|
|
|
|
|
|
|
|
if (ht_cap->mcs.rx_mask[3])
|
|
|
|
rx_streams = 4;
|
|
|
|
else if (ht_cap->mcs.rx_mask[2])
|
|
|
|
rx_streams = 3;
|
|
|
|
else if (ht_cap->mcs.rx_mask[1])
|
|
|
|
rx_streams = 2;
|
|
|
|
else
|
|
|
|
rx_streams = 1;
|
|
|
|
|
|
|
|
if (!(ht_cap->mcs.tx_params & IEEE80211_HT_MCS_TX_RX_DIFF))
|
|
|
|
return rx_streams;
|
|
|
|
|
|
|
|
return ((ht_cap->mcs.tx_params & IEEE80211_HT_MCS_TX_MAX_STREAMS_MASK)
|
|
|
|
>> IEEE80211_HT_MCS_TX_MAX_STREAMS_SHIFT) + 1;
|
|
|
|
}
|
2014-06-04 09:31:56 -06:00
|
|
|
|
|
|
|
void sta_set_sinfo(struct sta_info *sta, struct station_info *sinfo)
|
|
|
|
{
|
|
|
|
struct ieee80211_sub_if_data *sdata = sta->sdata;
|
|
|
|
struct ieee80211_local *local = sdata->local;
|
2014-07-25 08:22:36 -06:00
|
|
|
struct rate_control_ref *ref = NULL;
|
2014-06-04 09:31:56 -06:00
|
|
|
struct timespec uptime;
|
|
|
|
u32 thr = 0;
|
|
|
|
int i, ac;
|
|
|
|
|
2014-07-25 08:22:36 -06:00
|
|
|
if (test_sta_flag(sta, WLAN_STA_RATE_CONTROL))
|
|
|
|
ref = local->rate_ctrl;
|
|
|
|
|
2014-06-04 09:31:56 -06:00
|
|
|
sinfo->generation = sdata->local->sta_generation;
|
|
|
|
|
2015-01-21 13:09:02 -07:00
|
|
|
/* do before driver, so beacon filtering drivers have a
|
|
|
|
* chance to e.g. just add the number of filtered beacons
|
|
|
|
* (or just modify the value entirely, of course)
|
|
|
|
*/
|
|
|
|
if (sdata->vif.type == NL80211_IFTYPE_STATION)
|
|
|
|
sinfo->rx_beacon = sdata->u.mgd.count_beacon_signal;
|
|
|
|
|
2014-11-17 03:35:23 -07:00
|
|
|
drv_sta_statistics(local, sdata, &sta->sta, sinfo);
|
|
|
|
|
2014-11-17 06:08:11 -07:00
|
|
|
sinfo->filled |= BIT(NL80211_STA_INFO_INACTIVE_TIME) |
|
|
|
|
BIT(NL80211_STA_INFO_STA_FLAGS) |
|
|
|
|
BIT(NL80211_STA_INFO_BSS_PARAM) |
|
|
|
|
BIT(NL80211_STA_INFO_CONNECTED_TIME) |
|
|
|
|
BIT(NL80211_STA_INFO_RX_DROP_MISC) |
|
|
|
|
BIT(NL80211_STA_INFO_BEACON_LOSS);
|
2014-06-04 09:31:56 -06:00
|
|
|
|
2014-06-11 17:59:14 -06:00
|
|
|
ktime_get_ts(&uptime);
|
2014-06-04 09:31:56 -06:00
|
|
|
sinfo->connected_time = uptime.tv_sec - sta->last_connected;
|
|
|
|
sinfo->inactive_time = jiffies_to_msecs(jiffies - sta->last_rx);
|
2014-11-17 03:35:23 -07:00
|
|
|
|
2014-11-17 06:08:11 -07:00
|
|
|
if (!(sinfo->filled & (BIT(NL80211_STA_INFO_TX_BYTES64) |
|
|
|
|
BIT(NL80211_STA_INFO_TX_BYTES)))) {
|
2014-11-17 03:35:23 -07:00
|
|
|
sinfo->tx_bytes = 0;
|
|
|
|
for (ac = 0; ac < IEEE80211_NUM_ACS; ac++)
|
|
|
|
sinfo->tx_bytes += sta->tx_bytes[ac];
|
2014-11-17 06:08:11 -07:00
|
|
|
sinfo->filled |= BIT(NL80211_STA_INFO_TX_BYTES64);
|
2014-11-17 03:35:23 -07:00
|
|
|
}
|
|
|
|
|
2014-11-17 06:08:11 -07:00
|
|
|
if (!(sinfo->filled & BIT(NL80211_STA_INFO_TX_PACKETS))) {
|
2014-11-17 03:35:23 -07:00
|
|
|
sinfo->tx_packets = 0;
|
|
|
|
for (ac = 0; ac < IEEE80211_NUM_ACS; ac++)
|
|
|
|
sinfo->tx_packets += sta->tx_packets[ac];
|
2014-11-17 06:08:11 -07:00
|
|
|
sinfo->filled |= BIT(NL80211_STA_INFO_TX_PACKETS);
|
2014-11-17 03:35:23 -07:00
|
|
|
}
|
|
|
|
|
2014-11-17 06:08:11 -07:00
|
|
|
if (!(sinfo->filled & (BIT(NL80211_STA_INFO_RX_BYTES64) |
|
|
|
|
BIT(NL80211_STA_INFO_RX_BYTES)))) {
|
2014-11-17 03:35:23 -07:00
|
|
|
sinfo->rx_bytes = sta->rx_bytes;
|
2014-11-17 06:08:11 -07:00
|
|
|
sinfo->filled |= BIT(NL80211_STA_INFO_RX_BYTES64);
|
2014-11-17 03:35:23 -07:00
|
|
|
}
|
|
|
|
|
2014-11-17 06:08:11 -07:00
|
|
|
if (!(sinfo->filled & BIT(NL80211_STA_INFO_RX_PACKETS))) {
|
2014-11-17 03:35:23 -07:00
|
|
|
sinfo->rx_packets = sta->rx_packets;
|
2014-11-17 06:08:11 -07:00
|
|
|
sinfo->filled |= BIT(NL80211_STA_INFO_RX_PACKETS);
|
2014-11-17 03:35:23 -07:00
|
|
|
}
|
|
|
|
|
2014-11-17 06:08:11 -07:00
|
|
|
if (!(sinfo->filled & BIT(NL80211_STA_INFO_TX_RETRIES))) {
|
2014-11-17 03:35:23 -07:00
|
|
|
sinfo->tx_retries = sta->tx_retry_count;
|
2014-11-17 06:08:11 -07:00
|
|
|
sinfo->filled |= BIT(NL80211_STA_INFO_TX_RETRIES);
|
2014-11-17 03:35:23 -07:00
|
|
|
}
|
|
|
|
|
2014-11-17 06:08:11 -07:00
|
|
|
if (!(sinfo->filled & BIT(NL80211_STA_INFO_TX_FAILED))) {
|
2014-11-17 03:35:23 -07:00
|
|
|
sinfo->tx_failed = sta->tx_retry_failed;
|
2014-11-17 06:08:11 -07:00
|
|
|
sinfo->filled |= BIT(NL80211_STA_INFO_TX_FAILED);
|
2014-06-04 09:31:56 -06:00
|
|
|
}
|
2014-11-17 03:35:23 -07:00
|
|
|
|
2014-06-04 09:31:56 -06:00
|
|
|
sinfo->rx_dropped_misc = sta->rx_dropped;
|
|
|
|
sinfo->beacon_loss_count = sta->beacon_loss_count;
|
|
|
|
|
2015-01-21 13:09:02 -07:00
|
|
|
if (sdata->vif.type == NL80211_IFTYPE_STATION &&
|
|
|
|
!(sdata->vif.driver_flags & IEEE80211_VIF_BEACON_FILTER)) {
|
|
|
|
sinfo->filled |= BIT(NL80211_STA_INFO_BEACON_RX) |
|
|
|
|
BIT(NL80211_STA_INFO_BEACON_SIGNAL_AVG);
|
|
|
|
sinfo->rx_beacon_signal_avg = ieee80211_ave_rssi(&sdata->vif);
|
|
|
|
}
|
|
|
|
|
2015-06-02 13:39:54 -06:00
|
|
|
if (ieee80211_hw_check(&sta->local->hw, SIGNAL_DBM) ||
|
|
|
|
ieee80211_hw_check(&sta->local->hw, SIGNAL_UNSPEC)) {
|
2014-11-17 06:08:11 -07:00
|
|
|
if (!(sinfo->filled & BIT(NL80211_STA_INFO_SIGNAL))) {
|
2014-06-04 09:31:56 -06:00
|
|
|
sinfo->signal = (s8)sta->last_signal;
|
2014-11-17 06:08:11 -07:00
|
|
|
sinfo->filled |= BIT(NL80211_STA_INFO_SIGNAL);
|
2014-11-17 03:35:23 -07:00
|
|
|
}
|
|
|
|
|
2014-11-17 06:08:11 -07:00
|
|
|
if (!(sinfo->filled & BIT(NL80211_STA_INFO_SIGNAL_AVG))) {
|
2015-07-13 04:26:46 -06:00
|
|
|
sinfo->signal_avg =
|
|
|
|
(s8) -ewma_signal_read(&sta->avg_signal);
|
2014-11-17 06:08:11 -07:00
|
|
|
sinfo->filled |= BIT(NL80211_STA_INFO_SIGNAL_AVG);
|
2014-11-17 03:35:23 -07:00
|
|
|
}
|
2014-06-04 09:31:56 -06:00
|
|
|
}
|
2014-11-17 03:35:23 -07:00
|
|
|
|
|
|
|
if (sta->chains &&
|
2014-11-17 06:08:11 -07:00
|
|
|
!(sinfo->filled & (BIT(NL80211_STA_INFO_CHAIN_SIGNAL) |
|
|
|
|
BIT(NL80211_STA_INFO_CHAIN_SIGNAL_AVG)))) {
|
|
|
|
sinfo->filled |= BIT(NL80211_STA_INFO_CHAIN_SIGNAL) |
|
|
|
|
BIT(NL80211_STA_INFO_CHAIN_SIGNAL_AVG);
|
2014-06-04 09:31:56 -06:00
|
|
|
|
|
|
|
sinfo->chains = sta->chains;
|
|
|
|
for (i = 0; i < ARRAY_SIZE(sinfo->chain_signal); i++) {
|
|
|
|
sinfo->chain_signal[i] = sta->chain_signal_last[i];
|
|
|
|
sinfo->chain_signal_avg[i] =
|
2015-07-13 04:26:46 -06:00
|
|
|
(s8) -ewma_signal_read(&sta->chain_signal_avg[i]);
|
2014-06-04 09:31:56 -06:00
|
|
|
}
|
|
|
|
}
|
|
|
|
|
2014-11-17 06:08:11 -07:00
|
|
|
if (!(sinfo->filled & BIT(NL80211_STA_INFO_TX_BITRATE))) {
|
2014-11-17 03:35:23 -07:00
|
|
|
sta_set_rate_info_tx(sta, &sta->last_tx_rate, &sinfo->txrate);
|
2014-11-17 06:08:11 -07:00
|
|
|
sinfo->filled |= BIT(NL80211_STA_INFO_TX_BITRATE);
|
2014-11-17 03:35:23 -07:00
|
|
|
}
|
|
|
|
|
2014-11-17 06:08:11 -07:00
|
|
|
if (!(sinfo->filled & BIT(NL80211_STA_INFO_RX_BITRATE))) {
|
2014-11-17 03:35:23 -07:00
|
|
|
sta_set_rate_info_rx(sta, &sinfo->rxrate);
|
2014-11-17 06:08:11 -07:00
|
|
|
sinfo->filled |= BIT(NL80211_STA_INFO_RX_BITRATE);
|
2014-11-17 03:35:23 -07:00
|
|
|
}
|
2014-06-04 09:31:56 -06:00
|
|
|
|
2014-11-21 06:26:31 -07:00
|
|
|
sinfo->filled |= BIT(NL80211_STA_INFO_TID_STATS);
|
|
|
|
for (i = 0; i < IEEE80211_NUM_TIDS + 1; i++) {
|
|
|
|
struct cfg80211_tid_stats *tidstats = &sinfo->pertid[i];
|
|
|
|
|
|
|
|
if (!(tidstats->filled & BIT(NL80211_TID_STATS_RX_MSDU))) {
|
|
|
|
tidstats->filled |= BIT(NL80211_TID_STATS_RX_MSDU);
|
|
|
|
tidstats->rx_msdu = sta->rx_msdu[i];
|
|
|
|
}
|
|
|
|
|
|
|
|
if (!(tidstats->filled & BIT(NL80211_TID_STATS_TX_MSDU))) {
|
|
|
|
tidstats->filled |= BIT(NL80211_TID_STATS_TX_MSDU);
|
|
|
|
tidstats->tx_msdu = sta->tx_msdu[i];
|
|
|
|
}
|
|
|
|
|
|
|
|
if (!(tidstats->filled &
|
|
|
|
BIT(NL80211_TID_STATS_TX_MSDU_RETRIES)) &&
|
2015-06-02 13:39:54 -06:00
|
|
|
ieee80211_hw_check(&local->hw, REPORTS_TX_ACK_STATUS)) {
|
2014-11-21 06:26:31 -07:00
|
|
|
tidstats->filled |=
|
|
|
|
BIT(NL80211_TID_STATS_TX_MSDU_RETRIES);
|
|
|
|
tidstats->tx_msdu_retries = sta->tx_msdu_retries[i];
|
|
|
|
}
|
|
|
|
|
|
|
|
if (!(tidstats->filled &
|
|
|
|
BIT(NL80211_TID_STATS_TX_MSDU_FAILED)) &&
|
2015-06-02 13:39:54 -06:00
|
|
|
ieee80211_hw_check(&local->hw, REPORTS_TX_ACK_STATUS)) {
|
2014-11-21 06:26:31 -07:00
|
|
|
tidstats->filled |=
|
|
|
|
BIT(NL80211_TID_STATS_TX_MSDU_FAILED);
|
|
|
|
tidstats->tx_msdu_failed = sta->tx_msdu_failed[i];
|
|
|
|
}
|
|
|
|
}
|
|
|
|
|
2014-06-04 09:31:56 -06:00
|
|
|
if (ieee80211_vif_is_mesh(&sdata->vif)) {
|
|
|
|
#ifdef CONFIG_MAC80211_MESH
|
2014-11-17 06:08:11 -07:00
|
|
|
sinfo->filled |= BIT(NL80211_STA_INFO_LLID) |
|
|
|
|
BIT(NL80211_STA_INFO_PLID) |
|
|
|
|
BIT(NL80211_STA_INFO_PLINK_STATE) |
|
|
|
|
BIT(NL80211_STA_INFO_LOCAL_PM) |
|
|
|
|
BIT(NL80211_STA_INFO_PEER_PM) |
|
|
|
|
BIT(NL80211_STA_INFO_NONPEER_PM);
|
2014-06-04 09:31:56 -06:00
|
|
|
|
2015-06-17 02:31:00 -06:00
|
|
|
sinfo->llid = sta->mesh->llid;
|
|
|
|
sinfo->plid = sta->mesh->plid;
|
|
|
|
sinfo->plink_state = sta->mesh->plink_state;
|
2014-06-04 09:31:56 -06:00
|
|
|
if (test_sta_flag(sta, WLAN_STA_TOFFSET_KNOWN)) {
|
2014-11-17 06:08:11 -07:00
|
|
|
sinfo->filled |= BIT(NL80211_STA_INFO_T_OFFSET);
|
2015-06-17 02:31:00 -06:00
|
|
|
sinfo->t_offset = sta->mesh->t_offset;
|
2014-06-04 09:31:56 -06:00
|
|
|
}
|
2015-06-17 02:31:00 -06:00
|
|
|
sinfo->local_pm = sta->mesh->local_pm;
|
|
|
|
sinfo->peer_pm = sta->mesh->peer_pm;
|
|
|
|
sinfo->nonpeer_pm = sta->mesh->nonpeer_pm;
|
2014-06-04 09:31:56 -06:00
|
|
|
#endif
|
|
|
|
}
|
|
|
|
|
|
|
|
sinfo->bss_param.flags = 0;
|
|
|
|
if (sdata->vif.bss_conf.use_cts_prot)
|
|
|
|
sinfo->bss_param.flags |= BSS_PARAM_FLAGS_CTS_PROT;
|
|
|
|
if (sdata->vif.bss_conf.use_short_preamble)
|
|
|
|
sinfo->bss_param.flags |= BSS_PARAM_FLAGS_SHORT_PREAMBLE;
|
|
|
|
if (sdata->vif.bss_conf.use_short_slot)
|
|
|
|
sinfo->bss_param.flags |= BSS_PARAM_FLAGS_SHORT_SLOT_TIME;
|
2014-09-03 06:25:04 -06:00
|
|
|
sinfo->bss_param.dtim_period = sdata->vif.bss_conf.dtim_period;
|
2014-06-04 09:31:56 -06:00
|
|
|
sinfo->bss_param.beacon_interval = sdata->vif.bss_conf.beacon_int;
|
|
|
|
|
|
|
|
sinfo->sta_flags.set = 0;
|
|
|
|
sinfo->sta_flags.mask = BIT(NL80211_STA_FLAG_AUTHORIZED) |
|
|
|
|
BIT(NL80211_STA_FLAG_SHORT_PREAMBLE) |
|
|
|
|
BIT(NL80211_STA_FLAG_WME) |
|
|
|
|
BIT(NL80211_STA_FLAG_MFP) |
|
|
|
|
BIT(NL80211_STA_FLAG_AUTHENTICATED) |
|
|
|
|
BIT(NL80211_STA_FLAG_ASSOCIATED) |
|
|
|
|
BIT(NL80211_STA_FLAG_TDLS_PEER);
|
|
|
|
if (test_sta_flag(sta, WLAN_STA_AUTHORIZED))
|
|
|
|
sinfo->sta_flags.set |= BIT(NL80211_STA_FLAG_AUTHORIZED);
|
|
|
|
if (test_sta_flag(sta, WLAN_STA_SHORT_PREAMBLE))
|
|
|
|
sinfo->sta_flags.set |= BIT(NL80211_STA_FLAG_SHORT_PREAMBLE);
|
2014-07-22 06:50:47 -06:00
|
|
|
if (sta->sta.wme)
|
2014-06-04 09:31:56 -06:00
|
|
|
sinfo->sta_flags.set |= BIT(NL80211_STA_FLAG_WME);
|
|
|
|
if (test_sta_flag(sta, WLAN_STA_MFP))
|
|
|
|
sinfo->sta_flags.set |= BIT(NL80211_STA_FLAG_MFP);
|
|
|
|
if (test_sta_flag(sta, WLAN_STA_AUTH))
|
|
|
|
sinfo->sta_flags.set |= BIT(NL80211_STA_FLAG_AUTHENTICATED);
|
|
|
|
if (test_sta_flag(sta, WLAN_STA_ASSOC))
|
|
|
|
sinfo->sta_flags.set |= BIT(NL80211_STA_FLAG_ASSOCIATED);
|
|
|
|
if (test_sta_flag(sta, WLAN_STA_TDLS_PEER))
|
|
|
|
sinfo->sta_flags.set |= BIT(NL80211_STA_FLAG_TDLS_PEER);
|
|
|
|
|
|
|
|
/* check if the driver has a SW RC implementation */
|
|
|
|
if (ref && ref->ops->get_expected_throughput)
|
|
|
|
thr = ref->ops->get_expected_throughput(sta->rate_ctrl_priv);
|
|
|
|
else
|
|
|
|
thr = drv_get_expected_throughput(local, &sta->sta);
|
|
|
|
|
|
|
|
if (thr != 0) {
|
2014-11-17 06:08:11 -07:00
|
|
|
sinfo->filled |= BIT(NL80211_STA_INFO_EXPECTED_THROUGHPUT);
|
2014-06-04 09:31:56 -06:00
|
|
|
sinfo->expected_throughput = thr;
|
|
|
|
}
|
|
|
|
}
|