2006-01-02 11:04:38 -07:00
|
|
|
/*
|
|
|
|
* net/tipc/name_distr.c: TIPC name distribution code
|
2007-02-09 07:25:21 -07:00
|
|
|
*
|
tipc: add name distributor resiliency queue
TIPC name table updates are distributed asynchronously in a cluster,
entailing a risk of certain race conditions. E.g., if two nodes
simultaneously issue conflicting (overlapping) publications, this may
not be detected until both publications have reached a third node, in
which case one of the publications will be silently dropped on that
node. Hence, we end up with an inconsistent name table.
In most cases this conflict is just a temporary race, e.g., one
node is issuing a publication under the assumption that a previous,
conflicting, publication has already been withdrawn by the other node.
However, because of the (rtt related) distributed update delay, this
may not yet hold true on all nodes. The symptom of this failure is a
syslog message: "tipc: Cannot publish {%u,%u,%u}, overlap error".
In this commit we add a resiliency queue at the receiving end of
the name table distributor. When insertion of an arriving publication
fails, we retain it in this queue for a short amount of time, assuming
that another update will arrive very soon and clear the conflict. If so
happens, we insert the publication, otherwise we drop it.
The (configurable) retention value defaults to 2000 ms. Knowing from
experience that the situation described above is extremely rare, there
is no risk that the queue will accumulate any large number of items.
Signed-off-by: Erik Hugne <erik.hugne@ericsson.com>
Signed-off-by: Jon Maloy <jon.maloy@ericsson.com>
Acked-by: Ying Xue <ying.xue@windriver.com>
Signed-off-by: David S. Miller <davem@davemloft.net>
2014-08-28 01:08:47 -06:00
|
|
|
* Copyright (c) 2000-2006, 2014, Ericsson AB
|
2011-02-23 11:51:15 -07:00
|
|
|
* Copyright (c) 2005, 2010-2011, Wind River Systems
|
2006-01-02 11:04:38 -07:00
|
|
|
* All rights reserved.
|
|
|
|
*
|
2006-01-11 05:30:43 -07:00
|
|
|
* Redistribution and use in source and binary forms, with or without
|
2006-01-02 11:04:38 -07:00
|
|
|
* modification, are permitted provided that the following conditions are met:
|
|
|
|
*
|
2006-01-11 05:30:43 -07:00
|
|
|
* 1. Redistributions of source code must retain the above copyright
|
|
|
|
* notice, this list of conditions and the following disclaimer.
|
|
|
|
* 2. Redistributions in binary form must reproduce the above copyright
|
|
|
|
* notice, this list of conditions and the following disclaimer in the
|
|
|
|
* documentation and/or other materials provided with the distribution.
|
|
|
|
* 3. Neither the names of the copyright holders nor the names of its
|
|
|
|
* contributors may be used to endorse or promote products derived from
|
|
|
|
* this software without specific prior written permission.
|
2006-01-02 11:04:38 -07:00
|
|
|
*
|
2006-01-11 05:30:43 -07:00
|
|
|
* Alternatively, this software may be distributed under the terms of the
|
|
|
|
* GNU General Public License ("GPL") version 2 as published by the Free
|
|
|
|
* Software Foundation.
|
|
|
|
*
|
|
|
|
* THIS SOFTWARE IS PROVIDED BY THE COPYRIGHT HOLDERS AND CONTRIBUTORS "AS IS"
|
|
|
|
* AND ANY EXPRESS OR IMPLIED WARRANTIES, INCLUDING, BUT NOT LIMITED TO, THE
|
|
|
|
* IMPLIED WARRANTIES OF MERCHANTABILITY AND FITNESS FOR A PARTICULAR PURPOSE
|
|
|
|
* ARE DISCLAIMED. IN NO EVENT SHALL THE COPYRIGHT OWNER OR CONTRIBUTORS BE
|
|
|
|
* LIABLE FOR ANY DIRECT, INDIRECT, INCIDENTAL, SPECIAL, EXEMPLARY, OR
|
|
|
|
* CONSEQUENTIAL DAMAGES (INCLUDING, BUT NOT LIMITED TO, PROCUREMENT OF
|
|
|
|
* SUBSTITUTE GOODS OR SERVICES; LOSS OF USE, DATA, OR PROFITS; OR BUSINESS
|
|
|
|
* INTERRUPTION) HOWEVER CAUSED AND ON ANY THEORY OF LIABILITY, WHETHER IN
|
|
|
|
* CONTRACT, STRICT LIABILITY, OR TORT (INCLUDING NEGLIGENCE OR OTHERWISE)
|
|
|
|
* ARISING IN ANY WAY OUT OF THE USE OF THIS SOFTWARE, EVEN IF ADVISED OF THE
|
2006-01-02 11:04:38 -07:00
|
|
|
* POSSIBILITY OF SUCH DAMAGE.
|
|
|
|
*/
|
|
|
|
|
|
|
|
#include "core.h"
|
|
|
|
#include "link.h"
|
|
|
|
#include "name_distr.h"
|
|
|
|
|
tipc: add name distributor resiliency queue
TIPC name table updates are distributed asynchronously in a cluster,
entailing a risk of certain race conditions. E.g., if two nodes
simultaneously issue conflicting (overlapping) publications, this may
not be detected until both publications have reached a third node, in
which case one of the publications will be silently dropped on that
node. Hence, we end up with an inconsistent name table.
In most cases this conflict is just a temporary race, e.g., one
node is issuing a publication under the assumption that a previous,
conflicting, publication has already been withdrawn by the other node.
However, because of the (rtt related) distributed update delay, this
may not yet hold true on all nodes. The symptom of this failure is a
syslog message: "tipc: Cannot publish {%u,%u,%u}, overlap error".
In this commit we add a resiliency queue at the receiving end of
the name table distributor. When insertion of an arriving publication
fails, we retain it in this queue for a short amount of time, assuming
that another update will arrive very soon and clear the conflict. If so
happens, we insert the publication, otherwise we drop it.
The (configurable) retention value defaults to 2000 ms. Knowing from
experience that the situation described above is extremely rare, there
is no risk that the queue will accumulate any large number of items.
Signed-off-by: Erik Hugne <erik.hugne@ericsson.com>
Signed-off-by: Jon Maloy <jon.maloy@ericsson.com>
Acked-by: Ying Xue <ying.xue@windriver.com>
Signed-off-by: David S. Miller <davem@davemloft.net>
2014-08-28 01:08:47 -06:00
|
|
|
int sysctl_tipc_named_timeout __read_mostly = 2000;
|
|
|
|
|
|
|
|
struct distr_queue_item {
|
|
|
|
struct distr_item i;
|
|
|
|
u32 dtype;
|
|
|
|
u32 node;
|
|
|
|
unsigned long expires;
|
|
|
|
struct list_head next;
|
|
|
|
};
|
|
|
|
|
2006-01-02 11:04:38 -07:00
|
|
|
/**
|
|
|
|
* publ_to_item - add publication info to a publication message
|
|
|
|
*/
|
|
|
|
static void publ_to_item(struct distr_item *i, struct publication *p)
|
|
|
|
{
|
|
|
|
i->type = htonl(p->type);
|
|
|
|
i->lower = htonl(p->lower);
|
|
|
|
i->upper = htonl(p->upper);
|
|
|
|
i->ref = htonl(p->ref);
|
|
|
|
i->key = htonl(p->key);
|
|
|
|
}
|
|
|
|
|
|
|
|
/**
|
|
|
|
* named_prepare_buf - allocate & initialize a publication message
|
|
|
|
*/
|
2015-01-09 00:27:10 -07:00
|
|
|
static struct sk_buff *named_prepare_buf(struct net *net, u32 type, u32 size,
|
|
|
|
u32 dest)
|
2006-01-02 11:04:38 -07:00
|
|
|
{
|
2015-02-05 06:36:36 -07:00
|
|
|
struct tipc_net *tn = net_generic(net, tipc_net_id);
|
2011-05-31 13:03:18 -06:00
|
|
|
struct sk_buff *buf = tipc_buf_acquire(INT_H_SIZE + size);
|
2006-01-02 11:04:38 -07:00
|
|
|
struct tipc_msg *msg;
|
|
|
|
|
|
|
|
if (buf != NULL) {
|
|
|
|
msg = buf_msg(buf);
|
2015-02-05 06:36:36 -07:00
|
|
|
tipc_msg_init(tn->own_addr, msg, NAME_DISTRIBUTOR, type,
|
|
|
|
INT_H_SIZE, dest);
|
2011-05-31 13:03:18 -06:00
|
|
|
msg_set_size(msg, INT_H_SIZE + size);
|
2006-01-02 11:04:38 -07:00
|
|
|
}
|
|
|
|
return buf;
|
|
|
|
}
|
|
|
|
|
|
|
|
/**
|
2006-01-17 16:38:21 -07:00
|
|
|
* tipc_named_publish - tell other nodes about a new publication by this node
|
2006-01-02 11:04:38 -07:00
|
|
|
*/
|
2015-01-09 00:27:09 -07:00
|
|
|
struct sk_buff *tipc_named_publish(struct net *net, struct publication *publ)
|
2006-01-02 11:04:38 -07:00
|
|
|
{
|
2015-01-09 00:27:09 -07:00
|
|
|
struct tipc_net *tn = net_generic(net, tipc_net_id);
|
2006-01-02 11:04:38 -07:00
|
|
|
struct sk_buff *buf;
|
|
|
|
struct distr_item *item;
|
|
|
|
|
2014-12-02 00:00:30 -07:00
|
|
|
list_add_tail_rcu(&publ->local_list,
|
2015-01-09 00:27:09 -07:00
|
|
|
&tn->nametbl->publ_list[publ->scope]);
|
2006-01-02 11:04:38 -07:00
|
|
|
|
2012-04-17 15:57:52 -06:00
|
|
|
if (publ->scope == TIPC_NODE_SCOPE)
|
2014-04-28 04:00:10 -06:00
|
|
|
return NULL;
|
2012-04-17 15:57:52 -06:00
|
|
|
|
2015-01-09 00:27:10 -07:00
|
|
|
buf = named_prepare_buf(net, PUBLICATION, ITEM_SIZE, 0);
|
2006-01-02 11:04:38 -07:00
|
|
|
if (!buf) {
|
2012-06-28 22:16:37 -06:00
|
|
|
pr_warn("Publication distribution failure\n");
|
2014-04-28 04:00:10 -06:00
|
|
|
return NULL;
|
2006-01-02 11:04:38 -07:00
|
|
|
}
|
|
|
|
|
|
|
|
item = (struct distr_item *)msg_data(buf_msg(buf));
|
|
|
|
publ_to_item(item, publ);
|
2014-04-28 04:00:10 -06:00
|
|
|
return buf;
|
2006-01-02 11:04:38 -07:00
|
|
|
}
|
|
|
|
|
|
|
|
/**
|
2006-01-17 16:38:21 -07:00
|
|
|
* tipc_named_withdraw - tell other nodes about a withdrawn publication by this node
|
2006-01-02 11:04:38 -07:00
|
|
|
*/
|
2015-01-09 00:27:10 -07:00
|
|
|
struct sk_buff *tipc_named_withdraw(struct net *net, struct publication *publ)
|
2006-01-02 11:04:38 -07:00
|
|
|
{
|
|
|
|
struct sk_buff *buf;
|
|
|
|
struct distr_item *item;
|
|
|
|
|
|
|
|
list_del(&publ->local_list);
|
|
|
|
|
2012-04-17 15:57:52 -06:00
|
|
|
if (publ->scope == TIPC_NODE_SCOPE)
|
2014-04-28 04:00:10 -06:00
|
|
|
return NULL;
|
2012-04-17 15:57:52 -06:00
|
|
|
|
2015-01-09 00:27:10 -07:00
|
|
|
buf = named_prepare_buf(net, WITHDRAWAL, ITEM_SIZE, 0);
|
2006-01-02 11:04:38 -07:00
|
|
|
if (!buf) {
|
2012-06-28 22:16:37 -06:00
|
|
|
pr_warn("Withdrawal distribution failure\n");
|
2014-04-28 04:00:10 -06:00
|
|
|
return NULL;
|
2006-01-02 11:04:38 -07:00
|
|
|
}
|
|
|
|
|
|
|
|
item = (struct distr_item *)msg_data(buf_msg(buf));
|
|
|
|
publ_to_item(item, publ);
|
2014-04-28 04:00:10 -06:00
|
|
|
return buf;
|
2006-01-02 11:04:38 -07:00
|
|
|
}
|
|
|
|
|
2014-07-16 18:40:58 -06:00
|
|
|
/**
|
2012-04-17 15:57:52 -06:00
|
|
|
* named_distribute - prepare name info for bulk distribution to another node
|
2014-11-25 20:41:55 -07:00
|
|
|
* @list: list of messages (buffers) to be returned from this function
|
2014-07-16 18:40:58 -06:00
|
|
|
* @dnode: node to be updated
|
|
|
|
* @pls: linked list of publication items to be packed into buffer chain
|
2012-04-17 15:57:52 -06:00
|
|
|
*/
|
2015-01-09 00:27:05 -07:00
|
|
|
static void named_distribute(struct net *net, struct sk_buff_head *list,
|
|
|
|
u32 dnode, struct list_head *pls)
|
2012-04-17 15:57:52 -06:00
|
|
|
{
|
|
|
|
struct publication *publ;
|
2014-11-25 20:41:55 -07:00
|
|
|
struct sk_buff *skb = NULL;
|
2012-04-17 15:57:52 -06:00
|
|
|
struct distr_item *item = NULL;
|
2015-01-09 00:27:05 -07:00
|
|
|
uint msg_dsz = (tipc_node_get_mtu(net, dnode, 0) / ITEM_SIZE) *
|
|
|
|
ITEM_SIZE;
|
2014-12-02 00:00:23 -07:00
|
|
|
uint msg_rem = msg_dsz;
|
2012-04-17 15:57:52 -06:00
|
|
|
|
2014-12-02 00:00:24 -07:00
|
|
|
list_for_each_entry(publ, pls, local_list) {
|
2014-07-16 18:40:58 -06:00
|
|
|
/* Prepare next buffer: */
|
2014-11-25 20:41:55 -07:00
|
|
|
if (!skb) {
|
2015-01-09 00:27:10 -07:00
|
|
|
skb = named_prepare_buf(net, PUBLICATION, msg_rem,
|
|
|
|
dnode);
|
2014-11-25 20:41:55 -07:00
|
|
|
if (!skb) {
|
2012-06-28 22:16:37 -06:00
|
|
|
pr_warn("Bulk publication failure\n");
|
2012-04-17 15:57:52 -06:00
|
|
|
return;
|
|
|
|
}
|
2014-11-25 20:41:55 -07:00
|
|
|
item = (struct distr_item *)msg_data(buf_msg(skb));
|
2012-04-17 15:57:52 -06:00
|
|
|
}
|
2014-07-16 18:40:58 -06:00
|
|
|
|
|
|
|
/* Pack publication into message: */
|
2012-04-17 15:57:52 -06:00
|
|
|
publ_to_item(item, publ);
|
|
|
|
item++;
|
2014-07-16 18:40:58 -06:00
|
|
|
msg_rem -= ITEM_SIZE;
|
|
|
|
|
|
|
|
/* Append full buffer to list: */
|
|
|
|
if (!msg_rem) {
|
2014-11-25 20:41:55 -07:00
|
|
|
__skb_queue_tail(list, skb);
|
|
|
|
skb = NULL;
|
2014-12-02 00:00:23 -07:00
|
|
|
msg_rem = msg_dsz;
|
2012-04-17 15:57:52 -06:00
|
|
|
}
|
|
|
|
}
|
2014-12-02 00:00:23 -07:00
|
|
|
if (skb) {
|
|
|
|
msg_set_size(buf_msg(skb), INT_H_SIZE + (msg_dsz - msg_rem));
|
|
|
|
skb_trim(skb, INT_H_SIZE + (msg_dsz - msg_rem));
|
|
|
|
__skb_queue_tail(list, skb);
|
|
|
|
}
|
2012-04-17 15:57:52 -06:00
|
|
|
}
|
|
|
|
|
2006-01-02 11:04:38 -07:00
|
|
|
/**
|
2006-01-17 16:38:21 -07:00
|
|
|
* tipc_named_node_up - tell specified node about all publications by this node
|
2006-01-02 11:04:38 -07:00
|
|
|
*/
|
2015-01-09 00:27:05 -07:00
|
|
|
void tipc_named_node_up(struct net *net, u32 dnode)
|
2006-01-02 11:04:38 -07:00
|
|
|
{
|
2015-01-09 00:27:09 -07:00
|
|
|
struct tipc_net *tn = net_generic(net, tipc_net_id);
|
2014-11-25 20:41:55 -07:00
|
|
|
struct sk_buff_head head;
|
|
|
|
|
|
|
|
__skb_queue_head_init(&head);
|
2011-05-31 11:38:02 -06:00
|
|
|
|
2014-12-02 00:00:30 -07:00
|
|
|
rcu_read_lock();
|
2015-01-09 00:27:05 -07:00
|
|
|
named_distribute(net, &head, dnode,
|
2015-01-09 00:27:09 -07:00
|
|
|
&tn->nametbl->publ_list[TIPC_CLUSTER_SCOPE]);
|
2015-01-09 00:27:05 -07:00
|
|
|
named_distribute(net, &head, dnode,
|
2015-01-09 00:27:09 -07:00
|
|
|
&tn->nametbl->publ_list[TIPC_ZONE_SCOPE]);
|
2014-12-02 00:00:30 -07:00
|
|
|
rcu_read_unlock();
|
2011-05-31 11:38:02 -06:00
|
|
|
|
2015-10-22 06:51:47 -06:00
|
|
|
tipc_node_xmit(net, &head, dnode, 0);
|
2006-01-02 11:04:38 -07:00
|
|
|
}
|
|
|
|
|
|
|
|
/**
|
2014-11-25 20:41:45 -07:00
|
|
|
* tipc_publ_purge - remove publication associated with a failed node
|
2007-02-09 07:25:21 -07:00
|
|
|
*
|
|
|
|
* Invoked for each publication issued by a newly failed node.
|
2006-01-02 11:04:38 -07:00
|
|
|
* Removes publication structure from name table & deletes it.
|
|
|
|
*/
|
2015-01-09 00:27:05 -07:00
|
|
|
static void tipc_publ_purge(struct net *net, struct publication *publ, u32 addr)
|
2006-01-02 11:04:38 -07:00
|
|
|
{
|
2015-01-09 00:27:09 -07:00
|
|
|
struct tipc_net *tn = net_generic(net, tipc_net_id);
|
2006-01-02 11:04:38 -07:00
|
|
|
struct publication *p;
|
2006-06-26 00:51:37 -06:00
|
|
|
|
2015-01-09 00:27:09 -07:00
|
|
|
spin_lock_bh(&tn->nametbl_lock);
|
|
|
|
p = tipc_nametbl_remove_publ(net, publ->type, publ->lower,
|
2006-01-17 16:38:21 -07:00
|
|
|
publ->node, publ->ref, publ->key);
|
2011-02-23 11:51:15 -07:00
|
|
|
if (p)
|
2015-11-19 12:30:42 -07:00
|
|
|
tipc_node_unsubscribe(net, &p->nodesub_list, addr);
|
2015-01-09 00:27:09 -07:00
|
|
|
spin_unlock_bh(&tn->nametbl_lock);
|
2006-06-26 00:51:37 -06:00
|
|
|
|
2007-02-09 07:25:21 -07:00
|
|
|
if (p != publ) {
|
2012-06-28 22:16:37 -06:00
|
|
|
pr_err("Unable to remove publication from failed node\n"
|
|
|
|
" (type=%u, lower=%u, node=0x%x, ref=%u, key=%u)\n",
|
|
|
|
publ->type, publ->lower, publ->node, publ->ref,
|
|
|
|
publ->key);
|
2006-06-26 00:51:37 -06:00
|
|
|
}
|
|
|
|
|
2014-12-02 00:00:30 -07:00
|
|
|
kfree_rcu(p, rcu);
|
2006-01-02 11:04:38 -07:00
|
|
|
}
|
|
|
|
|
2016-04-07 08:40:44 -06:00
|
|
|
/**
|
|
|
|
* tipc_dist_queue_purge - remove deferred updates from a node that went down
|
|
|
|
*/
|
|
|
|
static void tipc_dist_queue_purge(struct net *net, u32 addr)
|
|
|
|
{
|
|
|
|
struct tipc_net *tn = net_generic(net, tipc_net_id);
|
|
|
|
struct distr_queue_item *e, *tmp;
|
|
|
|
|
|
|
|
spin_lock_bh(&tn->nametbl_lock);
|
|
|
|
list_for_each_entry_safe(e, tmp, &tn->dist_queue, next) {
|
|
|
|
if (e->node != addr)
|
|
|
|
continue;
|
|
|
|
list_del(&e->next);
|
|
|
|
kfree(e);
|
|
|
|
}
|
|
|
|
spin_unlock_bh(&tn->nametbl_lock);
|
|
|
|
}
|
|
|
|
|
2015-01-09 00:27:05 -07:00
|
|
|
void tipc_publ_notify(struct net *net, struct list_head *nsub_list, u32 addr)
|
2014-11-25 20:41:45 -07:00
|
|
|
{
|
|
|
|
struct publication *publ, *tmp;
|
|
|
|
|
|
|
|
list_for_each_entry_safe(publ, tmp, nsub_list, nodesub_list)
|
2015-01-09 00:27:05 -07:00
|
|
|
tipc_publ_purge(net, publ, addr);
|
2016-04-07 08:40:44 -06:00
|
|
|
tipc_dist_queue_purge(net, addr);
|
2014-11-25 20:41:45 -07:00
|
|
|
}
|
|
|
|
|
2014-08-28 01:08:46 -06:00
|
|
|
/**
|
|
|
|
* tipc_update_nametbl - try to process a nametable update and notify
|
|
|
|
* subscribers
|
|
|
|
*
|
|
|
|
* tipc_nametbl_lock must be held.
|
|
|
|
* Returns the publication item if successful, otherwise NULL.
|
|
|
|
*/
|
2015-01-09 00:27:05 -07:00
|
|
|
static bool tipc_update_nametbl(struct net *net, struct distr_item *i,
|
|
|
|
u32 node, u32 dtype)
|
2014-08-28 01:08:46 -06:00
|
|
|
{
|
|
|
|
struct publication *publ = NULL;
|
|
|
|
|
|
|
|
if (dtype == PUBLICATION) {
|
2015-01-09 00:27:09 -07:00
|
|
|
publ = tipc_nametbl_insert_publ(net, ntohl(i->type),
|
|
|
|
ntohl(i->lower),
|
2014-08-28 01:08:46 -06:00
|
|
|
ntohl(i->upper),
|
|
|
|
TIPC_CLUSTER_SCOPE, node,
|
|
|
|
ntohl(i->ref), ntohl(i->key));
|
|
|
|
if (publ) {
|
2015-11-19 12:30:42 -07:00
|
|
|
tipc_node_subscribe(net, &publ->nodesub_list, node);
|
2014-09-10 06:02:50 -06:00
|
|
|
return true;
|
2014-08-28 01:08:46 -06:00
|
|
|
}
|
|
|
|
} else if (dtype == WITHDRAWAL) {
|
2015-01-09 00:27:09 -07:00
|
|
|
publ = tipc_nametbl_remove_publ(net, ntohl(i->type),
|
|
|
|
ntohl(i->lower),
|
2014-08-28 01:08:46 -06:00
|
|
|
node, ntohl(i->ref),
|
|
|
|
ntohl(i->key));
|
|
|
|
if (publ) {
|
2015-11-19 12:30:42 -07:00
|
|
|
tipc_node_unsubscribe(net, &publ->nodesub_list, node);
|
2014-12-02 00:00:30 -07:00
|
|
|
kfree_rcu(publ, rcu);
|
2014-09-10 06:02:50 -06:00
|
|
|
return true;
|
2014-08-28 01:08:46 -06:00
|
|
|
}
|
|
|
|
} else {
|
|
|
|
pr_warn("Unrecognized name table message received\n");
|
|
|
|
}
|
2014-09-10 06:02:50 -06:00
|
|
|
return false;
|
2014-08-28 01:08:46 -06:00
|
|
|
}
|
|
|
|
|
tipc: add name distributor resiliency queue
TIPC name table updates are distributed asynchronously in a cluster,
entailing a risk of certain race conditions. E.g., if two nodes
simultaneously issue conflicting (overlapping) publications, this may
not be detected until both publications have reached a third node, in
which case one of the publications will be silently dropped on that
node. Hence, we end up with an inconsistent name table.
In most cases this conflict is just a temporary race, e.g., one
node is issuing a publication under the assumption that a previous,
conflicting, publication has already been withdrawn by the other node.
However, because of the (rtt related) distributed update delay, this
may not yet hold true on all nodes. The symptom of this failure is a
syslog message: "tipc: Cannot publish {%u,%u,%u}, overlap error".
In this commit we add a resiliency queue at the receiving end of
the name table distributor. When insertion of an arriving publication
fails, we retain it in this queue for a short amount of time, assuming
that another update will arrive very soon and clear the conflict. If so
happens, we insert the publication, otherwise we drop it.
The (configurable) retention value defaults to 2000 ms. Knowing from
experience that the situation described above is extremely rare, there
is no risk that the queue will accumulate any large number of items.
Signed-off-by: Erik Hugne <erik.hugne@ericsson.com>
Signed-off-by: Jon Maloy <jon.maloy@ericsson.com>
Acked-by: Ying Xue <ying.xue@windriver.com>
Signed-off-by: David S. Miller <davem@davemloft.net>
2014-08-28 01:08:47 -06:00
|
|
|
/**
|
|
|
|
* tipc_named_add_backlog - add a failed name table update to the backlog
|
|
|
|
*
|
|
|
|
*/
|
2016-04-07 08:40:43 -06:00
|
|
|
static void tipc_named_add_backlog(struct net *net, struct distr_item *i,
|
|
|
|
u32 type, u32 node)
|
tipc: add name distributor resiliency queue
TIPC name table updates are distributed asynchronously in a cluster,
entailing a risk of certain race conditions. E.g., if two nodes
simultaneously issue conflicting (overlapping) publications, this may
not be detected until both publications have reached a third node, in
which case one of the publications will be silently dropped on that
node. Hence, we end up with an inconsistent name table.
In most cases this conflict is just a temporary race, e.g., one
node is issuing a publication under the assumption that a previous,
conflicting, publication has already been withdrawn by the other node.
However, because of the (rtt related) distributed update delay, this
may not yet hold true on all nodes. The symptom of this failure is a
syslog message: "tipc: Cannot publish {%u,%u,%u}, overlap error".
In this commit we add a resiliency queue at the receiving end of
the name table distributor. When insertion of an arriving publication
fails, we retain it in this queue for a short amount of time, assuming
that another update will arrive very soon and clear the conflict. If so
happens, we insert the publication, otherwise we drop it.
The (configurable) retention value defaults to 2000 ms. Knowing from
experience that the situation described above is extremely rare, there
is no risk that the queue will accumulate any large number of items.
Signed-off-by: Erik Hugne <erik.hugne@ericsson.com>
Signed-off-by: Jon Maloy <jon.maloy@ericsson.com>
Acked-by: Ying Xue <ying.xue@windriver.com>
Signed-off-by: David S. Miller <davem@davemloft.net>
2014-08-28 01:08:47 -06:00
|
|
|
{
|
|
|
|
struct distr_queue_item *e;
|
2016-04-07 08:40:43 -06:00
|
|
|
struct tipc_net *tn = net_generic(net, tipc_net_id);
|
tipc: add name distributor resiliency queue
TIPC name table updates are distributed asynchronously in a cluster,
entailing a risk of certain race conditions. E.g., if two nodes
simultaneously issue conflicting (overlapping) publications, this may
not be detected until both publications have reached a third node, in
which case one of the publications will be silently dropped on that
node. Hence, we end up with an inconsistent name table.
In most cases this conflict is just a temporary race, e.g., one
node is issuing a publication under the assumption that a previous,
conflicting, publication has already been withdrawn by the other node.
However, because of the (rtt related) distributed update delay, this
may not yet hold true on all nodes. The symptom of this failure is a
syslog message: "tipc: Cannot publish {%u,%u,%u}, overlap error".
In this commit we add a resiliency queue at the receiving end of
the name table distributor. When insertion of an arriving publication
fails, we retain it in this queue for a short amount of time, assuming
that another update will arrive very soon and clear the conflict. If so
happens, we insert the publication, otherwise we drop it.
The (configurable) retention value defaults to 2000 ms. Knowing from
experience that the situation described above is extremely rare, there
is no risk that the queue will accumulate any large number of items.
Signed-off-by: Erik Hugne <erik.hugne@ericsson.com>
Signed-off-by: Jon Maloy <jon.maloy@ericsson.com>
Acked-by: Ying Xue <ying.xue@windriver.com>
Signed-off-by: David S. Miller <davem@davemloft.net>
2014-08-28 01:08:47 -06:00
|
|
|
unsigned long now = get_jiffies_64();
|
|
|
|
|
|
|
|
e = kzalloc(sizeof(*e), GFP_ATOMIC);
|
|
|
|
if (!e)
|
|
|
|
return;
|
|
|
|
e->dtype = type;
|
|
|
|
e->node = node;
|
|
|
|
e->expires = now + msecs_to_jiffies(sysctl_tipc_named_timeout);
|
|
|
|
memcpy(e, i, sizeof(*i));
|
2016-04-07 08:40:43 -06:00
|
|
|
list_add_tail(&e->next, &tn->dist_queue);
|
tipc: add name distributor resiliency queue
TIPC name table updates are distributed asynchronously in a cluster,
entailing a risk of certain race conditions. E.g., if two nodes
simultaneously issue conflicting (overlapping) publications, this may
not be detected until both publications have reached a third node, in
which case one of the publications will be silently dropped on that
node. Hence, we end up with an inconsistent name table.
In most cases this conflict is just a temporary race, e.g., one
node is issuing a publication under the assumption that a previous,
conflicting, publication has already been withdrawn by the other node.
However, because of the (rtt related) distributed update delay, this
may not yet hold true on all nodes. The symptom of this failure is a
syslog message: "tipc: Cannot publish {%u,%u,%u}, overlap error".
In this commit we add a resiliency queue at the receiving end of
the name table distributor. When insertion of an arriving publication
fails, we retain it in this queue for a short amount of time, assuming
that another update will arrive very soon and clear the conflict. If so
happens, we insert the publication, otherwise we drop it.
The (configurable) retention value defaults to 2000 ms. Knowing from
experience that the situation described above is extremely rare, there
is no risk that the queue will accumulate any large number of items.
Signed-off-by: Erik Hugne <erik.hugne@ericsson.com>
Signed-off-by: Jon Maloy <jon.maloy@ericsson.com>
Acked-by: Ying Xue <ying.xue@windriver.com>
Signed-off-by: David S. Miller <davem@davemloft.net>
2014-08-28 01:08:47 -06:00
|
|
|
}
|
|
|
|
|
|
|
|
/**
|
|
|
|
* tipc_named_process_backlog - try to process any pending name table updates
|
|
|
|
* from the network.
|
|
|
|
*/
|
2015-01-09 00:27:05 -07:00
|
|
|
void tipc_named_process_backlog(struct net *net)
|
tipc: add name distributor resiliency queue
TIPC name table updates are distributed asynchronously in a cluster,
entailing a risk of certain race conditions. E.g., if two nodes
simultaneously issue conflicting (overlapping) publications, this may
not be detected until both publications have reached a third node, in
which case one of the publications will be silently dropped on that
node. Hence, we end up with an inconsistent name table.
In most cases this conflict is just a temporary race, e.g., one
node is issuing a publication under the assumption that a previous,
conflicting, publication has already been withdrawn by the other node.
However, because of the (rtt related) distributed update delay, this
may not yet hold true on all nodes. The symptom of this failure is a
syslog message: "tipc: Cannot publish {%u,%u,%u}, overlap error".
In this commit we add a resiliency queue at the receiving end of
the name table distributor. When insertion of an arriving publication
fails, we retain it in this queue for a short amount of time, assuming
that another update will arrive very soon and clear the conflict. If so
happens, we insert the publication, otherwise we drop it.
The (configurable) retention value defaults to 2000 ms. Knowing from
experience that the situation described above is extremely rare, there
is no risk that the queue will accumulate any large number of items.
Signed-off-by: Erik Hugne <erik.hugne@ericsson.com>
Signed-off-by: Jon Maloy <jon.maloy@ericsson.com>
Acked-by: Ying Xue <ying.xue@windriver.com>
Signed-off-by: David S. Miller <davem@davemloft.net>
2014-08-28 01:08:47 -06:00
|
|
|
{
|
|
|
|
struct distr_queue_item *e, *tmp;
|
2016-04-07 08:40:43 -06:00
|
|
|
struct tipc_net *tn = net_generic(net, tipc_net_id);
|
tipc: add name distributor resiliency queue
TIPC name table updates are distributed asynchronously in a cluster,
entailing a risk of certain race conditions. E.g., if two nodes
simultaneously issue conflicting (overlapping) publications, this may
not be detected until both publications have reached a third node, in
which case one of the publications will be silently dropped on that
node. Hence, we end up with an inconsistent name table.
In most cases this conflict is just a temporary race, e.g., one
node is issuing a publication under the assumption that a previous,
conflicting, publication has already been withdrawn by the other node.
However, because of the (rtt related) distributed update delay, this
may not yet hold true on all nodes. The symptom of this failure is a
syslog message: "tipc: Cannot publish {%u,%u,%u}, overlap error".
In this commit we add a resiliency queue at the receiving end of
the name table distributor. When insertion of an arriving publication
fails, we retain it in this queue for a short amount of time, assuming
that another update will arrive very soon and clear the conflict. If so
happens, we insert the publication, otherwise we drop it.
The (configurable) retention value defaults to 2000 ms. Knowing from
experience that the situation described above is extremely rare, there
is no risk that the queue will accumulate any large number of items.
Signed-off-by: Erik Hugne <erik.hugne@ericsson.com>
Signed-off-by: Jon Maloy <jon.maloy@ericsson.com>
Acked-by: Ying Xue <ying.xue@windriver.com>
Signed-off-by: David S. Miller <davem@davemloft.net>
2014-08-28 01:08:47 -06:00
|
|
|
char addr[16];
|
|
|
|
unsigned long now = get_jiffies_64();
|
|
|
|
|
2016-04-07 08:40:43 -06:00
|
|
|
list_for_each_entry_safe(e, tmp, &tn->dist_queue, next) {
|
tipc: add name distributor resiliency queue
TIPC name table updates are distributed asynchronously in a cluster,
entailing a risk of certain race conditions. E.g., if two nodes
simultaneously issue conflicting (overlapping) publications, this may
not be detected until both publications have reached a third node, in
which case one of the publications will be silently dropped on that
node. Hence, we end up with an inconsistent name table.
In most cases this conflict is just a temporary race, e.g., one
node is issuing a publication under the assumption that a previous,
conflicting, publication has already been withdrawn by the other node.
However, because of the (rtt related) distributed update delay, this
may not yet hold true on all nodes. The symptom of this failure is a
syslog message: "tipc: Cannot publish {%u,%u,%u}, overlap error".
In this commit we add a resiliency queue at the receiving end of
the name table distributor. When insertion of an arriving publication
fails, we retain it in this queue for a short amount of time, assuming
that another update will arrive very soon and clear the conflict. If so
happens, we insert the publication, otherwise we drop it.
The (configurable) retention value defaults to 2000 ms. Knowing from
experience that the situation described above is extremely rare, there
is no risk that the queue will accumulate any large number of items.
Signed-off-by: Erik Hugne <erik.hugne@ericsson.com>
Signed-off-by: Jon Maloy <jon.maloy@ericsson.com>
Acked-by: Ying Xue <ying.xue@windriver.com>
Signed-off-by: David S. Miller <davem@davemloft.net>
2014-08-28 01:08:47 -06:00
|
|
|
if (time_after(e->expires, now)) {
|
2015-01-09 00:27:05 -07:00
|
|
|
if (!tipc_update_nametbl(net, &e->i, e->node, e->dtype))
|
tipc: add name distributor resiliency queue
TIPC name table updates are distributed asynchronously in a cluster,
entailing a risk of certain race conditions. E.g., if two nodes
simultaneously issue conflicting (overlapping) publications, this may
not be detected until both publications have reached a third node, in
which case one of the publications will be silently dropped on that
node. Hence, we end up with an inconsistent name table.
In most cases this conflict is just a temporary race, e.g., one
node is issuing a publication under the assumption that a previous,
conflicting, publication has already been withdrawn by the other node.
However, because of the (rtt related) distributed update delay, this
may not yet hold true on all nodes. The symptom of this failure is a
syslog message: "tipc: Cannot publish {%u,%u,%u}, overlap error".
In this commit we add a resiliency queue at the receiving end of
the name table distributor. When insertion of an arriving publication
fails, we retain it in this queue for a short amount of time, assuming
that another update will arrive very soon and clear the conflict. If so
happens, we insert the publication, otherwise we drop it.
The (configurable) retention value defaults to 2000 ms. Knowing from
experience that the situation described above is extremely rare, there
is no risk that the queue will accumulate any large number of items.
Signed-off-by: Erik Hugne <erik.hugne@ericsson.com>
Signed-off-by: Jon Maloy <jon.maloy@ericsson.com>
Acked-by: Ying Xue <ying.xue@windriver.com>
Signed-off-by: David S. Miller <davem@davemloft.net>
2014-08-28 01:08:47 -06:00
|
|
|
continue;
|
|
|
|
} else {
|
|
|
|
tipc_addr_string_fill(addr, e->node);
|
|
|
|
pr_warn_ratelimited("Dropping name table update (%d) of {%u, %u, %u} from %s key=%u\n",
|
|
|
|
e->dtype, ntohl(e->i.type),
|
|
|
|
ntohl(e->i.lower),
|
|
|
|
ntohl(e->i.upper),
|
|
|
|
addr, ntohl(e->i.key));
|
|
|
|
}
|
|
|
|
list_del(&e->next);
|
|
|
|
kfree(e);
|
|
|
|
}
|
|
|
|
}
|
|
|
|
|
2006-01-02 11:04:38 -07:00
|
|
|
/**
|
tipc: resolve race problem at unicast message reception
TIPC handles message cardinality and sequencing at the link layer,
before passing messages upwards to the destination sockets. During the
upcall from link to socket no locks are held. It is therefore possible,
and we see it happen occasionally, that messages arriving in different
threads and delivered in sequence still bypass each other before they
reach the destination socket. This must not happen, since it violates
the sequentiality guarantee.
We solve this by adding a new input buffer queue to the link structure.
Arriving messages are added safely to the tail of that queue by the
link, while the head of the queue is consumed, also safely, by the
receiving socket. Sequentiality is secured per socket by only allowing
buffers to be dequeued inside the socket lock. Since there may be multiple
simultaneous readers of the queue, we use a 'filter' parameter to reduce
the risk that they peek the same buffer from the queue, hence also
reducing the risk of contention on the receiving socket locks.
This solves the sequentiality problem, and seems to cause no measurable
performance degradation.
A nice side effect of this change is that lock handling in the functions
tipc_rcv() and tipc_bcast_rcv() now becomes uniform, something that
will enable future simplifications of those functions.
Reviewed-by: Ying Xue <ying.xue@windriver.com>
Signed-off-by: Jon Maloy <jon.maloy@ericsson.com>
Signed-off-by: David S. Miller <davem@davemloft.net>
2015-02-05 06:36:41 -07:00
|
|
|
* tipc_named_rcv - process name table update messages sent by another node
|
2006-01-02 11:04:38 -07:00
|
|
|
*/
|
tipc: resolve race problem at unicast message reception
TIPC handles message cardinality and sequencing at the link layer,
before passing messages upwards to the destination sockets. During the
upcall from link to socket no locks are held. It is therefore possible,
and we see it happen occasionally, that messages arriving in different
threads and delivered in sequence still bypass each other before they
reach the destination socket. This must not happen, since it violates
the sequentiality guarantee.
We solve this by adding a new input buffer queue to the link structure.
Arriving messages are added safely to the tail of that queue by the
link, while the head of the queue is consumed, also safely, by the
receiving socket. Sequentiality is secured per socket by only allowing
buffers to be dequeued inside the socket lock. Since there may be multiple
simultaneous readers of the queue, we use a 'filter' parameter to reduce
the risk that they peek the same buffer from the queue, hence also
reducing the risk of contention on the receiving socket locks.
This solves the sequentiality problem, and seems to cause no measurable
performance degradation.
A nice side effect of this change is that lock handling in the functions
tipc_rcv() and tipc_bcast_rcv() now becomes uniform, something that
will enable future simplifications of those functions.
Reviewed-by: Ying Xue <ying.xue@windriver.com>
Signed-off-by: Jon Maloy <jon.maloy@ericsson.com>
Signed-off-by: David S. Miller <davem@davemloft.net>
2015-02-05 06:36:41 -07:00
|
|
|
void tipc_named_rcv(struct net *net, struct sk_buff_head *inputq)
|
2006-01-02 11:04:38 -07:00
|
|
|
{
|
2015-01-09 00:27:09 -07:00
|
|
|
struct tipc_net *tn = net_generic(net, tipc_net_id);
|
tipc: resolve race problem at unicast message reception
TIPC handles message cardinality and sequencing at the link layer,
before passing messages upwards to the destination sockets. During the
upcall from link to socket no locks are held. It is therefore possible,
and we see it happen occasionally, that messages arriving in different
threads and delivered in sequence still bypass each other before they
reach the destination socket. This must not happen, since it violates
the sequentiality guarantee.
We solve this by adding a new input buffer queue to the link structure.
Arriving messages are added safely to the tail of that queue by the
link, while the head of the queue is consumed, also safely, by the
receiving socket. Sequentiality is secured per socket by only allowing
buffers to be dequeued inside the socket lock. Since there may be multiple
simultaneous readers of the queue, we use a 'filter' parameter to reduce
the risk that they peek the same buffer from the queue, hence also
reducing the risk of contention on the receiving socket locks.
This solves the sequentiality problem, and seems to cause no measurable
performance degradation.
A nice side effect of this change is that lock handling in the functions
tipc_rcv() and tipc_bcast_rcv() now becomes uniform, something that
will enable future simplifications of those functions.
Reviewed-by: Ying Xue <ying.xue@windriver.com>
Signed-off-by: Jon Maloy <jon.maloy@ericsson.com>
Signed-off-by: David S. Miller <davem@davemloft.net>
2015-02-05 06:36:41 -07:00
|
|
|
struct tipc_msg *msg;
|
|
|
|
struct distr_item *item;
|
|
|
|
uint count;
|
|
|
|
u32 node;
|
|
|
|
struct sk_buff *skb;
|
|
|
|
int mtype;
|
2006-01-02 11:04:38 -07:00
|
|
|
|
2015-01-09 00:27:09 -07:00
|
|
|
spin_lock_bh(&tn->nametbl_lock);
|
tipc: resolve race problem at unicast message reception
TIPC handles message cardinality and sequencing at the link layer,
before passing messages upwards to the destination sockets. During the
upcall from link to socket no locks are held. It is therefore possible,
and we see it happen occasionally, that messages arriving in different
threads and delivered in sequence still bypass each other before they
reach the destination socket. This must not happen, since it violates
the sequentiality guarantee.
We solve this by adding a new input buffer queue to the link structure.
Arriving messages are added safely to the tail of that queue by the
link, while the head of the queue is consumed, also safely, by the
receiving socket. Sequentiality is secured per socket by only allowing
buffers to be dequeued inside the socket lock. Since there may be multiple
simultaneous readers of the queue, we use a 'filter' parameter to reduce
the risk that they peek the same buffer from the queue, hence also
reducing the risk of contention on the receiving socket locks.
This solves the sequentiality problem, and seems to cause no measurable
performance degradation.
A nice side effect of this change is that lock handling in the functions
tipc_rcv() and tipc_bcast_rcv() now becomes uniform, something that
will enable future simplifications of those functions.
Reviewed-by: Ying Xue <ying.xue@windriver.com>
Signed-off-by: Jon Maloy <jon.maloy@ericsson.com>
Signed-off-by: David S. Miller <davem@davemloft.net>
2015-02-05 06:36:41 -07:00
|
|
|
for (skb = skb_dequeue(inputq); skb; skb = skb_dequeue(inputq)) {
|
2015-11-19 12:30:40 -07:00
|
|
|
skb_linearize(skb);
|
tipc: resolve race problem at unicast message reception
TIPC handles message cardinality and sequencing at the link layer,
before passing messages upwards to the destination sockets. During the
upcall from link to socket no locks are held. It is therefore possible,
and we see it happen occasionally, that messages arriving in different
threads and delivered in sequence still bypass each other before they
reach the destination socket. This must not happen, since it violates
the sequentiality guarantee.
We solve this by adding a new input buffer queue to the link structure.
Arriving messages are added safely to the tail of that queue by the
link, while the head of the queue is consumed, also safely, by the
receiving socket. Sequentiality is secured per socket by only allowing
buffers to be dequeued inside the socket lock. Since there may be multiple
simultaneous readers of the queue, we use a 'filter' parameter to reduce
the risk that they peek the same buffer from the queue, hence also
reducing the risk of contention on the receiving socket locks.
This solves the sequentiality problem, and seems to cause no measurable
performance degradation.
A nice side effect of this change is that lock handling in the functions
tipc_rcv() and tipc_bcast_rcv() now becomes uniform, something that
will enable future simplifications of those functions.
Reviewed-by: Ying Xue <ying.xue@windriver.com>
Signed-off-by: Jon Maloy <jon.maloy@ericsson.com>
Signed-off-by: David S. Miller <davem@davemloft.net>
2015-02-05 06:36:41 -07:00
|
|
|
msg = buf_msg(skb);
|
|
|
|
mtype = msg_type(msg);
|
|
|
|
item = (struct distr_item *)msg_data(msg);
|
|
|
|
count = msg_data_sz(msg) / ITEM_SIZE;
|
|
|
|
node = msg_orignode(msg);
|
|
|
|
while (count--) {
|
|
|
|
if (!tipc_update_nametbl(net, item, node, mtype))
|
2016-04-07 08:40:43 -06:00
|
|
|
tipc_named_add_backlog(net, item, mtype, node);
|
tipc: resolve race problem at unicast message reception
TIPC handles message cardinality and sequencing at the link layer,
before passing messages upwards to the destination sockets. During the
upcall from link to socket no locks are held. It is therefore possible,
and we see it happen occasionally, that messages arriving in different
threads and delivered in sequence still bypass each other before they
reach the destination socket. This must not happen, since it violates
the sequentiality guarantee.
We solve this by adding a new input buffer queue to the link structure.
Arriving messages are added safely to the tail of that queue by the
link, while the head of the queue is consumed, also safely, by the
receiving socket. Sequentiality is secured per socket by only allowing
buffers to be dequeued inside the socket lock. Since there may be multiple
simultaneous readers of the queue, we use a 'filter' parameter to reduce
the risk that they peek the same buffer from the queue, hence also
reducing the risk of contention on the receiving socket locks.
This solves the sequentiality problem, and seems to cause no measurable
performance degradation.
A nice side effect of this change is that lock handling in the functions
tipc_rcv() and tipc_bcast_rcv() now becomes uniform, something that
will enable future simplifications of those functions.
Reviewed-by: Ying Xue <ying.xue@windriver.com>
Signed-off-by: Jon Maloy <jon.maloy@ericsson.com>
Signed-off-by: David S. Miller <davem@davemloft.net>
2015-02-05 06:36:41 -07:00
|
|
|
item++;
|
|
|
|
}
|
|
|
|
kfree_skb(skb);
|
|
|
|
tipc_named_process_backlog(net);
|
2006-01-02 11:04:38 -07:00
|
|
|
}
|
2015-01-09 00:27:09 -07:00
|
|
|
spin_unlock_bh(&tn->nametbl_lock);
|
2006-01-02 11:04:38 -07:00
|
|
|
}
|
|
|
|
|
|
|
|
/**
|
2012-04-17 15:57:52 -06:00
|
|
|
* tipc_named_reinit - re-initialize local publications
|
2007-02-09 07:25:21 -07:00
|
|
|
*
|
2011-10-14 12:42:25 -06:00
|
|
|
* This routine is called whenever TIPC networking is enabled.
|
2012-04-17 15:57:52 -06:00
|
|
|
* All name table entries published by this node are updated to reflect
|
|
|
|
* the node's new network address.
|
2006-01-02 11:04:38 -07:00
|
|
|
*/
|
2015-01-09 00:27:09 -07:00
|
|
|
void tipc_named_reinit(struct net *net)
|
2006-01-02 11:04:38 -07:00
|
|
|
{
|
2015-01-09 00:27:09 -07:00
|
|
|
struct tipc_net *tn = net_generic(net, tipc_net_id);
|
2006-01-02 11:04:38 -07:00
|
|
|
struct publication *publ;
|
2012-04-17 15:57:52 -06:00
|
|
|
int scope;
|
2006-01-02 11:04:38 -07:00
|
|
|
|
2015-01-09 00:27:09 -07:00
|
|
|
spin_lock_bh(&tn->nametbl_lock);
|
2011-10-14 12:42:25 -06:00
|
|
|
|
2012-04-17 15:57:52 -06:00
|
|
|
for (scope = TIPC_ZONE_SCOPE; scope <= TIPC_NODE_SCOPE; scope++)
|
2015-01-09 00:27:09 -07:00
|
|
|
list_for_each_entry_rcu(publ, &tn->nametbl->publ_list[scope],
|
2014-12-02 00:00:30 -07:00
|
|
|
local_list)
|
2015-01-09 00:27:10 -07:00
|
|
|
publ->node = tn->own_addr;
|
2011-10-14 12:42:25 -06:00
|
|
|
|
2015-01-09 00:27:09 -07:00
|
|
|
spin_unlock_bh(&tn->nametbl_lock);
|
2006-01-02 11:04:38 -07:00
|
|
|
}
|