[PATCH] ext3: fix log_do_checkpoint() assertion failure
Fix possible false assertion failure in log_do_checkpoint(). We might fail to detect that we actually made a progress when cleaning up the checkpoint lists if we don't retry after writing something to disk. The patch was confirmed to fix observed assertion failures for several users. When we flushed some buffers we need to retry scanning the list. Otherwise we can fail to detect our progress. Signed-off-by: Jan Kara <jack@suse.cz> Signed-off-by: Andrew Morton <akpm@osdl.org> Signed-off-by: Linus Torvalds <torvalds@osdl.org>
This commit is contained in:
parent
1e86d1c648
commit
00ea81459c
|
@ -339,8 +339,10 @@ int log_do_checkpoint(journal_t *journal)
|
||||||
}
|
}
|
||||||
} while (jh != last_jh && !retry);
|
} while (jh != last_jh && !retry);
|
||||||
|
|
||||||
if (batch_count)
|
if (batch_count) {
|
||||||
__flush_batch(journal, bhs, &batch_count);
|
__flush_batch(journal, bhs, &batch_count);
|
||||||
|
retry = 1;
|
||||||
|
}
|
||||||
|
|
||||||
/*
|
/*
|
||||||
* If someone cleaned up this transaction while we slept, we're
|
* If someone cleaned up this transaction while we slept, we're
|
||||||
|
|
Loading…
Reference in a new issue