f2fs: fix overflow due to condition check order
commit e87f7329bb
upstream.
In the last ilen case, i was already increased, resulting in accessing out-
of-boundary entry of do_replace and blkaddr.
Fix to check ilen first to exit the loop.
Fixes: 2aa8fbb9693020 ("f2fs: refactor __exchange_data_block for speed up")
Signed-off-by: Jaegeuk Kim <jaegeuk@kernel.org>
Signed-off-by: Greg Kroah-Hartman <gregkh@linuxfoundation.org>
This commit is contained in:
parent
1134ef11ff
commit
027611ef34
|
@ -967,7 +967,7 @@ static int __clone_blkaddrs(struct inode *src_inode, struct inode *dst_inode,
|
||||||
new_size = (dst + i) << PAGE_SHIFT;
|
new_size = (dst + i) << PAGE_SHIFT;
|
||||||
if (dst_inode->i_size < new_size)
|
if (dst_inode->i_size < new_size)
|
||||||
f2fs_i_size_write(dst_inode, new_size);
|
f2fs_i_size_write(dst_inode, new_size);
|
||||||
} while ((do_replace[i] || blkaddr[i] == NULL_ADDR) && --ilen);
|
} while (--ilen && (do_replace[i] || blkaddr[i] == NULL_ADDR));
|
||||||
|
|
||||||
f2fs_put_dnode(&dn);
|
f2fs_put_dnode(&dn);
|
||||||
} else {
|
} else {
|
||||||
|
|
Loading…
Reference in a new issue