rtc: cmos: prevent kernel warning on IRQ flags mismatch
The Microsoft Surface 3 tablet shares interrupt line between RTC and one of SPI controllers. However, the rtc_cmos driver doesn't allow shared interrupts and user sees the following warning genirq: Flags mismatch irq 8. 00000080 (8086228E:02) vs. 00000000 (rtc0) ... [<ffffffffa004eb01>] pxa2xx_spi_probe+0x151/0x600 [spi_pxa2xx_platform] Allow RTC driver to use shared interrupts. Seems we are on the safe side to do just this simple change since cmos_interrupt() handler checks for the actual hardware status anyway. Signed-off-by: Andy Shevchenko <andriy.shevchenko@linux.intel.com> Signed-off-by: Alexandre Belloni <alexandre.belloni@free-electrons.com>
This commit is contained in:
parent
c4c23f58a9
commit
079062b28f
|
@ -725,7 +725,7 @@ cmos_do_probe(struct device *dev, struct resource *ports, int rtc_irq)
|
||||||
rtc_cmos_int_handler = cmos_interrupt;
|
rtc_cmos_int_handler = cmos_interrupt;
|
||||||
|
|
||||||
retval = request_irq(rtc_irq, rtc_cmos_int_handler,
|
retval = request_irq(rtc_irq, rtc_cmos_int_handler,
|
||||||
0, dev_name(&cmos_rtc.rtc->dev),
|
IRQF_SHARED, dev_name(&cmos_rtc.rtc->dev),
|
||||||
cmos_rtc.rtc);
|
cmos_rtc.rtc);
|
||||||
if (retval < 0) {
|
if (retval < 0) {
|
||||||
dev_dbg(dev, "IRQ %d is already in use\n", rtc_irq);
|
dev_dbg(dev, "IRQ %d is already in use\n", rtc_irq);
|
||||||
|
|
Loading…
Reference in a new issue