redonkable/remarkable-linux
redonkable/remarkable-linux
1
0
Fork 0
Code Releases Activity

ecryptfs: make register_filesystem() the last potential failure exit

Browse source 
Signed-off-by: Al Viro <viro@zeniv.linux.org.uk>
This commit is contained in:
Al Viro 2012-03-17 21:29:13 -04:00
parent f4c5499d2c
commit 0794f569ec
1 changed files with 8 additions and 8 deletions
Show stats Download patch file Download diff file Expand all files Collapse all files

16
fs/ecryptfs/main.c
View file

@ -794,15 +794,10 @@ static int __init ecryptfs_init(void)
"Failed to allocate one or more kmem_cache objects\n"); "Failed to allocate one or more kmem_cache objects\n");
goto out; goto out;
} }
rc = register_filesystem(&ecryptfs_fs_type);
if (rc) {
printk(KERN_ERR "Failed to register filesystem\n");
goto out_free_kmem_caches;
}
rc = do_sysfs_registration(); rc = do_sysfs_registration();
if (rc) { if (rc) {
printk(KERN_ERR "sysfs registration failed\n"); printk(KERN_ERR "sysfs registration failed\n");
goto out_unregister_filesystem; goto out_free_kmem_caches;
} }
rc = ecryptfs_init_kthread(); rc = ecryptfs_init_kthread();
if (rc) { if (rc) {
@ -823,19 +818,24 @@ static int __init ecryptfs_init(void)
"rc = [%d]\n", rc); "rc = [%d]\n", rc);
goto out_release_messaging; goto out_release_messaging;
} }
rc = register_filesystem(&ecryptfs_fs_type);
if (rc) {
printk(KERN_ERR "Failed to register filesystem\n");
goto out_destroy_crypto;
}
if (ecryptfs_verbosity > 0) if (ecryptfs_verbosity > 0)
printk(KERN_CRIT "eCryptfs verbosity set to %d. Secret values " printk(KERN_CRIT "eCryptfs verbosity set to %d. Secret values "
"will be written to the syslog!\n", ecryptfs_verbosity); "will be written to the syslog!\n", ecryptfs_verbosity);
goto out; goto out;
out_destroy_crypto:
ecryptfs_destroy_crypto();
out_release_messaging: out_release_messaging:
ecryptfs_release_messaging(); ecryptfs_release_messaging();
out_destroy_kthread: out_destroy_kthread:
ecryptfs_destroy_kthread(); ecryptfs_destroy_kthread();
out_do_sysfs_unregistration: out_do_sysfs_unregistration:
do_sysfs_unregistration(); do_sysfs_unregistration();
out_unregister_filesystem:
unregister_filesystem(&ecryptfs_fs_type);
out_free_kmem_caches: out_free_kmem_caches:
ecryptfs_free_kmem_caches(); ecryptfs_free_kmem_caches();
out: out: