xfs: remove newlines from strings passed to __xfs_printk
__xfs_printk adds its own "\n". Having it in the original string leads to unintentional blank lines from these messages. Most format strings have no newline, but a few do, leading to i.e.: [ 7347.119911] XFS (sdb2): Access to block zero in inode 132 start_block: 0 start_off: 0 blkcnt: 0 extent-state: 0 lastx: 1a05 [ 7347.119911] [ 7347.119919] XFS (sdb2): Access to block zero in inode 132 start_block: 0 start_off: 0 blkcnt: 0 extent-state: 0 lastx: 1a05 [ 7347.119919] Fix them all. Signed-off-by: Eric Sandeen <sandeen@redhat.com> Reviewed-by: Mark Tinguely <tinguely@sgi.com> Signed-off-by: Ben Myers <bpm@sgi.com>
This commit is contained in:
parent
2c6e24ce1a
commit
08e96e1a3c
|
@ -1482,7 +1482,7 @@ xfs_bmap_search_extents(
|
||||||
xfs_alert_tag(ip->i_mount, XFS_PTAG_FSBLOCK_ZERO,
|
xfs_alert_tag(ip->i_mount, XFS_PTAG_FSBLOCK_ZERO,
|
||||||
"Access to block zero in inode %llu "
|
"Access to block zero in inode %llu "
|
||||||
"start_block: %llx start_off: %llx "
|
"start_block: %llx start_off: %llx "
|
||||||
"blkcnt: %llx extent-state: %x lastx: %x\n",
|
"blkcnt: %llx extent-state: %x lastx: %x",
|
||||||
(unsigned long long)ip->i_ino,
|
(unsigned long long)ip->i_ino,
|
||||||
(unsigned long long)gotp->br_startblock,
|
(unsigned long long)gotp->br_startblock,
|
||||||
(unsigned long long)gotp->br_startoff,
|
(unsigned long long)gotp->br_startoff,
|
||||||
|
|
|
@ -590,7 +590,7 @@ found:
|
||||||
error = _xfs_buf_map_pages(bp, flags);
|
error = _xfs_buf_map_pages(bp, flags);
|
||||||
if (unlikely(error)) {
|
if (unlikely(error)) {
|
||||||
xfs_warn(target->bt_mount,
|
xfs_warn(target->bt_mount,
|
||||||
"%s: failed to map pages\n", __func__);
|
"%s: failed to map pagesn", __func__);
|
||||||
xfs_buf_relse(bp);
|
xfs_buf_relse(bp);
|
||||||
return NULL;
|
return NULL;
|
||||||
}
|
}
|
||||||
|
@ -809,7 +809,7 @@ xfs_buf_get_uncached(
|
||||||
error = _xfs_buf_map_pages(bp, 0);
|
error = _xfs_buf_map_pages(bp, 0);
|
||||||
if (unlikely(error)) {
|
if (unlikely(error)) {
|
||||||
xfs_warn(target->bt_mount,
|
xfs_warn(target->bt_mount,
|
||||||
"%s: failed to map pages\n", __func__);
|
"%s: failed to map pages", __func__);
|
||||||
goto fail_free_mem;
|
goto fail_free_mem;
|
||||||
}
|
}
|
||||||
|
|
||||||
|
@ -1618,7 +1618,7 @@ xfs_setsize_buftarg_flags(
|
||||||
bdevname(btp->bt_bdev, name);
|
bdevname(btp->bt_bdev, name);
|
||||||
|
|
||||||
xfs_warn(btp->bt_mount,
|
xfs_warn(btp->bt_mount,
|
||||||
"Cannot set_blocksize to %u on device %s\n",
|
"Cannot set_blocksize to %u on device %s",
|
||||||
sectorsize, name);
|
sectorsize, name);
|
||||||
return EINVAL;
|
return EINVAL;
|
||||||
}
|
}
|
||||||
|
|
|
@ -1101,7 +1101,7 @@ xfs_dir2_leafn_rebalance(
|
||||||
state->inleaf = 1;
|
state->inleaf = 1;
|
||||||
blk2->index = 0;
|
blk2->index = 0;
|
||||||
xfs_alert(args->dp->i_mount,
|
xfs_alert(args->dp->i_mount,
|
||||||
"%s: picked the wrong leaf? reverting original leaf: blk1->index %d\n",
|
"%s: picked the wrong leaf? reverting original leaf: blk1->index %d",
|
||||||
__func__, blk1->index);
|
__func__, blk1->index);
|
||||||
}
|
}
|
||||||
}
|
}
|
||||||
|
|
|
@ -159,7 +159,7 @@ xfs_error_report(
|
||||||
{
|
{
|
||||||
if (level <= xfs_error_level) {
|
if (level <= xfs_error_level) {
|
||||||
xfs_alert_tag(mp, XFS_PTAG_ERROR_REPORT,
|
xfs_alert_tag(mp, XFS_PTAG_ERROR_REPORT,
|
||||||
"Internal error %s at line %d of file %s. Caller 0x%p\n",
|
"Internal error %s at line %d of file %s. Caller 0x%p",
|
||||||
tag, linenum, filename, ra);
|
tag, linenum, filename, ra);
|
||||||
|
|
||||||
xfs_stack_trace();
|
xfs_stack_trace();
|
||||||
|
|
|
@ -110,7 +110,7 @@ xfs_alert_fsblock_zero(
|
||||||
xfs_alert_tag(ip->i_mount, XFS_PTAG_FSBLOCK_ZERO,
|
xfs_alert_tag(ip->i_mount, XFS_PTAG_FSBLOCK_ZERO,
|
||||||
"Access to block zero in inode %llu "
|
"Access to block zero in inode %llu "
|
||||||
"start_block: %llx start_off: %llx "
|
"start_block: %llx start_off: %llx "
|
||||||
"blkcnt: %llx extent-state: %x\n",
|
"blkcnt: %llx extent-state: %x",
|
||||||
(unsigned long long)ip->i_ino,
|
(unsigned long long)ip->i_ino,
|
||||||
(unsigned long long)imap->br_startblock,
|
(unsigned long long)imap->br_startblock,
|
||||||
(unsigned long long)imap->br_startoff,
|
(unsigned long long)imap->br_startoff,
|
||||||
|
|
|
@ -1989,7 +1989,7 @@ xlog_print_tic_res(
|
||||||
|
|
||||||
for (i = 0; i < ticket->t_res_num; i++) {
|
for (i = 0; i < ticket->t_res_num; i++) {
|
||||||
uint r_type = ticket->t_res_arr[i].r_type;
|
uint r_type = ticket->t_res_arr[i].r_type;
|
||||||
xfs_warn(mp, "region[%u]: %s - %u bytes\n", i,
|
xfs_warn(mp, "region[%u]: %s - %u bytes", i,
|
||||||
((r_type <= 0 || r_type > XLOG_REG_TYPE_MAX) ?
|
((r_type <= 0 || r_type > XLOG_REG_TYPE_MAX) ?
|
||||||
"bad-rtype" : res_type_str[r_type-1]),
|
"bad-rtype" : res_type_str[r_type-1]),
|
||||||
ticket->t_res_arr[i].r_len);
|
ticket->t_res_arr[i].r_len);
|
||||||
|
|
|
@ -305,9 +305,9 @@ xlog_header_check_dump(
|
||||||
xfs_mount_t *mp,
|
xfs_mount_t *mp,
|
||||||
xlog_rec_header_t *head)
|
xlog_rec_header_t *head)
|
||||||
{
|
{
|
||||||
xfs_debug(mp, "%s: SB : uuid = %pU, fmt = %d\n",
|
xfs_debug(mp, "%s: SB : uuid = %pU, fmt = %d",
|
||||||
__func__, &mp->m_sb.sb_uuid, XLOG_FMT);
|
__func__, &mp->m_sb.sb_uuid, XLOG_FMT);
|
||||||
xfs_debug(mp, " log : uuid = %pU, fmt = %d\n",
|
xfs_debug(mp, " log : uuid = %pU, fmt = %d",
|
||||||
&head->h_fs_uuid, be32_to_cpu(head->h_fmt));
|
&head->h_fs_uuid, be32_to_cpu(head->h_fmt));
|
||||||
}
|
}
|
||||||
#else
|
#else
|
||||||
|
@ -4077,7 +4077,7 @@ xlog_unpack_data_crc(
|
||||||
if (crc != rhead->h_crc) {
|
if (crc != rhead->h_crc) {
|
||||||
if (rhead->h_crc || xfs_sb_version_hascrc(&log->l_mp->m_sb)) {
|
if (rhead->h_crc || xfs_sb_version_hascrc(&log->l_mp->m_sb)) {
|
||||||
xfs_alert(log->l_mp,
|
xfs_alert(log->l_mp,
|
||||||
"log record CRC mismatch: found 0x%x, expected 0x%x.\n",
|
"log record CRC mismatch: found 0x%x, expected 0x%x.",
|
||||||
le32_to_cpu(rhead->h_crc),
|
le32_to_cpu(rhead->h_crc),
|
||||||
le32_to_cpu(crc));
|
le32_to_cpu(crc));
|
||||||
xfs_hex_dump(dp, 32);
|
xfs_hex_dump(dp, 32);
|
||||||
|
|
|
@ -287,7 +287,7 @@ xfs_qm_scall_trunc_qfiles(
|
||||||
int error = 0, error2 = 0;
|
int error = 0, error2 = 0;
|
||||||
|
|
||||||
if (!xfs_sb_version_hasquota(&mp->m_sb) || flags == 0) {
|
if (!xfs_sb_version_hasquota(&mp->m_sb) || flags == 0) {
|
||||||
xfs_debug(mp, "%s: flags=%x m_qflags=%x\n",
|
xfs_debug(mp, "%s: flags=%x m_qflags=%x",
|
||||||
__func__, flags, mp->m_qflags);
|
__func__, flags, mp->m_qflags);
|
||||||
return XFS_ERROR(EINVAL);
|
return XFS_ERROR(EINVAL);
|
||||||
}
|
}
|
||||||
|
@ -325,7 +325,7 @@ xfs_qm_scall_quotaon(
|
||||||
sbflags = 0;
|
sbflags = 0;
|
||||||
|
|
||||||
if (flags == 0) {
|
if (flags == 0) {
|
||||||
xfs_debug(mp, "%s: zero flags, m_qflags=%x\n",
|
xfs_debug(mp, "%s: zero flags, m_qflags=%x",
|
||||||
__func__, mp->m_qflags);
|
__func__, mp->m_qflags);
|
||||||
return XFS_ERROR(EINVAL);
|
return XFS_ERROR(EINVAL);
|
||||||
}
|
}
|
||||||
|
@ -348,7 +348,7 @@ xfs_qm_scall_quotaon(
|
||||||
(mp->m_sb.sb_qflags & XFS_PQUOTA_ACCT) == 0 &&
|
(mp->m_sb.sb_qflags & XFS_PQUOTA_ACCT) == 0 &&
|
||||||
(flags & XFS_PQUOTA_ENFD))) {
|
(flags & XFS_PQUOTA_ENFD))) {
|
||||||
xfs_debug(mp,
|
xfs_debug(mp,
|
||||||
"%s: Can't enforce without acct, flags=%x sbflags=%x\n",
|
"%s: Can't enforce without acct, flags=%x sbflags=%x",
|
||||||
__func__, flags, mp->m_sb.sb_qflags);
|
__func__, flags, mp->m_sb.sb_qflags);
|
||||||
return XFS_ERROR(EINVAL);
|
return XFS_ERROR(EINVAL);
|
||||||
}
|
}
|
||||||
|
@ -648,7 +648,7 @@ xfs_qm_scall_setqlim(
|
||||||
q->qi_bsoftlimit = soft;
|
q->qi_bsoftlimit = soft;
|
||||||
}
|
}
|
||||||
} else {
|
} else {
|
||||||
xfs_debug(mp, "blkhard %Ld < blksoft %Ld\n", hard, soft);
|
xfs_debug(mp, "blkhard %Ld < blksoft %Ld", hard, soft);
|
||||||
}
|
}
|
||||||
hard = (newlim->d_fieldmask & FS_DQ_RTBHARD) ?
|
hard = (newlim->d_fieldmask & FS_DQ_RTBHARD) ?
|
||||||
(xfs_qcnt_t) XFS_BB_TO_FSB(mp, newlim->d_rtb_hardlimit) :
|
(xfs_qcnt_t) XFS_BB_TO_FSB(mp, newlim->d_rtb_hardlimit) :
|
||||||
|
@ -664,7 +664,7 @@ xfs_qm_scall_setqlim(
|
||||||
q->qi_rtbsoftlimit = soft;
|
q->qi_rtbsoftlimit = soft;
|
||||||
}
|
}
|
||||||
} else {
|
} else {
|
||||||
xfs_debug(mp, "rtbhard %Ld < rtbsoft %Ld\n", hard, soft);
|
xfs_debug(mp, "rtbhard %Ld < rtbsoft %Ld", hard, soft);
|
||||||
}
|
}
|
||||||
|
|
||||||
hard = (newlim->d_fieldmask & FS_DQ_IHARD) ?
|
hard = (newlim->d_fieldmask & FS_DQ_IHARD) ?
|
||||||
|
@ -681,7 +681,7 @@ xfs_qm_scall_setqlim(
|
||||||
q->qi_isoftlimit = soft;
|
q->qi_isoftlimit = soft;
|
||||||
}
|
}
|
||||||
} else {
|
} else {
|
||||||
xfs_debug(mp, "ihard %Ld < isoft %Ld\n", hard, soft);
|
xfs_debug(mp, "ihard %Ld < isoft %Ld", hard, soft);
|
||||||
}
|
}
|
||||||
|
|
||||||
/*
|
/*
|
||||||
|
|
|
@ -249,13 +249,13 @@ xfs_mount_validate_sb(
|
||||||
if (xfs_sb_version_has_pquotino(sbp)) {
|
if (xfs_sb_version_has_pquotino(sbp)) {
|
||||||
if (sbp->sb_qflags & (XFS_OQUOTA_ENFD | XFS_OQUOTA_CHKD)) {
|
if (sbp->sb_qflags & (XFS_OQUOTA_ENFD | XFS_OQUOTA_CHKD)) {
|
||||||
xfs_notice(mp,
|
xfs_notice(mp,
|
||||||
"Version 5 of Super block has XFS_OQUOTA bits.\n");
|
"Version 5 of Super block has XFS_OQUOTA bits.");
|
||||||
return XFS_ERROR(EFSCORRUPTED);
|
return XFS_ERROR(EFSCORRUPTED);
|
||||||
}
|
}
|
||||||
} else if (sbp->sb_qflags & (XFS_PQUOTA_ENFD | XFS_GQUOTA_ENFD |
|
} else if (sbp->sb_qflags & (XFS_PQUOTA_ENFD | XFS_GQUOTA_ENFD |
|
||||||
XFS_PQUOTA_CHKD | XFS_GQUOTA_CHKD)) {
|
XFS_PQUOTA_CHKD | XFS_GQUOTA_CHKD)) {
|
||||||
xfs_notice(mp,
|
xfs_notice(mp,
|
||||||
"Superblock earlier than Version 5 has XFS_[PQ]UOTA_{ENFD|CHKD} bits.\n");
|
"Superblock earlier than Version 5 has XFS_[PQ]UOTA_{ENFD|CHKD} bits.");
|
||||||
return XFS_ERROR(EFSCORRUPTED);
|
return XFS_ERROR(EFSCORRUPTED);
|
||||||
}
|
}
|
||||||
|
|
||||||
|
|
|
@ -1241,7 +1241,7 @@ xfs_fs_remount(
|
||||||
*/
|
*/
|
||||||
#if 0
|
#if 0
|
||||||
xfs_info(mp,
|
xfs_info(mp,
|
||||||
"mount option \"%s\" not supported for remount\n", p);
|
"mount option \"%s\" not supported for remount", p);
|
||||||
return -EINVAL;
|
return -EINVAL;
|
||||||
#else
|
#else
|
||||||
break;
|
break;
|
||||||
|
|
Loading…
Reference in a new issue