redonkable
/
remarkable-linux
1
0
Fork 0
Code Releases Activity

regulator: tps65090: Fix using wrong dev argument for calling of_regulator_match 

The dev parameter is the device requesting the data.
In this case it should be &pdev->dev rather than pdev->dev.parent.

The dev parameter is used to call devm_kzalloc in of_get_regulator_init_data(),
which means this fixes a memory leak because the memory is allocated every time
probe() is called, thus it should be freed when this driver is unloaded.

Signed-off-by: Axel Lin <axel.lin@ingics.com>
Signed-off-by: Mark Brown <broonie@opensource.wolfsonmicro.com>
wifi-calibration
Axel Lin 2013-01-30 20:28:20 +08:00 committed by Mark Brown
parent 6c7a7a0e36
commit 09a228e70b
1 changed files with 1 additions and 1 deletions
Show Stats Download Patch File Download Diff File Expand all files Collapse all files

2
drivers/regulator/tps65090-regulator.c
View File

@ -186,7 +186,7 @@ static struct tps65090_platform_data *tps65090_parse_dt_reg_data(
return ERR_PTR(-ENODEV);
}
ret = of_regulator_match(pdev->dev.parent, regulators, tps65090_matches,
ret = of_regulator_match(&pdev->dev, regulators, tps65090_matches,
ARRAY_SIZE(tps65090_matches));
if (ret < 0) {
dev_err(&pdev->dev,