redonkable/remarkable-linux
redonkable/remarkable-linux
1
0
Fork 0
Code Releases Activity

backlight: jornada720: fix checkpatch error and warning

Browse source 
This patch fixes the checkpatch error and warning as below:

  ERROR: return is not a function, parentheses are not required

Also, long comments are fixed for the preferred style.

Signed-off-by: Jingoo Han <jg1.han@samsung.com>
Cc: Richard Purdie <rpurdie@rpsys.net>
Signed-off-by: Andrew Morton <akpm@linux-foundation.org>
Signed-off-by: Linus Torvalds <torvalds@linux-foundation.org>
This commit is contained in:
Jingoo Han 2012-12-17 16:00:21 -08:00 committed by Linus Torvalds
parent c0b6cc499c
commit 0a75a568b3
1 changed files with 19 additions and 12 deletions
Show stats Download patch file Download diff file Expand all files Collapse all files

31
drivers/video/backlight/jornada720_bl.c
View file

@ -48,7 +48,7 @@ static int jornada_bl_get_brightness(struct backlight_device *bd)
jornada_ssp_end(); jornada_ssp_end();
return (BL_MAX_BRIGHT - ret); return BL_MAX_BRIGHT - ret;
} }
static int jornada_bl_update_status(struct backlight_device *bd) static int jornada_bl_update_status(struct backlight_device *bd)
@ -77,18 +77,23 @@ static int jornada_bl_update_status(struct backlight_device *bd)
goto out; goto out;
} }
/* at this point we expect that the mcu has accepted /*
our command and is waiting for our new value * at this point we expect that the mcu has accepted
please note that maximum brightness is 255, * our command and is waiting for our new value
but due to physical layout it is equal to 0, so we simply * please note that maximum brightness is 255,
invert the value (MAX VALUE - NEW VALUE). */ * but due to physical layout it is equal to 0, so we simply
if (jornada_ssp_byte(BL_MAX_BRIGHT - bd->props.brightness) != TXDUMMY) { * invert the value (MAX VALUE - NEW VALUE).
*/
if (jornada_ssp_byte(BL_MAX_BRIGHT - bd->props.brightness)
!= TXDUMMY) {
pr_err("set brightness failed\n"); pr_err("set brightness failed\n");
ret = -ETIMEDOUT; ret = -ETIMEDOUT;
} }
/* If infact we get an TXDUMMY as output we are happy and dont /*
make any further comments about it */ * If infact we get an TXDUMMY as output we are happy and dont
* make any further comments about it
*/
out: out:
jornada_ssp_end(); jornada_ssp_end();
@ -121,9 +126,11 @@ static int jornada_bl_probe(struct platform_device *pdev)
bd->props.power = FB_BLANK_UNBLANK; bd->props.power = FB_BLANK_UNBLANK;
bd->props.brightness = BL_DEF_BRIGHT; bd->props.brightness = BL_DEF_BRIGHT;
/* note. make sure max brightness is set otherwise /*
you will get seemingly non-related errors when * note. make sure max brightness is set otherwise
trying to change brightness */ * you will get seemingly non-related errors when
* trying to change brightness
*/
jornada_bl_update_status(bd); jornada_bl_update_status(bd);
platform_set_drvdata(pdev, bd); platform_set_drvdata(pdev, bd);