redonkable
/
remarkable-linux
1
0
Fork 0
Code Releases Activity

MLK-20190-03 brcmfmac: check thre return value of .brcmf_fil_iovar_data_get() 

Check the return value of .brcmf_fil_iovar_data_get() to fix
the coverity issue of "error handling issue".

Reviewed-by: Haibo Chen <haibo.chen@nxp.com>
Signed-off-by: Fugang Duan <fugang.duan@nxp.com>
pull/10/head
Andy Duan 2018-11-07 15:06:03 +08:00
parent 6bde763b3d
commit 0a93178425
1 changed files with 5 additions and 2 deletions
Show Stats Download Patch File Download Diff File Expand all files Collapse all files

7
drivers/net/wireless/broadcom/brcm80211/brcmfmac/sdio.c
View File

@ -2560,12 +2560,15 @@ brcmf_sdio_ulp_preinit(struct device *dev)
struct brcmf_bus *bus_if = dev_get_drvdata(dev);
struct brcmf_sdio_dev *sdiodev = bus_if->bus_priv.sdio;
struct brcmf_if *ifp = bus_if->drvr->iflist[0];
s32 err = 0;
brcmf_dbg(TRACE, "Enter\n");
/* Query ulp_sdioctrl iovar to get the ULP related SHM offsets */
brcmf_fil_iovar_data_get(ifp, "ulp_sdioctrl", &sdiodev->shm_ulp,
sizeof(sdiodev->shm_ulp));
err = brcmf_fil_iovar_data_get(ifp, "ulp_sdioctrl", &sdiodev->shm_ulp,
sizeof(sdiodev->shm_ulp));
if (err)
brcmf_err("ulp_sdioctrl iovar returned err = %d\n", err);
sdiodev->ulp = false;