perf symbols: Check return value of filename__read_debuglink()
When dso__read_binary_type_filename() called, it doesn't check the return value of filename__read_debuglink() so that it'll try to open the debuglink file even if it doesn't exist. Also fix return value of the filename__read_debuglink() as it always return -1 regardless of the result. Signed-off-by: Namhyung Kim <namhyung@kernel.org> Cc: Cody P Schafer <cody@linux.vnet.ibm.com> Cc: Ingo Molnar <mingo@kernel.org> Cc: Namhyung Kim <namhyung.kim@lge.com> Cc: Namhyung Kim <namhyung@kernel.org> Cc: Paul Mackerras <paulus@samba.org> Cc: Peter Zijlstra <a.p.zijlstra@chello.nl> Link: http://lkml.kernel.org/r/1392859976-32760-3-git-send-email-namhyung@kernel.org Signed-off-by: Arnaldo Carvalho de Melo <acme@redhat.com>
This commit is contained in:
parent
9e8c06eaba
commit
0d3dc5e8b8
|
@ -45,8 +45,8 @@ int dso__read_binary_type_filename(const struct dso *dso,
|
|||
debuglink--;
|
||||
if (*debuglink == '/')
|
||||
debuglink++;
|
||||
filename__read_debuglink(dso->long_name, debuglink,
|
||||
size - (debuglink - filename));
|
||||
ret = filename__read_debuglink(dso->long_name, debuglink,
|
||||
size - (debuglink - filename));
|
||||
}
|
||||
break;
|
||||
case DSO_BINARY_TYPE__BUILD_ID_CACHE:
|
||||
|
|
|
@ -506,6 +506,8 @@ int filename__read_debuglink(const char *filename, char *debuglink,
|
|||
/* the start of this section is a zero-terminated string */
|
||||
strncpy(debuglink, data->d_buf, size);
|
||||
|
||||
err = 0;
|
||||
|
||||
out_elf_end:
|
||||
elf_end(elf);
|
||||
out_close:
|
||||
|
|
Loading…
Reference in a new issue