redonkable/remarkable-linux
redonkable/remarkable-linux
1
0
Fork 0
Code Releases Activity

firewire: ohci: optimize find_branch_descriptor()

Browse source 
When z==2, the condition "key == 2" is superfluous because it cannot
occur without "b == 3", as a descriptor with b!=3 and key==2 would be
an OUTPUT_MORE_IMMEDIATE descriptor which cannot be used alone.

Also remove magic numbers and needless computations on the b field.

Signed-off-by: Clemens Ladisch <clemens@ladisch.de>
Signed-off-by: Stefan Richter <stefanr@s5r6.in-berlin.de>
This commit is contained in:
Clemens Ladisch 2011-04-12 07:54:59 +02:00 committed by Stefan Richter
parent da28947e7e
commit 0ff8fbc617
1 changed files with 3 additions and 4 deletions
Show stats Download patch file Download diff file Expand all files Collapse all files

7
drivers/firewire/ohci.c
View file

@ -1006,13 +1006,12 @@ static void ar_context_run(struct ar_context *ctx)
static struct descriptor *find_branch_descriptor(struct descriptor *d, int z) static struct descriptor *find_branch_descriptor(struct descriptor *d, int z)
{ {
int b, key; __le16 branch;
b = (le16_to_cpu(d->control) & DESCRIPTOR_BRANCH_ALWAYS) >> 2; branch = d->control & cpu_to_le16(DESCRIPTOR_BRANCH_ALWAYS);
key = (le16_to_cpu(d->control) & DESCRIPTOR_KEY_IMMEDIATE) >> 8;
/* figure out which descriptor the branch address goes in */ /* figure out which descriptor the branch address goes in */
if (z == 2 && (b == 3 || key == 2)) if (z == 2 && branch == cpu_to_le16(DESCRIPTOR_BRANCH_ALWAYS))
return d; return d;
else else
return d + z - 1; return d + z - 1;