remoteproc/keystone: Ensure the DSPs are in reset in probe
The DSPs are expected to be in reset when the driver probes a device. If the DSPs are out of reset in probe, the system may crash when the firmware is being loaded. So, add a check to make sure the DSP resets are asserted, and if not, throw a eye-catchy warning and assert the resets specifically. Signed-off-by: Andrew F. Davis <afd@ti.com> [s-anna@ti.com: replace warning with a WARN] Signed-off-by: Suman Anna <s-anna@ti.com> Acked-by: Santosh Shilimkar <ssantosh@kernel.org> Signed-off-by: Bjorn Andersson <bjorn.andersson@linaro.org>zero-colors
parent
e88bb8f7a1
commit
11d2a2ffa8
|
@ -456,6 +456,16 @@ static int keystone_rproc_probe(struct platform_device *pdev)
|
||||||
if (of_reserved_mem_device_init(dev))
|
if (of_reserved_mem_device_init(dev))
|
||||||
dev_warn(dev, "device does not have specific CMA pool\n");
|
dev_warn(dev, "device does not have specific CMA pool\n");
|
||||||
|
|
||||||
|
/* ensure the DSP is in reset before loading firmware */
|
||||||
|
ret = reset_control_status(ksproc->reset);
|
||||||
|
if (ret < 0) {
|
||||||
|
dev_err(dev, "failed to get reset status, status = %d\n", ret);
|
||||||
|
goto release_mem;
|
||||||
|
} else if (ret == 0) {
|
||||||
|
WARN(1, "device is not in reset\n");
|
||||||
|
keystone_rproc_dsp_reset(ksproc);
|
||||||
|
}
|
||||||
|
|
||||||
ret = rproc_add(rproc);
|
ret = rproc_add(rproc);
|
||||||
if (ret) {
|
if (ret) {
|
||||||
dev_err(dev, "failed to add register device with remoteproc core, status = %d\n",
|
dev_err(dev, "failed to add register device with remoteproc core, status = %d\n",
|
||||||
|
|
Loading…
Reference in New Issue