[PKTGEN]: Fix kernel_thread() fail leak.
Free all the alocated resources if kernel_thread() call fails. Signed-off-by: Luiz Capitulino <lcapitulino@mandriva.com.br> Signed-off-by: David S. Miller <davem@davemloft.net>
This commit is contained in:
parent
cdcdbe0b17
commit
12e1872328
|
@ -3082,6 +3082,7 @@ static struct pktgen_thread *__init pktgen_find_thread(const char *name)
|
||||||
|
|
||||||
static int __init pktgen_create_thread(const char *name, int cpu)
|
static int __init pktgen_create_thread(const char *name, int cpu)
|
||||||
{
|
{
|
||||||
|
int err;
|
||||||
struct pktgen_thread *t = NULL;
|
struct pktgen_thread *t = NULL;
|
||||||
struct proc_dir_entry *pe;
|
struct proc_dir_entry *pe;
|
||||||
|
|
||||||
|
@ -3120,9 +3121,15 @@ static int __init pktgen_create_thread(const char *name, int cpu)
|
||||||
|
|
||||||
t->removed = 0;
|
t->removed = 0;
|
||||||
|
|
||||||
if (kernel_thread((void *)pktgen_thread_worker, (void *)t,
|
err = kernel_thread((void *)pktgen_thread_worker, (void *)t,
|
||||||
CLONE_FS | CLONE_FILES | CLONE_SIGHAND) < 0)
|
CLONE_FS | CLONE_FILES | CLONE_SIGHAND);
|
||||||
|
if (err < 0) {
|
||||||
printk("pktgen: kernel_thread() failed for cpu %d\n", t->cpu);
|
printk("pktgen: kernel_thread() failed for cpu %d\n", t->cpu);
|
||||||
|
remove_proc_entry(t->name, pg_proc_dir);
|
||||||
|
list_del(&t->th_list);
|
||||||
|
kfree(t);
|
||||||
|
return err;
|
||||||
|
}
|
||||||
|
|
||||||
return 0;
|
return 0;
|
||||||
}
|
}
|
||||||
|
|
Loading…
Reference in a new issue