redonkable/remarkable-linux
redonkable/remarkable-linux
1
0
Fork 0
Code Releases Activity

[PATCH] icn driver fails to unload when no hardware present

Browse source 
Fix a null dereference in module unload path.

Found by a simple modprobe icn ; rmmod icn

Signed-off-by: Dave Jones <davej@redhat.com>
Signed-off-by: Andrew Morton <akpm@osdl.org>
Signed-off-by: Linus Torvalds <torvalds@osdl.org>
This commit is contained in:
Dave Jones 2005-08-08 16:13:15 -07:00 committed by Linus Torvalds
parent 92e52b2e82
commit 138b9dd1fd
1 changed files with 3 additions and 2 deletions
Show stats Download patch file Download diff file Expand all files Collapse all files

5
drivers/isdn/icn/icn.c
View file

@ -1650,7 +1650,7 @@ static void __exit icn_exit(void)
{ {
isdn_ctrl cmd; isdn_ctrl cmd;
icn_card *card = cards; icn_card *card = cards;
icn_card *last; icn_card *last, *tmpcard;
int i; int i;
unsigned long flags; unsigned long flags;
@ -1670,8 +1670,9 @@ static void __exit icn_exit(void)
for (i = 0; i < ICN_BCH; i++) for (i = 0; i < ICN_BCH; i++)
icn_free_queue(card, i); icn_free_queue(card, i);
} }
card = card->next; tmpcard = card->next;
spin_unlock_irqrestore(&card->lock, flags); spin_unlock_irqrestore(&card->lock, flags);
card = tmpcard;
} }
card = cards; card = cards;
cards = NULL; cards = NULL;