redonkable/remarkable-linux
redonkable/remarkable-linux
1
0
Fork 0
Code Releases Activity

zd1211rw: Replace ZD_CS_MULTICAST with ZD_CS_NO_ACK

Browse source 
According to my tests, all that ZD_CS_MULTICAST does is to
disable retrying/waiting for an ACK. Reflect this by renaming
the bit to ZD_CS_NO_ACK and setting it based on
IEEE80211_TX_CTL_NO_ACK, instead of is_multicast_ether_addr.

Signed-off-by: Gábor Stefanik <netrolller.3d@gmail.com>
Signed-off-by: John W. Linville <linville@tuxdriver.com>
This commit is contained in:
Gábor Stefanik 2009-05-14 17:34:59 +00:00 committed by John W. Linville
parent cccaec98a3
commit 13bdcd90bb
2 changed files with 4 additions and 4 deletions
Show stats Download patch file Download diff file Expand all files Collapse all files

6
drivers/net/wireless/zd1211rw/zd_mac.c
View file

@ -420,9 +420,9 @@ static void cs_set_control(struct zd_mac *mac, struct zd_ctrlset *cs,
if (info->flags & IEEE80211_TX_CTL_FIRST_FRAGMENT) if (info->flags & IEEE80211_TX_CTL_FIRST_FRAGMENT)
cs->control |= ZD_CS_NEED_RANDOM_BACKOFF; cs->control |= ZD_CS_NEED_RANDOM_BACKOFF;
/* Multicast */ /* No ACK expected (multicast, etc.) */
if (is_multicast_ether_addr(header->addr1)) if (info->flags & IEEE80211_TX_CTL_NO_ACK)
cs->control |= ZD_CS_MULTICAST; cs->control |= ZD_CS_NO_ACK;
/* PS-POLL */ /* PS-POLL */
if (ieee80211_is_pspoll(header->frame_control)) if (ieee80211_is_pspoll(header->frame_control))

2
drivers/net/wireless/zd1211rw/zd_mac.h
View file

@ -87,7 +87,7 @@ struct zd_ctrlset {
/* zd_ctrlset control field */ /* zd_ctrlset control field */
#define ZD_CS_NEED_RANDOM_BACKOFF 0x01 #define ZD_CS_NEED_RANDOM_BACKOFF 0x01
#define ZD_CS_MULTICAST 0x02 #define ZD_CS_NO_ACK 0x02
#define ZD_CS_FRAME_TYPE_MASK 0x0c #define ZD_CS_FRAME_TYPE_MASK 0x0c
#define ZD_CS_DATA_FRAME 0x00 #define ZD_CS_DATA_FRAME 0x00