redonkable/remarkable-linux
redonkable/remarkable-linux
1
0
Fork 0
Code Releases Activity

media: radio: wl1273: add check on core->write() return value

Browse source 
Check return value from call to core->write(), so in case of
error print error message, jump to goto label fail and eventually
return.

Addresses-Coverity-ID: 1226943

Signed-off-by: Gustavo A. R. Silva <garsilva@embeddedor.com>
Signed-off-by: Hans Verkuil <hansverk@cisco.com>
Signed-off-by: Mauro Carvalho Chehab <mchehab@s-opensource.com>
This commit is contained in:
Gustavo A. R. Silva 2017-06-22 01:01:22 -03:00 committed by Mauro Carvalho Chehab
parent 0a0c1b823c
commit 13c2bede49
1 changed files with 13 additions and 2 deletions
Show stats Download patch file Download diff file Expand all files Collapse all files

15
drivers/media/radio/radio-wl1273.c
View file

@ -610,10 +610,21 @@ static int wl1273_fm_start(struct wl1273_device *radio, int new_mode)
}
}
if (radio->rds_on)
if (radio->rds_on) {
r = core->write(core, WL1273_RDS_DATA_ENB, 1);
else
if (r) {
dev_err(dev, "%s: RDS_DATA_ENB ON fails\n",
__func__);
goto fail;
}
} else {
r = core->write(core, WL1273_RDS_DATA_ENB, 0);
if (r) {
dev_err(dev, "%s: RDS_DATA_ENB OFF fails\n",
__func__);
goto fail;
}
}
} else {
dev_warn(dev, "%s: Illegal mode.\n", __func__);
}