redonkable/remarkable-linux
redonkable/remarkable-linux
1
0
Fork 0
Code Releases Activity

PCI/MSI: Fix cut-and-paste errors in documentation

Browse source 
Function pci_enable_msi_range() is used in examples where
pci_enable_msix_range() should have been used instead.

Reported-by: Bjorn Helgaas <bhelgaas@google.com>
Signed-off-by: Alexander Gordeev <agordeev@redhat.com>
Signed-off-by: Bjorn Helgaas <bhelgaas@google.com>
This commit is contained in:
Alexander Gordeev 2014-02-13 10:47:56 -07:00 committed by Bjorn Helgaas
parent 7918b2dc66
commit 13f9653dab
1 changed files with 6 additions and 6 deletions
Show stats Download patch file Download diff file Expand all files Collapse all files

12
Documentation/PCI/MSI-HOWTO.txt
View file

@ -274,8 +274,8 @@ possible, likely up to the limit returned by pci_msix_vec_count() function:
static int foo_driver_enable_msix(struct foo_adapter *adapter, int nvec) static int foo_driver_enable_msix(struct foo_adapter *adapter, int nvec)
{ {
return pci_enable_msi_range(adapter->pdev, adapter->msix_entries, return pci_enable_msix_range(adapter->pdev, adapter->msix_entries,
1, nvec); 1, nvec);
} }
Note the value of 'minvec' parameter is 1. As 'minvec' is inclusive, Note the value of 'minvec' parameter is 1. As 'minvec' is inclusive,
@ -286,8 +286,8 @@ In this case the function could look like this:
static int foo_driver_enable_msix(struct foo_adapter *adapter, int nvec) static int foo_driver_enable_msix(struct foo_adapter *adapter, int nvec)
{ {
return pci_enable_msi_range(adapter->pdev, adapter->msix_entries, return pci_enable_msix_range(adapter->pdev, adapter->msix_entries,
FOO_DRIVER_MINIMUM_NVEC, nvec); FOO_DRIVER_MINIMUM_NVEC, nvec);
} }
4.3.1.2 Exact number of MSI-X interrupts 4.3.1.2 Exact number of MSI-X interrupts
@ -299,8 +299,8 @@ parameters:
static int foo_driver_enable_msix(struct foo_adapter *adapter, int nvec) static int foo_driver_enable_msix(struct foo_adapter *adapter, int nvec)
{ {
return pci_enable_msi_range(adapter->pdev, adapter->msix_entries, return pci_enable_msix_range(adapter->pdev, adapter->msix_entries,
nvec, nvec); nvec, nvec);
} }
4.3.1.3 Specific requirements to the number of MSI-X interrupts 4.3.1.3 Specific requirements to the number of MSI-X interrupts