redonkable
/
remarkable-linux
1
0
Fork 0
Code Releases Activity

[S390] cio: wake up on failed recognition 

Wake up even on failed device recognition, since this may be triggered
from a user trying to force a device online. With this patch a write
to the online sysfs attribute will not block for ever but return with
-EAGAIN in this case.

Signed-off-by: Sebastian Ott <sebott@linux.vnet.ibm.com>
Signed-off-by: Martin Schwidefsky <schwidefsky@de.ibm.com>
wifi-calibration
Sebastian Ott 2009-03-31 19:16:03 +02:00 committed by Martin Schwidefsky
parent 33b26d7951
commit 156013ffd1
2 changed files with 10 additions and 4 deletions
Show Stats Download Patch File Download Diff File Expand all files Collapse all files

10
drivers/s390/cio/device.c
View File

@ -482,17 +482,21 @@ static int online_store_recog_and_online(struct ccw_device *cdev)
}
wait_event(cdev->private->wait_q,
cdev->private->flags.recog_done);
if (cdev->private->state != DEV_STATE_OFFLINE)
/* recognition failed */
return -EAGAIN;
}
if (cdev->drv && cdev->drv->set_online)
ccw_device_set_online(cdev);
return 0;
}
static int online_store_handle_online(struct ccw_device *cdev, int force)
{
int ret;
ret = online_store_recog_and_online(cdev);
if (ret)
if (ret && !force)
return ret;
if (force && cdev->private->state == DEV_STATE_BOXED) {
ret = ccw_device_stlck(cdev);
@ -500,7 +504,9 @@ static int online_store_handle_online(struct ccw_device *cdev, int force)
return ret;
if (cdev->id.cu_type == 0)
cdev->private->state = DEV_STATE_NOT_OPER;
online_store_recog_and_online(cdev);
ret = online_store_recog_and_online(cdev);
if (ret)
return ret;
}
return 0;
}

4
drivers/s390/cio/device_fsm.c
View File

@ -260,6 +260,7 @@ ccw_device_recog_done(struct ccw_device *cdev, int state)
if (state == DEV_STATE_NOT_OPER) {
cdev->private->flags.recog_done = 1;
cdev->private->state = DEV_STATE_DISCONNECTED;
wake_up(&cdev->private->wait_q);
return;
}
/* Boxed devices don't need extra treatment. */
@ -311,8 +312,7 @@ ccw_device_recog_done(struct ccw_device *cdev, int state)
}
cdev->private->state = state;
io_subchannel_recog_done(cdev);
if (state != DEV_STATE_NOT_OPER)
wake_up(&cdev->private->wait_q);
wake_up(&cdev->private->wait_q);
}
/*