redonkable/remarkable-linux
redonkable/remarkable-linux
1
0
Fork 0
Code Releases Activity

serial: Fix crash if the minimum rate of the device is > 9600 baud

Browse source 
In that situation if the old rate is invalid and the new rate is invalid
and the chip cannot do 9600 baud we report zero, which makes all the
drivers explode.

Instead force the rate based on min/max

Signed-off-by: Alan Cox <alan@linux.intel.com>
Signed-off-by: Greg Kroah-Hartman <gregkh@suse.de>
This commit is contained in:
Alan Cox 2010-01-04 16:26:21 +00:00 committed by Greg Kroah-Hartman
parent 4547be7809
commit 16ae2a877b
1 changed files with 12 additions and 5 deletions
Show stats Download patch file Download diff file Expand all files Collapse all files

17
drivers/serial/serial_core.c
View file

@ -385,13 +385,20 @@ uart_get_baud_rate(struct uart_port *port, struct ktermios *termios,
}
/*
* As a last resort, if the quotient is zero,
* default to 9600 bps
* As a last resort, if the range cannot be met then clip to
* the nearest chip supported rate.
*/
if (!hung_up)
tty_termios_encode_baud_rate(termios, 9600, 9600);
if (!hung_up) {
if (baud <= min)
tty_termios_encode_baud_rate(termios,
min + 1, min + 1);
else
tty_termios_encode_baud_rate(termios,
max - 1, max - 1);
}
}
/* Should never happen */
WARN_ON(1);
return 0;
}