redonkable
/
remarkable-linux
1
0
Fork 0
Code Releases Activity

PCI: artpec6: Fix platform_get_irq() error handling 

platform_get_irq() returns a negative number on failure, so adjust the
logic to detect such condition and propagate the real error value on
failure.

Signed-off-by: Fabio Estevam <fabio.estevam@nxp.com>
Signed-off-by: Bjorn Helgaas <bhelgaas@google.com>
Acked-by: Niklas Cassel <niklas.cassel@axis.com>
zero-colors
Fabio Estevam 2017-08-31 14:52:04 -03:00 committed by Bjorn Helgaas
parent 16f73eb02d
commit 16df7cdb9e
1 changed files with 2 additions and 2 deletions
Show Stats Download Patch File Download Diff File Expand all files Collapse all files

4
drivers/pci/dwc/pcie-artpec6.c
View File

@ -207,9 +207,9 @@ static int artpec6_add_pcie_port(struct artpec6_pcie *artpec6_pcie,
if (IS_ENABLED(CONFIG_PCI_MSI)) {
pp->msi_irq = platform_get_irq_byname(pdev, "msi");
if (pp->msi_irq <= 0) {
if (pp->msi_irq < 0) {
dev_err(dev, "failed to get MSI irq\n");
return -ENODEV;
return pp->msi_irq;
}
ret = devm_request_irq(dev, pp->msi_irq,