redonkable
/
remarkable-linux
1
0
Fork 0
Code Releases Activity

RDMA/netlink: Add and implement doit netlink callback 

The .doit callback is used by netlink core to differentiate
between get and set operations. Common convention is to use
that call for command operations like (SET, ADD, e.t.c.) and/or
access without NLF_M_DUMP flag.

This commit adds proper declaration and implementation
to RDMA netlink.

Signed-off-by: Leon Romanovsky <leonro@mellanox.com>
Reviewed-by: Steve Wise <swise@opengridcomputing.com>
zero-colors
Leon Romanovsky 2017-06-15 12:46:33 +03:00 committed by Leon Romanovsky
parent ecc82c53f9
commit 1830ba21b9
2 changed files with 16 additions and 5 deletions
Show Stats Download Patch File Download Diff File Expand all files Collapse all files

19
drivers/infiniband/core/netlink.c
View File

@ -76,9 +76,13 @@ static bool is_nl_msg_valid(unsigned int type, unsigned int op)
static bool is_nl_valid(unsigned int type, unsigned int op)
{
if (!is_nl_msg_valid(type, op) ||
!rdma_nl_types[type].cb_table ||
!rdma_nl_types[type].cb_table[op].dump)
const struct rdma_nl_cbs *cb_table;
if (!is_nl_msg_valid(type, op))
return false;
cb_table = rdma_nl_types[type].cb_table;
if (!cb_table || (!cb_table[op].dump && !cb_table[op].doit))
return false;
return true;
}
@ -151,6 +155,7 @@ static int rdma_nl_rcv_msg(struct sk_buff *skb, struct nlmsghdr *nlh,
unsigned int op = RDMA_NL_GET_OP(type);
struct netlink_callback cb = {};
struct netlink_dump_control c = {};
int ret;
if (!is_nl_valid(index, op))
return -EINVAL;
@ -169,10 +174,14 @@ static int rdma_nl_rcv_msg(struct sk_buff *skb, struct nlmsghdr *nlh,
cb.nlh = nlh;
cb.dump = rdma_nl_types[index].cb_table[op].dump;
return cb.dump(skb, &cb);
} else {
c.dump = rdma_nl_types[index].cb_table[op].dump;
return netlink_dump_start(nls, skb, nlh, &c);
}
if (rdma_nl_types[index].cb_table[op].doit)
ret = rdma_nl_types[index].cb_table[op].doit(skb, nlh, extack);
return ret;
c.dump = rdma_nl_types[index].cb_table[op].dump;
return netlink_dump_start(nls, skb, nlh, &c);
}
/*

2
include/rdma/rdma_netlink.h
View File

@ -6,6 +6,8 @@
#include <uapi/rdma/rdma_netlink.h>
struct rdma_nl_cbs {
int (*doit)(struct sk_buff *skb, struct nlmsghdr *nlh,
struct netlink_ext_ack *extack);
int (*dump)(struct sk_buff *skb, struct netlink_callback *nlcb);
u8 flags;
};